From unknown Sat Sep 13 08:55:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53048 <53048@debbugs.gnu.org> To: bug#53048 <53048@debbugs.gnu.org> Subject: Status: 28.0.90; [PATCH] GNU ELPA local build fails silently on macOS Reply-To: bug#53048 <53048@debbugs.gnu.org> Date: Sat, 13 Sep 2025 15:55:36 +0000 retitle 53048 28.0.90; [PATCH] GNU ELPA local build fails silently on macOS reassign 53048 emacs submitter 53048 "Y. E." severity 53048 normal tag 53048 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 06 05:36:01 2022 Received: (at submit) by debbugs.gnu.org; 6 Jan 2022 10:36:01 +0000 Received: from localhost ([127.0.0.1]:39748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Q7k-0002fV-Qt for submit@debbugs.gnu.org; Thu, 06 Jan 2022 05:36:01 -0500 Received: from lists.gnu.org ([209.51.188.17]:37580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Q7j-0002fO-7w for submit@debbugs.gnu.org; Thu, 06 Jan 2022 05:35:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Q7i-0008Nt-Ud for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 05:35:59 -0500 Received: from [2001:41d0:2:267::] (port=33454 helo=out0.migadu.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Q7f-0003JR-6T for bug-gnu-emacs@gnu.org; Thu, 06 Jan 2022 05:35:58 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ego.team; s=key1; t=1641465342; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Iyvz4h0HOPcGlsmKQyrRdwKRVQMVirJCFntmCqFD1/o=; b=NZqfsOFxTvDLGavwQ4saL8qN3sHKTKABrc+suf3gmCBjzr5r1tne4RjPkpz+UauVgP9CPD RTUedhl8ly5B3zwAbh7qzdWFaUZQmTFdGx+Gw7Jk9jW4z35P3EPTS/AegaYZ+cpJLjpr28 P5572nuZqgulooMi+9Z72POjUx+xPEI= From: Y. E. To: bug-gnu-emacs@gnu.org Subject: 28.0.90; [PATCH] GNU ELPA local build fails silently on macOS Date: Thu, 06 Jan 2022 12:35:41 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: ego.team X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:41d0:2:267:: (failed) Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=yet@ego.team; helo=out0.migadu.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Y. E." Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain On macOS, with the default 'bsdtar', 'make build/' fails to create a tarball, but does not warn about it, outputting: > ======== Building tarball archive-devel/.tar... > ######## Built new package archive-devel/.tar! > ======== Building tarball archive/.tar... > ######## Built new package archive/.tar! ['bsdtar' does not expose '--transform' option. Though it provides a similar '-s' option with a bit different syntax.] This patch suggests asserting a tarball was generated. This would result in a more helpful output on a failed generation: > ======== Building tarball archive-devel/.tar... > Build error for archive-devel/.tar: (cl-assertion-failed (file-readable-p tarball)) > ######## Build of package archive-devel/.tar FAILED!! > ======== Building tarball archive/.tar... > Build error for archive/.tar: (cl-assertion-failed (file-readable-p tarball)) > ######## Build of package archive/.tar FAILED!! In GNU Emacs 28.0.90 (build 1, x86_64-apple-darwin21.1.0, NS appkit-2113.00 Version 12.0.1 (Build 21A559)) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-admin-elpa-admin.el-elpaa-make-one-tarball-1-Assert-.patch Content-Description: Assert tarball exists >From b8ce44d9f3da636a9236d7fc6a29dffb73d819ec Mon Sep 17 00:00:00 2001 From: YugaEgo Date: Thu, 6 Jan 2022 11:55:27 +0200 Subject: [PATCH] * admin/elpa-admin.el (elpaa--make-one-tarball-1): Assert tarball exists --- elpa-admin.el | 1 + 1 file changed, 1 insertion(+) diff --git a/elpa-admin.el b/elpa-admin.el index b4ad318ef6..d94cc7fd73 100644 --- a/elpa-admin.el +++ b/elpa-admin.el @@ -612,6 +612,7 @@ auxillary files unless TARBALL-ONLY is non-nil ." ,(format "s|^packages/%s|%s-%s|" pkgname pkgname vers) "-chf" ,tarball ,(concat "packages/" pkgname))) + (cl-assert (file-readable-p tarball)) (unless tarball-only (let* ((pkgdesc ;; FIXME: `elpaa--write-pkg-file' wrote the metadata to -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 09 08:25:32 2022 Received: (at 53048-done) by debbugs.gnu.org; 9 Jan 2022 13:25:32 +0000 Received: from localhost ([127.0.0.1]:49378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6YCS-00038v-BJ for submit@debbugs.gnu.org; Sun, 09 Jan 2022 08:25:32 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:46941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6YCO-00038f-Ry for 53048-done@debbugs.gnu.org; Sun, 09 Jan 2022 08:25:30 -0500 Received: by mail-pj1-f52.google.com with SMTP id rj2-20020a17090b3e8200b001b1944bad25so13256255pjb.5 for <53048-done@debbugs.gnu.org>; Sun, 09 Jan 2022 05:25:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=DPPS21pyWCDqTmDhA4TU6sqHZcIw7R70xVY+iZDXsxI=; b=zyAbLn67zUj7xWlZ09NP/idmGKJgct4z07Wjw7cHq9Y73aHP37U3TVAWIOX6FtQTak ZqyLdmhSMH0wkTs+Ex0mxoTwdYfqoEA7zQt0g9TYkcxl/2B9QAEnnkCHy9WBW2tpBmwz dt7ekQ0wnz+ElBKOnzRDgQ9if8JGiF7NVrbanQaczsitmHpt51OfxUN+7yDbtj0VoSbo TLHux12kark9paarZ7ljpYue1bz5m2PpHdleCveYrtJ4yhL9I1U2gRAdaxiNCYitVksy 7sNOP9JezE433Trf04A7z1tvXtl6e5y7wA7YeHJJ2YYwCVFNXEncpndSYNAjsZFwCBNP kiHQ== X-Gm-Message-State: AOAM532AznV7LDdoSFAQ1ZNorEmkORRdnZktDE2eNqn5pQjArA+G2Ibu wuxsDwttTb1MFr3VOSUHDXK2EVMrpT8lIEbvTKc= X-Google-Smtp-Source: ABdhPJxy/A9T/iglSuQ47nwemCd9f9PCcQQwFLuILAsnIccGUPRuUJyeBPomRIWaMD3urRPn9rkpmPzUDv+/q+vxhh4= X-Received: by 2002:a17:90b:4b0e:: with SMTP id lx14mr25339842pjb.132.1641734722980; Sun, 09 Jan 2022 05:25:22 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 9 Jan 2022 07:25:22 -0600 From: Stefan Kangas In-Reply-To: (Y. E.'s message of "Thu, 06 Jan 2022 12:35:41 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sun, 9 Jan 2022 07:25:22 -0600 Message-ID: Subject: Re: bug#53048: 28.0.90; [PATCH] GNU ELPA local build fails silently on macOS To: "Y. E." Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 53048-done Cc: 53048-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Y. E. writes: > From b8ce44d9f3da636a9236d7fc6a29dffb73d819ec Mon Sep 17 00:00:00 2001 > From: YugaEgo > Date: Thu, 6 Jan 2022 11:55:27 +0200 > Subject: [PATCH] * admin/elpa-admin.el (elpaa--make-one-tarball-1): Assert > tarball exists > > --- > elpa-admin.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/elpa-admin.el b/elpa-admin.el > index b4ad318ef6..d94cc7fd73 100644 > --- a/elpa-admin.el > +++ b/elpa-admin.el > @@ -612,6 +612,7 @@ auxillary files unless TARBALL-ONLY is non-nil ." > ,(format "s|^packages/%s|%s-%s|" pkgname pkgname vers) > "-chf" ,tarball > ,(concat "packages/" pkgname))) > + (cl-assert (file-readable-p tarball)) > (unless tarball-only > (let* ((pkgdesc > ;; FIXME: `elpaa--write-pkg-file' wrote the metadata to Makes sense, pushed as commit 102694997e. Thanks for the patch! From unknown Sat Sep 13 08:55:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 Feb 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator