GNU bug report logs - #53046
[PATCH] gnu: python-args: Patch reference to basestring.

Previous Next

Package: guix-patches;

Reported by: Tanguy Le Carrour <tanguy <at> bioneland.org>

Date: Thu, 6 Jan 2022 10:22:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #17 received at 53046 <at> debbugs.gnu.org (full text, mbox):

From: Tanguy LE CARROUR <tanguy <at> bioneland.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53046 <at> debbugs.gnu.org
Subject: Re: bug#53046: [PATCH] gnu: python-args: Patch reference to
 basestring.
Date: Mon, 10 Jan 2022 08:48:49 +0100

Hi Maxime,


Quoting Maxime Devos (2022-01-09 22:34:52)
> Maxime Devos schreef op zo 09-01-2022 om 22:15 [+0100]:
> > > This fixes a build failure in the 'sanity-check' phase.
> > > +             (substitute* "args.py"
> > > +               (("basestring") "str"))
> > 
> > Does it actually fix the build failure, or is it only suppressed?
> > [...]
> 
> According to <https://github.com/kennethreitz-archive/args/pull/19>,
> the tests are excluded from the tarball.  It would be useful to
> switch to git-fetch such that tests can be run, verifying whether
> this change causes problems or not.

I'll switch to `git-fetch` and see! Maybe Python 2 tests will also pass
with the patch!?

I'll apply all your suggestions and send a v2.

Thanks again for your time and advice.

-- 
Tanguy
This bug report was last modified 2 years and 293 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.