GNU bug report logs - #53046
[PATCH] gnu: python-args: Patch reference to basestring.

Previous Next

Package: guix-patches;

Reported by: Tanguy Le Carrour <tanguy <at> bioneland.org>

Date: Thu, 6 Jan 2022 10:22:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Tanguy LE CARROUR <tanguy <at> bioneland.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 53046 <at> debbugs.gnu.org
Subject: [bug#53046] [PATCH] gnu: python-args: Patch reference to basestring.
Date: Mon, 10 Jan 2022 08:46:16 +0100

Hi Maxime,


Quoting Maxime Devos (2022-01-09 22:15:41)
> > This fixes a build failure in the 'sanity-check' phase.
> > +             (substitute* "args.py"
> > +               (("basestring") "str"))
> 
> Does it actually fix the build failure, or is it only suppressed?
> 
> Looking at
> 
> <https://github.com/kennethreitz-archive/args/blob/master/args.py>,
> line 15--18, it appears that basestring should actually be basestring,
> at least for Python 2 (python2-args).

Believe it or not, I had totally forgotten about Python 2 when I wrote
that! ^_^'


> Also, returning #true isn't necessary anymore, and this seems better
> fit for a snippet.

OK, I'll fix it.

Thanks for reviewing,

-- 
Tanguy
This bug report was last modified 2 years and 293 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.