From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 06 04:46:22 2022 Received: (at submit) by debbugs.gnu.org; 6 Jan 2022 09:46:22 +0000 Received: from localhost ([127.0.0.1]:39682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PLi-0001Pl-9Z for submit@debbugs.gnu.org; Thu, 06 Jan 2022 04:46:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:45888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PLf-0001Pc-AW for submit@debbugs.gnu.org; Thu, 06 Jan 2022 04:46:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5PLe-0006w7-0q for guix-patches@gnu.org; Thu, 06 Jan 2022 04:46:19 -0500 Received: from [2001:470:142:3::e] (port=39448 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5PLc-0006de-Hw; Thu, 06 Jan 2022 04:46:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=Mi7cAnM4o7vLPGUBGTLJkYmn3mIxP5UuMzUoIj98xNo=; b=JXrzsEJbdlBHzM 25DbymR35oyji2NbCxrp1D7eghZNWaUxICn7VoJgWxC8EWkrBsNwA/yuKM6Mha3rX+RYuuGYVFfA2 Vnm7Ly0JCbKnl2XGYU/Kp5+NBzxjf7I2Tb2aLxH6I7x11OWzxs1f0npunc75jSc0o1T5ZJhq+pFc4 lpQr37GCJDdDPY7w8AEwfRfouW3/RrGNJQVCvxGoaJSoHeLIwE16d4tmlEjOB2M95WCEZHErBbhGy nMZawCis3yPrTt0CgQK1nJzhZ191Jqg0SkgLgkWtuQCV6awB4BPc2x5vqOZY4hTmnX8CRXfVc1bLA X6JyG/8PzrxLMOqlJOBg==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34736 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5PLZ-0003vZ-UL; Thu, 06 Jan 2022 04:46:15 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH] services: networking: Add netmask to loopback address. Date: Thu, 6 Jan 2022 10:46:03 +0100 Message-Id: <20220106094603.11283-1-ludo@gnu.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Debbugs-Cc: Yann Dupont Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From: Ludovic Courtès Previously, we would get a fishy 127.0.0.1/0 interface: $ ip a show dev lo 1: lo: mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet 127.0.0.1/0 scope global lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever With this change, we get nothing but the "/8" version: $ ip a show dev lo 1: lo: mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope global lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever Reported by Yann Dupont . * gnu/services/base.scm (assert-valid-address): Remove special cases for 127.0.0.1 and ::1. (%loopback-static-networking): Add "/8". --- gnu/services/base.scm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 88869e40d2..e46bb591a9 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Ludovic Courtès +;;; Copyright © 2013-2022 Ludovic Courtès ;;; Copyright © 2015, 2016 Alex Kost ;;; Copyright © 2015, 2016, 2020 Mark H Weaver ;;; Copyright © 2015 Sou Bunnbu @@ -2393,11 +2393,7 @@ (define (ipv6-address? str) (define-compile-time-procedure (assert-valid-address (address string?)) "Ensure ADDRESS has a valid netmask." - (unless (or (cidr->netmask address) - (and=> (false-if-exception (inet-pton AF_INET address)) - (cut = INADDR_LOOPBACK <>)) - (and=> (false-if-exception (inet-pton AF_INET6 address)) - (cut = 1 <>))) + (unless (cidr->netmask address) (raise (make-compound-condition (formatted-message (G_ "address '~a' lacks a network mask") @@ -2741,7 +2737,7 @@ (define %loopback-static-networking (static-networking (addresses (list (network-address (device "lo") - (value "127.0.0.1")))) + (value "127.0.0.1/8")))) (requirement '()) (provision '(loopback)))) base-commit: 97657689507a0681aa9699407d292383ff22c330 -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 07 08:48:17 2022 Received: (at 53045) by debbugs.gnu.org; 7 Jan 2022 13:48:18 +0000 Received: from localhost ([127.0.0.1]:43361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5pbN-0005DT-Km for submit@debbugs.gnu.org; Fri, 07 Jan 2022 08:48:17 -0500 Received: from smtptls1-loi.cpub.univ-nantes.fr ([193.52.103.112]:55038 helo=smtp-tls.univ-nantes.fr) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5n7e-0006p3-HI for 53045@debbugs.gnu.org; Fri, 07 Jan 2022 06:09:30 -0500 Received: from localhost (localhost [127.0.0.1]) by smtp-tls.univ-nantes.fr (Postfix) with ESMTP id 643F86140C8 for <53045@debbugs.gnu.org>; Fri, 7 Jan 2022 12:09:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=univ-nantes.fr; s=mailv2; t=1641553765; bh=Nu4dAwBmPnFY4nHo4gyxiwWHtibZvwDShL1vkGDeP98=; h=To:Subject:From:Date:From; b=XQbVKjHoX46T8csHttbz40odxAh1oKJFBRK6NzkEEzvP/eDAnUPJO1ZD/7LrR1h71 N/5bmT64t8DZfMea+72eBfQ1jQTQ7rhHkWcbMQyyKU6AMuTNc5OgHI9OVKI5vPZX4a rSEhc+4zKAc5lFVPoYcACqJgu1OneNnNu+EK3fwNEc1YhEZqR3j2sVKCyVSWF8sA0V 0RRAOZqNOVxbHd1suokbiVfM3Fl4GGU3h+cNOdyyZDTojBawdRyDlZDucJeuIY1g9U NekhoN0oFsC4atnhjihniOaZ52mYsNhBjSIZNTHvH+7TLjTKbhXU2Mqbga+2alaknB mEul904i5mhzQ== X-Virus-Scanned: Debian amavisd-new at smtptls1-lmb.cpub.univ-nantes.fr Received: from smtp-tls.univ-nantes.fr ([127.0.0.1]) by localhost (smtptls1-loi.cpub.univ-nantes.fr [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 92KVY8JYmWdj for <53045@debbugs.gnu.org>; Fri, 7 Jan 2022 12:09:25 +0100 (CET) Received: from [192.168.21.210] (82-65-76-120.subs.proxad.net [82.65.76.120]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-tls.univ-nantes.fr (Postfix) with ESMTPSA id 2B017614298 for <53045@debbugs.gnu.org>; Fri, 7 Jan 2022 12:09:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=univ-nantes.fr; s=mailv2; t=1641553765; bh=Nu4dAwBmPnFY4nHo4gyxiwWHtibZvwDShL1vkGDeP98=; h=To:Subject:From:Date:From; b=XQbVKjHoX46T8csHttbz40odxAh1oKJFBRK6NzkEEzvP/eDAnUPJO1ZD/7LrR1h71 N/5bmT64t8DZfMea+72eBfQ1jQTQ7rhHkWcbMQyyKU6AMuTNc5OgHI9OVKI5vPZX4a rSEhc+4zKAc5lFVPoYcACqJgu1OneNnNu+EK3fwNEc1YhEZqR3j2sVKCyVSWF8sA0V 0RRAOZqNOVxbHd1suokbiVfM3Fl4GGU3h+cNOdyyZDTojBawdRyDlZDucJeuIY1g9U NekhoN0oFsC4atnhjihniOaZ52mYsNhBjSIZNTHvH+7TLjTKbhXU2Mqbga+2alaknB mEul904i5mhzQ== To: 53045@debbugs.gnu.org Subject: [PATCH] services: networking: Add netmask to loopback address. From: Yann Dupont Message-ID: Date: Fri, 7 Jan 2022 12:09:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: fr X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53045 X-Mailman-Approved-At: Fri, 07 Jan 2022 08:48:15 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Just tested here and it works as expected. -- Yann Dupont - Centre Calcul Intensif Pays de la Loire & Datacenter Tel : 02.53.48.49.39 - Mail/Jabber : Yann.Dupont@univ-nantes.fr From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 08 17:29:01 2022 Received: (at 53045-done) by debbugs.gnu.org; 8 Jan 2022 22:29:01 +0000 Received: from localhost ([127.0.0.1]:48878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6KCr-00025q-36 for submit@debbugs.gnu.org; Sat, 08 Jan 2022 17:29:01 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:53046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6KCp-00025c-3C for 53045-done@debbugs.gnu.org; Sat, 08 Jan 2022 17:28:59 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id AE7F234B; Sat, 8 Jan 2022 23:28:53 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IlOzxX8gc9nI; Sat, 8 Jan 2022 23:28:53 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 214741BD; Sat, 8 Jan 2022 23:28:53 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Yann Dupont Subject: Re: bug#53045: [PATCH] services: networking: Add netmask to loopback address. References: <20220106094603.11283-1-ludo@gnu.org> Date: Sat, 08 Jan 2022 23:28:52 +0100 In-Reply-To: (Yann Dupont's message of "Fri, 7 Jan 2022 12:09:24 +0100") Message-ID: <87mtk5276j.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: AE7F234B X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 53045-done Cc: 53045-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, Yann Dupont skribis: > Just tested here and it works as expected. Perfect, pushed as 5c354c204d288439ae5783aae34addaf2004c7a0. Thanks again! Ludo=E2=80=99. From unknown Sun Jun 22 00:54:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 06 Feb 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator