From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 17:46:35 2022 Received: (at submit) by debbugs.gnu.org; 5 Jan 2022 22:46:35 +0000 Received: from localhost ([127.0.0.1]:39233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5F3C-0001e4-U0 for submit@debbugs.gnu.org; Wed, 05 Jan 2022 17:46:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:47094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5F3B-0001dw-82 for submit@debbugs.gnu.org; Wed, 05 Jan 2022 17:46:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5F3A-00065A-0J for guix-patches@gnu.org; Wed, 05 Jan 2022 17:46:32 -0500 Received: from mx1.dismail.de ([78.46.223.134]:45408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5F37-0004q5-U0 for guix-patches@gnu.org; Wed, 05 Jan 2022 17:46:31 -0500 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 37913d39 for ; Wed, 5 Jan 2022 23:46:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=20190914; bh=rkx8Xo1LuPg4LEuvdUk3I Y4FMy+s8tA2MGEoj6CkAu8=; b=qxoerWNHH7K9EZ0gUJ6h2HoVJbRManV994/oV dz7LrUSFi5Oq/RMDt81a+LHjy9PYM6uwMWIUNjYa9I5xjzxEAMb/eVirDNu73+Q4 qy4SWVRuUw3mhN2MGOtu0OOJ9II1ewa8kvLM4lbh0rXGNoiEuVwLtLn7NwUKQjAW 7btjvKvTaO2/Aa8M2qUxe/Qc332r/Yu3arSvoHpBkMSS+gs7xwIdiMB4l9Cs6qal L28dV8vinUyffH+TAJv4vJUJ7XJ//AtznMGT4qFFvIgb1f9RQiuGUxTgc7DtUV96 ug+qa88nFVk83hxVOaiymqoPgZVr5XhcKOZ7x4eVtAm5BW+Ag== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx1.dismail.de (OpenSMTPD) with ESMTP id d544f779 for ; Wed, 5 Jan 2022 23:46:12 +0100 (CET) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id d77e064e for ; Wed, 5 Jan 2022 23:46:12 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 95873204 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 5 Jan 2022 23:46:11 +0100 (CET) From: jgart To: guix-patches@gnu.org Subject: [PATCH] build-system/python: Change let* to let. Date: Wed, 5 Jan 2022 17:46:00 -0500 Message-Id: <20220105224600.9227-1-jgart@dismail.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@dismail.de; helo=mx1.dismail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: jgart X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * guix/build/python-build-system.scm (site-packages): Change let* to let for readability and since let* is unused. --- guix/build/python-build-system.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm index 08871f60cd..a9b1c74f63 100644 --- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -11,6 +11,7 @@ ;;; Copyright © 2020 Efraim Flashner ;;; Copyright © 2021 Lars-Dominik Braun ;;; Copyright © 2021 Maxime Devos +;;; Copyright © 2022 jgart ;;; ;;; This file is part of GNU Guix. ;;; @@ -176,8 +177,8 @@ (define (python-output outputs) (define (site-packages inputs outputs) "Return the path of the current output's Python site-package." - (let* ((out (python-output outputs)) - (python (assoc-ref inputs "python"))) + (let ((out (python-output outputs)) + (python (assoc-ref inputs "python"))) (string-append out "/lib/python" (python-version python) "/site-packages"))) (define (add-installed-pythonpath inputs outputs) -- 2.34.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 09 16:03:38 2022 Received: (at 53039) by debbugs.gnu.org; 9 Jan 2022 21:03:39 +0000 Received: from localhost ([127.0.0.1]:51431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6fLm-00023P-OP for submit@debbugs.gnu.org; Sun, 09 Jan 2022 16:03:38 -0500 Received: from andre.telenet-ops.be ([195.130.132.53]:49068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6fLh-00023C-TL for 53039@debbugs.gnu.org; Sun, 09 Jan 2022 16:03:36 -0500 Received: from [172.20.10.5] ([188.188.14.77]) by andre.telenet-ops.be with bizsmtp id gl3X2600A1flEHY01l3Xx3; Sun, 09 Jan 2022 22:03:32 +0100 Message-ID: <0cecb536c6d706cd018a121f6595810b2b374347.camel@telenet.be> Subject: Re: [PATCH] build-system/python: Change let* to let. From: Maxime Devos To: 53039@debbugs.gnu.org Date: Sun, 09 Jan 2022 22:03:31 +0100 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-LBDDaihlu+Zx3EAE/a0a" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1641762212; bh=yFrOjZ2QxdfDpkl9z9UDzYUvCXM9zNsbUrBLaxH6mI0=; h=Subject:From:To:Date; b=O/4FGI4coz1wuIzXEfz0xi1R/NMNUq5UTDkNTuxCl1oWnY0oi/pEhvHaU65DR0+t0 T2AbstHImVgJwOIifZZyNhD3Y9jNdAldGtBPGrkJqFa5b910fBsTJE0iY6rsdARIj1 WGsxVJV8MyqI1AsOYtrlx9+CC8PXT4kYCjgIdAAnpzvl5nfj2FVvEMTfDt8hWFCUJ7 Bp53REWsysDIqE9l9PhyMwSEMuxHE6z0Fo0W21G6O34FwyLIKx67zDZvCfTaImbIn2 ulCF9+ERwIp8er0fXnZVtLVm2TwCstCjnSY3oPrntx9OcZvC7zp6KSOc8Rk7yZAtOp OfZ3OLnUHH2PA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 53039 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-LBDDaihlu+Zx3EAE/a0a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable retitle [PATCH core-updates-frozen] build-system-python: Change let* to let= . thanks >[python-build-system.scm] > - (let* ((out (python-output outputs)) > - (python (assoc-ref inputs "python"))) > + (let ((out (python-output outputs)) > + (python (assoc-ref inputs "python"))) According to "guix refresh -l python-six", this would rebuild a lot (at least 3122), so this would need to be done on core-updates. Seems ok otherwise. --=-LBDDaihlu+Zx3EAE/a0a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYdtNoxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rLeAQCoXB5oWxnPAwXk+Js8bgGARgq9 tGx+X6jevrlXdMcYiQEArv+YRBSP86uOYnQu317fMp20f0cZZDiMQMdRX9dPDQI= =ZJeD -----END PGP SIGNATURE----- --=-LBDDaihlu+Zx3EAE/a0a-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 09:07:23 2022 Received: (at 53039-done) by debbugs.gnu.org; 18 May 2022 13:07:23 +0000 Received: from localhost ([127.0.0.1]:59368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrJOc-0001TO-Ce for submit@debbugs.gnu.org; Wed, 18 May 2022 09:07:23 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:42778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrJOM-0001Sb-K3 for 53039-done@debbugs.gnu.org; Wed, 18 May 2022 09:07:21 -0400 Received: by mail-qk1-f171.google.com with SMTP id j6so1355973qkp.9 for <53039-done@debbugs.gnu.org>; Wed, 18 May 2022 06:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=oUA/uib+3p/rFe874kzNASkSFE7lk1E796BEqyyUqAM=; b=ltEeBOFVlnmG1fgv0hdDBgq0VsMENasa87jvTs7xGa5uv0+TrojT+BwjhV64Jbyc8v 4aa1i8Jo65PegR8gMOd/0v2gv4SXR+98YjnS9GRb23nu5hhWj0g1vaTZmszPjoefrfzG m61gEq7Vs1GmY+mKBL0eLpDBSajZPTyU8z0Yz3GfqVyLa9PU1Zydh2AahLxwKoY+HeAp NO0PAnYKmGDqBtW9fQHI6w7MSK8t0rNs/ldZQqVkpyONdAm2vBT1HV8+3T/OX6VFZG1x xuq6l8O1blUrBl6wOVDD1XbW8l5RSlryS7jOFhWGvw2Psj/AvY20v2na3f8TnU0j/6oQ tjvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=oUA/uib+3p/rFe874kzNASkSFE7lk1E796BEqyyUqAM=; b=Gkcy4x34fpd8jDFAx2NcDzY+6Bxy2FV+emArP/F/ssFTDkVfF5L0q/PRU/gmcmi+bh hQBcDGEDS7trVwJjHMWhTLKMYpYPb2NilXuBcjsPVp7rL0g9NDjeBt3oTOii867Ceyq6 n/IxTjpJT/zR3eqEW6cZFhmAxOWuJ7BxPg6yqqCmp2Uw2paUSzgZRg8TRkaT18uDw7qj FDxAscF7MXANXeHK7PZosQf8eft4a9a2HlHXbSgn8PWUgGw6iyOr0/7vSJnOboETTpkM OaDJ5ayjMmfFpyalD8V+MIIAq0HJ3fZs8CqhXF13UI8d+q/gVypD12lY61uIu/SJ19+K rxGg== X-Gm-Message-State: AOAM531jNiwzrQJN1SbwOqcS6JyjdBQGgbllNvduUzA0wNh+k7o9mtUk tQ16379XFROeJrAh7h+ikKjjplaFu54jlV0Q X-Google-Smtp-Source: ABdhPJxt8pD+22AMLXE6YBRX9Z8eV2R8x/7/eDuDmcEFAEnP8TBiC0cbuKNCCzU+/LC3H7s8SzRBrQ== X-Received: by 2002:a05:620a:400f:b0:6a0:5a16:69f3 with SMTP id h15-20020a05620a400f00b006a05a1669f3mr20050006qko.103.1652879220678; Wed, 18 May 2022 06:07:00 -0700 (PDT) Received: from hurd (dsl-205-233-124-104.b2b2c.ca. [205.233.124.104]) by smtp.gmail.com with ESMTPSA id x12-20020ac85f0c000000b002f39b99f6bdsm1292395qta.87.2022.05.18.06.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 06:07:00 -0700 (PDT) From: Maxim Cournoyer To: jgart Subject: Re: bug#53039: [PATCH] build-system/python: Change let* to let. References: <20220105224600.9227-1-jgart@dismail.de> Date: Wed, 18 May 2022 09:06:58 -0400 In-Reply-To: <20220105224600.9227-1-jgart@dismail.de> (jgart@dismail.de's message of "Wed, 5 Jan 2022 17:46:00 -0500") Message-ID: <87czgb0z2l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53039-done Cc: 53039-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, jgart writes: > * guix/build/python-build-system.scm (site-packages): Change let* to let = for > readability and since let* is unused. > --- > guix/build/python-build-system.scm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/guix/build/python-build-system.scm b/guix/build/python-build= -system.scm > index 08871f60cd..a9b1c74f63 100644 > --- a/guix/build/python-build-system.scm > +++ b/guix/build/python-build-system.scm > @@ -11,6 +11,7 @@ > ;;; Copyright =C2=A9 2020 Efraim Flashner > ;;; Copyright =C2=A9 2021 Lars-Dominik Braun > ;;; Copyright =C2=A9 2021 Maxime Devos > +;;; Copyright =C2=A9 2022 jgart > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -176,8 +177,8 @@ (define (python-output outputs) >=20=20 > (define (site-packages inputs outputs) > "Return the path of the current output's Python site-package." > - (let* ((out (python-output outputs)) > - (python (assoc-ref inputs "python"))) > + (let ((out (python-output outputs)) > + (python (assoc-ref inputs "python"))) > (string-append out "/lib/python" (python-version python) "/site-pack= ages"))) >=20=20 > (define (add-installed-pythonpath inputs outputs) As Maxime mentioned, that should go to core-updates. It's nice to use the --subject-prefix option of 'git format-patch' to change it to "[PATCH core-updates]", so that we don't apply these mistakenly to master and cause world rebuilds :-) Another note; only changes of minimally 10 lines are copyrightable, so you do not need to add a copyright attribution for trivial changes such as this one. I've made the change to core-updates and committed as 47fac5dc59; closing. Thank you! Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu May 19 00:51:12 2022 Received: (at 53039-done) by debbugs.gnu.org; 19 May 2022 04:51:12 +0000 Received: from localhost ([127.0.0.1]:34162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrY80-0007uX-9H for submit@debbugs.gnu.org; Thu, 19 May 2022 00:51:12 -0400 Received: from mx2.dismail.de ([159.69.191.136]:25900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrY7x-0007uI-PW for 53039-done@debbugs.gnu.org; Thu, 19 May 2022 00:51:11 -0400 Received: from mx2.dismail.de (localhost [127.0.0.1]) by mx2.dismail.de (OpenSMTPD) with ESMTP id bb6d5c56; Thu, 19 May 2022 06:51:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date :message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s= 20190914; bh=20wt7+AimxWDyQNNBKOdhBM5FoyQ2neRdV0/MYfK+AA=; b=DDl avNeLW9J1n2LF/1Jmfc/jUTvgd2Mz+z/Ml9ZbND69SiJYOXGJXX+PTKwPzp1sA0+ CLjGy83B4wwh1s8azNw8dqAdJ1vNbr4LuIeFz1O9n5wNxO7+BBa9jpA09EVjfBQO eYwHVKD4R07B5s2dyoleLPXeLCFcJhUvPov/sPDh3EFCo3m9GVpzIaAousu+8v9Z 3wcBS+V3b6wuKS3EpIUOQuHQ9H6lk8+b/Th5+uLnF+azDIzAJf/wrs/kdYkvB3U4 tSAqTMvwhNuk6IibzDh2qI0s57VgwN+YwZlWb6Bw/0rf/d5wlFe1OPSf62O5GnUt XCunR2+CYjNr9TmdTbQ== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 096413bc; Thu, 19 May 2022 06:51:03 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id 806fde5c; Thu, 19 May 2022 06:51:03 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 9bf2f1b4 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 19 May 2022 06:51:02 +0200 (CEST) Date: Wed, 18 May 2022 23:50:56 -0500 Message-ID: <20220518235056.GD14290@gac> From: jgart To: Maxim Cournoyer Subject: Re: bug#53039: [PATCH] build-system/python: Change let* to let. In-Reply-To: <87czgb0z2l.fsf@gmail.com> References: <20220105224600.9227-1-jgart@dismail.de> <87czgb0z2l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 53039-done Cc: 53039-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Wed, 18 May 2022 09:06:58 -0400 Maxim Cournoyer wrote: > I've made the change to core-updates and committed as 47fac5dc59; closing. Hi Maxim, Thank you for doing that. Sorry, I couldn't get to it. I've been in the onboarding process of starting a new job and moving to a new city and have been really busy. Hope to get some free time soon to continue contributing to Guix :) all best, jgart From unknown Fri Jun 20 07:25:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Jun 2022 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator