GNU bug report logs - #53036
[PATCH] gnu: syncthing-gtk: Fix autostart.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#53036: closed ([PATCH] gnu: syncthing-gtk: Fix autostart.)
Date: Wed, 05 Jan 2022 21:14:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 5 Jan 2022 16:13:00 -0500
with message-id <YdYJ3LxdBjPVw/F8 <at> jasmine.lan>
and subject line Re: [bug#53036] [PATCH] gnu: syncthing-gtk: Fix autostart.
has caused the debbugs.gnu.org bug report #53036,
regarding [PATCH] gnu: syncthing-gtk: Fix autostart.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
53036: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53036
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: syncthing-gtk: Fix autostart.
Date: Wed, 05 Jan 2022 19:20:14 +0000

[Message part 3 (text/plain, inline)]

Hello,

This is a simple fix/workaround for https://issues.guix.gnu.org/50789

As discussed there, there is not a perfect solution for syncthing-gtk writing ~/.config/autostart/Syncthing-GTK.desktop with the Exec line pointing to the store path of ".syncthing-gtk-real". I've opted for a simple fix that won't break upon changes to the syncthing-gtk store path that was done similarly to e.g. the desktop files Flatpak writes in 9c4244cc73db4d5c3adf6f8342f6b08b39dd3628: just use plain "syncthing-gtk". While this means different syncthing-gtk could conflict (whatever is first in PATH wins), that seems unlikely given this package is just a frontend to syncthing. Anyway, seems like the best option right now so that the autostart file is usable and won't break.

Thanks,
John

[0001-gnu-syncthing-gtk-Fix-autostart.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: John Kehayias via Guix-patches via <guix-patches <at> gnu.org>
Cc: 53036-done <at> debbugs.gnu.org
Subject: Re: [bug#53036] [PATCH] gnu: syncthing-gtk: Fix autostart.
Date: Wed, 5 Jan 2022 16:13:00 -0500

On Wed, Jan 05, 2022 at 07:20:14PM +0000, John Kehayias via Guix-patches via wrote:
> From 1d62676b2b507f67103110c3fce5d8c6dc483f8b Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias <at> protonmail.com>
> Date: Wed, 5 Jan 2022 14:09:42 -0500
> Subject: [PATCH] gnu: syncthing-gtk: Fix autostart.
> 
> * gnu/packages/syncthing.scm (syncthing-gtk)[#:phases]: Add autostart-path
> phase to use "syncthing-gtk" (rather than a store path to
> ".syncthing-gtk-real") as the exec command for the autostart desktop file
> written by syncthing-gtk.

Thanks! I pushed as c37559e81979232feee07aa1eb39faacb093c5ca with the
following changes:

1) I renamed the phase to 'fix-autostart-path'. It's not very important
but typically build phases are named imperatively.

2) I rewrote the commit message and code comment to be more clear about
what the change does. I found it a bit confusing and had to reread the
previous discussion to remind myself. Hopefully this is an improvement.

Thanks again for taking care of this package!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.