From unknown Sat Jun 21 05:06:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#53020 <53020@debbugs.gnu.org> To: bug#53020 <53020@debbugs.gnu.org> Subject: Status: [PATCH] gnu: racket: Backport fix for .desktop files. Reply-To: bug#53020 <53020@debbugs.gnu.org> Date: Sat, 21 Jun 2025 12:06:22 +0000 retitle 53020 [PATCH] gnu: racket: Backport fix for .desktop files. reassign 53020 guix-patches submitter 53020 Philip McGrath severity 53020 normal tag 53020 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 01:09:14 2022 Received: (at submit) by debbugs.gnu.org; 5 Jan 2022 06:09:14 +0000 Received: from localhost ([127.0.0.1]:39398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4zU1-0002Ky-G5 for submit@debbugs.gnu.org; Wed, 05 Jan 2022 01:09:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:47266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4zTu-0002Kk-1v for submit@debbugs.gnu.org; Wed, 05 Jan 2022 01:09:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4zTt-0004GE-Lt for guix-patches@gnu.org; Wed, 05 Jan 2022 01:09:05 -0500 Received: from [2607:f8b0:4864:20::936] (port=34627 helo=mail-ua1-x936.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4zTq-0002Sj-UC for guix-patches@gnu.org; Wed, 05 Jan 2022 01:09:05 -0500 Received: by mail-ua1-x936.google.com with SMTP id y4so10427550uad.1 for ; Tue, 04 Jan 2022 22:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HTzvWCtMJCvZBeqZz6BW3EthvpDFblcrHpULtVtmSfo=; b=SqInOtQ4UPfFySx43ql/M+DPHWs+jLYKrDAqUDZmOLtP3Y58zrA+jGH3QecJghvvVW bOYxZjAkMammiOc0fiHgkjv8/1z1BotZSUwG2Ix9AkY8GmmwmBfj7qmtHIX/Ux02iq2l tKZVvWvW6tpsilOG23Bg2ljKZ2sYqbJQ+vWA95JUj5+hpK2AGAI3xX1ShTHV1217PVsg FpIFhS9572ZjZEHjQQQ2oF0BEYzASNpgnVhTC8DqHPnZmiIA4x/SOiuNFmaVA5im/bI9 N1H7DjBR7dTXbAuLooyXduTtI5BTBSbtV+HnBlthHgmUyUn744sB+Th6RMg85veobJOj 3HGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HTzvWCtMJCvZBeqZz6BW3EthvpDFblcrHpULtVtmSfo=; b=yT0MDESD6wWiaxKg+uTX6m048g4O4TWH9jF9wS8fy2d3KXQoFZjJI3tAh0TBV5YE61 MRg5S8tOuOmKXCzaz8EwxvsBHVK3yA3qfIbH1a99PoFMvU2wSc7EgnsWh748owLU8XRy 5Sc89J4JAY5Uk56JcjakhOFMmu/FsN3/QvNm3QlTXri+hU7T/kS797hX7Y4EeZ8BAlqg 9FJL/vB1eMT7WL7dB8fcfCGHeSKgnmAUmayVjGWDUJd41c/b9daG0cqoqcrAATwuWj7/ e4nnC4UJ0ZWlL/BGoPjRDry5eTTBlb39Ca+j7FfHTs7YzcfnK4XRwMIl/dNYoASyvMgF 5WPw== X-Gm-Message-State: AOAM532CgYGLpkctVsoszxt8hcoCQDudHPP3pWPFfVxruR0PXDS/G6Tv mo9keVtrAw8+LKOSOGxyPtEeWdosz3lStdy+ X-Google-Smtp-Source: ABdhPJz8JAf7XBLngBrEtJgBNen5ZbpZreFfL4l33N5cjueV5PFkrx2d/QafGyejBNUpEPCKgTI/mg== X-Received: by 2002:ab0:700e:: with SMTP id k14mr13849396ual.105.1641362940080; Tue, 04 Jan 2022 22:09:00 -0800 (PST) Received: from localhost (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with UTF8SMTPSA id n9sm4075540uaj.11.2022.01.04.22.08.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 22:08:59 -0800 (PST) From: Philip McGrath To: guix-patches@gnu.org Subject: [PATCH] gnu: racket: Backport fix for .desktop files. Date: Wed, 5 Jan 2022 01:06:31 -0500 Message-Id: <20220105060630.218938-1-philip@philipmcgrath.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-Debbugs-CC: Philip McGrath Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::936 (failed) Received-SPF: neutral client-ip=2607:f8b0:4864:20::936; envelope-from=philip@philipmcgrath.com; helo=mail-ua1-x936.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Philip McGrath X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) This commit backports a repair by Matthew Flatt for Racket's creation and installation of '.desktop' files in tethered Racket installations. Guix's 'racket' package is structured as a tethered installation, so the Guix package now installs 'drracket.desktop' and 'slideshow.desktop' properly, for example. For further upstream discussion, see: . * gnu/packages/patches/racket-minimal-backport-4079-fix.patch: New patch. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/racket.scm (racket-minimal)[source]: Use it. (extend-layer): Set config-tethered-apps-dir. --- Guix is a significant use-case for this functionality in Racket, so it would be great to have more Guix users confirm that these repairs fully solve the problem before the upcoming Racket 8.4 release. gnu/local.mk | 1 + .../racket-minimal-backport-4079-fix.patch | 318 ++++++++++++++++++ gnu/packages/racket.scm | 15 +- 3 files changed, 330 insertions(+), 4 deletions(-) create mode 100644 gnu/packages/patches/racket-minimal-backport-4079-fix.patch diff --git a/gnu/local.mk b/gnu/local.mk index c8ec622aa1..008583d0f5 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1748,6 +1748,7 @@ dist_patch_DATA = \ %D%/packages/patches/ripperx-missing-file.patch \ %D%/packages/patches/rpcbind-CVE-2017-8779.patch \ %D%/packages/patches/rtags-separate-rct.patch \ + %D%/packages/patches/racket-minimal-backport-4079-fix.patch \ %D%/packages/patches/racket-minimal-sh-via-rktio.patch \ %D%/packages/patches/remake-impure-dirs.patch \ %D%/packages/patches/restic-0.9.6-fix-tests-for-go1.15.patch \ diff --git a/gnu/packages/patches/racket-minimal-backport-4079-fix.patch b/gnu/packages/patches/racket-minimal-backport-4079-fix.patch new file mode 100644 index 0000000000..8af48476e0 --- /dev/null +++ b/gnu/packages/patches/racket-minimal-backport-4079-fix.patch @@ -0,0 +1,318 @@ +From 05263c7b306e156f256942bd5a099d17846b5d30 Mon Sep 17 00:00:00 2001 +From: Matthew Flatt +Date: Mon, 3 Jan 2022 13:53:30 -0700 +Subject: [PATCH 1/2] config: add '{config,addon}-tethered-apps-dir + +Support ".desktop" files in a tethered layer. + +Addresses #4079 + +(cherry picked from commit 11ccee31d6c0903720250655fda3f7ed879769e8) +--- + .../scribblings/raco/launcher.scrbl | 13 ++++-- + pkgs/racket-doc/scribblings/raco/setup.scrbl | 43 ++++++++++++------- + racket/collects/launcher/launcher.rkt | 39 ++++++++++------- + racket/collects/setup/dirs.rkt | 13 +++++- + racket/collects/setup/private/dirs.rkt | 2 + + 5 files changed, 75 insertions(+), 35 deletions(-) + +diff --git a/pkgs/racket-doc/scribblings/raco/launcher.scrbl b/pkgs/racket-doc/scribblings/raco/launcher.scrbl +index daece40c57..9a94a624b5 100644 +--- a/pkgs/racket-doc/scribblings/raco/launcher.scrbl ++++ b/pkgs/racket-doc/scribblings/raco/launcher.scrbl +@@ -415,14 +415,21 @@ Backward-compatible aliases for + @history[#:changed "6.5.0.2" @elem{Added the @racket[#:tethered?] argument.}]} + + +-@defproc[(installed-executable-path->desktop-path [exec-path path-string?] [user? any/c]) +- (and/c path? complete-path?)]{ ++@defproc[(installed-executable-path->desktop-path [exec-path path-string?] [user? any/c] [tethered? any/c]) ++ (or/c (and/c path? complete-path?) #f)]{ + + Returns a path for a @filepath{.desktop} file to describe the + installed executable at @racket[exec-path]. Only the filename part of + @racket[exec-path] is used. The @racket[user?] argument should be true + if @racket[exec-path] is installed in a user-specific location (in +-which case the result path will also be user-specific).} ++which case the result path will also be user-specific). The ++@racket[tethered?] argument should be true for a @tech{tethered} ++install. The result can be @racket[#f] only when @racket[tethered?] is ++true and @racket[find-addon-tethered-apps-dir] (when @racket[user?] is ++true) or @racket[find-config-tethered-apps-dir] (when @racket[user?] is ++@racket[#f]) returns @racket[#f]. ++ ++@history[#:changed "8.3.0.11" @elem{Added the @racket[tethered?] argument.}]} + + + @defproc[(installed-desktop-path->icon-path [desktop-path path-string?] +diff --git a/pkgs/racket-doc/scribblings/raco/setup.scrbl b/pkgs/racket-doc/scribblings/raco/setup.scrbl +index f1d2b99c52..f7d1051419 100644 +--- a/pkgs/racket-doc/scribblings/raco/setup.scrbl ++++ b/pkgs/racket-doc/scribblings/raco/setup.scrbl +@@ -1775,9 +1775,11 @@ current-system paths while @racket[get-cross-lib-search-dirs] and + @deftogether[( + @defproc[(find-addon-tethered-console-bin-dir) (or/c #f path?)] + @defproc[(find-addon-tethered-gui-bin-dir) (or/c #f path?)] ++@defproc[(find-addon-tethered-apps-dir) (or/c #f path?)] + )]{ + Returns a path to a user-specific directory to hold an extra copy of +- each installed executable, where the extra copy is created by ++ each installed executable and @filepath{.desktop} ++ file (for Unix), where the extra copy is created by + @exec{raco setup} and tethered to a particular result for + @racket[(find-system-path 'addon-dir)] and + @racket[(find-config-dir)]. +@@ -1785,33 +1787,39 @@ current-system paths while @racket[get-cross-lib-search-dirs] and + Unlike other directories, which are configured via + @filepath{config.rktd} in the @racket[(find-config-dir)] directory + (see @secref["config-file"]), these paths are configured via +- @racket['addon-tethered-console-bin-dir] and +- @racket['addon-tethered-gui-bin-dir] entries in ++ @racket['addon-tethered-console-bin-dir], ++ @racket['addon-tethered-gui-bin-dir], and ++ @racket['addon-tethered-apps-dir] entries in + @filepath{config.rktd} in @racket[(build-path (find-system-path + 'addon-dir) "etc")]. If no configuration is present, the result from + the corresponding function, +- @racket[find-addon-tethered-console-bin-dir] or +- @racket[find-addon-tethered-gui-bin-dir], is @racket[#f] instead of ++ @racket[find-addon-tethered-console-bin-dir], ++ @racket[find-addon-tethered-gui-bin-dir], or ++ @racket[find-addon-tethered-apps-dir], is @racket[#f] instead of + a path. + + See @secref["tethered-install"] for more information. + +- @history[#:added "6.5.0.2"]} ++ @history[#:added "6.5.0.2" ++ #:changed "8.3.0.11" @elem{Added @racket[find-addon-tethered-apps-dir].}]]} + + + @deftogether[( + @defproc[(find-config-tethered-console-bin-dir) (or/c #f path?)] + @defproc[(find-config-tethered-gui-bin-dir) (or/c #f path?)] ++@defproc[(find-config-tethered-apps-dir) (or/c #f path?)] + )]{ +- Similar to @racket[find-addon-tethered-console-bin-dir] and +- @racket[find-addon-tethered-gui-bin-dir], but configured via ++ Similar to @racket[find-addon-tethered-console-bin-dir], ++ @racket[find-addon-tethered-gui-bin-dir], and ++ @racket[find-addon-tethered-apps-dir], but configured via + @filepath{config.rktd} in the @racket[(find-config-dir)] directory + (see @secref["config-file"]) and triggers executables that are + tethered only to a particular value of @racket[(find-config-dir)]. + + See @secref["tethered-install"] for more information. + +- @history[#:added "6.5.0.2"]} ++ @history[#:added "6.5.0.2" ++ #:changed "8.3.0.11" @elem{Added @racket[find-addon-tethered-apps-dir].}]} + + @; ------------------------------------------------------------------------ + +@@ -2578,9 +2586,11 @@ layer: + directory @nonterm{addon-dir} and a + @filepath{@nonterm{addon-dir}/etc/config.rktd} file that maps + @racket['addon-tethered-console-bin-dir] to +- @nonterm{tethered-bin-dir} and ++ @nonterm{tethered-bin-dir}, + @racket['addon-tethered-gui-bin-dir] to +- @nonterm{tethered-gui-bin-dir}. Initialize the tethered layer ++ @nonterm{tethered-gui-bin-dir}, and (optionally) ++ @racket['addon-tethered-apps-dir] to ++ @nonterm{tethered-apps-dir}. Initialize the tethered layer + with + + @commandline{racket -A @nonterm{addon-dir} -l- raco setup --avoid-main}} +@@ -2588,10 +2598,12 @@ layer: + @item{An @defterm{installation} layer with tethering is like a one + without tethering (see @secref["layered-install"]), but where + the layer's @filepath{@nonterm{layer-dir}/etc/config.rktd} file +- that maps @racket['config-tethered-console-bin-dir] to +- @nonterm{tethered-bin-dir} and ++ maps @racket['config-tethered-console-bin-dir] to ++ @nonterm{tethered-bin-dir}, + @racket['config-tethered-gui-bin-dir] to +- @nonterm{tethered-gui-bin-dir}. The @racket['bin-dir] and ++ @nonterm{tethered-gui-bin-dir}, and (optionally) ++ @racket['config-tethered-apps-dir] to ++ @nonterm{tethered-apps-dir}. The @racket['bin-dir] and + @racket['gui-bin-dir] configurations can point to the same + directories, but executables are not specifically created there by + @exec{raco setup}. Initialize the tethered layer with +@@ -2602,7 +2614,8 @@ layer: + + In either case, initialization creates tethered executables in the + directories @nonterm{tethered-bin-dir} and +-@nonterm{tethered-gui-bin-dir}. Thereafter, tethered executables like ++@nonterm{tethered-gui-bin-dir}, writing @filepath{.desktop} files ++(for Unix) in @nonterm{tethered-apps-dir} (if specified). Thereafter, tethered executables like + @exec{@nonterm{tethered-bin-dir}/racket} and + @exec{@nonterm{tethered-bin-dir}/raco} can be used to work with the + tethered layer. +diff --git a/racket/collects/launcher/launcher.rkt b/racket/collects/launcher/launcher.rkt +index e48cd623cc..ca8d64745d 100644 +--- a/racket/collects/launcher/launcher.rkt ++++ b/racket/collects/launcher/launcher.rkt +@@ -530,18 +530,23 @@ + (file-name-from-path dest)) + (cdr m))))))) + +-(define (installed-executable-path->desktop-path dest user?) ++(define (installed-executable-path->desktop-path dest user? tethered?) + (unless (path-string? dest) + (raise-argument-error 'installed-executable-path->desktop-path + "path-string?" + dest)) +- (define dir (if user? +- (find-user-apps-dir) +- (or (find-apps-dir) +- (error 'installed-executable-path->desktop-path +- "no installation directory is available")))) +- (path-replace-extension (build-path dir (file-name-from-path dest)) +- #".desktop")) ++ (define dir (if tethered? ++ (if user? ++ (find-addon-tethered-apps-dir) ++ (find-config-tethered-apps-dir)) ++ (if user? ++ (find-user-apps-dir) ++ (or (find-apps-dir) ++ (error 'installed-executable-path->desktop-path ++ "no installation directory is available"))))) ++ (and dir ++ (path-replace-extension (build-path dir (file-name-from-path dest)) ++ #".desktop"))) + + (define (installed-desktop-path->icon-path dest user? extension) + ;; We put icons files in "share" so that `setup/unixstyle-install' +@@ -566,13 +571,16 @@ + (define (check-desktop aux dest) + (when (eq? 'unix (cross-system-type)) + (let ([im (assoc 'install-mode aux)]) +- (when (and im (member (cdr im) '(main user))) +- (define user? (eq? (cdr im) 'user)) +- ;; create Unix ".desktop" files, if any +- (let ([m (assoc 'desktop aux)]) +- (when (and m (cdr m)) +- (define file (installed-executable-path->desktop-path dest +- user?)) ++ (define addon? (and im (eq? (cdr im) 'addon-tethered))) ++ (define config? (and im (eq? (cdr im) 'config-tethered))) ++ (define user? (or addon? (and im (eq? (cdr im) 'user)))) ++ ;; create Unix ".desktop" files, if any ++ (let ([m (assoc 'desktop aux)]) ++ (when (and m (cdr m)) ++ (define file (installed-executable-path->desktop-path dest ++ user? ++ (or addon? config?))) ++ (when file + (make-directory* (path-only file)) + (define (adjust-path p) + ;; A ".desktop" file is supposed to have absolute paths +@@ -582,6 +590,7 @@ + ;; and be patched up by `setup/unixstyle-install'. + (let ([p (simple-form-path (path->complete-path p))]) + (if (or user? ++ config? + (get-absolute-installation?)) + p + (find-relative-path (simple-form-path (path-only file)) p)))) +diff --git a/racket/collects/setup/dirs.rkt b/racket/collects/setup/dirs.rkt +index 3721a8fabe..0a6469f1e7 100644 +--- a/racket/collects/setup/dirs.rkt ++++ b/racket/collects/setup/dirs.rkt +@@ -14,6 +14,7 @@ + config:gui-bin-search-dirs + config:config-tethered-console-bin-dir + config:config-tethered-gui-bin-dir ++ config:config-tethered-apps-dir + config:lib-search-dirs + config:share-search-dirs + config:man-search-dirs +@@ -45,7 +46,8 @@ + [(unix) "bin"])) + + (provide find-config-tethered-console-bin-dir +- find-config-tethered-gui-bin-dir) ++ find-config-tethered-gui-bin-dir ++ find-config-tethered-apps-dir) + + (define (find-config-tethered-console-bin-dir) + (force config:config-tethered-console-bin-dir)) +@@ -53,8 +55,12 @@ + (define (find-config-tethered-gui-bin-dir) + (force config:config-tethered-gui-bin-dir)) + ++(define (find-config-tethered-apps-dir) ++ (force config:config-tethered-apps-dir)) ++ + (provide find-addon-tethered-console-bin-dir +- find-addon-tethered-gui-bin-dir) ++ find-addon-tethered-gui-bin-dir ++ find-addon-tethered-apps-dir) + + (define addon-bin-table + (delay/sync +@@ -87,6 +93,9 @@ + (define (find-addon-tethered-gui-bin-dir) + (find-addon-bin-dir 'addon-tethered-gui-bin-dir)) + ++(define (find-addon-tethered-apps-dir) ++ (find-addon-bin-dir 'addon-tethered-apps-dir)) ++ + ;; ---------------------------------------- + ;; Extra search paths + +diff --git a/racket/collects/setup/private/dirs.rkt b/racket/collects/setup/private/dirs.rkt +index 745e9c0f59..fa1477d627 100644 +--- a/racket/collects/setup/private/dirs.rkt ++++ b/racket/collects/setup/private/dirs.rkt +@@ -73,6 +73,7 @@ + (define config:gui-bin-search-dirs (delay/sync (or (force config:gui-bin-search-dirs/raw) (force config:bin-search-dirs)))) + (define-config config:config-tethered-console-bin-dir 'config-tethered-console-bin-dir to-path) + (define-config config:config-tethered-gui-bin-dir 'config-tethered-gui-bin-dir to-path) ++(define-config config:config-tethered-apps-dir 'config-tethered-apps-dir to-path) + (define-config config:man-dir 'man-dir to-path) + (define-config config:man-search-dirs 'man-search-dirs to-path) + (define-config config:links-file 'links-file to-path) +@@ -289,6 +290,7 @@ + config:gui-bin-dir + config:config-tethered-console-bin-dir + config:config-tethered-gui-bin-dir ++ config:config-tethered-apps-dir + config:bin-search-dirs + config:gui-bin-search-dirs) + +-- +2.32.0 + + +From 61d31acc4f5a12b648dd1d4bba4811ccd95d7568 Mon Sep 17 00:00:00 2001 +From: Matthew Flatt +Date: Tue, 4 Jan 2022 10:52:42 -0700 +Subject: [PATCH 2/2] launcher: fix new argument that is meant to be optional + +Repairs a problem with 11ccee31d6. + +(cherry picked from commit ece8b17fd6ea05268a647ff8810d0acee1f3b5e3) +--- + racket/collects/launcher/launcher.rkt | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/racket/collects/launcher/launcher.rkt b/racket/collects/launcher/launcher.rkt +index ca8d64745d..e2b03c6b0b 100644 +--- a/racket/collects/launcher/launcher.rkt ++++ b/racket/collects/launcher/launcher.rkt +@@ -530,7 +530,7 @@ + (file-name-from-path dest)) + (cdr m))))))) + +-(define (installed-executable-path->desktop-path dest user? tethered?) ++(define (installed-executable-path->desktop-path dest user? [tethered? #f]) + (unless (path-string? dest) + (raise-argument-error 'installed-executable-path->desktop-path + "path-string?" +-- +2.32.0 + diff --git a/gnu/packages/racket.scm b/gnu/packages/racket.scm index d0a5ca494b..1d834e5a39 100644 --- a/gnu/packages/racket.scm +++ b/gnu/packages/racket.scm @@ -139,7 +139,13 @@ (define-public racket-minimal (sha256 "1i1jnv1wb0kanfg47hniafx2vhwjc33qqx66lq7wkf5hbmgsyws3") (file-name (git-file-name name version)) - (patches (search-patches "racket-minimal-sh-via-rktio.patch")) + (patches (search-patches "racket-minimal-sh-via-rktio.patch" + ;; The following patch backports a repair + ;; for generating .desktop files, motivated in + ;; part by Guix: it should no longer be needed + ;; by Racket 8.4. See upstream discussion at: + ;; https://github.com/racket/racket/issues/4079 + "racket-minimal-backport-4079-fix.patch")) (modules '((guix build utils))) (snippet (with-imported-modules '((guix build utils)) @@ -589,9 +595,10 @@ (define rx:racket (build-path-string parent-layer pth)) (filter values (hash-ref config search-key null)))))] [config - (hash-set config - 'apps-dir - (build-path-string prefix "share/applications"))] + (let ([apps-dir (build-path-string prefix "share/applications")]) + (hash-set* config + 'apps-dir apps-dir + 'config-tethered-apps-dir apps-dir))] [config ;; place new foreign lib-search-dirs before old ;; foreign dirs, but after Racket layers -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 04:00:39 2022 Received: (at 53020) by debbugs.gnu.org; 5 Jan 2022 09:00:40 +0000 Received: from localhost ([127.0.0.1]:39527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n529v-0006ec-Nn for submit@debbugs.gnu.org; Wed, 05 Jan 2022 04:00:39 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:36849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n529s-0006eO-TE for 53020@debbugs.gnu.org; Wed, 05 Jan 2022 04:00:38 -0500 Received: by mail-wr1-f44.google.com with SMTP id r17so81478264wrc.3 for <53020@debbugs.gnu.org>; Wed, 05 Jan 2022 01:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=IVG0MCOvsjQVgL57pVHI07S9LC2CsbdZIpdVjeUbtEk=; b=WLavVF6TKgW+yvHurh5QxdkuazMoRuUW/dofhDRltQD3D7xi74Jm284OSOL0TodWZv 9Nkm+NhnVSz20fu2+ZPlJ0c4zbDkUHNmBKuMZYqvow0ri+pQYpeIvoZl84Oyvr1X1VMC ZHOnsYOg1I/z4aSMl3csfJzeeVrjGp+iLqnronHxZpmmQ/BJigTUZy4m2EFlLV/W5rs5 UZwMbsAt+DnMFyyKEqT9391U1zpQYXPpl1GZWSv76u8IEGt6V0fARrMu1htWDgWBA5li p02+e0qJTNs1nvZIc5FVFsiYl9z9Vby5nJt3arshOYuSiDZNMYLBFeZPgl2J9K3A2yyX is6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=IVG0MCOvsjQVgL57pVHI07S9LC2CsbdZIpdVjeUbtEk=; b=FvBS4nTIqdpGr+RhlDpAOYD9hNDiAzVKmfeMxSs+ncjtG8MHln9Hq/DpDsRFOSvPpw K5cC55o+nCJ3/URN7wHm63R5IFDZzM1G8DYygozGDzMC+aaXFqmGL+zz8luJ0DPkM5pc ZPSR9H/r82TpfkmMRLRI8stlMyIpUXTg5h9IfRqL/0dBN+o5JIdj7AVwn/uHkT0YnWGq fuMDr2J9vAmfOq8FY1ZhWUc4+CM70bsrdadVqJQCu9H7MmlnrOnQAJHzoAyyBvdBmiFh PNaK2TWYm7rUwypqanTpEUGEpTT9xMgk7m+Vfh7TBdUIfN4J5+XXww7B3Dud053fKs9i 3IUw== X-Gm-Message-State: AOAM5307s6i9/+Soh9yRTjB8JTVrIe+paQX4MQTtAIO/368/CIwX1g5M 3XXopv7Kkgp07dI8srV3goA= X-Google-Smtp-Source: ABdhPJxT1S4JQdsglHUIuJuYbW/s1Oj+p+NccoJLGee6giJ0m1Odx/74mi95qjR/A4KVF9HfaT2/rA== X-Received: by 2002:a5d:64c2:: with SMTP id f2mr46387667wri.483.1641373230884; Wed, 05 Jan 2022 01:00:30 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id m17sm40342109wrw.11.2022.01.05.01.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 01:00:30 -0800 (PST) From: zimoun To: Philip McGrath , 53020@debbugs.gnu.org Subject: Re: [bug#53020] [PATCH] gnu: racket: Backport fix for .desktop files. In-Reply-To: <20220105060630.218938-1-philip@philipmcgrath.com> References: <20220105060630.218938-1-philip@philipmcgrath.com> Date: Wed, 05 Jan 2022 09:59:59 +0100 Message-ID: <86v8yy8smo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53020 Cc: Philip McGrath X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Philip, On Wed, 05 Jan 2022 at 01:06, Philip McGrath wrote: > This commit backports a repair by Matthew Flatt for Racket's > creation and installation of '.desktop' files in tethered Racket > installations. Guix's 'racket' package is structured as a tethered > installation, so the Guix package now installs 'drracket.desktop' > and 'slideshow.desktop' properly, for example. For further upstream > discussion, see: . In this mentioned issue, it reads: I will send a patch to Guix in the hope of getting more people to try 11ccee3 and ece8b17 before the 8.4 release. > * gnu/packages/patches/racket-minimal-backport-4079-fix.patch: New > patch. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/racket.scm (racket-minimal)[source]: Use it. > (extend-layer): Set config-tethered-apps-dir. So my naive question is: is it worth to include now and not just wait for the next Racket 8.4 release? (One or two months if Racket keep the 4 releases per year schedule) Other said, for testing new Racket features in the Guix ecosystem, it appears to me easier to use transformation: guix build racket-minimal --with-commit=ece8b17 (or something along this line :-)) BTW, thanks for bridging the gap between Guix and Racket and it can be cool if Guix can help Racket. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 06:26:50 2022 Received: (at 53020) by debbugs.gnu.org; 5 Jan 2022 11:26:50 +0000 Received: from localhost ([127.0.0.1]:39677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n54RN-0006Y6-Kj for submit@debbugs.gnu.org; Wed, 05 Jan 2022 06:26:49 -0500 Received: from mail-lf1-f53.google.com ([209.85.167.53]:39457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n54RK-0006Xr-Dr for 53020@debbugs.gnu.org; Wed, 05 Jan 2022 06:26:47 -0500 Received: by mail-lf1-f53.google.com with SMTP id bp20so88425646lfb.6 for <53020@debbugs.gnu.org>; Wed, 05 Jan 2022 03:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j2SVFneEoZery/SxcTVc0bP0MYgtLWqHon6m9Zywf+U=; b=edZPy4cL+3hTHk6nP5VeA//RRJLovbl1M5xuyva0uGwzQKRiv60v7nbAI9GcYPmiBI 0s3GMHGb35ctMtu6wHhYdIJG8zVPOyBKnvcfnMVRhpHD3hQLLVtk1Y7phryPA8XkFrUu ARiA3q+M0gBdDMKXs12fm7/Csx23Q7KbPkKJsYh99QxQnz2932JytHcMZPJMHL5qUkuE bAwikMYMYH7n/0y55APIkFK/+Do9UvCSAstYFgRb3X9mtOTCA1ufHZT1iAVUkSaCNOBO QH4j5ynm+qtZb6Qlj6DXyPed7lkpHN3rm58eqvsU5UOO+hoLZYGHZmZUjVxfXeHcG8hq vUBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j2SVFneEoZery/SxcTVc0bP0MYgtLWqHon6m9Zywf+U=; b=59JSqX9RmRBqreqFfoWjrLF+4ctLrlHB010uJAFlaKybmeiNGXQfpZomvowiyWewD8 NVyhrVJj2CZOFhZ4jNtxxu/uWtJDpiGpWTp4iRTfjgNqeC7asWKbyeUFsPeV7Qn48i6q aFnWgVT/uLZhCIUpoybJG6SL5+Vf4wzwVvhA5/vAq0INDrmkZubAKB+AQtEiDSy1A6+S wEsW0TOLdsOCgTNp+CQoQ8z0XlXaDXzp+ljoQy6p7wqCHUeX0XF1fAyFdPFtaVjVp2p/ tgoy5dC24OAPApMUK3g4lb/OYoPQrPptj0+iuhMZ0wHRmSIQHNzeM1vjjyAWp8bWPYK4 +qeg== X-Gm-Message-State: AOAM533iWQl/y+6lUbDzdUhjhPhaWn9GlenORK2+gGR1g+mE1vu0fpJp A64TDYdUBfeygSYSqsi+ndZgdQQtXr13FLaKY8HXsXsE X-Google-Smtp-Source: ABdhPJya/DA+El0nV072vE2yRmmi2gmdUF9ixWCfkf1nnojwYfsJB1cXokR7PAPOzRyIHNFhlsWOuI42dUpLnMPCxk4= X-Received: by 2002:ac2:46d4:: with SMTP id p20mr47246399lfo.653.1641382000335; Wed, 05 Jan 2022 03:26:40 -0800 (PST) MIME-Version: 1.0 References: <20220105060630.218938-1-philip@philipmcgrath.com> <86v8yy8smo.fsf@gmail.com> In-Reply-To: <86v8yy8smo.fsf@gmail.com> From: Malte Gerdes Date: Wed, 5 Jan 2022 12:26:28 +0100 Message-ID: Subject: Re: [bug#53020] [PATCH] gnu: racket: Backport fix for .desktop files. To: 53020@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000121df005d4d407e5" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 53020 Cc: Philip McGrath , zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000121df005d4d407e5 Content-Type: text/plain; charset="UTF-8" It builds with ``` guix build --with-git-url=racket=https://github.com/racket/racket --with-branch=racket-minimal=master --with-git-url=racket-minimal= https://github.com/racket/racket --with-branch=racket=master package ``` Where package is racket and racket-minimal respectively. Neither `/gnu/store/11y27mj1z7mhljw2w3ni7lp2w0a1zhfr-racket-git.master` nor /gnu/store/gfbyzj9b13kzi438cjfv43hij4zhh2sh-racket-minimal-git.master have .desktop files in their directory hierarchy. (I might be doing it wrong though) mfg On Wed, 5 Jan 2022, 10:01 zimoun, wrote: > Hi Philip, > > On Wed, 05 Jan 2022 at 01:06, Philip McGrath > wrote: > > > This commit backports a repair by Matthew Flatt for Racket's > > creation and installation of '.desktop' files in tethered Racket > > installations. Guix's 'racket' package is structured as a tethered > > installation, so the Guix package now installs 'drracket.desktop' > > and 'slideshow.desktop' properly, for example. For further upstream > > discussion, see: . > > In this mentioned issue, it reads: > > I will send a patch to Guix in the hope of getting more people > to try 11ccee3 and ece8b17 before the 8.4 release. > > > > > > * gnu/packages/patches/racket-minimal-backport-4079-fix.patch: New > > patch. > > * gnu/local.mk (dist_patch_DATA): Add it. > > * gnu/packages/racket.scm (racket-minimal)[source]: Use it. > > (extend-layer): Set config-tethered-apps-dir. > > So my naive question is: is it worth to include now and not just wait > for the next Racket 8.4 release? (One or two months if Racket keep the 4 > releases per year schedule) > > Other said, for testing new Racket features in the Guix ecosystem, it > appears to me easier to use transformation: > > guix build racket-minimal --with-commit=ece8b17 > > (or something along this line :-)) > > BTW, thanks for bridging the gap between Guix and Racket and it can be > cool if Guix can help Racket. :-) > > > Cheers, > simon > > > > --000000000000121df005d4d407e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It builds with=C2=A0

```
guix build --with-git-url=3Dracket=3D<= a href=3D"https://github.com/racket/racket">https://github.com/racket/racke= t --with-branch=3Dracket-minimal=3Dmaster --with-git-url=3Dracket-minim= al=3Dhttps://github.com/racket= /racket --with-branch=3Dracket=3Dmaster package
```
Where package is racket and racket-minimal r= espectively.


<= div dir=3D"auto">Neither `/gnu/store/11y27mj1z7mhljw2w3ni7lp2w0a1zhfr-racke= t-git.master` nor /gnu/store/gfbyzj9b13kzi438cjfv43hij4zhh2sh-racket-minima= l-git.master have .desktop files in their directory hierarchy. (I might be = doing it wrong though)

<= br>
mfg

On Wed, 5 Jan 2022, 10:01 zimoun, <<= a href=3D"mailto:zimon.toutoune@gmail.com">zimon.toutoune@gmail.com>= wrote:
Hi Philip,

On Wed, 05 Jan 2022 at 01:06, Philip McGrath <philip@philipmcgrath= .com> wrote:

> This commit backports a repair by Matthew Flatt for Racket's
> creation and installation of '.desktop' files in tethered Rack= et
> installations. Guix's 'racket' package is structured as a = tethered
> installation, so the Guix package now installs 'drracket.desktop&#= 39;
> and 'slideshow.desktop' properly, for example. For further ups= tream
> discussion, see: <https://github.com/= racket/racket/issues/4079>.

In this mentioned issue, it reads:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 I will send a patch to Guix in the hope of gett= ing more people
=C2=A0 =C2=A0 =C2=A0 =C2=A0 to try 11ccee3 and ece8b17 before the 8.4 relea= se.

<https://github.co= m/racket/racket/issues/4079#issuecomment-1005397718>


> * gnu/packages/patches/racket-minimal-backport-4079-fix.patch: New
> patch.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/racket.scm (racket-minimal)[source]: Use it.
> (extend-layer): Set config-tethered-apps-dir.

So my naive question is: is it worth to include now and not just wait
for the next Racket 8.4 release? (One or two months if Racket keep the 4 releases per year schedule)

Other said, for testing new Racket features in the Guix ecosystem, it
appears to me easier to use transformation:

=C2=A0 =C2=A0 guix build racket-minimal --with-commit=3Dece8b17

(or something along this line :-))

BTW, thanks for bridging the gap between Guix and Racket and it can be
cool if Guix can help Racket. :-)


Cheers,
simon



--000000000000121df005d4d407e5-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 09:49:39 2022 Received: (at 53020) by debbugs.gnu.org; 5 Jan 2022 14:49:39 +0000 Received: from localhost ([127.0.0.1]:39818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n57bf-0005cY-5y for submit@debbugs.gnu.org; Wed, 05 Jan 2022 09:49:39 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:39797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n57bd-0005cK-0f for 53020@debbugs.gnu.org; Wed, 05 Jan 2022 09:49:37 -0500 Received: by mail-qt1-f169.google.com with SMTP id bp39so37462620qtb.6 for <53020@debbugs.gnu.org>; Wed, 05 Jan 2022 06:49:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ljgHkz2iw+fKua2rrq8J1ibcm67lN3uuqWg99RK/oE0=; b=awhijxBaZxsXUAq1Q+XjULtZxicdRSgDq1d+Zh3JxsocE6P10aHjUOOAPCN5C/hrr7 tmlQU/QMvct1X1wRdsCkitYQxEvPBdEmCIl5ryRE9dFlskFIjxxDWIpOut97Wh25Z9YB Cg0qk3Noe5BRUS+szR/Sisb40rQ7+fY8LOYs5J4Dtx3gHvztctmRdV0BZkw/R3Vw2b56 1g9F51Mn6/uFPN5eGszRHtp4acrbbnIXhyPh5Mg1luPuaXaw/vx4sUPhzCWIRZbz+PVp MKqUMCngqeSWEq/fTmnP6kIOOuIWu7xs5cc6y1ddHX3f9wPmvkDmMKR7HEHd6bsdgJqJ FOgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ljgHkz2iw+fKua2rrq8J1ibcm67lN3uuqWg99RK/oE0=; b=zizZljfe+5/cSLJ5dWfDgj74rqJJmy8LghmLEvioZzP9iPqe2zpdk7veTrUXjdHSXL gbXrgMe1Wvee80qS2StrZghgWhQzliGLUs1mmGVO5Cb9aaxqK/00Ty7uwkF3N25VBfdh U8/o6D7mmNrTQe4fe5TxfBkEZE0o9jHUcbYWXi2ImUkJXll86ISG0odrVFWmETd9G48x pOjW9KnYfxnMj7UUOkoePpKaP6h+WmfecSQGVJ6C1C7+QM/Rt61sxqvkO0FY4laNhe4+ 1uxuZu1yU3jgX+k4X6JxcfAeXqPuiYZPfngoABoxDRiYQ28LjIkV71oSc0bVf/UR12I0 efZA== X-Gm-Message-State: AOAM5303/AymNrlaaVb1V52kU4y9uYk6u0d17NCEHfQ7wB+AcqCgWzHm FyJv+ETVjAMX2MfZK+T3Ij4T7g== X-Google-Smtp-Source: ABdhPJyihwmqoM+VOI65zIPdQSf4M2XqV5dPRaLo62WqKs6uxHQnuZJLP/d7xRmi2UGt4qGkV6NAZA== X-Received: by 2002:ac8:5f89:: with SMTP id j9mr49282585qta.391.1641394171332; Wed, 05 Jan 2022 06:49:31 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id bs16sm34908490qkb.45.2022.01.05.06.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jan 2022 06:49:31 -0800 (PST) Message-ID: Date: Wed, 5 Jan 2022 09:49:30 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [bug#53020] [PATCH] gnu: racket: Backport fix for .desktop files. Content-Language: en-US To: Malte Gerdes , 53020@debbugs.gnu.org References: <20220105060630.218938-1-philip@philipmcgrath.com> <86v8yy8smo.fsf@gmail.com> From: Philip McGrath In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 53020 Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Hi, On 1/5/22 06:26, Malte Gerdes wrote: > It builds with > > ``` > guix build --with-git-url=racket=https://github.com/racket/racket > --with-branch=racket-minimal=master > --with-git-url=racket-minimal=https://github.com/racket/racket > --with-branch=racket=master package > ``` > Where package is racket and racket-minimal respectively. > > > Neither `/gnu/store/11y27mj1z7mhljw2w3ni7lp2w0a1zhfr-racket-git.master` > nor > /gnu/store/gfbyzj9b13kzi438cjfv43hij4zhh2sh-racket-minimal-git.master > have .desktop files in their directory hierarchy. (I might be doing it > wrong though) > That transformation isn't quite enough: it misses the change to 'extend-layer' in gnu/packages/racket.scm to set the new config-tethered-apps-dir key in the built etc/racket/config.rktd (for the 'racket' package). (Just in case this is confusing, the fix is to 'racket-minimal' and 'extend-layer', but the .desktop files show up in the fixed version of 'racket'.) I don't think there's a convenient way to express the change to 'extend-layer' as a command-line option, which is one reason I sent this patch. -Philip From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 11:38:48 2022 Received: (at 53020) by debbugs.gnu.org; 5 Jan 2022 16:38:48 +0000 Received: from localhost ([127.0.0.1]:41612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n59JI-0002tO-8N for submit@debbugs.gnu.org; Wed, 05 Jan 2022 11:38:48 -0500 Received: from mail-qt1-f182.google.com ([209.85.160.182]:36625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n59JF-0002t7-8c for 53020@debbugs.gnu.org; Wed, 05 Jan 2022 11:38:47 -0500 Received: by mail-qt1-f182.google.com with SMTP id m18so37662862qtk.3 for <53020@debbugs.gnu.org>; Wed, 05 Jan 2022 08:38:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=2Xy/0snpKDeNe12T15KNc+08WqcdkxI3rugjplep8SY=; b=dNBK9vOTbgCwfzpVO31bdKdxisdEXZSTkas22jvENASe9pLlW4OykfLESbUvfyD+ql IxGUh1O4gJt85drbZhBXrHrRW0+9XaBcCtVgQrCwkqoc4GTDfQM+8giWhfCyWUQbhqX7 XNQVpYzdeVrtPSrJBvN09bKNoln7RDFBBtKeu2hbAO2PZMljljXG1znjdURR9vfiwy5D rvCGPwzJRwZZJasJDrZKNCXjlHexmxb/zR+MdjoKFp8mi2TWAlT05/SRODQYdc5B5Gk1 U/YUxsOPaxq3oEOIE2X6l3sGwM+hS5Zp9WimQUK6jsmRlrnQlUp9y81fUOxajpNdLZvh 2mgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=2Xy/0snpKDeNe12T15KNc+08WqcdkxI3rugjplep8SY=; b=gDBskfsJjTgTzhzt5NG/zjGDJnZeve+IdZ0WjuiMRx+WIYeqfqxyddPa0B/TiQYDQf cGQyrt+m5DBl4JLwgTsKZkDj8ErQP8ueKo81zDqLVkt7fOV0lsLBR/5CFNAk9VLPUmOo R046S5Zp3XqEjsFUMm0ThgWKq7FgVFfOUYxEUpXQguxlfdCAjZXmJ46grdBlN/AQ6wWT sfa3MSnephKjIAq56ZVvYsZMZMtjwRi0cW/14zYh0kYp7QfEUN3eBGELC4tsbDulfu74 WECYteprYfXTrjQoTq0Uhi9z6LpH8UkEvcGR/mPfdsDe4JseWo1CoFw7zdOORHtYWsJb jH+g== X-Gm-Message-State: AOAM532ixT4f6VFo0pEWH98S+rukP7U8QOY4VjlavoZQd8jvAj3oBED/ j+Cw0uCtsWtMvJ9haDTF6ACkS7vRdAI26Ml5 X-Google-Smtp-Source: ABdhPJzB3ABFd9KWuB8mJ4LYs9wsQXubBDBKQOSRDRchQbz5hpt02K0l2hF60LqpKNR0rHWAwQZDbw== X-Received: by 2002:ac8:6b58:: with SMTP id x24mr49075611qts.14.1641400719527; Wed, 05 Jan 2022 08:38:39 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id bj26sm1097639qkb.58.2022.01.05.08.38.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jan 2022 08:38:39 -0800 (PST) Message-ID: <2e6c4a29-57e6-1d93-0e4d-446af214aa34@philipmcgrath.com> Date: Wed, 5 Jan 2022 11:38:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [bug#53020] [PATCH] gnu: racket: Backport fix for .desktop files. Content-Language: en-US To: zimoun , 53020@debbugs.gnu.org, Malte Frank Gerdes References: <20220105060630.218938-1-philip@philipmcgrath.com> <86v8yy8smo.fsf@gmail.com> From: Philip McGrath In-Reply-To: <86v8yy8smo.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 53020 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Hi, On 1/5/22 03:59, zimoun wrote: > So my naive question is: is it worth to include now and not just wait > for the next Racket 8.4 release? (One or two months if Racket keep the 4 > releases per year schedule) > > Other said, for testing new Racket features in the Guix ecosystem, it > appears to me easier to use transformation: > > guix build racket-minimal --with-commit=ece8b17 > > (or something along this line :-)) > > BTW, thanks for bridging the gap between Guix and Racket and it can be > cool if Guix can help Racket. :-) Certainly it is debatable, and it would be useful even just to have more Guix people try out this patch, but, in my opinion, it is worth it to include this in Guix now and not just wait for the Racket 8.4 release (in about a month, if all goes according to schedule). (But perhaps that's not so surprising that I think so, since I sent this patch.) I see basically two considerations that distinguish this case from recruiting Guix for Racket's pre-release testing, which I generally wouldn't suggest. First, this fixes a very annoying regression in Guix's Racket packaging introduced (by me) in Guix commit 65bad4d03684a32598e0c6fb3449e481e37acfde (the switch to make 'racket' a config-tethered installation layer on top of 'racket-minimal'), in which, though I didn't notice it at the time, the 'racket' package stopped building/installing "share/applications/drracket.desktop". Symptoms include DrRacket not showing up in desktop application menus, disruption to the handling of ".rkt" files, and various other annoyances. (Time will tell, but I suspect it may have been the culprit behind some Wayland troubles that non-Guix users haven't been able to reproduce.) Second, the Racket patches are changes to the low-level support for "layered" and "tethered" installations. Guix's 'racket' package is a major high-level use of that low-level support, e.g. Matthew Flatt filled in some missing parts of that low-level support to make the above-referenced Guix commit possible. So, while this isn't quite a Guix-specific fix, it's fairly close. I'm convinced that this it is an improvement, and it seems like a complete solution, but there's still time to make any adjustments that might turn out to be needed before the 8.4 release, when Racket's strong compatibility commitments kick in. In the best case, which I think is most likely, Guix users get a fix for an annoying packaging bug early; in the worst case, we get a partial fix now and a chance to identify anything that still needs to be fixed. I explained in my reply to Malte why the command-line package transformation doesn't quite work: that's not inherently part of these considerations, but perhaps it does further suggest that this fix is unusually closely connected to the way Guix packages Racket. -Philip From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 13 17:07:30 2022 Received: (at 53020-close) by debbugs.gnu.org; 13 Feb 2022 22:07:30 +0000 Received: from localhost ([127.0.0.1]:39097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJN1l-0005qc-PV for submit@debbugs.gnu.org; Sun, 13 Feb 2022 17:07:30 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:47000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJN1h-0005qL-Pp for 53020-close@debbugs.gnu.org; Sun, 13 Feb 2022 17:07:28 -0500 Received: by mail-qt1-f172.google.com with SMTP id t1so14007421qtq.13 for <53020-close@debbugs.gnu.org>; Sun, 13 Feb 2022 14:07:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=sTKVAAWSRSXGfOiVAKieDirEqYiwqu2it8TJBnfQIYY=; b=XMkLOKgWufXk+G9XV7UNZckzIgwqRsOxvycYV3VG341cVGHuG1V6uRMcN9vpe5uzlF Uu9GS+CQDApCMXGvwIVA7Rse5Bf9ZXMBHtf6J9USu2MdhsD0v6Xdnu6edsBMjjZnfEHC +9c3PfIk54Z03rvPYQlSX3QxDasLpfmJCCsrezzKFs2vc/rbRakN9xCBbA9EEv9CV3W4 Bqg7uXw2bVASrOYP99DiUTz+/omhlpJU/GenGldx9+EhMQKkpdXs4ccbA1LRbyUSeIC6 EYbu7as9k8oxp40Qp/JSS3zbuZ5pHH+Q/iP7KNnw7OmC91TdBd4f4tREHgZHVKCZv7on UsdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=sTKVAAWSRSXGfOiVAKieDirEqYiwqu2it8TJBnfQIYY=; b=UZZEU+eGd0Y4+okLuE0lfmT1ztw5WrTKN8x3Tw5nMAbP0lLwbec6FCB6uM8ceDo58V mz67F2KMOGQR3xatACkY0IPgTD78EByBpEVXINGZ4YhDVu1S7pedkISEyWE77sWzB4bg Ef3AY8aLe95s8dOs9W0a1noMjvsM2fNRA4Xf9wxhiUWfyXHfK0zfvw1HBOvGZZjypNcR kkqQRTwv0ujXfMVMNXLrfp+QjY1oSx9WVJHZuQVQDXnQ+7Lmxh8I9GZwP0RM3vkfGClB P3bqhllJ93z7nBaHUxodkicd5nMsm/I3b8lLuOxtxY3OiXMpNPq7A04ZQ0AQMrO5JfyG tV3g== X-Gm-Message-State: AOAM533X017BPS34u2u5LQKLgPE+gK/Rs/mJI/gk9EWK1R5lEUZ81rir CeEEccRng2a0lNmvH2iDptTo+g== X-Google-Smtp-Source: ABdhPJzIsAlrS7tJPnwygnl888ROurPxDEsIEXaA8sTztgzzDwb5/khK5vv/4KYThm1ztNjYRn9ynA== X-Received: by 2002:ac8:5906:: with SMTP id 6mr7507604qty.663.1644790039101; Sun, 13 Feb 2022 14:07:19 -0800 (PST) Received: from [192.168.45.36] (c-73-125-98-51.hsd1.fl.comcast.net. [73.125.98.51]) by smtp.gmail.com with ESMTPSA id m194sm3016493qke.52.2022.02.13.14.07.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Feb 2022 14:07:18 -0800 (PST) Message-ID: <720f1636-b4b2-d2d7-a1a7-c90fd5e4b056@philipmcgrath.com> Date: Sun, 13 Feb 2022 17:07:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [bug#53020] [PATCH] gnu: racket: Backport fix for .desktop files. Content-Language: en-US From: Philip McGrath To: zimoun , Malte Frank Gerdes , 53020-close@debbugs.gnu.org References: <20220105060630.218938-1-philip@philipmcgrath.com> <86v8yy8smo.fsf@gmail.com> <2e6c4a29-57e6-1d93-0e4d-446af214aa34@philipmcgrath.com> In-Reply-To: <2e6c4a29-57e6-1d93-0e4d-446af214aa34@philipmcgrath.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 53020-close X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Racket 8.4 is out now, so I'm closing this in favor of . -Philip From unknown Sat Jun 21 05:06:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 Mar 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator