From unknown Fri Jun 13 11:05:35 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5301: 23.1; unload-feature remove defadvice Reply-To: Kevin Ryde , 5301@debbugs.gnu.org Mail-Followup-To: Kevin Ryde , 5301@debbugs.gnu.org Resent-From: Kevin Ryde Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jan 2010 23:29:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: report 5301 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@debbugs.gnu.org id=B.126256130311408 (code B ref -1); Sun, 03 Jan 2010 23:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2010 23:28:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRZry-0002xx-Kf for submit@debbugs.gnu.org; Sun, 03 Jan 2010 18:28:22 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRZrw-0002xs-Kc for submit@debbugs.gnu.org; Sun, 03 Jan 2010 18:28:21 -0500 Received: from mail.gnu.org ([199.232.76.166]:40564 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRZrs-0003Kz-Py for submit@debbugs.gnu.org; Sun, 03 Jan 2010 18:28:16 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NRZro-000728-Ei for submit@debbugs.gnu.org; Sun, 03 Jan 2010 18:28:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO,UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:37234) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NRZro-000724-8r for submit@debbugs.gnu.org; Sun, 03 Jan 2010 18:28:12 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRZro-00032C-0j for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 18:28:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRZrj-0002zv-AO for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 18:28:11 -0500 Received: from [199.232.76.173] (port=56802 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRZrj-0002zs-6J for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 18:28:07 -0500 Received: from mailout1-6.pacific.net.au ([61.8.2.213]:40665 helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NRZri-0006za-4U for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 18:28:06 -0500 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id C969F507FD1 for ; Mon, 4 Jan 2010 10:28:01 +1100 (EST) Received: from blah.blah (ppp2EA9.dyn.pacific.net.au [61.8.46.169]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 0AA1827430 for ; Mon, 4 Jan 2010 10:28:01 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.71) (envelope-from ) id 1NRZrX-0004xH-Ct for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2010 10:27:55 +1100 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Date: Mon, 04 Jan 2010 10:27:54 +1100 Message-ID: <877hry7oqt.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) As an idea, it'd be good if defadvice were among the `def' things automatically unloaded by `unload-feature'. A defadvice will nearly always use functions or whatever in the defining package and if they've been unloaded it could leave the advised target function badly broken. I know it's possible for a foo-unload-function to undo its defadvices. I've done that for some of my things, but it gets very repetitive and makes me think defadvice could set that up itself. I know advice is a slightly second class citizen, but if the necessary unloading stuff were confined to advice.el then it needn't be a burden if no advise is in use. My best idea so far would be for defadvice to record something in load-history like (defadvice . (TARGET CLASS AD-NAME)) if it could beg a tie-in to unload-feature at a good spot. Something indirect like a property setting on the `defadvice' symbol appearing in the load-history might let other `def' macros jig up unloading for themselves in a general way. ;; untested! (put 'defadvice 'load-history-unload-feature-function (lambda (elem) (when (apply 'ad-find-advice (cdr elem)) (apply 'ad-remove-advice (cdr elem)) (ad-activate (cadr elem))))) May have to think about what happens if the package defining the `def' macro is unloaded when things it has `def'fed still exist. But if `require's express dependencies correctly that might never arise. In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 16 19:59:11 2010 Received: (at control) by debbugs.gnu.org; 17 Jan 2010 00:59:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWJTy-0007bh-Pc for submit@debbugs.gnu.org; Sat, 16 Jan 2010 19:59:10 -0500 Received: from mail-bw0-f216.google.com ([209.85.218.216]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWJTw-0007bc-MF for control@debbugs.gnu.org; Sat, 16 Jan 2010 19:59:09 -0500 Received: by bwz8 with SMTP id 8so1226931bwz.39 for ; Sat, 16 Jan 2010 16:59:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=GYHzJNYQnjx2M0WpVgTKMzMzJ0s1ZcFvL7TQIcbhjP8=; b=QZBlrBoch6moZg0M5pFhglsfN3FG4X9H+SESuf7eqqK30tJIVaFdZWcYiAb6gUGTGV 7zJieGyw41dbepsqZxq/zMYTpU89k00R4g7WNdeSW5zt1Dgy6gXdpRkXsm1BLQW5PIqN QY/CuCo0hohNWlbd0XDj5MrraWRfkMin5USfk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=r0jhpL3UM01gsNrKySem9VTaHgzAKkBy9dxq0stAxYDTaNdASFitwVipXkAy/Evy8L mJ/A1cz3pwUfAaj1jsTUghlGq4DXKAzBKviBzRhwaPGA1loVtRV4xHU4BEW1Luj0Oc11 MK8CGpvsrh5lwyyuEiJtgFKtfV6aFeBIxbcxs= MIME-Version: 1.0 Received: by 10.204.156.195 with SMTP id y3mr2274285bkw.46.1263689943263; Sat, 16 Jan 2010 16:59:03 -0800 (PST) From: Juanma Barranquero Date: Sun, 17 Jan 2010 01:58:43 +0100 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) reassign 5400 emacs,ada-mode severity 5301 wishlist quit