From unknown Fri Aug 15 14:17:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#530 <530@debbugs.gnu.org> To: bug#530 <530@debbugs.gnu.org> Subject: Status: Emacs 22 occasionally loses undo buffer? Reply-To: bug#530 <530@debbugs.gnu.org> Date: Fri, 15 Aug 2025 21:17:47 +0000 retitle 530 Emacs 22 occasionally loses undo buffer? reassign 530 emacs submitter 530 "Casey Muratori" severity 530 wishlist tag 530 patch wontfix thanks From casey@mollyrocket.com Thu Jul 3 16:14:39 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Jul 2008 23:14:39 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m63NEZmp004653 for ; Thu, 3 Jul 2008 16:14:36 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEY0Y-00020l-AO for bug-gnu-emacs@gnu.org; Thu, 03 Jul 2008 19:14:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEY0X-0001zp-0x for bug-gnu-emacs@gnu.org; Thu, 03 Jul 2008 19:14:33 -0400 Received: from [199.232.76.173] (port=51811 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEY0W-0001zf-Mg for bug-gnu-emacs@gnu.org; Thu, 03 Jul 2008 19:14:32 -0400 Received: from wr-out-0506.google.com ([64.233.184.227]:30629) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KEY0W-0004lT-I9 for bug-gnu-emacs@gnu.org; Thu, 03 Jul 2008 19:14:32 -0400 Received: by wr-out-0506.google.com with SMTP id c30so746210wra.14 for ; Thu, 03 Jul 2008 16:14:30 -0700 (PDT) Received: by 10.90.28.3 with SMTP id b3mr580224agb.117.1215126869990; Thu, 03 Jul 2008 16:14:29 -0700 (PDT) Received: by 10.90.74.11 with HTTP; Thu, 3 Jul 2008 16:14:29 -0700 (PDT) Message-ID: <96bc81c70807031614q206d3356jb2139cd1896da806@mail.gmail.com> Date: Thu, 3 Jul 2008 16:14:29 -0700 From: "Casey Muratori" To: bug-gnu-emacs@gnu.org Subject: Emacs 22 occasionally loses undo buffer? MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) I'm a long-time GNU Emacs user, and recently I updated to 22.x. In 21.x, I never had any problems with undo, but in both 22.1 and 22.2 I will get an occasional loss of undo information for no apparent reason. After some editing operation, usually a kill or the undo of a kill, etc., Emacs spontaneously decides that there is "no further undo information", even though there clearly was, and the buffer is still marked as modified. It seems to happen _less_ frequently in 22.2 than in 22.1 so far, but it's hard to tell, since I've been unable to come up with a reliable way to reproduce the bug. Is this a known problem? Has anyone else reported something similar? I've been trying to think of a way to debug it, but it seems very difficult since there's no way to know when the bug will happen, and once it happens, it's presumably too late to find out why... This is running under Win32, btw, if that makes any difference: GNU Emacs 22.2.1 (i386-mingw-nt5.1.2600) - Casey From rgm@gnu.org Mon Jul 7 13:59:22 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.5 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, NOSUBJECT,RCVD_IN_DNSWL_MED,VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 7 Jul 2008 20:59:22 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m67KxJVc029566 for ; Mon, 7 Jul 2008 13:59:20 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KFxnS-0004oQ-CP; Mon, 07 Jul 2008 16:58:54 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18546.33678.308761.886930@fencepost.gnu.org> Date: Mon, 7 Jul 2008 16:58:54 -0400 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: yellow X-Ran: >J.ch*}uS&rF]A^O>PKRK,y_eH^z%a4s$U=;C$lU^U$]@u@%0qa5TC X-Debbugs-No-Ack: yes reassign 520 spam reassign 521 spam reassign 522 spam reassign 525 spam reassign 542 spam owner 523 Alan Mackenzie tags 530 moreinfo tags 543 moreinfo merge 536 537 From jasonrumney@gmail.com Sat Dec 20 01:56:44 2008 Received: (at control) by emacsbugs.donarmstrong.com; 20 Dec 2008 09:56:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.186]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBK9ufeE021303 for ; Sat, 20 Dec 2008 01:56:42 -0800 Received: by ti-out-0910.google.com with SMTP id b6so919551tic.1 for ; Sat, 20 Dec 2008 01:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=H9cFowt+VAxpCCy5OC89rk8sbAFNQS9UqXQZKVwNfwU=; b=iUGRpfC0p7hQcBeHc9OtrEaie1J8haKUcbHusAKsVt6UXTg4N9+/7K+OzaHV3FyufH 8ULGBWfqNsa6TVbwnGJQpR5aOaXf7LN4X0wI8f1PXcZyOQJaV/kl39ShPCBPXwxxVQzc cvJfbmi5PMc31A9muyC8m0DaQs1M1sg5wAvGc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=ugERbIrFQ2HBxJI1FVuGT6hcv9DghYc1rmRhT53WJqjP3yl/+VshHUxtAZ53J+L/PB 3/DJTFL4FPRz4u6N0YYAtKUQdvYU9wLjRTlKvP14RQ7l4wjITCaT353SDjKXD/RPB/gQ 4MGx6SF2JyYbKbEdUQS2PBKe+PQhSF3HUX3Nc= Received: by 10.110.41.20 with SMTP id o20mr1683522tio.41.1229767000815; Sat, 20 Dec 2008 01:56:40 -0800 (PST) Received: from ?192.168.1.3? ([118.101.181.97]) by mx.google.com with ESMTPS id u8sm3744621tia.8.2008.12.20.01.56.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 20 Dec 2008 01:56:39 -0800 (PST) Sender: Jason Rumney Message-ID: <494CC13A.2070809@gnu.org> Date: Sat, 20 Dec 2008 17:56:10 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: more info provided Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit tags 99 -moreinfo tags 530 -moreinfo merge 1501 530 tags 656 -moreinfo From cyd@stupidchicken.com Tue Jan 27 12:58:46 2009 Received: (at control) by emacsbugs.donarmstrong.com; 27 Jan 2009 20:58:46 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RKwhxP006234 for ; Tue, 27 Jan 2009 12:58:44 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 364E457E205; Tue, 27 Jan 2009 15:59:14 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: severity 1501 wishlist Date: Tue, 27 Jan 2009 15:59:14 -0500 Message-ID: <87ab9cwjml.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii severity 1501 wishlist thanks From cyd@stupidchicken.com Tue Jan 27 13:01:26 2009 Received: (at control) by emacsbugs.donarmstrong.com; 27 Jan 2009 21:01:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RL1KbC007419 for ; Tue, 27 Jan 2009 13:01:21 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 5F81357E205; Tue, 27 Jan 2009 16:01:51 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: severity 530 wishlist Date: Tue, 27 Jan 2009 16:01:51 -0500 Message-ID: <8763k0wji8.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii severity 530 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 21:01:53 2021 Received: (at control) by debbugs.gnu.org; 20 Oct 2021 01:01:53 +0000 Received: from localhost ([127.0.0.1]:52316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mczzN-0006Nw-4d for submit@debbugs.gnu.org; Tue, 19 Oct 2021 21:01:53 -0400 Received: from mail-pl1-f182.google.com ([209.85.214.182]:38750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mczzK-0006NW-Rl for control@debbugs.gnu.org; Tue, 19 Oct 2021 21:01:51 -0400 Received: by mail-pl1-f182.google.com with SMTP id i5so8697185pla.5 for ; Tue, 19 Oct 2021 18:01:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=V1uT8TK31jAD0X8tzIVhFKqrAV9GWZ6V9/DUFmshnTw=; b=QTTQgb5Z5NvI2Uy/jujWYV47pbSkfkWa7zichf3yMdyH/+V0/4UYOcHVgnx6Ub+gqs 24DPhZQMpyxNjL9LN55LICFW+Dl9nszYPn8nPjKv3o6J8JsELyCusbp/jBmQ6eCKPW+L mrSYlbfuiPcpyV0CpN2o6Casn58kOt6XMG+AkSC2b+h/HtlMIkcd3g/8rkw2gS+2cvRW oTaELK6cb/bpHZn7HXqhFUoV73RudgYfOiNJ1f8ZmITwgpguek4Ta9zHNCzo2wDc72Qu w0e8exLVa/uMr9ZLML9V5EsS81/CtIrDuTa09mhNAJmjxPLBM48We3d5kIvOUARD+mKr 3FZg== X-Gm-Message-State: AOAM530adAAN4/SmoQZotmkm9qPAaFf5qBLQWWII3vCeieXihzkOwxzW D1fI6E9U4SPgdSF4ZCnidpFBTu2z2SbRzhqQS/o= X-Google-Smtp-Source: ABdhPJy8e8C9pM8QIm5I5gYNn2R+IA6DB4p/+BAYPeToAh2kTgWxxoLn5QuDj1CQ4MMmjCsYhwQ0i80CIRR5OLkeE18= X-Received: by 2002:a17:90b:17d2:: with SMTP id me18mr3708909pjb.132.1634691704928; Tue, 19 Oct 2021 18:01:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 Oct 2021 18:01:43 -0700 From: Stefan Kangas In-Reply-To: <87ef1engij.fsf@gmail.com> (Noam Postavsky's message of "Wed, 21 Aug 2019 21:19:32 -0400") References: <85k1b7k763.fsf@gmail.com> <87ef1engij.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 19 Oct 2021 18:01:43 -0700 Message-ID: Subject: Re: bug#1501: Emacs 22 loses undo buffer To: Noam Postavsky Content-Type: multipart/mixed; boundary="00000000000063cfd205cebe524c" Bcc: control@debbugs.gnu.org X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control Cc: Emerick Rogul , 1501@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --00000000000063cfd205cebe524c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tags 1501 + patch thanks Noam Postavsky writes: > Stefan Kangas writes: > >> Noam Postavsky writes: >> >>> Stefan Kangas writes: >>> >>> > increase in the memory usage of each undo record, especially when >>> > using font-lock-mode. I'm not sure that is a serious problem, since >>> > memory is only getting cheaper, but it might be worth investigating. >>> > On the other hand, we could just decide that this is not worth the >>> > effort and close this as wontfix. >>> >>> Hmm, it sounds like the problem might just be due to saving text >>> properties in the undo records? If so, maybe a simple fix is to just >>> drop them (or drop only face and font-lock-face properties). >> >> Is it not worth saving also that information? > > Definitely not face, since it's overwritten as soon as font-lock runs. > It's true font-lock-face can sometimes be set manually, though usually > it's computed by font-lock rules. This would be fairly simple to do, as in the attached patch. But I'm not sure that we should make this change, since both `face' and `font-lock-face' could be used by a major mode at various times, without getting automatically re-added by font-lock. >From (info "(elisp) Precalculated Fontification"): But if the mode does not use the normal Font Lock machinery, it should not set the variable =E2=80=98font-lock-defaults=E2=80=99. In t= his case the =E2=80=98face=E2=80=99 property will not be overridden, so using the = =E2=80=98face=E2=80=99 property could work too. IOW, I'm not sure that the proposed change won't introduce subtle bugs. Other than that, we have doubled all undo limits in Emacs 27.1, so maybe that's enough of a fix for now? Any other opinions? --00000000000063cfd205cebe524c Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Decrease-size-of-undo-entries.patch" Content-Disposition: attachment; filename="0001-Decrease-size-of-undo-entries.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 83095a7432305b3f_0.1 RnJvbSA3YjBmZWE0MmY3OTNkN2I3ZjlmYTk5MzhiM2M5OWIxZjI4MzIzNTMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogV2VkLCAyMCBPY3QgMjAyMSAwMjo0MjozMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIERlY3Jl YXNlIHNpemUgb2YgdW5kbyBlbnRyaWVzCgoqIHNyYy91bmRvLmMgKHJlY29yZF9kZWxldGUpOiBS ZW1vdmUgdGhlICdmYWNlJyBwcm9wZXJ0eSBmcm9tIHVuZG8KZW50cmllcyB0byBzYXZlIHNwYWNl LiAgKEJ1ZzE1MDEpCi0tLQogc3JjL3VuZG8uYyB8IDcgKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy91bmRvLmMgYi9zcmMvdW5kby5jCmlu ZGV4IDJkYjQwMWViYzcuLjI2MGNmNzkyYzcgMTAwNjQ0Ci0tLSBhL3NyYy91bmRvLmMKKysrIGIv c3JjL3VuZG8uYwpAQCAtMTY0LDYgKzE2NCwxMyBAQCByZWNvcmRfZGVsZXRlIChwdHJkaWZmX3Qg YmVnLCBMaXNwX09iamVjdCBzdHJpbmcsIGJvb2wgcmVjb3JkX21hcmtlcnMpCiB7CiAgIExpc3Bf T2JqZWN0IHNiZWc7CiAKKyAgLyogUmVtb3ZlIHRoZSBgZmFjZScgcHJvcGVydHkgdG8gc2F2ZSBz cGFjZS4gIChCdWcxNTAxKSAgKi8KKyAgaWYgKCFOSUxQIChzdHJpbmcpKQorICAgIEZyZW1vdmVf bGlzdF9vZl90ZXh0X3Byb3BlcnRpZXMgKG1ha2VfZml4bnVtICgwKSwKKwkJCQkgICAgIG1ha2Vf Zml4bnVtIChTQ0hBUlMgKHN0cmluZykpLAorCQkJCSAgICAgQ0FMTE4gKEZsaXN0LCBRZmFjZSks CisJCQkJICAgICBzdHJpbmcpOworCiAgIGlmIChFUSAoQlZBUiAoY3VycmVudF9idWZmZXIsIHVu ZG9fbGlzdCksIFF0KSkKICAgICByZXR1cm47CiAKLS0gCjIuMzAuMgoK --00000000000063cfd205cebe524c-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 21 16:46:31 2021 Received: (at control) by debbugs.gnu.org; 21 Oct 2021 20:46:31 +0000 Received: from localhost ([127.0.0.1]:58725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdexL-0002wQ-FS for submit@debbugs.gnu.org; Thu, 21 Oct 2021 16:46:31 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:41550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdexJ-0002w4-Ii for control@debbugs.gnu.org; Thu, 21 Oct 2021 16:46:30 -0400 Received: by mail-pj1-f50.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so1493938pjb.0 for ; Thu, 21 Oct 2021 13:46:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=/8pH3RWNknwUsxHGOkzJraBXj8CTuvNeEvOCidUVLRk=; b=rLofKxLZW8H6buf81NN3YS+nI7Wj6k+w0dS4wXSBqIjXdBJoa6FXeZHVJD7nZRvpf1 xoPrlpAjJZ1N9QQfqI/AXagKmVD3Wd0G+i5wzh2I7BuA3aERUCtRrRHGrSES0eFk5rCD z9NDTbYRnhJEVM1qIJHmwIG2ZGx747o3/pPqg99ynXHq5sAk2hPNdDGEwib5gA9G5jEX ic9kR2u+o94av24+SmCGL+tYbmma0eFfnekjjB6Yzn183WoVxvqCl//6XNNO62gzuyOo /0eQUVMSl4FS/eRmo+40RxZLqooQWcaF4+ORXCTHBEgpviOg/iBWAYsT4HJlBbRVBr9J x1IA== X-Gm-Message-State: AOAM532M1TzAsZH5S9o7VVXO2lqVovj5mBAbzg/ampZYj6we/pVQ7OQD rIvboZ3iUq9Q+4CtNvI/t+IK2Vw6h5cIEiqJEPA= X-Google-Smtp-Source: ABdhPJzgEaZPG3pl2TC7EBVCNnI+/zMZkTUoAakyBqnVyAk37ktAuZcWK7oHQgD9g4hCKUg+Rg2T/zFQC6dsAKGFgwU= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr7149298pls.71.1634849183784; Thu, 21 Oct 2021 13:46:23 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 21 Oct 2021 13:46:23 -0700 From: Stefan Kangas In-Reply-To: <83k0i7c35d.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Oct 2021 15:05:34 +0300") References: <85k1b7k763.fsf@gmail.com> <87ef1engij.fsf@gmail.com> <83k0i7c35d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Thu, 21 Oct 2021 13:46:23 -0700 Message-ID: Subject: Re: bug#1501: Emacs 22 loses undo buffer To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Bcc: control@debbugs.gnu.org X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control Cc: emerick@gmail.com, 1501@debbugs.gnu.org, cyd@stupidchicken.com, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 1501 wontfix close 1501 thanks Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Tue, 19 Oct 2021 18:01:43 -0700 >> Cc: Emerick Rogul , 1501@debbugs.gnu.org, >> Chong Yidong >> >> + /* Remove the `face' property to save space. (Bug1501) */ >> + if (!NILP (string)) >> + Fremove_list_of_text_properties (make_fixnum (0), >> + make_fixnum (SCHARS (string)), >> + CALLN (Flist, Qface), >> + string); > > This modifies the text properties of STRING, which you don't own. > > Also, it will do unnecessary non-trivial processing when undo is > turned off. > > I definitely think that with the enlarged undo-limit we should leave > this obscure situation alone. It isn't worth making such significant > low-level changes due to such obscure problems, which are arguably > cockpit errors. OK, I'm therefore closing this bug as wontfix. (Alternatively, we could just close it as "fixed" (with the doubling of undo limits) but let's be a bit more explicit.) From unknown Fri Aug 15 14:17:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 19 Nov 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator