From unknown Sat Jun 21 03:30:59 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5298: file VC state not updated after a directory check in Reply-To: Dan Nicolaescu , 5298@debbugs.gnu.org Mail-Followup-To: Dan Nicolaescu , 5298@debbugs.gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jan 2010 18:15:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: report 5298 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@debbugs.gnu.org id=B.12625424501848 (code B ref -1); Sun, 03 Jan 2010 18:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jan 2010 18:14:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRUxt-0000Tl-PF for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:10 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRUxr-0000Tg-FW for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:08 -0500 Received: from mx10.gnu.org ([199.232.76.166]:33733) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRUxn-0004sP-2A for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:03 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NRUxl-0006zc-LB for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:57324) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NRUxl-0006zK-D3 for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:01 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRUxl-0003RC-0M for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 13:14:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRUxg-0003Q1-7y for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 13:14:00 -0500 Received: from [199.232.76.173] (port=42293 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRUxg-0003Pq-2k for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 13:13:56 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:50144) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRUxf-0006Po-Gg for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 13:13:55 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o03ICJKp020912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 3 Jan 2010 10:12:19 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o03ICJ8d025607; Sun, 3 Jan 2010 10:12:19 -0800 (PST) Date: Sun, 3 Jan 2010 10:12:19 -0800 (PST) Message-Id: <201001031812.o03ICJ8d025607@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Lines: 35 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o03ICJKp020912 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.4 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) mkdir /tmp/test cd /tmp/test bzr init echo blah > foo bzr add foo emacs -Q C-x C-f /tmp/test/foo RET C-x v d /tmp/test RET Move point to "./" C-x v v write something in the log-edit buffer. C-c C-c now see that in the *vc-dir* the state for "foo" has changed to `up-to-date' but the mode-line for the "foo" buffer does not show that the buffer is up to date. (vc-state "/tmp/test/foo") returns `added'. The buffer content has been reverted as expected (this can be verified by using a VCS that does keyword expansion and adding a "$Id$" in "foo"). If the point is on the "foo" line instead of "./" everything works as expected, the VC state is updated. The problem only happens when checking in directories. "bzr" is just used as an example above, the problem happens with all VC backends. From unknown Sat Jun 21 03:30:59 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5298: file VC state not updated after a directory check in Reply-To: Dan Nicolaescu , 5298@debbugs.gnu.org Mail-Followup-To: Dan Nicolaescu , 5298@debbugs.gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jan 2010 02:56:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5298 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 5298-submit@debbugs.gnu.org id=B5298.126266014626380 (code B ref 5298); Tue, 05 Jan 2010 02:56:02 +0000 Received: (at 5298) by debbugs.gnu.org; 5 Jan 2010 02:55:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRzaE-0006rR-8I for submit@debbugs.gnu.org; Mon, 04 Jan 2010 21:55:46 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRzaC-0006rM-1I for 5298@debbugs.gnu.org; Mon, 04 Jan 2010 21:55:44 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o052tY77029174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 4 Jan 2010 18:55:34 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o052tYbi005887; Mon, 4 Jan 2010 18:55:34 -0800 (PST) Date: Mon, 4 Jan 2010 18:55:34 -0800 (PST) Message-Id: <201001050255.o052tYbi005887@godzilla.ics.uci.edu> From: Dan Nicolaescu To: 5298@debbugs.gnu.org References: <201001031812.o03ICJ8d025607@godzilla.ics.uci.edu> In-Reply-To: <201001031812.o03ICJ8d025607@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 3 Jan 2010 10:12:19 -0800 (PST)") Lines: 68 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o052tY77029174 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Status: No X-Spam-Score: -2.6 (--) Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Dan Nicolaescu writes: > mkdir /tmp/test > cd /tmp/test > bzr init > echo blah > foo > bzr add foo > > emacs -Q > C-x C-f /tmp/test/foo RET > C-x v d /tmp/test RET > > Move point to "./" > > C-x v v > write something in the log-edit buffer. > C-c C-c > > now see that in the *vc-dir* the state for "foo" has changed to `up-to-date' > > but the mode-line for the "foo" buffer does not show that the buffer is > up to date. > (vc-state "/tmp/test/foo") returns `added'. > > The buffer content has been reverted as expected (this can be verified > by using a VCS that does keyword expansion and adding a "$Id$" in > "foo"). > > If the point is on the "foo" line instead of "./" everything works as > expected, the VC state is updated. The problem only happens when > checking in directories. > > "bzr" is just used as an example above, the problem happens with all VC backends. This can be solved by extending `with-vc-properties' to actually do something when passed a directory argument: apply the properties to all buffers in that directory. Stefan, WDYT? --- vc.el.~1.746.~ 2009-12-07 03:49:17.000000000 -0800 +++ vc.el 2010-01-04 18:51:46.000000000 -0800 @@ -791,13 +791,23 @@ in their implementation of vc-BACKEND-di (defmacro with-vc-properties (files form settings) "Execute FORM, then maybe set per-file properties for FILES. +If any of FILES is actually a directory, then do the same for all +buffers for files in that directory. SETTINGS is an association list of property/value pairs. After executing FORM, set those properties from SETTINGS that have not yet been updated to their corresponding values." (declare (debug t)) - `(let ((vc-touched-properties (list t))) - ,form + `(let ((vc-touched-properties (list t)) + (flist nil)) (dolist (file ,files) + (if (file-directory-p file) + (dolist (buffer (buffer-list)) + (let ((fname (buffer-file-name buffer))) + (when (and fname (vc-string-prefix-p file fname)) + (push fname flist)))) + (push file flist))) + ,form + (dolist (file flist) (dolist (setting ,settings) (let ((property (car setting))) (unless (memq property vc-touched-properties) From unknown Sat Jun 21 03:30:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: bug-gnu-emacs@gnu.org From: bug-gnu-emacs@gnu.org (Emacs bug Tracking System) To: Dan Nicolaescu Subject: bug#5298 closed by Dan Nicolaescu (Re: bug#5298: file VC state not updated after a directory check in) Message-ID: References: <201001172223.o0HMNcAF010395@godzilla.ics.uci.edu> <201001031812.o03ICJ8d025607@godzilla.ics.uci.edu> X-Emacs-PR-Message: they-closed 5298 X-Emacs-PR-Package: emacs Reply-To: 5298@debbugs.gnu.org Date: Sun, 17 Jan 2010 22:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1263767042-20439-1" This is a multi-part message in MIME format... ------------=_1263767042-20439-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #5298: file VC state not updated after a directory check in It has been closed by Dan Nicolaescu . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Dan Nicolaescu by replying to this email. --=20 5298: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5298 Emacs Bug Tracking System Contact bug-gnu-emacs@gnu.org with problems ------------=_1263767042-20439-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 5298-done) by debbugs.gnu.org; 17 Jan 2010 22:23:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWdXC-0005JQ-KL for submit@debbugs.gnu.org; Sun, 17 Jan 2010 17:23:50 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NWdXA-0005JL-Nz for 5298-done@debbugs.gnu.org; Sun, 17 Jan 2010 17:23:49 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o0HMNc3A020149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <5298-done@debbugs.gnu.org>; Sun, 17 Jan 2010 14:23:38 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o0HMNcAF010395; Sun, 17 Jan 2010 14:23:38 -0800 (PST) Date: Sun, 17 Jan 2010 14:23:38 -0800 (PST) Message-Id: <201001172223.o0HMNcAF010395@godzilla.ics.uci.edu> From: Dan Nicolaescu To: 5298-done@debbugs.gnu.org Subject: Re: bug#5298: file VC state not updated after a directory check in References: <201001031812.o03ICJ8d025607@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: <201001031812.o03ICJ8d025607@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 3 Jan 2010 10:12:19 -0800 (PST)") Lines: 2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o0HMNc3A020149 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 5298-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Fixed. ------------=_1263767042-20439-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Jan 2010 18:14:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRUxt-0000Tl-PF for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:10 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRUxr-0000Tg-FW for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:08 -0500 Received: from mx10.gnu.org ([199.232.76.166]:33733) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRUxn-0004sP-2A for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:03 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NRUxl-0006zc-LB for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on monty-python X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00, UNPARSEABLE_RELAY autolearn=ham version=3.1.0 Received: from lists.gnu.org ([199.232.76.165]:57324) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NRUxl-0006zK-D3 for submit@debbugs.gnu.org; Sun, 03 Jan 2010 13:14:01 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRUxl-0003RC-0M for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 13:14:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRUxg-0003Q1-7y for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 13:14:00 -0500 Received: from [199.232.76.173] (port=42293 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRUxg-0003Pq-2k for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 13:13:56 -0500 Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:50144) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRUxf-0006Po-Gg for bug-gnu-emacs@gnu.org; Sun, 03 Jan 2010 13:13:55 -0500 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o03ICJKp020912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 3 Jan 2010 10:12:19 -0800 Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o03ICJ8d025607; Sun, 3 Jan 2010 10:12:19 -0800 (PST) Date: Sun, 3 Jan 2010 10:12:19 -0800 (PST) Message-Id: <201001031812.o03ICJ8d025607@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: file VC state not updated after a directory check in X-Debbugs-No-Ack: yes Lines: 35 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o03ICJKp020912 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) mkdir /tmp/test cd /tmp/test bzr init echo blah > foo bzr add foo emacs -Q C-x C-f /tmp/test/foo RET C-x v d /tmp/test RET Move point to "./" C-x v v write something in the log-edit buffer. C-c C-c now see that in the *vc-dir* the state for "foo" has changed to `up-to-date' but the mode-line for the "foo" buffer does not show that the buffer is up to date. (vc-state "/tmp/test/foo") returns `added'. The buffer content has been reverted as expected (this can be verified by using a VCS that does keyword expansion and adding a "$Id$" in "foo"). If the point is on the "foo" line instead of "./" everything works as expected, the VC state is updated. The problem only happens when checking in directories. "bzr" is just used as an example above, the problem happens with all VC backends. ------------=_1263767042-20439-1--