GNU bug report logs - #52977
[PATCH 0/6] Update some minetest packages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#52977: closed ([PATCH 0/6] Update some minetest packages)
Date: Wed, 05 Jan 2022 22:32:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 05 Jan 2022 23:30:53 +0100
with message-id <87czl5hl2a.fsf <at> gnu.org>
and subject line Re: bug#52977: [PATCH 0/6] Update some minetest packages
has caused the debbugs.gnu.org bug report #52977,
regarding [PATCH 0/6] Update some minetest packages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
52977: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52977
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/6] Update some minetest packages
Date: Mon, 03 Jan 2022 14:45:13 +0100

[Message part 3 (text/plain, inline)]

Hi,

This patch series updates some minetest packages.
They were made with 'guix refresh -u -t minetest', using the 'git-
fetch' updater from <https://issues.guix.gnu.org/50072#24>.

Checklist:
  * [x] version, commit and sha256/base32 updated
  * [x] it builds: ./pre-inst-env guix build minetest-homedecor-modpack
minetest-unified-inventory minetest-mobs-animal minetest-mobs minetest-
basic-materials minetest-technic --rounds=2
  * [x] linter is satisfied: ./pre-inst-env guix lint minetest-
homedecor-modpack minetest-unified-inventory minetest-mobs-animal
minetest-mobs minetest-basic-materials minetest-technic
  * [x] source code diff reasonable

    minetest-technic: some small documentation and code changes
    minetest-basic-materials: new subdirectory '.github'.
    minetest-mobs: some code changes, updated translations
    minetest-mobs-animal: Some code changes (chickens are different
now?)
    minetest-unified-inventory: Lots of code changes, some
documentation changes, updated translations and images
    minetest-homedecor-modpack: Some code changes.
  * [x] Minetest doesn't crash
    ./pre-inst-env guix shell --pure minetest-homedecor-modpack
minetest-unified-inventory minetest-mobs-animal minetest-mobs minetest-
basic-materials minetest-technic minetest -- minetest
    Create world with all mods enabled.
    + [x] Inventory mode appears to work
    + [x] spawning chickens appears to work
    + [x] rotating blocks from homedecor works

A TODO for the git-fetch updater:
  * [ ] following redirects (to avoid mixed case -> lower case changes
and .git suffixes in GitHub URLs)
  * [ ] Support (let ((commit ...) (revision ...)) [...]) so more
packages can be updated automatically

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 52977-done <at> debbugs.gnu.org
Subject: Re: bug#52977: [PATCH 0/6] Update some minetest packages
Date: Wed, 05 Jan 2022 23:30:53 +0100

Hey Maxime,

Welcome back!  ;-)

Maxime Devos <maximedevos <at> telenet.be> skribis:

> This patch series updates some minetest packages.
> They were made with 'guix refresh -u -t minetest', using the 'git-
> fetch' updater from <https://issues.guix.gnu.org/50072#24>.

Oh nice.

> Checklist:
>   * [x] version, commit and sha256/base32 updated
>   * [x] it builds: ./pre-inst-env guix build minetest-homedecor-modpack
> minetest-unified-inventory minetest-mobs-animal minetest-mobs minetest-
> basic-materials minetest-technic --rounds=2
>   * [x] linter is satisfied: ./pre-inst-env guix lint minetest-
> homedecor-modpack minetest-unified-inventory minetest-mobs-animal
> minetest-mobs minetest-basic-materials minetest-technic
>   * [x] source code diff reasonable
>
>     minetest-technic: some small documentation and code changes
>     minetest-basic-materials: new subdirectory '.github'.
>     minetest-mobs: some code changes, updated translations
>     minetest-mobs-animal: Some code changes (chickens are different
> now?)
>     minetest-unified-inventory: Lots of code changes, some
> documentation changes, updated translations and images
>     minetest-homedecor-modpack: Some code changes.
>   * [x] Minetest doesn't crash
>     ./pre-inst-env guix shell --pure minetest-homedecor-modpack
> minetest-unified-inventory minetest-mobs-animal minetest-mobs minetest-
> basic-materials minetest-technic minetest -- minetest
>     Create world with all mods enabled.
>     + [x] Inventory mode appears to work
>     + [x] spawning chickens appears to work
>     + [x] rotating blocks from homedecor works

Neat.  I applied them all.

> A TODO for the git-fetch updater:
>   * [ ] following redirects (to avoid mixed case -> lower case changes
> and .git suffixes in GitHub URLs)
>   * [ ] Support (let ((commit ...) (revision ...)) [...]) so more
> packages can be updated automatically

Hmm wasn’t it the reason we introduced ‘package-definition-location’?

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.