From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 03 08:07:14 2022 Received: (at submit) by debbugs.gnu.org; 3 Jan 2022 13:07:14 +0000 Received: from localhost ([127.0.0.1]:34326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4N3S-0002gN-EP for submit@debbugs.gnu.org; Mon, 03 Jan 2022 08:07:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:44440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4N3P-0002gC-O4 for submit@debbugs.gnu.org; Mon, 03 Jan 2022 08:07:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4N3P-000081-KM for bug-guix@gnu.org; Mon, 03 Jan 2022 08:07:11 -0500 Received: from smtprelay03.ispgateway.de ([80.67.31.41]:5651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4N3N-0001OL-Sy for bug-guix@gnu.org; Mon, 03 Jan 2022 08:07:11 -0500 Received: from [92.195.30.39] (helo=milk) by smtprelay03.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n4N3V-0006wr-Og; Mon, 03 Jan 2022 14:07:17 +0100 From: Simon Streit To: bug-guix@gnu.org Subject: Some tools in Samba fail to find modules, and a missing dependency Gcc: nnfolder+archive:sent.2022-01 Date: Mon, 03 Jan 2022 14:07:04 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Df-Sender: bGlzdHNAbmV0cGFuaWMub3Jn Received-SPF: none client-ip=80.67.31.41; envelope-from=simon@netpanic.org; helo=smtprelay03.ispgateway.de X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain While experimenting with Samba, I noticed that some tools, especially samba-tools will not run, and crash: --8<---------------cut here---------------start------------->8--- root@motor ~# samba-tool Traceback (most recent call last): File "/run/current-system/profile/bin/samba-tool", line 33, in from samba.netcmd.main import cmd_sambatool File "/gnu/store/78baaab8085rd5xnfrpdkxdf07zkmin9-samba-mod-4.13.14/lib/python3.9/site-packages/samba/__init__.py", line 29, in import samba.param ModuleNotFoundError: No module named 'talloc' --8<---------------cut here---------------end--------------->8--- Doing more testing, other tools appear to not find the libraries they need too. The combination is as folows: - samba-tool, fails when tdb missing. - samba-gpupdate Idem. - samba_dnsupdate requires dnspython, but fails when talloc missing. - samba_downgrade_db" fails when tdb missing. - samba_kcc Idem. - samba_spnupdate" Idem. - samba_upgradedns" dns not found when talloc missing. I prepared a small patch to wrap up the inputs appropriately. I hope it is acceptable that they are all combined in one wrap procedure. dnspython was added as a new input too. Kind regards Simon --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-samba-Use-PYTHONPATH.patch >From 201dc8e01fa4484e24b3e088ab6a4211e9839f33 Mon Sep 17 00:00:00 2001 From: Simon Streit Date: Mon, 3 Jan 2022 13:08:23 +0100 Subject: [PATCH] gnu: samba: Use PYTHONPATH. * gnu/packages/samba.scm (samba): Use PYTHONPATH in 'wrap-program phase.. --- gnu/packages/samba.scm | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/gnu/packages/samba.scm b/gnu/packages/samba.scm index bb5b402eee..33a39eb3be 100644 --- a/gnu/packages/samba.scm +++ b/gnu/packages/samba.scm @@ -235,7 +235,30 @@ (define-public samba (lambda _ (substitute* "dynconfig/wscript" (("bld\\.INSTALL_DIR.*") "")) - #t))) + #t)) + (add-after 'install 'wrap-program + ;; Some samba tools selectively fail to find talloc, tdb + ;; and dnspython. + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (string-append (assoc-ref outputs "out"))) + (talloc (string-append (assoc-ref inputs "talloc") + "/lib/python3.9/site-packages")) + (tdb (string-append (assoc-ref inputs "tdb") + "/lib/python3.9/site-packages")) + (python-dnspython (string-append + (assoc-ref inputs "python-dnspython") + "/lib/python3.9/site-packages"))) + (for-each + (lambda (bin) + (wrap-program (string-append out bin) + `("PYTHONPATH" prefix (,talloc ,tdb ,python-dnspython)))) + '("/bin/samba-tool" + "/sbin/samba-gpupdate" + "/sbin/samba_dnsupdate" + "/sbin/samba_downgrade_db" + "/sbin/samba_kcc" + "/sbin/samba_spnupdate" + "/sbin/samba_upgradedns")))))) ;; FIXME: The test suite seemingly hangs after failing to provision the ;; test environment. #:tests? #f)) @@ -258,7 +281,8 @@ (define-public samba python popt readline - tdb)) + tdb + python-dnspython)) (propagated-inputs ;; In Requires or Requires.private of pkg-config files. (list ldb talloc tevent)) -- 2.34.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 22:36:48 2022 Received: (at 52976) by debbugs.gnu.org; 14 Jan 2022 03:36:48 +0000 Received: from localhost ([127.0.0.1]:35125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8DOS-000242-Cr for submit@debbugs.gnu.org; Thu, 13 Jan 2022 22:36:48 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:42983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8DOQ-00023m-FW for 52976@debbugs.gnu.org; Thu, 13 Jan 2022 22:36:47 -0500 Received: by mail-qt1-f173.google.com with SMTP id y17so9521209qtx.9 for <52976@debbugs.gnu.org>; Thu, 13 Jan 2022 19:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hW2uYboQWE3TgSWRCLdtRI/8M2Ge7fuo9OclCPQhrp4=; b=gyKj0dJH44lh66YTVuQg1k4HHZL0h7yy16MlUujlNAIYKcHDTS+8aX/jDtJH4LxDnK CxeX8eFiW1RtOJs65rK+QCxKw93V2A0IFdsDyypobfHhhuWA2+eP6l8K4RSdqZOJvnZr 3cvTgoLgLVYRj0HSqk2G3ru3I9mSkpEROR4h6YTkO5NzYgNqbBYeQlqm8X57TphZhH4y NKHurLUOAOJiT8R4j7DZU9/58iXDJmQa6p+AE7WaZtNk1L1UeLPFSJwIfKlVj4ophGCx JCsL5UYgDUAuaB4GeYq0C/qUd8LjFWeiUiuID/aDbqxgcbKDto2mwxJN8XptyR1VLRVF Zzpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hW2uYboQWE3TgSWRCLdtRI/8M2Ge7fuo9OclCPQhrp4=; b=IFa+5vZKBmCWxRvLyDfWtV1gl7jNEmm3FUsFw3lDNZpH/6HkVosYAx0/v9B+/tzCxo t2OPVWUE789YJwvg04yOlykguxtxWE1NP0D4JqEYQesafDQO5hKFQ9laaJATnMMiizjU OoDock5az52dWIvzPYAUrQg21prWwBz/eDd77NL0cbUHzQbJ8iryu7vo0S6N+Iy8WdJp wzJZ4EHjP58fHZEs8WTK4jMcPPObEk+w0piEfAFsZfYU3GmYgg015gGBQ3oxrYxK5PQA yjkvLIQ5R5iVug4OssQxVHgctMUb40om4vl1fe2mnUbdqagkWfa89dUMX91AuKadzKKo yT7w== X-Gm-Message-State: AOAM530F41u+K75dP7gS9ARWifRF7MJ5KF/p5lN0UD3rjktCXEOfi6Jz xXmrSu0aVJIj5GC5l/1AspNJMFq3IpR+rw== X-Google-Smtp-Source: ABdhPJyFV2ifkD0bN6x2MnOmR2CBYsicC+AmK2MByPWMedBz9CbOYsjQGSMQcBKDTIle6gbOszlzyQ== X-Received: by 2002:a05:622a:174b:: with SMTP id l11mr6400670qtk.182.1642131400617; Thu, 13 Jan 2022 19:36:40 -0800 (PST) Received: from hurd (dsl-152-155.b2b2c.ca. [66.158.152.155]) by smtp.gmail.com with ESMTPSA id g6sm712209qtp.44.2022.01.13.19.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 19:36:40 -0800 (PST) From: Maxim Cournoyer To: Simon Streit Subject: Re: bug#52976: Some tools in Samba fail to find modules, and a missing dependency References: Date: Thu, 13 Jan 2022 22:36:39 -0500 In-Reply-To: (Simon Streit's message of "Mon, 03 Jan 2022 14:07:04 +0100") Message-ID: <8735lrxa2g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52976 Cc: 52976@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Simon, Simon Streit writes: > While experimenting with Samba, I noticed that some tools, especially > samba-tools will not run, and crash: > > root@motor ~# samba-tool > Traceback (most recent call last): > File "/run/current-system/profile/bin/samba-tool", line 33, in > from samba.netcmd.main import cmd_sambatool > File "/gnu/store/78baaab8085rd5xnfrpdkxdf07zkmin9-samba-mod-4.13.14/lib/python3.9/site-packages/samba/__init__.py", line 29, in > import samba.param > ModuleNotFoundError: No module named 'talloc' > > Doing more testing, other tools appear to not find the libraries they > need too. The combination is as folows: > - samba-tool, fails when tdb missing. > - samba-gpupdate Idem. > - samba_dnsupdate requires dnspython, but fails when talloc missing. > - samba_downgrade_db" fails when tdb missing. > - samba_kcc Idem. > - samba_spnupdate" Idem. > - samba_upgradedns" dns not found when talloc missing. > > I prepared a small patch to wrap up the inputs appropriately. I hope it > is acceptable that they are all combined in one wrap procedure. Thanks for testing samba! I've updated samba recently on the version-1.4.0 branch; but the problem probably remains (I've only tested smbd and smbclient). It's now at version 4.15.3 and I nedded to add the python-cryptogaphy, python-dnspython, python-markdown and python-pyasn1 as native inputs. Based on your findings it probably should be moved to an input. >>>From 201dc8e01fa4484e24b3e088ab6a4211e9839f33 Mon Sep 17 00:00:00 2001 > From: Simon Streit > Date: Mon, 3 Jan 2022 13:08:23 +0100 > Subject: [PATCH] gnu: samba: Use PYTHONPATH. > > * gnu/packages/samba.scm (samba): Use PYTHONPATH in 'wrap-program phase.. > --- > gnu/packages/samba.scm | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/samba.scm b/gnu/packages/samba.scm > index bb5b402eee..33a39eb3be 100644 > --- a/gnu/packages/samba.scm > +++ b/gnu/packages/samba.scm > @@ -235,7 +235,30 @@ (define-public samba > (lambda _ > (substitute* "dynconfig/wscript" > (("bld\\.INSTALL_DIR.*") "")) > - #t))) > + #t)) Trailing #t are no longer needed. > + (add-after 'install 'wrap-program > + ;; Some samba tools selectively fail to find talloc, tdb > + ;; and dnspython. > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((out (string-append (assoc-ref outputs "out"))) > + (talloc (string-append (assoc-ref inputs "talloc") > + "/lib/python3.9/site-packages")) > + (tdb (string-append (assoc-ref inputs "tdb") > + "/lib/python3.9/site-packages")) > + (python-dnspython (string-append > + (assoc-ref inputs "python-dnspython") > + "/lib/python3.9/site-packages"))) We shouldn't hard code Python versions in the paths as it'd be too prone to break. You could probably make good use of the recently introduced search-input-directory procedure here :-). > + (for-each > + (lambda (bin) > + (wrap-program (string-append out bin) > + `("PYTHONPATH" prefix (,talloc ,tdb ,python-dnspython)))) Make sure to run 'guix lint', it'll probably suggest to add minimal-bash as an input because of the use of wrap-program. > + '("/bin/samba-tool" > + "/sbin/samba-gpupdate" > + "/sbin/samba_dnsupdate" > + "/sbin/samba_downgrade_db" > + "/sbin/samba_kcc" > + "/sbin/samba_spnupdate" > + "/sbin/samba_upgradedns")))))) > ;; FIXME: The test suite seemingly hangs after failing to provision the > ;; test environment. > #:tests? #f)) > @@ -258,7 +281,8 @@ (define-public samba > python > popt > readline > - tdb)) > + tdb > + python-dnspython)) > (propagated-inputs > ;; In Requires or Requires.private of pkg-config files. > (list ldb talloc tevent)) Otherwise it LGTM. Could you try to rebase this patch on top of the version-1.4.0 branch? Otherwise, wait a few days and it should be merged into master. Thank you! Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 17 08:10:58 2022 Received: (at 52976) by debbugs.gnu.org; 17 Jan 2022 13:10:58 +0000 Received: from localhost ([127.0.0.1]:45079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Rmk-0004Qs-5a for submit@debbugs.gnu.org; Mon, 17 Jan 2022 08:10:58 -0500 Received: from smtprelay06.ispgateway.de ([80.67.18.29]:25347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9Rmg-0004QW-NJ for 52976@debbugs.gnu.org; Mon, 17 Jan 2022 08:10:56 -0500 Received: from [92.195.30.39] (helo=milk) by smtprelay06.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9Rkz-0005dC-Tz; Mon, 17 Jan 2022 14:09:10 +0100 From: Simon Streit To: Maxim Cournoyer Subject: Re: bug#52976: Some tools in Samba fail to find modules, and a missing dependency References: <8735lrxa2g.fsf@gmail.com> Gcc: nnfolder+archive:sent.2022-01 Date: Mon, 17 Jan 2022 14:10:52 +0100 In-Reply-To: <8735lrxa2g.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 13 Jan 2022 22:36:39 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: bGlzdHNAbmV0cGFuaWMub3Jn X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52976 Cc: 52976@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Maxim, thanks for having look at my patch.=20 Maxim Cournoyer writes: > We shouldn't hard code Python versions in the paths as it'd be too prone > to break. You could probably make good use of the recently introduced > search-input-directory procedure here :-). I tried your suggestion, but unfortunately my attempt with modifying the lines to as such: --8<---------------cut here---------------start------------->8--- (talloc (string-append (search-input-directory inputs "/lib/python3.9/site-packages"))) (tdb (string-append (search-input-directory inputs "/lib/python3.9/site-packages"))) (python-dnspython (string-append (search-input-directory inputs "/lib/python3.9/site-packages")= )) --8<---------------cut here---------------end--------------->8--- compiles to a package. But =E2=80=98samba-tools=E2=80=99 fails again. It is not quite clear to me now why this method is better? Is hard coding being avoid now? Should I avoid the =E2=80=983.9=E2=80=99 in the se= arch path? Sorry that I have to ask for an explanation. And while we are at it. I noticed that you have already replaced heimdal with mit-krb5, which I had done personally already without proposing it yet. Thanks for that. Point is that I was trying to pull up an AD DC, which is why I run these problems. And then, can I ask you to add avahi to inputs? Since some time Samba has disabled SMBv1, which means host discovery with NetBIOS doesn=E2=80=99t= work any more. Now it is best to have Avahi running alongside Samba hosts, so that Samba can publish it=E2=80=99s service over multicast. No extra configuration is needed for this.=20 This doesn=E2=80=99t help much for Windows hosts though. I=E2=80=99ve alre= ady packaged wsdd [1], and have prepared a service, which I haven=E2=80=99t made public either yet. I haven=E2=80=99t completed the documentation for info so far. Should really finish it now. I will open another issue for this later, and will not hijack this thread for it. Kind regards Simon [1] https://github.com/christgau/wsdd From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 17 10:53:42 2022 Received: (at 52976) by debbugs.gnu.org; 17 Jan 2022 15:53:42 +0000 Received: from localhost ([127.0.0.1]:47650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9UKD-0001YG-SX for submit@debbugs.gnu.org; Mon, 17 Jan 2022 10:53:41 -0500 Received: from smtprelay07.ispgateway.de ([134.119.228.97]:19140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9UKB-0001Y5-Lm for 52976@debbugs.gnu.org; Mon, 17 Jan 2022 10:53:40 -0500 Received: from [79.252.151.159] (helo=motorball) by smtprelay07.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n9UHZ-000757-Lb; Mon, 17 Jan 2022 16:50:57 +0100 From: Simon Streit To: Maxim Cournoyer Subject: Re: bug#52976: Some tools in Samba fail to find modules, and a missing dependency References: <8735lrxa2g.fsf@gmail.com> Gcc: nnfolder+archive:sent.2022-01 Date: Mon, 17 Jan 2022 16:53:37 +0100 In-Reply-To: (Simon Streit's message of "Mon, 17 Jan 2022 14:10:52 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: bGlzdHNAbmV0cGFuaWMub3Jn X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52976 Cc: 52976@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Simon Streit writes: > compiles to a package. But =E2=80=98samba-tools=E2=80=99 fails again. Just a quick follow up, samba-tools fails with ldb being missing: --8<---------------cut here---------------start------------->8--- ModuleNotFoundError: No module named 'ldb' --8<---------------cut here---------------end--------------->8--- I put ldb into inputs, and wrapped it as well. That didn't help. Kind regards Simon