GNU bug report logs - #52973
Adding a few context-menu-mode commands

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Mon, 3 Jan 2022 08:38:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 52973 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#52973: Adding a few context-menu-mode commands
Date: Thu, 06 Jan 2022 21:19:39 +0100

Philip Kaludercic <philipk <at> posteo.net> writes:

> * lisp/net/webjump.el (webjump-default-search-engine): Add user option
> (webjump-choose-search-engine): Add function

I think putting this shared functionality in the webjump package isn't
optimal.  Webjump is "webjump.el --- programmable Web hotlist", and this
doesn't seem related.  

browse-url (or even url-something) would be more natural, I think.

The functionality otherwise looks good to me.

One micro-comment on the code:

> +(make-obsolete-variable 'eww-search-prefix
> +                        "webjump-default-search-engine"

Should be:

> +(make-obsolete-variable 'eww-search-prefix
> +                        'webjump-default-search-engine


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 3 years and 115 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.