GNU bug report logs - #52960
[PATCH 0/2] Add hueplusplus and openrgb packages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#52960: closed ([PATCH 0/2] Add hueplusplus and openrgb packages)
Date: Thu, 06 Jan 2022 18:28:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 6 Jan 2022 13:27:24 -0500
with message-id <Ydc0jGwb3bfiLYR/@jasmine.lan>
and subject line Re: [bug#52960] [PATCH 0/2] Add hueplusplus and openrgb packages
has caused the debbugs.gnu.org bug report #52960,
regarding [PATCH 0/2] Add hueplusplus and openrgb packages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
52960: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52960
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH 0/2] Add hueplusplus and openrgb packages
Date: Sun, 02 Jan 2022 17:12:56 +0000

Hi Guix,

Incoming are two patches for control of hardware lights, hueplusplus (the Hue lighting system, but I haven't tried it) and OpenRGB. I've been using OpenRGB on my computer to control all those LEDs and it has worked well. The package includes needed udev rules, but that could be split out if desired (is just a single file in the source tree).

Both packages required some unbundling, mbedtls for hueplusplus and json plus hueplusplus for OpenRGB. OpenRGB has other libraries in the dependencies folder, but as far as I can tell the others are either for different systems (Windows), or are modified/updated versions of other libraries. A few also just seem like smaller helper libraries that only live in there. Please let me know if I missed something though.

Thanks!
John

[Message part 3 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: John Kehayias via Guix-patches via <guix-patches <at> gnu.org>
Cc: 52960-done <at> debbugs.gnu.org
Subject: Re: [bug#52960] [PATCH 0/2] Add hueplusplus and openrgb packages
Date: Thu, 6 Jan 2022 13:27:24 -0500

On Sun, Jan 02, 2022 at 05:12:56PM +0000, John Kehayias via Guix-patches via wrote:
> Hi Guix,
> 
> Incoming are two patches for control of hardware lights, hueplusplus (the Hue lighting system, but I haven't tried it) and OpenRGB. I've been using OpenRGB on my computer to control all those LEDs and it has worked well. The package includes needed udev rules, but that could be split out if desired (is just a single file in the source tree).
> 
> Both packages required some unbundling, mbedtls for hueplusplus and json plus hueplusplus for OpenRGB. OpenRGB has other libraries in the dependencies folder, but as far as I can tell the others are either for different systems (Windows), or are modified/updated versions of other libraries. A few also just seem like smaller helper libraries that only live in there. Please let me know if I missed something though.

Thanks! I pushed as b1cf1d44f402cef3fccbb37277554bc7d5dd27d4 with the
following changes:

I changed the license of hueplusplus from lgpl3 to lgpl3+. This is
because the source file license headers all say "either version 3 of the License, or
(at your option) any later version." For example:

https://github.com/enwi/hueplusplus/blob/master/src/Schedule.cpp

From the hueplusplus description, I removed from the feature list
"tested with google test", since we aren't doing that yet.

I alo removed some of the so-called "marketing language" from the
synopsis and description of hueplusplus. For example, "simple and easy
to use". This subject is mentioned here:

https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

For OpenRGB, I changed the arguments field to use the new style, with
G-Expressions. And I removed the phrase "Open source" from its synopsis.
Everything in Guix is free and open source, so we don't mention it :)

Thanks again for these contributions!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.