GNU bug report logs - #5296
vc-rcs rcsdiff -u1 -> -u -1

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5296 in the body.
You can then email your comments to 5296 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: karl <at> freefriends.org (Karl Berry)
To: bug-emacs <at> gnu.org
Subject: vc-rcs rcsdiff -u1 -> -u -1
Date: Sat, 2 Jan 2010 22:49:43 GMT

In Emacs 23.1, doing vc-diff on an RCS file results in an error with
GNU diff 2.8.1 (or later):

/usr/bin/diff: `-1' option is obsolete; use `-U 1'                          
..

The *Messages* buffer reports:
vc-do-command: Running rcsdiff -q   -p -u1 maintainers...FAILED (status 2)

I could not quickly tell where the invocation was in vc-rcs.el, but
afaik replacing -u1 with -u 1 (or -U 1) is the solution.  (The workaround for
users is to set _POSIX2_VERSION=0 in the environment.)

karl

Message #8 received at 5296 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: karl <at> freefriends.org (Karl Berry)
Cc: 5296 <at> debbugs.gnu.org
Subject: Re: bug#5296: vc-rcs rcsdiff -u1 -> -u -1
Date: Sun, 3 Jan 2010 09:58:56 -0800 (PST)

karl <at> freefriends.org (Karl Berry) writes:

  > In Emacs 23.1, doing vc-diff on an RCS file results in an error with
  > GNU diff 2.8.1 (or later):
  > 
  > /usr/bin/diff: `-1' option is obsolete; use `-U 1'                          
  > ..
  > 
  > The *Messages* buffer reports:
  > vc-do-command: Running rcsdiff -q   -p -u1 maintainers...FAILED (status 2)
  > 
  > I could not quickly tell where the invocation was in vc-rcs.el, but
  > afaik replacing -u1 with -u 1 (or -U 1) is the solution.  (The workaround for
  > users is to set _POSIX2_VERSION=0 in the environment.)

Do you set `diff-switches' to "-u1" ?

This call:
(vc-switches 'RCS 'diff)
in `vc-rcs-diff' uses `diff-switches', and passes the result to "rcsdiff".

Not sure what to do here.  We already have a bug:
#4422: diff-switches is a bad idea

Message #11 received at 5296 <at> debbugs.gnu.org (full text, mbox):

From: karl <at> freefriends.org (Karl Berry)
To: dann <at> ics.uci.edu
Cc: 5296 <at> debbugs.gnu.org
Subject: Re: bug#5296: vc-rcs rcsdiff -u1 -> -u -1
Date: Sun, 3 Jan 2010 22:31:34 GMT

    Do you set `diff-switches' to "-u1" ?

You're completely right (I did that umpteen years ago).  Sorry for
wasting everyone's time.

    #4422: diff-switches is a bad idea

Despite my own bug, I don't agree it's a bad idea.

Message #16 received at 5296-done <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: karl <at> freefriends.org (Karl Berry)
Cc: 5296-done <at> debbugs.gnu.org
Subject: Re: bug#5296: vc-rcs rcsdiff -u1 -> -u -1
Date: Sun, 3 Jan 2010 19:55:42 -0800 (PST)

karl <at> freefriends.org (Karl Berry) writes:

  >     Do you set `diff-switches' to "-u1" ?
  > 
  > You're completely right (I did that umpteen years ago).

In that case we can close the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.