From unknown Fri Jun 20 18:21:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52946 <52946@debbugs.gnu.org> To: bug#52946 <52946@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Update Audacity to 3.1.3. Reply-To: bug#52946 <52946@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:21:46 +0000 retitle 52946 [PATCH 0/2] Update Audacity to 3.1.3. reassign 52946 guix-patches submitter 52946 Liliana Marie Prikler severity 52946 normal tag 52946 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 02 04:51:29 2022 Received: (at submit) by debbugs.gnu.org; 2 Jan 2022 09:51:29 +0000 Received: from localhost ([127.0.0.1]:59935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3xWT-0000jd-4l for submit@debbugs.gnu.org; Sun, 02 Jan 2022 04:51:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:43172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3xWS-0000jX-Mt for submit@debbugs.gnu.org; Sun, 02 Jan 2022 04:51:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3xWR-00088T-VQ for guix-patches@gnu.org; Sun, 02 Jan 2022 04:51:28 -0500 Received: from [2a00:1450:4864:20::343] (port=53858 helo=mail-wm1-x343.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n3xWQ-0004wd-Fh for guix-patches@gnu.org; Sun, 02 Jan 2022 04:51:27 -0500 Received: by mail-wm1-x343.google.com with SMTP id l4so19821565wmq.3 for ; Sun, 02 Jan 2022 01:51:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:subject:mime-version:to:content-transfer-encoding :message-id; bh=sDV4EtC/xLxDA+X74966ydFJnnX0o/MicApvyJYYgWs=; b=o7bFxvE2BIFqkl/baMH4VN9DTh1luqI5JbtqWcU74CV1jvgy5f/VshzBA0j2lQ/o4J +TgZtnmylZsDSjxi8JBIOiBH9QGABt4m8BCCpFWoVvSbymsQMxXB+rREmcv+KNc7Iz0L 1ks2cqKES7z1U2/o1xRFxZ512Qwr2owcfBphuwQ12yO8Kr4qNOtg9TNw9G3ODxK1OEgo k4VVnjvZqxVaLAojYnwB9csNAk4QZk9EbDSL0IGuNS4Z97mLoWYPUTzrZsrUqeqJXXfS WSzDrEYogat+WEKtjd5bByxpd0Y1nCZDYTjoCnVxLwR9OiHiu8d6LL9efJXrn/QZxTpO dkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:subject:mime-version:to :content-transfer-encoding:message-id; bh=sDV4EtC/xLxDA+X74966ydFJnnX0o/MicApvyJYYgWs=; b=Hl4d0WMVRu66dLDxHK2cW+NaTBqck7BKLprkLTYMULjx/DD+vXPucDGA9xbE3hYCnM Z3HInEovZkW1nN7yHRs5vJZz8W9FkSIKyWS40tROrSvu9nCeT0SJq8xoFpH6S8Gp2bLY 7aA6rzYtie7FL2qPTcz8krLybGX9NMv+e1ZZi2XURBWD/bGSBZGbg/A/D3xtyXcsrl0R v3hC51zt3iZUsxpvxO/m9/wcfSXSocOcfPiQbHGYhW2kdaI5cy+xFZ5QEd3uBu+6g2Wd WxSxVgdFZKsijhIItLtgx5ltU4cXLmjRvao1Ifdr5rwrMfW95isCczYvHc4qbgNKAoW9 vulg== X-Gm-Message-State: AOAM530L8GGQ7Fg8za7+cJVlWVv09QH2mqSM4QDOKgdk5LA6ni8ec3i+ TVaVu7spgktmABwXOIDAyTvWMCsJrVcyeQ== X-Google-Smtp-Source: ABdhPJwkWyTuU2Gk1WxVQTOC71Ba8r/V3jgL/FnGPCoc5aLTuSz7qmT/SbI8WKy1kntlWgLMK8jVSg== X-Received: by 2002:a7b:c194:: with SMTP id y20mr35328171wmi.79.1641117083835; Sun, 02 Jan 2022 01:51:23 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g7sm32369348wrx.104.2022.01.02.01.51.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 01:51:23 -0800 (PST) From: Liliana Marie Prikler Date: Sun, 2 Jan 2022 10:42:52 +0100 Subject: [PATCH 0/2] Update Audacity to 3.1.3. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 to: guix-patches@gnu.org Content-Transfer-Encoding: 7bit Message-ID: X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::343 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::343; envelope-from=liliana.prikler@gmail.com; helo=mail-wm1-x343.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This series updates wxwidgets-3.1 and thereafter audacity. Both packages come with a series of adjustments to things changed in the build system in newer versions. Particularly concerning is that audacity relies on linux-internal headers in order to do file magic. Would it be feasible to patch their code so that it works in terms of the file package? Cheers Liliana Marie Prikler (2): gnu: wxwidgets-3.1: Update to 3.1.5. gnu: audacity: Update to 3.1.3 gnu/local.mk | 2 - gnu/packages/audio.scm | 66 ++++++++++++------- .../patches/audacity-add-include.patch | 15 ----- ...audacity-build-with-system-portaudio.patch | 62 ----------------- gnu/packages/wxwidgets.scm | 29 ++++++-- 5 files changed, 66 insertions(+), 108 deletions(-) delete mode 100644 gnu/packages/patches/audacity-add-include.patch delete mode 100644 gnu/packages/patches/audacity-build-with-system-portaudio.patch -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 02 05:26:07 2022 Received: (at 52946) by debbugs.gnu.org; 2 Jan 2022 10:26:07 +0000 Received: from localhost ([127.0.0.1]:59952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3y3y-0003rF-Nq for submit@debbugs.gnu.org; Sun, 02 Jan 2022 05:26:07 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:39724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3y3v-0003qc-Lt for 52946@debbugs.gnu.org; Sun, 02 Jan 2022 05:26:04 -0500 Received: by mail-wr1-f67.google.com with SMTP id s1so64381628wra.6 for <52946@debbugs.gnu.org>; Sun, 02 Jan 2022 02:26:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:subject:mime-version:to:content-transfer-encoding :message-id; bh=apbiCjdoKzebJs3pPQYjOjm4mQKzVd2ueSzxpwkLb2M=; b=n/kZ223bJ2UagaGV0IcEbOdB26/eIHoqcvG0GnqUWVLor43MZiLA+Z/BCW541VxTvT oYF52KhEA41KnZDnjAJ/7K1BjuEhz17658a7cAkcOljHGfAsog43o/TbtLa+T3ytmV1O KuV6jujKP+HdShvPP8duwplGrv8gSEqY2Yz1WSaXS470sHSJ7mxSnHLg9vUWpAwmJDXp UCPJQppfFv2CQ1uWdBpFAqyH298/qPeZCztPO2hutdQVFwE41UGwS6C6yzXGvVzt9Jwp odOO6ZTcxVGfqJunrYgwF3hHxn3OXRTQCgClUOVxyKjaUrX/gvAOiksQ1vmW6tJZeN7X j8xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:subject:mime-version:to :content-transfer-encoding:message-id; bh=apbiCjdoKzebJs3pPQYjOjm4mQKzVd2ueSzxpwkLb2M=; b=EQ/0oNAePI2Qe9iJLgQGAcPCAbk4BNLILGfsZngHGALpH5anrHtplL6GqtDTmO2r7z YO2Hlj77HX+dKpuhUkLSsMlB0MXILN9CJqTV1mb/bcflZlsfZ4ixrnt073lG35s31VfI JUpVF//MN0/5sa71IABm7wgZEOs+fQWVc6EiT52mMP+MEqzr3p2DCy44TUoD0HhJeKWQ RYoNbq+pexz5xDqDPJn2pqiVEN4/v3p3wwxBxOsvxWKdSkv5szH7MTogBDzhD+iVO1YZ CgoutvuzE6ndnaXeOUhPr6MBVnssMnX2Jp/gLcTxASOSaIQQjpmmeYSByAeQsfqYupcW yfQw== X-Gm-Message-State: AOAM531MMOlN6Edq7WuO2b2oIzlPniptAoLt0Nq1r5qkxg+yLdZnYVJv 6w4KiHs5axb2CqQDRr92BdEPREVcwzam+A== X-Google-Smtp-Source: ABdhPJythh2RehuqDwDSgTu9OJJ2MV2HXlEFPcGIqG59pqfQX2VRcF8qowG31dXXOhwn5vKSEZNs2g== X-Received: by 2002:a5d:47cd:: with SMTP id o13mr35218900wrc.669.1641119157817; Sun, 02 Jan 2022 02:25:57 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a2sm35414123wri.17.2022.01.02.02.25.56 for <52946@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 02:25:57 -0800 (PST) From: Liliana Marie Prikler Date: Thu, 30 Dec 2021 15:23:51 +0100 Subject: [PATCH 1/2] gnu: wxwidgets-3.1: Update to 3.1.5. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 to: 52946@debbugs.gnu.org Content-Transfer-Encoding: 8bit Message-ID: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52946 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/wxwidgets.scm (wxwidgets-3.1): Update to 3.1.5. [inputs]: Add catch-framework. [#:configure-flags]: List out all flags. [#:phases]: Add ‘add-catch’ phase. Replace ‘configure’ with manual configuration. --- gnu/packages/wxwidgets.scm | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/gnu/packages/wxwidgets.scm b/gnu/packages/wxwidgets.scm index 1776532..41ea99f 100644 --- a/gnu/packages/wxwidgets.scm +++ b/gnu/packages/wxwidgets.scm @@ -26,6 +26,7 @@ (define-module (gnu packages wxwidgets) #:use-module (guix packages) + #:use-module (guix gexp) #:use-module (guix download) #:use-module (guix git-download) #:use-module ((guix licenses) #:prefix l:) @@ -33,6 +34,7 @@ (define-module (gnu packages wxwidgets) #:use-module (guix build-system python) #:use-module (guix utils) #:use-module (gnu packages) + #:use-module (gnu packages check) #:use-module (gnu packages compression) #:use-module (gnu packages databases) #:use-module (gnu packages freedesktop) @@ -162,7 +164,7 @@ (define-public wxwidgets-gtk2 ;; This can be removed when wxWidgets is updated to the next stable version. (define-public wxwidgets-3.1 (package (inherit wxwidgets) - (version "3.1.0") + (version "3.1.5") (source (origin (method git-fetch) @@ -172,13 +174,32 @@ (define-public wxwidgets-3.1 (file-name (git-file-name "wxwidgets" version)) (sha256 (base32 - "14kl1rsngm70v3mbyv1mal15iz2b18k97avjx8jn7s81znha1c7f")))) + "0j998nzqmycafignclxmahgqm5kgs1fiqbsiyvzm7bnpnafi333y")))) (inputs (modify-inputs (package-inputs wxwidgets) - (prepend gstreamer gst-plugins-base))) + (prepend catch-framework gstreamer gst-plugins-base))) (arguments (substitute-keyword-arguments (package-arguments wxwidgets) ((#:configure-flags flags) - `(cons "--enable-mediactrl" ,flags)))))) + '(list "--with-regex" "--with-libmspack" "--with-sdl" + "--enable-mediactrl" "--enable-webviewwebkit")) + ((#:phases phases) + `(modify-phases ,phases + (add-after 'unpack 'add-catch + (lambda* (#:key inputs #:allow-other-keys) + (install-file + (search-input-file inputs "include/catch.hpp") + "3rdparty/catch/include/"))) + (replace 'configure + (lambda* (#:key configure-flags inputs native-inputs outputs + #:allow-other-keys) + (let ((sh (search-input-file (or native-inputs inputs) + "bin/sh"))) + (apply invoke "./configure" + (string-append "SHELL=" sh) + (string-append "CONFIG_SHELL=" sh) + (string-append "--prefix=" + (assoc-ref outputs "out")) + configure-flags)))))))))) (define-public wxwidgets-gtk2-3.1 (package/inherit wxwidgets-3.1 -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 02 05:26:07 2022 Received: (at 52946) by debbugs.gnu.org; 2 Jan 2022 10:26:08 +0000 Received: from localhost ([127.0.0.1]:59954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3y3z-0003rH-36 for submit@debbugs.gnu.org; Sun, 02 Jan 2022 05:26:07 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3y3w-0003qe-5v for 52946@debbugs.gnu.org; Sun, 02 Jan 2022 05:26:04 -0500 Received: by mail-wr1-f66.google.com with SMTP id o3so6209122wrh.10 for <52946@debbugs.gnu.org>; Sun, 02 Jan 2022 02:26:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:date:subject:to:content-transfer-encoding:message-id :mime-version; bh=jKNtqpCeKZaI8U/clVZzjli+97vA2I3P4aTY4QLKwzc=; b=PhMMUCNwyhrWXaOsPr/aMIyiCza4FsagfAdM5iPIiTuUfCyjW7hCYLWd8Qxy6rEJoH LQ7gkSuXLmP+KVpD38Cf9rJ5yc7QhdcXodsYJ/VLJ1O4WCUp0mmZ4bZOw//ijgBxM3qb 0jRVgnf/AJGOQ+u93lgtT+Js7pV3QXyjPOLb4ps+Town8WVNcwAvAghc13AKx5miC/7i jPl4VXukqyf5HSAu8hMv6Rzo92GUH663C+prSZ9RD8j5WxN7A2ke4XdaMpuXEItWMF/n wvk37sOyRxqlcpMDXD+NkB6kdf9iKAm17+uRdb2MZQdBRTTzOUjmuakS+87W9tSfR2cE Jl0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:date:subject:to:content-transfer-encoding :message-id:mime-version; bh=jKNtqpCeKZaI8U/clVZzjli+97vA2I3P4aTY4QLKwzc=; b=vf9H6DcDpPwveyJ4T3V1n+gNEOKdgto9x2fdSQe1dlDyMqMwZOdHOgNHM5z84JB9Yd Hhn3IuAKeduwuDRqYgx6QFkM2562bBZ0jV+UisNv2PqyS1ddh2QWj8rM4ihQ7ZcyF02d OCdoreUNwFP4MGr8ZYVionmtTkZH/8dNYQqmMwO84VS89KImvXV5e+UcxHN+mq09aHwo vOghXk0G+oG0ewBCHcTZ444oytXgHLYxxhpXaIupM6AZ/LI5cUKGLkz5PCcVY7HAhAFB C+noekjNylAADqO2FPV4Uv+kFsN525h5egrlJIdGehaJYdIsngu2G5GRYSMCCg3R+9eN Ut8Q== X-Gm-Message-State: AOAM530jTcBkVONV+/gOUjw8Fgqj+TTqdhUHmzzGuyNyB1V0I6at7/7L 6afhxx+Vzba2JbzANFrIJdUq+F4N+EHksA== X-Google-Smtp-Source: ABdhPJza5hHn4+XIBiQ5DD18LufGA71h31PyPFemlSKr4Gx1CvKtp4D5sszf6XzQK2EpZL/dgW+VFA== X-Received: by 2002:a5d:5887:: with SMTP id n7mr34802891wrf.510.1641119158478; Sun, 02 Jan 2022 02:25:58 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a2sm35414123wri.17.2022.01.02.02.25.57 for <52946@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 02:25:58 -0800 (PST) From: Liliana Marie Prikler Date: Sun, 2 Jan 2022 10:37:35 +0100 Subject: [PATCH 2/2] gnu: audacity: Update to 3.1.3 to: 52946@debbugs.gnu.org Content-Transfer-Encoding: 7bit Message-ID: <10fa664b44b8eefedb45bd444fc16fabea5595a8.camel@gmail.com> MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52946 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/patches/audacity-add-include.patch: Delete file. * gnu/packages/patches/audacity-build-with-system-portaudio.patch: Delete file. * gnu/local.mk (dist_patch_DATA): Adjust accordingly. * gnu/packages/audio (audacity): Update to 3.1.3 [inputs]: Use wxwidgets-3.1. Add linux-libre-headers, libjpeg-turbo, sqlite, portaudio. [#:configure-flags]: Update to disable conan during build, prefer system libraries, and disable features that phone home. [#:phases]: Add fix-cmake-rpath to ensure correct DT_RUNPATHs. Adjust comment-out-revision-indent and use-upstream-headers. [native-search-paths]: Add AUDACITY_MODULES_PATH and AUDACITY_PATH. --- gnu/local.mk | 2 - gnu/packages/audio.scm | 66 ++++++++++++------- .../patches/audacity-add-include.patch | 15 ----- ...audacity-build-with-system-portaudio.patch | 62 ----------------- 4 files changed, 41 insertions(+), 104 deletions(-) delete mode 100644 gnu/packages/patches/audacity-add-include.patch delete mode 100644 gnu/packages/patches/audacity-build-with-system-portaudio.patch diff --git a/gnu/local.mk b/gnu/local.mk index 21e536a..fd5c696 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -854,8 +854,6 @@ dist_patch_DATA = \ %D%/packages/patches/ath9k-htc-firmware-gcc-compat.patch \ %D%/packages/patches/ath9k-htc-firmware-objcopy.patch \ %D%/packages/patches/atlas-gfortran-compat.patch \ - %D%/packages/patches/audacity-build-with-system-portaudio.patch \ - %D%/packages/patches/audacity-add-include.patch \ %D%/packages/patches/audiofile-fix-datatypes-in-tests.patch \ %D%/packages/patches/audiofile-fix-sign-conversion.patch \ %D%/packages/patches/audiofile-CVE-2015-7747.patch \ diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 665631a..6b0c722 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -723,7 +723,7 @@ (define-public ardour (define-public audacity (package (name "audacity") - (version "2.4.2") + (version "3.1.3") (source (origin (method git-fetch) @@ -733,9 +733,7 @@ (define-public audacity (file-name (git-file-name name version)) (sha256 (base32 - "0lklcvqkxrr2gkb9gh3422iadzl2rv9v0a8s76rwq43lj2im7546")) - (patches (search-patches "audacity-build-with-system-portaudio.patch" - "audacity-add-include.patch")) + "1689q9apbjf9nnda62shb8j7hm4hxd47mhk4l5h3c728mjjkilmi")) (modules '((guix build utils))) (snippet ;; Remove bundled libraries. @@ -743,13 +741,10 @@ (define-public audacity (for-each (lambda (dir) (delete-file-recursively (string-append "lib-src/" dir))) - '("expat" "ffmpeg" "lame" "libflac" "libid3tag" "libmad" "libogg" - "libsndfile" "libsoxr" "libvamp" "libvorbis" "lv2" - "portmidi" "soundtouch" "twolame" + '("libsoxr" "libvamp" "lv2" "soundtouch" "sqlite" "twolame" ;; FIXME: these libraries have not been packaged yet: ;; "libnyquist" ;; "libscorealign" - ;; "libwidgetextra" ;; "portburn" ;; "portsmf" ;; "portmixer" @@ -761,26 +756,30 @@ (define-public audacity #t)))) (build-system cmake-build-system) (inputs - (list wxwidgets + (list wxwidgets-3.1 gtk+ alsa-lib jack-1 expat ffmpeg lame + linux-libre-headers flac libid3tag + libjpeg-turbo libmad ;;("libsbsms" ,libsbsms) ;bundled version is modified libsndfile soundtouch soxr ;replaces libsamplerate + sqlite twolame vamp libvorbis lv2 lilv ;for lv2 suil ;for lv2 + portaudio portmidi)) (native-inputs `(("autoconf" ,autoconf) @@ -793,10 +792,12 @@ (define-public audacity (arguments `(#:configure-flags (list - ;; Loading FFmpeg dynamically is problematic. - "-Daudacity_use_ffmpeg=linked" - "-Daudacity_use_lame=system" - "-Daudacity_use_portsmf=system") + "-Daudacity_conan_enabled=off" + "-Daudacity_lib_preference=system" + ;; TODO: enable this flag once we've packaged all dependencies + ;; "-Daudacity_obey_system_dependencies=on" + ;; disable crash reports, updates, ..., anything that phones home + "-Daudacity_has_networking=off") #:imported-modules ((guix build glib-or-gtk-build-system) ,@%cmake-build-system-modules) #:modules @@ -805,27 +806,42 @@ (define-public audacity ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)) #:phases (modify-phases %standard-phases + (add-after 'unpack 'fix-cmake-rpath + (lambda* (#:key outputs #:allow-other-keys) + (substitute* "CMakeLists.txt" + (("\\$ORIGIN/\\.\\./\\$\\{_PKGLIB\\}") + (string-append (assoc-ref outputs "out") "/lib/audacity")) + (("CMAKE_BUILD_WITH_INSTALL_RPATH [A-Z]*") + "CMAKE_BUILD_WITH_INSTALL_RPATH TRUE") + (("CMAKE_INSTALL_RPATH_USE_LINK_PATH [A-Z]*") + "CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE")) + (substitute* "src/CMakeLists.txt" + (("-Wl,--disable-new-dtags") "-Wl,--enable-new-dtags")))) (add-after 'unpack 'comment-out-revision-ident (lambda _ + (substitute* "src/CMakeLists.txt" + (("file\\( TOUCH \".*RevisionIdent\\.h\" \\)" directive) + (string-append "# " directive))) (substitute* "src/AboutDialog.cpp" (("(.*RevisionIdent\\.h.*)" include-line) (string-append "// " include-line))))) (add-after 'unpack 'use-upstream-headers (lambda* (#:key inputs #:allow-other-keys) - (substitute* '("src/NoteTrack.cpp" - "src/AudioIO.cpp" - "src/AudioIO.h" - "src/AudioIOBase.cpp") - (("../lib-src/portmidi/pm_common/portmidi.h") "portmidi.h") - (("../lib-src/portmidi/porttime/porttime.h") "porttime.h")) - (substitute* "src/prefs/MidiIOPrefs.cpp" - (("../../lib-src/portmidi/pm_common/portmidi.h") "portmidi.h")))) + (substitute* '("libraries/lib-files/FileNames.cpp") + (("\"/usr/include/linux/magic.h\"") "")))) (add-after 'wrap-program 'glib-or-gtk-wrap (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))) - ;; The test suite is not "well exercised" according to the developers, - ;; and fails with various errors. See - ;; . - #:tests? #f)) + ;; The test suite is not "well exercised" according to the developers, + ;; and fails with various errors. See + ;; . + #:tests? #f)) + (native-search-paths + (list (search-path-specification + (variable "AUDACITY_MODULES_PATH") + (files '("lib/audacity/modules"))) + (search-path-specification + (variable "AUDACITY_PATH") + (files '("share/audacity"))))) (home-page "https://www.audacityteam.org/") (synopsis "Software for recording and editing sounds") (description diff --git a/gnu/packages/patches/audacity-add-include.patch b/gnu/packages/patches/audacity-add-include.patch deleted file mode 100644 index a7f2791..0000000 --- a/gnu/packages/patches/audacity-add-include.patch +++ /dev/null @@ -1,15 +0,0 @@ -Without , gettimeofday is undefined. - -diff --git a/src/AudioIO.cpp b/src/AudioIO.cpp -index 0187e3962..e15d55f4c 100644 ---- a/src/AudioIO.cpp -+++ b/src/AudioIO.cpp -@@ -479,6 +479,8 @@ time warp info and AudioIOListener and whether the playback is looped. - #include "../lib-src/portmidi/porttime/porttime.h" - #include "../lib-src/header-substitutes/allegro.h" - -+#include -+ - #define MIDI_SLEEP 10 /* milliseconds */ - // how long do we think the thread that fills MIDI buffers, - // if it is separate from the portaudio thread, diff --git a/gnu/packages/patches/audacity-build-with-system-portaudio.patch b/gnu/packages/patches/audacity-build-with-system-portaudio.patch deleted file mode 100644 index 05325a1..0000000 --- a/gnu/packages/patches/audacity-build-with-system-portaudio.patch +++ /dev/null @@ -1,62 +0,0 @@ -Downloaded from here: -https://sourceforge.net/p/audacity/mailman/message/36106562/ - -Modified for use on later versions of audacity. - ->From 5f9482a191359f2c477763a36d2c865c5f186602 Mon Sep 17 00:00:00 2001 -From: Antonio Ospite -Date: Tue, 7 Nov 2017 13:06:33 +0100 -Subject: [PATCH] Fix building against the system portaudio library - -Building against the system portaudio results in this error: - -./src/AudioIO.cpp:983: undefined reference to `PaUtil_GetTime' -audacity-AudioIO.o: In function `audacityAudioCallback(void const*, void*, -unsigned long, PaStreamCallbackTimeInfo const*, unsigned long, void*)': -./src/AudioIO.cpp:4630: undefined reference to `PaUtil_GetTime' -collect2: error: ld returned 1 exit status -Makefile:2349: recipe for target 'audacity' failed -make[3]: *** [audacity] Error 1 - -This is because PaUtil_GetTime is declared as a C symbol in pa_util.h -but is resolved as a C++ symbol at link time. - -Audacity fixes this in the local tree with this change: -https://github.com/audacity/audacity/commit/38fd97b8e26060332ab3e9e000a8882326a70ba7 - -However this is not general enough for the portaudio debian package. - -Since PaUtil_GetTime() is the only function causing problems, just copy -over the code where it's used. ---- - src/AudioIO.cpp | 17 ++++++++++++++++- - 1 file changed, 16 insertions(+), 1 deletion(-) - -diff --git a/src/AudioIO.cpp b/src/AudioIO.cpp -index 48715869c..bb4bf472c 100644 ---- a/src/AudioIO.cpp -+++ b/src/AudioIO.cpp -@@ -480,9 +480,22 @@ time warp info and AudioIOListener and whether the playback is looped. - #define ROUND(x) (int) ((x)+0.5) - //#include - // #include "../lib-src/portmidi/pm_common/portmidi.h" -- #include "../lib-src/portaudio-v19/src/common/pa_util.h" - #include "NoteTrack.h" - #endif -+PaTime PaUtil_GetTime( void ) -+{ -+#ifdef HAVE_MACH_ABSOLUTE_TIME -+ return mach_absolute_time() * machSecondsConversionScaler_; -+#elif defined(HAVE_CLOCK_GETTIME) -+ struct timespec tp; -+ clock_gettime(CLOCK_REALTIME, &tp); -+ return (PaTime)(tp.tv_sec + tp.tv_nsec * 1e-9); -+#else -+ struct timeval tv; -+ gettimeofday( &tv, NULL ); -+ return (PaTime) tv.tv_usec * 1e-6 + tv.tv_sec; -+#endif -+} - - #ifdef EXPERIMENTAL_AUTOMATED_INPUT_LEVEL_ADJUSTMENT - #define LOWER_BOUND 0.0 -- 2.34.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 02 23:11:33 2022 Received: (at 52946) by debbugs.gnu.org; 3 Jan 2022 04:11:33 +0000 Received: from localhost ([127.0.0.1]:34003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4Eh3-0000Jc-7j for submit@debbugs.gnu.org; Sun, 02 Jan 2022 23:11:33 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:37081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4Eh0-0000JL-LS for 52946@debbugs.gnu.org; Sun, 02 Jan 2022 23:11:31 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7BCF0320046F; Sun, 2 Jan 2022 23:11:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 02 Jan 2022 23:11:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=i4XNEzL1+3fsdIsU7UVtkCSf knQEO7sDA4FlHuE687E=; b=eFzWlmRz1EHtBDfRrCmpswPyO5q1wuZu3CGljanU 9G8CZlKaaK7MlHhR6sqI/cJ5mFu7FlwkUVOSBuaPnioQL8Q+fGmvZE2RLbFqFWxw /cA4KQ+C73L7BfqOIc22wKwn0RdjtHEqELTErM6ct5xCcer4AAK4SB5uBJ0MD0wP xs0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=i4XNEz L1+3fsdIsU7UVtkCSfknQEO7sDA4FlHuE687E=; b=SORcxF58SfPXCsFzSsavS0 v3JG4mYgMrQqezJZoIJ9qfSrEjN+tmBut/oDjBsfiUT3MAxvTpsxm7d0+HFw73cK xsTzLcytM1QuzlU1dH8IWuP4FMyeUojN3AEKLjhik/MixYiZUB/Cfvto9d2jgwae 0LArPYms2xzIjVPlYsnUp3G83W993JO7Xs1vTcifKN91fPLFRAqrWTzFVjAoLEmf RaECSywNWDc5wksFXlV9scDvT48k93a2h28xHGB5cbto7h9deIFaPU7fQrcyLcVJ 1pBxmxPOAguZh9AVQo7MuTDhCGDfxoGD9JqrrVg7xItYEojcdAe2WX1dGeuCbw7w == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudeftddgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 2 Jan 2022 23:11:23 -0500 (EST) Date: Sun, 2 Jan 2022 23:11:21 -0500 From: Leo Famulari To: Liliana Marie Prikler Subject: Re: [bug#52946] [PATCH 0/2] Update Audacity to 3.1.3. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52946 Cc: 52946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, Jan 02, 2022 at 10:42:52AM +0100, Liliana Marie Prikler wrote: > This series updates wxwidgets-3.1 and thereafter audacity. Both packages > come with a series of adjustments to things changed in the build system > in newer versions. Thanks, it works for me using Guix on Debian. > Particularly concerning is that audacity relies on linux-internal headers > in order to do file magic. Would it be feasible to patch their code so > that it works in terms of the file package? I don't know about this subject, but I noticed the same thing while attempting this update. Do you think it's a problem? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 04 15:43:52 2022 Received: (at 52946) by debbugs.gnu.org; 4 Jan 2022 20:43:52 +0000 Received: from localhost ([127.0.0.1]:38864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4qet-0000ZX-TV for submit@debbugs.gnu.org; Tue, 04 Jan 2022 15:43:52 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4qeo-0000ZA-GW for 52946@debbugs.gnu.org; Tue, 04 Jan 2022 15:43:50 -0500 Received: by mail-wr1-f68.google.com with SMTP id v7so78471007wrv.12 for <52946@debbugs.gnu.org>; Tue, 04 Jan 2022 12:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=iLifJmGJLPv86e6DaPMBfGT5V4Pn8x1MMO5DZebMJOw=; b=LXGnbIEgfheq9X5F739IjCVZJ5h4BEh8Ka01bO1TvCnuDJJ2p43Q+y22cbITehOuks URCe9Mgctwsu6tSL/WdEUwrlQA1VrD9kCR5JsCUSQZwNm3MhUEHY+flJA2yFcUahkXxl 2ibAw2ZkE39poDtNfPL60XXZGAbNu/rOF1yLBK3EinG1ssDdCLAQtfC12kpTf1JisFNr iByTegB8ZmgwNu5xxZ9n38aZIrdJmoK+YgungEkRa8tqRQDMpKtZu4FmsW7nOnhYrmVb OgjJQSNzHBQFo0orH9Ej07VVU1isXeyzEhzn5p2w8Oi6ZrxUezKyiBnIrVkMi5oncNcO kejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=iLifJmGJLPv86e6DaPMBfGT5V4Pn8x1MMO5DZebMJOw=; b=VRQWg4oYzhfbe0AiPZkYN9dopQNQd1N2FQ2W5BUPMBHOVlhlrseSiFj5fcfgYbliRs 5m5eVqxlBAf56gkFMdmymMtOXF/pjESiUATb2zEg7g8moF9hVIHE5rSi4SuP+fjJOfjx mYP0Z4z2fXwP62+gKMK3y+ANC3vThPML3hLGB03O6J1nQIZlzhZGIgTa86A15ASMH0S2 MrJ3BToVhgqGIiP8KlXiacBF53NVabZmeo62W5jJcafq6u2bN8/DRizlXQtXBRbJF61O Bbgq/TsxwsjOVZCBZ1CC4PKASpDx/xeL1aCtYSQ0uOyWT7nc06FgAnJSDV9waEm/LHEV 6GAg== X-Gm-Message-State: AOAM532ipC9BiSCx11tj6XQAG67BHWLi2tFxhzjCuCAD+aZ0APXWWR2i OBhSeVWrZNjw1k056MnFQHIvtlbMoCyQyw== X-Google-Smtp-Source: ABdhPJzGzwRndmHtWY8y0cyZZDMqFloT7fcki/A0cd9BwipVUwPd1IIXV+rYoF6HiX5cGVHVOZL5/A== X-Received: by 2002:a5d:5982:: with SMTP id n2mr44809542wri.582.1641329020540; Tue, 04 Jan 2022 12:43:40 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u14sm38265032wrf.39.2022.01.04.12.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 12:43:39 -0800 (PST) Message-ID: Subject: Re: [bug#52946] [PATCH 0/2] Update Audacity to 3.1.3. From: Liliana Marie Prikler To: Leo Famulari Date: Tue, 04 Jan 2022 21:43:37 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52946 Cc: 52946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 02.01.2022 um 23:11 -0500 schrieb Leo Famulari: > On Sun, Jan 02, 2022 at 10:42:52AM +0100, Liliana Marie Prikler > wrote: > > This series updates wxwidgets-3.1 and thereafter audacity.  Both > > packages come with a series of adjustments to things changed in the > > build system in newer versions. > > Thanks, it works for me using Guix on Debian. Good to know. > > Particularly concerning is that audacity relies on linux-internal > > headers in order to do file magic.  Would it be feasible to patch > > their code so that it works in terms of the file package? > > I don't know about this subject, but I noticed the same thing while > attempting this update. Do you think it's a problem? I'd like to avoid it if possible. Audacity uses it to determine whether a particular file system is FAT so as to determine its limitations -- I'm sure there are better ways of doing that. Cheers From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 04 16:04:29 2022 Received: (at 52946) by debbugs.gnu.org; 4 Jan 2022 21:04:29 +0000 Received: from localhost ([127.0.0.1]:38877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4qyr-00016x-3f for submit@debbugs.gnu.org; Tue, 04 Jan 2022 16:04:29 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:38193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4qyn-00016j-Sx for 52946@debbugs.gnu.org; Tue, 04 Jan 2022 16:04:27 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 0110C3201F5F; Tue, 4 Jan 2022 16:04:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 04 Jan 2022 16:04:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=Xdm6rUmZKpKt9DE5l8WsOOR1 y23keM6D3jmH0BK7i6o=; b=I/DNgKnFh33bfbQOnwZ6O5wu7lGkKyq7buQmRBxH OUXcfgeQirnjNEhEAb43rkXrpYbO/5eboYyLBdp+3QFlMTg2y1Hkw4wbUfg26r9U okXnmxRqgUY1CrC3SV+WJQuw9cFeNWYE0QAk26+TAErdMORg53zXZd2rcRrg4R2N 6Rs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Xdm6rU mZKpKt9DE5l8WsOOR1y23keM6D3jmH0BK7i6o=; b=PtaYj595QuuGJeyntWo4fW wTqIPCnKnj1BLNN7yKOixvOll1JF2AqsmlteA25csCGLXnn63zg9ftylzYzxkwS7 1rf9gG4wa5LUQC6+QWxtJGhxtterNfecqPlwfSXr2uePha7USOXQRJFH1rOZrsJF Z5DPrC7elTjyJh81LmbHlyFI3KQ/zS8yRlf6epOCd372HVB33M1qbrrKEjlzNJzS 8HziiKcHCswawIj1Xer+DgV1HwbXJjVyu7Lmj2gXuSYO5r8U8IrfCVNYvswGuo9o JWQb5X6N/zomNxkUdgWFOufDOExK8anhhx9DLRHRRia5cdwf7HbXTc93tmteUoJQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudeffedgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheff vefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jan 2022 16:04:19 -0500 (EST) Date: Tue, 4 Jan 2022 16:04:17 -0500 From: Leo Famulari To: Liliana Marie Prikler Subject: Re: [bug#52946] [PATCH 0/2] Update Audacity to 3.1.3. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52946 Cc: 52946@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, Jan 04, 2022 at 09:43:37PM +0100, Liliana Marie Prikler wrote: > I'd like to avoid it if possible. Audacity uses it to determine > whether a particular file system is FAT so as to determine its > limitations -- I'm sure there are better ways of doing that. I agree that it would be nice to avoid it. On the other hand, if that's how Audacity made their program work, we should accept it unless it causes serious problems. I don't think that feature development of packaged programs should happen in the distro. I don't know what problems it could cause, just that it's unusual. A few packages do refer directly to "kernel-headers" from the build environment. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 19 15:16:26 2022 Received: (at 52946-done) by debbugs.gnu.org; 19 Jan 2022 20:16:26 +0000 Received: from localhost ([127.0.0.1]:55539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAHNa-0001qC-0I for submit@debbugs.gnu.org; Wed, 19 Jan 2022 15:16:26 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAHNZ-0001px-Co for 52946-done@debbugs.gnu.org; Wed, 19 Jan 2022 15:16:25 -0500 Received: by mail-wm1-f65.google.com with SMTP id r132-20020a1c448a000000b0034e043aaac7so515506wma.5 for <52946-done@debbugs.gnu.org>; Wed, 19 Jan 2022 12:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=ux9FPnCGJ00cBGqoNDhg6BfN0ZhhVTlEst6hAW8f2tM=; b=CGDZhfSvElT50WvNcc8pqqS+s9JqfyjMg9nhitvA5HYJirwU7qtrzOfEtz/G/HBsMC daPbY0irY8/mwKjbfWQF37T2GFiNgNKMpRLTllaWI5qR4263UcqNFbMdyZKTH4S607dG kp8mqgN3+iV1BqH0XSaVMnEaSzgRrJNUiDtYOZYO+JdmElQinrNW/ENMpnHFZCHaZv5F QQQPixdyDFt5r2gNC34g9nCWOQi66OOTSpTJCouEzwF/U0Gdhd2OqzFDzsaKDk+bmGoO l8Bm15bcQyFTYgQPQ9lOk9ZA/abKjbhCTMuLYKaDqnIX/CuQcIOXllYssHmD2CyNuRJS UYTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=ux9FPnCGJ00cBGqoNDhg6BfN0ZhhVTlEst6hAW8f2tM=; b=PHyGJS/CLy+uBW22Fd5v4Da0oPcp5kmQYmjDEJJpzTJlJ2JpQxo61lQ2TQ+WMnEgo4 BCo0XvwoR9to6pYFdC92Hf/Q2QcwodaAjnfdNAXyyrW6G8aWhBX9XiaukKXujtj47eCb ik35ke9P+Xjty7xV8Kzypuo3EXq6Z7+eF19pq5qObJCnT6NyedwKEIzqctAH8HDmCn/1 I91Kjf8DMAwUJ2AFyDXV+P9/sskGcw9BTNlEt2F5gsBshsUi1eQBRtZC/mfpC/mKLH5Z uMdG312/hqfHsO7vv/4taQ8EfTM6WDIZfTOxuNDJwHWq0E2azrKctyIaVhh9H4OSBBEx umSg== X-Gm-Message-State: AOAM532YUp8jQk/1v7X2GKGf1voP84JAZ0oWTRUnhyY052IyEu39KDYG EvFI9u7OT3CkdNOHJkgopnlEAz6e00M= X-Google-Smtp-Source: ABdhPJyG/P9x8yo7fJ4Qplg7ghZ1KLbtwxPPOnG3uQ/yIg/6Dpk1zlgx8DH/x4nxrvnntVIJnlivBg== X-Received: by 2002:a5d:5709:: with SMTP id a9mr30513777wrv.707.1642623379252; Wed, 19 Jan 2022 12:16:19 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id l9sm764508wrs.106.2022.01.19.12.16.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jan 2022 12:16:18 -0800 (PST) Message-ID: <0b21fa5bc96d2538439a4ae7cf1cb85f5bea1e45.camel@gmail.com> Subject: Re: [bug#52946] [PATCH 0/2] Update Audacity to 3.1.3. From: Liliana Marie Prikler To: Leo Famulari Date: Wed, 19 Jan 2022 21:16:16 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52946-done Cc: 52946-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 04.01.2022 um 16:04 -0500 schrieb Leo Famulari: > On Tue, Jan 04, 2022 at 09:43:37PM +0100, Liliana Marie Prikler > wrote: > > I'd like to avoid it if possible.  Audacity uses it to determine > > whether a particular file system is FAT so as to determine its > > limitations -- I'm sure there are better ways of doing that. > > I agree that it would be nice to avoid it. On the other hand, if > that's how Audacity made their program work, we should accept it > unless it causes serious problems. I don't think that feature > development of packaged programs should happen in the distro. > > I don't know what problems it could cause, just that it's unusual. A > few packages do refer directly to "kernel-headers" from the build > environment. Since it is just one header which is unlikely to change between kernel versions, I now pushed this as-is. Thanks From unknown Fri Jun 20 18:21:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 17 Feb 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator