GNU bug report logs - #52925
NonGNU ELPA: GitHub badge incorrectly displayed

Previous Next

To reply to this bug, email your comments to 52925 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: NonGNU ELPA: GitHub badge incorrectly displayed
Date: Fri, 31 Dec 2021 21:20:01 -0500

[Message part 1 (text/plain, inline)]

Severity: minor

On this page:

    http://elpa.nongnu.org/nongnu/webpaste.html

Above the headline "1 Webpaste.el – Paste text to pastebin-like
services", there are two squares where we should show a badge, but
currently don't.

See this screenshot:

[Message part 2 (text/plain, attachment)]

[screenshot.png (image/png, attachment)]

Message #8 received at 52925 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52925 <at> debbugs.gnu.org
Subject: Re: bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed
Date: Sat, 01 Jan 2022 09:32:53 +0100

On Dez 31 2021, Stefan Kangas wrote:

> On this page:
>
>     http://elpa.nongnu.org/nongnu/webpaste.html
>
> Above the headline "1 Webpaste.el – Paste text to pastebin-like
> services", there are two squares where we should show a badge, but
> currently don't.

WFM with eww.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #11 received at 52925 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52925 <at> debbugs.gnu.org
Subject: Re: bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed
Date: Sat, 15 Jan 2022 10:25:57 +0100

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefan <at> marxist.se> writes:

> Severity: minor
>
> On this page:
>
>     http://elpa.nongnu.org/nongnu/webpaste.html
>
> Above the headline "1 Webpaste.el – Paste text to pastebin-like
> services", there are two squares where we should show a badge, but
> currently don't.

Like Andreas said, this works in eww, but I also get an error in
Firefox.  But a different one than you're getting:

[Message part 2 (image/png, inline)]

[Message part 3 (text/plain, inline)]

Which is...  very strange.  Loading the SVG directly does display
correctly in Firefox:

https://s3.amazonaws.com/assets.coveralls.io/badges/coveralls_unknown.svg

Could it somehow be something with same origin policy that makes Firefox
refuse to read the SVGs?  (I haven't actually examined the web page or
the SVGs.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 52925 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52925 <at> debbugs.gnu.org
Subject: Re: bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed
Date: Sat, 15 Jan 2022 02:13:51 -0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Could it somehow be something with same origin policy that makes Firefox
> refuse to read the SVGs?  (I haven't actually examined the web page or
> the SVGs.)

My guess is that Firefox is more conscientious than eww with sending
some of the correct headers (referrer, etc.) to let Github now that we
are getting this file to render it on a different page.  And then Github
blocks it.

But I don't know.

Message #17 received at 52925 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52925 <at> debbugs.gnu.org
Subject: Re: bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed
Date: Sat, 15 Jan 2022 11:17:48 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> My guess is that Firefox is more conscientious than eww with sending
> some of the correct headers (referrer, etc.) to let Github now that we
> are getting this file to render it on a different page.  And then Github
> blocks it.

Ah, yes, that's possible.  If I remember correctly, eww/shr isn't
sending refe{r,rr}er at all when fetching images.  Which should be
fixed, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 52925 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 52925 <at> debbugs.gnu.org
Subject: Re: bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed
Date: Sat, 15 Jan 2022 02:44:55 -0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> If I remember correctly, eww/shr isn't sending refe{r,rr}er at all
> when fetching images.  Which should be fixed, I guess.

There are some privacy and security implications to consider, so the fix
might not be trivial.  FWIW, I wouldn't spend time on it without a clear
use case in mind.

Message #23 received at 52925 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52925 <at> debbugs.gnu.org
Subject: Re: bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed
Date: Sat, 15 Jan 2022 12:02:24 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> There are some privacy and security implications to consider, so the fix
> might not be trivial.  FWIW, I wouldn't spend time on it without a clear
> use case in mind.

I think eww does send over referrer when doing non-image stuff, so it's
a bit inconsistent.  But this should be redone more generally -- for
privacy reasons, eww shouldn't send referrer on cross-site requests, for
instance.  And there should be a way to customise this.

I've been meaning to fix this, but I keep forgetting.  I'll open a new
bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.