From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 31 04:35:14 2021 Received: (at submit) by debbugs.gnu.org; 31 Dec 2021 09:35:14 +0000 Received: from localhost ([127.0.0.1]:55099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3EJe-0005BG-2P for submit@debbugs.gnu.org; Fri, 31 Dec 2021 04:35:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:51958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3EJc-0005B6-9a for submit@debbugs.gnu.org; Fri, 31 Dec 2021 04:35:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3EJc-0002qc-23 for bug-guix@gnu.org; Fri, 31 Dec 2021 04:35:12 -0500 Received: from mout02.posteo.de ([185.67.36.66]:49437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3EJZ-0001N0-92 for bug-guix@gnu.org; Fri, 31 Dec 2021 04:35:11 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E528F240101 for ; Fri, 31 Dec 2021 10:35:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1640943304; bh=/08rg3qOlnFhJz4Z1fE+g3mGm9zcD2VPKrjfmu+mKDc=; h=From:To:Subject:Date:From; b=rxg6L+XRi/xUz4M8clSbjs50/bfjFhoeRnmYQbRk5Fb8sKTuq++w4zRjMwpZ59sXd rNrY9MoOADdIKTHqDuCFgYtQ+BWO2IK8SUaV+eQY2DVWyG6CtXIhxix5U2h4olH9Hm XP57CYCuEJhookixmzdkfUFGX+bdM+j5CWAd7zRWvUW0Tm7inzk+flErCw6Lkf7L1g 3DcEnCPnE3IZI/L2ufbAp/1GFvgSZWioevmLHrQb0NenAlv8kI6wn9CCSm9WInCIJi GD3gmdWsJKTAueenc16J3ARoMhImSBjvF6h31BE3ZpHdo/8YNWzn7S8o10aWxMrysa f5qrQtk1YSfGw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JQKk01hXLz6tmF for ; Fri, 31 Dec 2021 10:35:03 +0100 (CET) From: Guillaume Le Vaillant To: bug-guix@gnu.org Subject: 0ad only builds fine with a specific version of mozjs Date: Fri, 31 Dec 2021 09:17:25 +0000 Message-ID: <87y241azi0.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=185.67.36.66; envelope-from=glv@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The 0ad package checks the version of mozjs and throws an error if it is not exactly the version it expects. This check is done in "source/scriptinterface/ScriptTypes.h" and it currently requires version 78.6 of mozjs. As Guix has mozjs 78.15 instead, 0ad fails to build. Patching "ScriptTypes.h" to remove the check and compile with mozjs 78.15 doesn't work, the build phase fails with: =2D-8<---------------cut here---------------start------------->8--- ../../../source/scriptinterface/ScriptContext.cpp: In member function =E2= =80=98void ScriptContext::UnRegisterRealm(JS::Realm*)=E2=80=99: ../../../source/scriptinterface/ScriptContext.cpp:146:39: error: cannot con= vert =E2=80=98JS::Zone*=E2=80=99 to =E2=80=98JSContext*=E2=80=99 146 | JS::PrepareZoneForGC(js::GetRealmZone(realm)); | ~~~~~~~~~~~~~~~~^~~~~~~ | | | JS::Zone* In file included from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/Value.h:25, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/CallArgs.h:74, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/jsapi.h:31, from ../../../source/scriptinterface/ScriptTypes.h:63, from ../../../source/scriptinterface/ScriptContext.h:21, from ../../../source/scriptinterface/ScriptContext.cpp:20: /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.15.0/include/mozjs-78/= js/GCAPI.h:539:55: note: initializing argument 1 of =E2=80=98void JS::Pre= pareZoneForGC(JSContext*, JS::Zone*)=E2=80=99 539 | extern JS_PUBLIC_API void PrepareZoneForGC(JSContext* cx, Zone* zon= e); | ~~~~~~~~~~~^~ In file included from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/TraceKind.h:12, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/jspubtd.h:18, from ../../../source/scriptinterface/ScriptTypes.h:62, from ../../../source/scriptinterface/ScriptContext.h:21, from ../../../source/scriptinterface/ScriptContext.cpp:20: /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.15.0/include/mozjs-78/= js/TypeDecls.h:55:21: note: class type =E2=80=98JS::Zone=E2=80=99 is incomp= lete 55 | class JS_PUBLIC_API Zone; | ^~~~ ../../../source/scriptinterface/ScriptContext.cpp: In member function =E2= =80=98void ScriptContext::PrepareZonesForIncrementalGC() const=E2=80=99: ../../../source/scriptinterface/ScriptContext.cpp:264:40: error: cannot con= vert =E2=80=98JS::Zone*=E2=80=99 to =E2=80=98JSContext*=E2=80=99 264 | JS::PrepareZoneForGC(js::GetRealmZone(realm)); | ~~~~~~~~~~~~~~~~^~~~~~~ | | | JS::Zone* In file included from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/Value.h:25, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/CallArgs.h:74, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/jsapi.h:31, from ../../../source/scriptinterface/ScriptTypes.h:63, from ../../../source/scriptinterface/ScriptContext.h:21, from ../../../source/scriptinterface/ScriptContext.cpp:20: /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.15.0/include/mozjs-78/= js/GCAPI.h:539:55: note: initializing argument 1 of =E2=80=98void JS::Pre= pareZoneForGC(JSContext*, JS::Zone*)=E2=80=99 539 | extern JS_PUBLIC_API void PrepareZoneForGC(JSContext* cx, Zone* zon= e); | ~~~~~~~~~~~^~ In file included from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/js/TraceKind.h:12, from /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.= 15.0/include/mozjs-78/jspubtd.h:18, from ../../../source/scriptinterface/ScriptTypes.h:62, from ../../../source/scriptinterface/ScriptContext.h:21, from ../../../source/scriptinterface/ScriptContext.cpp:20: /gnu/store/gzsa3jrlhgcr3mr6i170lhgfsxsmpcps-mozjs-78.15.0/include/mozjs-78/= js/TypeDecls.h:55:21: note: class type =E2=80=98JS::Zone=E2=80=99 is incomp= lete 55 | class JS_PUBLIC_API Zone; | ^~~~ make[1]: *** [scriptinterface.make:146: obj/scriptinterface_Release/ScriptC= ontext.o] Error 1 =2D-8<---------------cut here---------------end--------------->8--- What would be the best way to fix this? - keep a mozjs-78.6 package around just for 0ad - patch 0ad to fix the compatibility issues with mozjs 78.15 - use the mozjs version bundled in the 0ad sources WDYT? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYc7Oxw8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j/KBwD/QRG086d0GsQcaPtmF9XknAi63U5m3nnrocJw 9X8NaqIA+wb0gAz34Lg1aj44VJHxGo+NEADlnRoRQRH1bvIIXxB0 =qyc9 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 01 14:14:31 2022 Received: (at 52913) by debbugs.gnu.org; 1 Jan 2022 19:14:31 +0000 Received: from localhost ([127.0.0.1]:59334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3jpn-0000pm-GD for submit@debbugs.gnu.org; Sat, 01 Jan 2022 14:14:31 -0500 Received: from mail-pl1-f170.google.com ([209.85.214.170]:44906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3jpi-0000pU-6y for 52913@debbugs.gnu.org; Sat, 01 Jan 2022 14:14:30 -0500 Received: by mail-pl1-f170.google.com with SMTP id h1so18970105pls.11 for <52913@debbugs.gnu.org>; Sat, 01 Jan 2022 11:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=20+PtbyMhB4T0pyHbeaSdWO8jdS8D3Y9LhSKawNvR+M=; b=PPaNpy7NBtsoLfgZWGZU+wGp3tJ8u4qTp1gRsHokuq9O3gSMxbfu+tTdDWhVew9A/C p0Zx349AYHsJuJw7q5gC5AW3/blOr7houwVJ8gFmRHgnyi3xGC6MisVovFKk40NR+TFg 2Gf3dSPgap3afCDhizoX17fIakoyBxM+1GBcTRdyY0flwgDxmC20kbH4DRPwsjdO6n3P j4mo06IKMWvFbcxf1xE3/w2GQI2HYJh4eNZQ45gzKPzZDAwpzpAEBsGJP/abXJ+rhQTm FoM8SHo6ZV7Vb23f32tRtXOktZA6d7QUqO4PCC3EH7xqgD0RPCGngHB4mntArvPCWUUS zV4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:subject:from:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=20+PtbyMhB4T0pyHbeaSdWO8jdS8D3Y9LhSKawNvR+M=; b=jyRYAfRqPvreXtMgVr273T9yb8vPSBA2Bl4WbZsWf0e0zGy+WJtN9Ab6zVw31jE7f/ kv5z2zOTF7xgrUG5J7/RklCT3SsmLUvYHae9dzkJ6vQcXiw+0I6E3A00agzr9RKCQBwc /157Ao6YD4O1v1ynHCaLUhNNrtwLj7SEY/msKtD87xD6zI7ZxNftA8ko1Dj8dUjXbb73 Qw9O0y4weeRSmytQoPd2N4M0CS+QPViqrlcJ7R2dwG7j6Qk6XPD0OTdRj/nW+DzCp13g c1p1uCr5xQp1OStXvRNIGd9KbFovfiwTY4X9zEv6zgQWUbjT3tqR3HQkexdIePFUm3wP 3zWg== X-Gm-Message-State: AOAM531meR3h/8DkIxShzET3QZ6Tdo1QYANBOjRw2STCn3JP74uCHvfc pRtMZOnJAeedTxxYu8HlhOzVoGjZs7E= X-Google-Smtp-Source: ABdhPJwODaGi63XMYyGVs/X01b5j5dKNDjRZgV4L5H9M2s1JpFPcEoxWZAj7Bthe0bN0DQtojr/KIQ== X-Received: by 2002:a17:902:7e82:b0:149:9714:699e with SMTP id z2-20020a1709027e8200b001499714699emr19306038pla.66.1641064460097; Sat, 01 Jan 2022 11:14:20 -0800 (PST) Received: from [192.168.1.201] ([38.141.58.134]) by smtp.gmail.com with ESMTPSA id u11sm32285031pfi.10.2022.01.01.11.14.19 for <52913@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jan 2022 11:14:19 -0800 (PST) To: 52913@debbugs.gnu.org Subject: 0ad only builds fine with a specific version of mozjs From: Jesse Gibbons Message-ID: <5491e57c-ae88-aa24-256b-c7d6f038cba2@gmail.com> Date: Sat, 1 Jan 2022 12:14:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.15.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 52913 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) > What would be the best way to fix this? >  - keep a mozjs-78.6 package around just for 0ad >  - patch 0ad to fix the compatibility issues with mozjs 78.15 >  - use the mozjs version bundled in the 0ad sources > > WDYT? Keeping mozjs-78.6 just for 0ad will probably make things harder later on because it's another package to maintain and users likely won't be able install 0ad and icecat/icedove in the same profile. I suppose users can always use `-P /path/to/0ad-profile` when installing or updating 0ad. I'm thinking using the bundled mozjs is perhaps the best option, though it isn't particularly guixy, because I expect most users would want the 0ad packaged by guix to be compatible with other 0ad builds in the wild. However, I think it would be useful to fix compatibility issues with mozjs 78.15 so interested contributors can tell upstream if guix's current minor version breaks the expected deterministic behaviors described in the error. Another option would be to keep mozjs-78.6 for 0ad and patch it so interested users can test updated mozjs using `--with-input=mozjs=mozjs`. It isn't very difficult to modify a list of packages to use a specific mozjs in a manifest or home configuration, right? Though I guess interested contributors could always add the patch themselves just as easily... Anyway, that's my two cents. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 01 15:27:23 2022 Received: (at 52913) by debbugs.gnu.org; 1 Jan 2022 20:27:23 +0000 Received: from localhost ([127.0.0.1]:59421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3kyI-0002oF-Tg for submit@debbugs.gnu.org; Sat, 01 Jan 2022 15:27:23 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3kyC-0002nx-Sa for 52913@debbugs.gnu.org; Sat, 01 Jan 2022 15:27:21 -0500 Received: by mail-wr1-f66.google.com with SMTP id d9so62050286wrb.0 for <52913@debbugs.gnu.org>; Sat, 01 Jan 2022 12:27:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=XWPG8/Po4L4z4a7zVvIASFVDO97OwurNB0LJmtI59P4=; b=artUKbu9PLul1uqSafFwwK+wr7H/+ws8SLQ4NfHdwFKR9wIzUkWbwG0Ytb/ZTvwriK 4Ll7jO+wRLHddL/WJBAe149LyKjmqbmIFDX+U1IOaP/irxQ9dTuAfNAjbopVlhI/mqFh twWn5mdsY3g9VIRsBuNPPmIWOhKpWuhaKuzBrQ2uvCWSrblrjDpTQmWx2bszk2gE9IvS 5rPu9ShKyK+iA/c+kKNtdzaF0k/DmEo33ZkkZCqtZd04yk29dnk7MTVhnDq6+uin6VZv u+4wwo55YacNbZweReHm2gsSRIHcnxVw8OSOpBvKiLGz4do9EgbEbqcDWoWUMjnk8Dn9 vEpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=XWPG8/Po4L4z4a7zVvIASFVDO97OwurNB0LJmtI59P4=; b=41UjRssKuKXp7GsMEZkwyynZrVsFt1bQGCTvtCD1xsww8v7aza7k7+UACeCRGzMuiD SVSrqj1bxJu3F/Wy6V80jGf+8zavfbVEG6nnNPXOabxtdawd2qES9L/eR2t8uhipXCrO NNAx6QZQVssCetdmKd6Z/mMwDNFLP7xMDySDEAO23GKGkrBhL7QG/ZrfHOGTnJsWhyrs nj9V3ts2c1f3Yv4XRPCGGNMG7omSsLPRIfiWXoOw7faqdQ/skqrljR/+/523fkBzcT3p 0OT36PGItsd7iLigyTpxTWpR5Qxb3OcWo0A3E8+t7CrVtyxsGZIYFktJuvAG4XYXvL/P qbEw== X-Gm-Message-State: AOAM531yjDALHRuulLDjLHJXVmbcXwi68tsBSLQlCDv0+NKuooV0+QRw /DPrD91KVwdW4nvp8PaF+AM= X-Google-Smtp-Source: ABdhPJwmB5I3k96HAtwDMg4IDk1hECDwPNlgwvMQspbufEf+lzMittd+NKXB7TetqpMvO2snjDqJEQ== X-Received: by 2002:a05:6000:120c:: with SMTP id e12mr33453935wrx.6.1641068830944; Sat, 01 Jan 2022 12:27:10 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id k31sm30176168wms.21.2022.01.01.12.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 12:27:10 -0800 (PST) Message-ID: Subject: Re: 0ad only builds fine with a specific version of mozjs From: Liliana Marie Prikler To: Jesse Gibbons , 52913@debbugs.gnu.org Date: Sat, 01 Jan 2022 21:27:09 +0100 In-Reply-To: <5491e57c-ae88-aa24-256b-c7d6f038cba2@gmail.com> References: <5491e57c-ae88-aa24-256b-c7d6f038cba2@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52913 Cc: Guillaume Le Vaillant X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Samstag, dem 01.01.2022 um 12:14 -0700 schrieb Jesse Gibbons: >  > What would be the best way to fix this? >  >  - keep a mozjs-78.6 package around just for 0ad >  >  - patch 0ad to fix the compatibility issues with mozjs 78.15 >  >  - use the mozjs version bundled in the 0ad sources >  > >  > WDYT? > > Keeping mozjs-78.6 just for 0ad will probably make things harder later > on because it's another package to maintain and users likely won't be > able install 0ad and icecat/icedove in the same profile. I suppose > users can always use `-P /path/to/0ad-profile` when installing or > updating 0ad. I don't think that would be a problem, since mozjs is a regular input. There ought to be no propagation conflicts between the two. > I'm thinking using the bundled mozjs is perhaps the best option, though > it isn't particularly guixy, because I expect most users would want the > 0ad packaged by guix to be compatible with other 0ad builds in the > wild. There is no benefit to using a bundled version over one packaged with Guix. > Another option would be to keep mozjs-78.6 for 0ad and patch it so > interested users can test updated mozjs using > `--with-input=mozjs=mozjs`. It isn't very difficult to modify a list of > packages to use a specific mozjs in a manifest or home configuration, > right? Though I guess interested contributors could always add the > patch themselves just as easily... Contributors would probably work on top of their local checkouts anyway, so there's no concern here (other than increased store space for another mozjs both locally for users and in CI). @Guillaume: From what I can gather from the build error, it appears as though the calling convention changed to require an additional parameter. I've tracked down the relevant commit [1] and bug [2]. Now obviously doing such a thing violates SemVer, so if rewriting 0ad with this and other changes in mind is not an option, I think having a hidden package for 0ad might be the lesser evil. Cheers [1] https://searchfox.org/mozilla-central/commit/a3c605929b16303e8a52ae9d99d5fe6769e8bf09 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1681268 From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 02 08:03:18 2022 Received: (at 52913-done) by debbugs.gnu.org; 2 Jan 2022 13:03:18 +0000 Received: from localhost ([127.0.0.1]:60044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n40Vv-00026p-15 for submit@debbugs.gnu.org; Sun, 02 Jan 2022 08:03:18 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n40Vs-00026I-RP for 52913-done@debbugs.gnu.org; Sun, 02 Jan 2022 08:03:05 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id A2F57240027 for <52913-done@debbugs.gnu.org>; Sun, 2 Jan 2022 14:02:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1641128578; bh=l+FMW3tNR117A9a22B0oEgZOOxmwOrFmO93P4cHQnOw=; h=From:To:Cc:Subject:Date:From; b=h9YGiTGavOuqik0eSLUjR5z9UYKWxrrHzRdZo+tuBiqf54ZRHdvRu7am8sPHl/g63 3Xof7Y8cAHNxCj5PiPXgUqXYDCA4VDxQGQm9rcaqrnqcT2q3wIn0ohB2mpGKChsQst vxophq21YuDvz9vV9GXwfMFk6qs2JLU+cvOrQdC+mg5tOLxzVyGq9lUTtVPncC3IZ1 beX+jAjT1bSry5JB6ytVt6VXXOJD5YS0oiiJrICRdO2AyLnnEFgshsNH5qF8WswXmK gbxocrPnOzbGsZOfDwrcmTKdvyMCoS+eLNEIqecUddSzqCrN0FpK0EzA4Z7LgCaTXL v++khSOCLYi5g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JRfDx2W3Cz6tn3; Sun, 2 Jan 2022 14:02:56 +0100 (CET) References: <5491e57c-ae88-aa24-256b-c7d6f038cba2@gmail.com> From: Guillaume Le Vaillant To: Liliana Marie Prikler Subject: Re: 0ad only builds fine with a specific version of mozjs Date: Sun, 02 Jan 2022 12:56:25 +0000 In-reply-to: Message-ID: <87h7amwarj.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52913-done Cc: Jesse Gibbons , 52913-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Liliana Marie Prikler skribis: > @Guillaume: From what I can gather from the build error, it appears as > though the calling convention changed to require an additional > parameter. I've tracked down the relevant commit [1] and bug [2]. > > Now obviously doing such a thing violates SemVer, so if rewriting 0ad > with this and other changes in mind is not an option, I think having a > hidden package for 0ad might be the lesser evil. > > Cheers > > [1] > https://searchfox.org/mozilla-central/commit/a3c605929b16303e8a52ae9d99d5fe6769e8bf09 > [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1681268 Thanks for the pointers. I added a phase to fix the compatibility issue with mozjs-78.15, and pushed as fea60a2fff443b9c172ed28bd37361e34e064f13. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYdGigA8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j+hcQD+IcTPz6fz0lGYV164v3zQdgONsnQASOuq/YUX d9Tr2qcA/2A1ktz4tmXiDnROSeM/ri9Gm8Lv542PqUuqKCDaXYOG =aoxs -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 04:11:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 31 Jan 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator