From unknown Sat Jun 21 10:38:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52881 <52881@debbugs.gnu.org> To: bug#52881 <52881@debbugs.gnu.org> Subject: Status: setting tab-line-separator to any value breaks clicking tabs with mouse Reply-To: bug#52881 <52881@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:38:49 +0000 retitle 52881 setting tab-line-separator to any value breaks clicking tabs = with mouse reassign 52881 emacs submitter 52881 Ben Sferrazza severity 52881 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 17:13:44 2021 Received: (at submit) by debbugs.gnu.org; 29 Dec 2021 22:13:44 +0000 Received: from localhost ([127.0.0.1]:50560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2hCa-0006e7-DO for submit@debbugs.gnu.org; Wed, 29 Dec 2021 17:13:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:60524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2h6v-0006Tw-Ns for submit@debbugs.gnu.org; Wed, 29 Dec 2021 17:08:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2h6v-0004AC-Kd for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 17:07:53 -0500 Received: from mail-dm6nam08on2131.outbound.protection.outlook.com ([40.107.102.131]:61088 helo=NAM04-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2h6t-00083f-JT for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 17:07:52 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nhb9/j1qRg54LBL2XvSjHrKIvkv9pKN0aNbJR1h3s7k9mFgpnVOuCPXVIPNi9UZ17UVgkoMWKymaYz/8sKvJ2G1Tudsc9aLA+iHnxtrmM2FrlbA9x3sU3oHx4AIe/kySPrr8ZFM1A+aC4r7z1E3ZJHgMEND5778/I0eqV8Iwr12WTTk3SSxWSiEdsY36CKLdebJx1Wl+XXk5Sxet5qmiEoA+m291fneeIN0hoQ+J2mjr28qxNd8MUYSQIvHyc2+G5ohJYhjTCrCWkppBN4n5+xoDtFqBNIbu1rCXOPCo+9t063S/+k2knMOMGqo2l2KQWP30pIZ6GFwxj4crdRFTMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mNLwDyoea61EwNd8VdXVqxG4Ja1vVQ54oRdqH4wdq7Y=; b=Qbcxm1GlYqKFyLK17WoDx3nreEWK56Gai3icPkt4Fcl+ZOtXBnoglIDv87AgRzd9hpytTnzt/1Dggiii1AVPAtj6mGAhb9KZo5j1NbGkyeIFSXTllzyheLxKfbZi+87Ds/tqZ9+enN1IlIt2JdhW52K/FuyDdzVBE4IaR/uyBoeDJwycHcKHLnStx4ZtTNbhmx1TNbab0kCBnzDCNYEqaKZQM7EuFQ/BJgAHqEi64uCcO0GeDok9+bEv42imNL6dtGV/9jrb72QmHZTmVN1/dg60yUAZK3KfD/4V2NvIVMo2aRFez41+2LGnwmVU7X+ttOHE8YuD207eMC+BmPgeLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aeonsemi.com; dmarc=pass action=none header.from=aeonsemi.com; dkim=pass header.d=aeonsemi.com; arc=none Received: from CO1PR19MB4984.namprd19.prod.outlook.com (2603:10b6:303:f5::12) by CO1PR19MB4999.namprd19.prod.outlook.com (2603:10b6:303:f0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.22; Wed, 29 Dec 2021 21:47:28 +0000 Received: from CO1PR19MB4984.namprd19.prod.outlook.com ([fe80::18a8:7cb4:73a2:7072]) by CO1PR19MB4984.namprd19.prod.outlook.com ([fe80::18a8:7cb4:73a2:7072%9]) with mapi id 15.20.4844.014; Wed, 29 Dec 2021 21:47:27 +0000 From: Ben Sferrazza To: "bug-gnu-emacs@gnu.org" Subject: setting tab-line-separator to any value breaks clicking tabs with mouse Thread-Topic: setting tab-line-separator to any value breaks clicking tabs with mouse Thread-Index: Adf8/QgTpkm6SR8pTfmHXd3CfWAMog== Date: Wed, 29 Dec 2021 21:47:27 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aeonsemi.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 29c932ad-11a1-48fc-d6fa-08d9cb14ced5 x-ms-traffictypediagnostic: CO1PR19MB4999:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yMYzUEft4TvD1/nMSV842giFQTrJG7LBEfJbbcez7QvHJ02MnS2vJ8L5GxK/F/ZXl7AlZXbxgFqwTTvkZNezmYF6yKIGYafGQD/CKtL88LnWZOOPZ4TneMzG2njcG8cK3PQ71EtsQHEgCaSP1WnFie2f+bVMxsXSPODm90vcW+WhezusmSltFZEqLpLgXTq0fd6jpHAuydmfvYc7mrszYa987JECZ8YpjZCUolq4yaQBKI0Cq882XJZMgK9OtrcU7BUNNMe0HlOfywEoyE9ey7qU8HY796wYDm5O74ZFsJuEU/U3ZSMoGgv7MPawb4Rz99wcjryercHJuqIumAzUbH1R+tt+aWeL768SjThi9WSSLOeqZO8/bSpb7V1ZYQsH6qHvKarL5kE4dYo1HU2M39PfzCpXZnmunqKhfsH56zeMv0bkf7BT5T8BwfBrZeK9Fhv3dDLpmsMow+QjVocgJf0JIlOVVei5xwJSX/5c9NWprcfs1BeuvTERKowuOgON/YJ43DUFqlqRjjxSWVhgeJSKv1mB122WyPaX+Cj26KGuXKZheh0QbcVrijXubkXHCwghX9Ef4vEl9+oIY86g5SktDW1Jd0mpT2DSPby1z3pZJRQiQxKRTLeyjK5U24grRRncXHLNWCP3pbTyTS7Gu3lBLSUHpdVDZ9ZKpc4vm9IUfkGApxsrAFV/vUsT3wOvWnegcr3wi3+6B9kt7NMPBA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR19MB4984.namprd19.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39830400003)(136003)(346002)(396003)(66556008)(64756008)(66476007)(186003)(86362001)(52536014)(8936002)(6506007)(508600001)(44832011)(71200400001)(6916009)(7696005)(66446008)(122000001)(38070700005)(26005)(316002)(38100700002)(55016003)(33656002)(8676002)(558084003)(2906002)(9686003)(76116006)(66946007)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?di0Mw+ZreCiv6sSafQ1ZvoJbIWq4bI4S5bgYQXfYf+ZOQhksaRtZ9wn5G2rl?= =?us-ascii?Q?9rBBve0ksTZ6i6BrhqOFEK7iQvzs1Mo9VvE6TUjErYCvfROmuvxh+ZKz9z/E?= =?us-ascii?Q?bDWfzoFheymPgz03906xnfBanQsVM77FvqkyAB9xZ0ChRaKHzDR8inH3zVwR?= =?us-ascii?Q?Hut1HsjfWd+uCwMC3qsJRmi+tgOzxY4nmC68czgTtqY43Y2Gxv3TFBnTM1pA?= =?us-ascii?Q?pMqxNq4yvu+GT2r7NbDZCj8i4ykWm0sGbrdpVEJIAfe60QPeFrAUBUIbhKsB?= =?us-ascii?Q?rguQd8Vh9Pfgj1dH0X7d2G/Y65ql6zyHobXeTVE0SKQU5t8cirNGxf+8S1OR?= =?us-ascii?Q?00fBOhQjXRGW/4pL7slOquc839gnWdMjIGVOT6zj0dQ3D3Y4Mt+xV4Q74fvt?= =?us-ascii?Q?KEW3d8TTI8QVgbqqBUZdZh/FF2ZFHUB4P14DSSnsvgKHR7f+cKDUEdx95ZdD?= =?us-ascii?Q?fuK4QHY57vepqTKJ8aPXWMqHMamQSX0hwx/YnOG82VhnUKfRxhXIlqblGmJd?= =?us-ascii?Q?MMppKKVEs0RvEQRdGl0FMK6dTx7IyCS4Xm2udy+ebxyZQlsGNnMTSRxqqq94?= =?us-ascii?Q?Yf4rR2fs99q9JKwPb3LG/pnj74AyIj7uy02DH2UWrULUW7aZQEPqvJA8hsqB?= =?us-ascii?Q?CrnNjLxmOz2ZAQ/qD6NtYEQ6lCG68V5FXKOMgZd/nNnCGgYJ/UiqYlSns5cE?= =?us-ascii?Q?TNcZXW9F4ASwzpTfTUxiNm+L4UVGuEIS9bKHYWEc5CFQA62OLwOyoOGf5m9I?= =?us-ascii?Q?dSi8F45FwgmQcfch4bJfSoNx2wdAk9JXazmSr3y5dF/b38KOO43HT9/5OyuI?= =?us-ascii?Q?9D33rHaiq5dgJNUS4OMcwJofzEKPrwBL2tpzoDohLP0rwXxsB1LG8rGcl4Ef?= =?us-ascii?Q?b3qtJIE4a50F49rxwJYEHQRfB+wa21Fj5QVH64Fc9C1iBb9avdaZWfrhyeRU?= =?us-ascii?Q?uT45viC27G526+pyLKKW1lR4W8mt0qFz/rVuRjBKXVx6QQ6O7IUEnDoHq6nz?= =?us-ascii?Q?Xz77bKDPAJYAlvPtcFuiSgPJ510TNqxZC/z8Lxa3OmYUmAL+DETB0AM3h8wJ?= =?us-ascii?Q?8I2tbh/qmK2vbawIzXDvwxvxA/kFfNhc9fHl8ICQk1YjipqKhuct/vla7A86?= =?us-ascii?Q?00H0ywMB4UZ/IEDtwPmvNlNcmBnmiTIItynIJypxmYm3MPR84qEOuK5ImJHW?= =?us-ascii?Q?h4d4qRxNUhjwtHcwZqm/MSWcFSLdzGQ3px0clmsSXZjJEy+TzLmHwN0WNvL3?= =?us-ascii?Q?MexYLILAq9sysBeJvvm5RUhYYZedtR6NfyvfbUKOhZDb72mRfAZpFlQChkBn?= =?us-ascii?Q?oOlKHjWHFP36LS0PAv7acRmyPPoHlevJBRF3rTojAkZeEShavB7vgegqp2VI?= =?us-ascii?Q?C63VUW3CESq3zgIS/WfMjAx/tzUu06dfEMQlcyGsMTA3sQHQYldPACxpEKBU?= =?us-ascii?Q?ZzmDG5ROtv8jaEsqlq7Ye1fvyAvWM72XHaDL8+O5gDC+37kWUp1kLTS3NLmm?= =?us-ascii?Q?uSuBwUKjBaf+P20lmYuZEXQeq45xSLcfxWgkKH9nCwzR/goGqkC2/hGrhA9l?= =?us-ascii?Q?EUej+RSTdpTc0SiolJeSLPIe2R2lqR1RLwunUOxP3mBFixNdArHLKXX66WtA?= =?us-ascii?Q?KA=3D=3D?= Content-Type: multipart/alternative; boundary="_000_CO1PR19MB498434CB237DCE18B9763C5F95449CO1PR19MB4984namp_" MIME-Version: 1.0 X-OriginatorOrg: aeonsemi.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR19MB4984.namprd19.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29c932ad-11a1-48fc-d6fa-08d9cb14ced5 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2021 21:47:27.8916 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9c152b5-484f-4354-abbf-32c59cde3923 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6JZlIAIMo/uv3dsGm7M3p8az+Rnzi8dBbYFbwymLSmasij+KPE03P4hs1AT8sbnUlznzHcblF6pJe1BIVmGjxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR19MB4999 Received-SPF: pass client-ip=40.107.102.131; envelope-from=ben.sferrazza@aeonsemi.com; helo=NAM04-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: 0 X-Spam_score: -0.0 X-Spam_bar: / X-Spam_report: (-0.0 / 5.0 requ) HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 29 Dec 2021 17:13:43 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --_000_CO1PR19MB498434CB237DCE18B9763C5F95449CO1PR19MB4984namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This is using Emacs 27.2 on a CentOS8 machine at work. I use Emacs exclusiv= ely with -nw in a terminal with mouse support enabled. Using something like (setq tab-line-separator " | ") breaks the ability to click on a tab to select it. Leaving it at the defaul= t value avoids the bug. Thanks, Ben --_000_CO1PR19MB498434CB237DCE18B9763C5F95449CO1PR19MB4984namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

This is using Emacs 27.2 on a CentOS8 machine at wor= k. I use Emacs exclusively with -nw in a terminal with mouse support enable= d.

 

Using something like

 

(setq tab-line-separator “ | “)

 

breaks the ability to click on a tab to select it. L= eaving it at the default value avoids the bug.

 

Thanks,

Ben

--_000_CO1PR19MB498434CB237DCE18B9763C5F95449CO1PR19MB4984namp_-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 03:10:17 2021 Received: (at 52881) by debbugs.gnu.org; 30 Dec 2021 08:10:17 +0000 Received: from localhost ([127.0.0.1]:51302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2qVt-0001XX-Dm for submit@debbugs.gnu.org; Thu, 30 Dec 2021 03:10:17 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2qVr-0001X6-27 for 52881@debbugs.gnu.org; Thu, 30 Dec 2021 03:10:15 -0500 Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 723CCE0005; Thu, 30 Dec 2021 08:10:06 +0000 (UTC) From: Juri Linkov To: Ben Sferrazza Subject: Re: bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse Organization: LINKOV.NET References: Date: Thu, 30 Dec 2021 10:05:24 +0200 In-Reply-To: (Ben Sferrazza's message of "Wed, 29 Dec 2021 21:47:27 +0000") Message-ID: <868rw28qm3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52881 Cc: 52881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain > This is using Emacs 27.2 on a CentOS8 machine at work. I use Emacs > exclusively with -nw in a terminal with mouse support enabled. > > Using something like > > (setq tab-line-separator " | ") > > breaks the ability to click on a tab to select it. Leaving it at the > default value avoids the bug. Sorry, tab-line had hard-coded assumption on separators no longer than 1 character wide. Eli, is it ok to push this patch to the release branch to support longer separators: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=tab-line-separator.patch diff --git a/lisp/tab-line.el b/lisp/tab-line.el index af0647acf7..5eae2eb7c4 100644 --- a/lisp/tab-line.el +++ b/lisp/tab-line.el @@ -636,7 +638,10 @@ tab-line-auto-hscroll (not (integerp hscroll))) (let ((selected (seq-position strings 'selected (lambda (str prop) - (get-pos-property 1 prop str))))) + (or (get-pos-property 0 prop str) + (and (next-single-property-change 0 prop str) + (get-pos-property (next-single-property-change 0 prop str) + prop str))))))) (cond ((null selected) ;; Do nothing if no tab is selected @@ -656,7 +661,11 @@ tab-line-auto-hscroll (new-hscroll (when tab-prop (seq-position strings tab-prop (lambda (str tab) - (eq (get-pos-property 1 'tab str) tab)))))) + (eq (or (get-pos-property 0 'tab str) + (and (next-single-property-change 0 'tab str) + (get-pos-property (next-single-property-change 0 'tab str) + 'tab str))) + tab)))))) (when new-hscroll (setq hscroll (float new-hscroll)) (set-window-parameter nil 'tab-line-hscroll hscroll))) @@ -683,7 +692,11 @@ tab-line-auto-hscroll (new-hscroll (when tab-prop (seq-position strings tab-prop (lambda (str tab) - (eq (get-pos-property 1 'tab str) tab)))))) + (eq (or (get-pos-property 0 'tab str) + (and (next-single-property-change 0 'tab str) + (get-pos-property (next-single-property-change 0 'tab str) + 'tab str))) + tab)))))) (when new-hscroll (setq hscroll (float new-hscroll)) (set-window-parameter nil 'tab-line-hscroll hscroll))))))))) @@ -742,7 +755,10 @@ tab-line-select-tab using the `previous-buffer' command." (interactive "e") (let* ((posnp (event-start event)) - (tab (get-pos-property 1 'tab (car (posn-string posnp)))) + (tab (or (get-pos-property 0 'tab (car (posn-string posnp))) + (and (next-single-property-change 0 'tab (car (posn-string posnp))) + (get-pos-property (next-single-property-change 0 'tab (car (posn-string posnp))) + 'tab (car (posn-string posnp)))))) (buffer (if (bufferp tab) tab (cdr (assq 'buffer tab))))) (if buffer (tab-line-select-tab-buffer buffer (posn-window posnp)) @@ -858,7 +874,10 @@ tab-line-close-tab (interactive (list last-nonmenu-event)) (let* ((posnp (and (listp event) (event-start event))) (window (and posnp (posn-window posnp))) - (tab (get-pos-property 1 'tab (car (posn-string posnp)))) + (tab (or (get-pos-property 0 'tab (car (posn-string posnp))) + (and (next-single-property-change 0 'tab (car (posn-string posnp))) + (get-pos-property (next-single-property-change 0 'tab (car (posn-string posnp))) + 'tab (car (posn-string posnp)))))) (buffer (if (bufferp tab) tab (cdr (assq 'buffer tab)))) (close-function (unless (bufferp tab) (cdr (assq 'close tab))))) (with-selected-window (or window (selected-window)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 03:44:12 2021 Received: (at 52881) by debbugs.gnu.org; 30 Dec 2021 08:44:12 +0000 Received: from localhost ([127.0.0.1]:51366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2r2h-0006zY-So for submit@debbugs.gnu.org; Thu, 30 Dec 2021 03:44:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2r2g-0006zF-L1 for 52881@debbugs.gnu.org; Thu, 30 Dec 2021 03:44:10 -0500 Received: from [2001:470:142:3::e] (port=38200 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2r2a-0003kf-80; Thu, 30 Dec 2021 03:44:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fIxbP1FjVuTdQhjAWBD2zZ5nRNRlAJRhEzfpguI7sv0=; b=gWMdIRFcPWlP sLjP7b8eLnkbH5wqQrOJrD5BjgNGDJkVD3hJHTex6hajl3s/raCGJj1ZcsJ0vvXD9vdWBrWauxbFL JrAHw4oPwJGBZyH+U6q0tx4POkgtY7xtgDSTHYcdR5X8tmm0mPfYSwc9aGWCyXPW+1mXAFbMRnmVl tKQdBdr2XbhFygw7mHs1Dpgfbfk6mHKcrCXpIy/LH8JcHjLBh3PrM9/XqqruSZq1h1WkXpyKYTxg+ clYOGTgWRbZLa2S/gviexzp9NvyFXeCytSm9I0u/WoHnC6KkgCL5z38xZEeMJeD4uItAncguTAkx7 0hTlUmurDXDFNnwQDI0b4Q==; Received: from [87.69.77.57] (port=4340 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2r2a-0007Zr-01; Thu, 30 Dec 2021 03:44:04 -0500 Date: Thu, 30 Dec 2021 10:44:08 +0200 Message-Id: <83pmpeiisn.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <868rw28qm3.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 30 Dec 2021 10:05:24 +0200) Subject: Re: bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse References: <868rw28qm3.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52881 Cc: 52881@debbugs.gnu.org, ben.sferrazza@aeonsemi.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Thu, 30 Dec 2021 10:05:24 +0200 > Cc: 52881@debbugs.gnu.org > > > This is using Emacs 27.2 on a CentOS8 machine at work. I use Emacs > > exclusively with -nw in a terminal with mouse support enabled. > > > > Using something like > > > > (setq tab-line-separator " | ") > > > > breaks the ability to click on a tab to select it. Leaving it at the > > default value avoids the bug. > > Sorry, tab-line had hard-coded assumption on separators > no longer than 1 character wide. > > Eli, is it ok to push this patch to the release branch > to support longer separators: Yes, but can you make it a bit cleaner? Like having a single function to do that, and also not calling next-single-property-change twice an a row? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 11:12:00 2021 Received: (at 52881) by debbugs.gnu.org; 30 Dec 2021 16:12:00 +0000 Received: from localhost ([127.0.0.1]:54281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2y23-00075w-Pq for submit@debbugs.gnu.org; Thu, 30 Dec 2021 11:11:59 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:58013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2y23-00075b-4T for 52881@debbugs.gnu.org; Thu, 30 Dec 2021 11:11:59 -0500 Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 40D56100003; Thu, 30 Dec 2021 16:11:51 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse Organization: LINKOV.NET References: <868rw28qm3.fsf@mail.linkov.net> <83pmpeiisn.fsf@gnu.org> Date: Thu, 30 Dec 2021 18:08:12 +0200 In-Reply-To: <83pmpeiisn.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 30 Dec 2021 10:44:08 +0200") Message-ID: <86v8z6t78i.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52881 Cc: 52881@debbugs.gnu.org, ben.sferrazza@aeonsemi.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Eli, is it ok to push this patch to the release branch >> to support longer separators: > > Yes, but can you make it a bit cleaner? Like having a single function > to do that, and also not calling next-single-property-change twice an > a row? I could optimize this, but I wonder why there is no simple function to find a text property and its first value in the string? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 11:43:59 2021 Received: (at 52881) by debbugs.gnu.org; 30 Dec 2021 16:43:59 +0000 Received: from localhost ([127.0.0.1]:54293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2yX1-0008Jz-JE for submit@debbugs.gnu.org; Thu, 30 Dec 2021 11:43:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2yWz-0008Jd-LS for 52881@debbugs.gnu.org; Thu, 30 Dec 2021 11:43:58 -0500 Received: from [2001:470:142:3::e] (port=48112 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2yWt-0006Gd-SS; Thu, 30 Dec 2021 11:43:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=46L4ZRLUvVqpJHhy/zmlV3VcVcvjxgFbNc53hMeodB8=; b=cW3KShYr1N79 ygpR5S+TVqG1uNvmynhxP51TXz7fXxO3v9UBbFX0w5IrxNAgH872FvUj9uvq4m19+naoBoG2JtUAY 69xehNba67Scdrpulb6BMG4EA3wVPhel+/xWcuJhYE9axlMprG0PwWII3tTqfaep4f3uWbAtO9fUQ 9CjWjaqNMCFuoK5lTlhlU+XvadX3K2yiYWd+0aFbwHc60M3bb0sKN2LR6mqndjwZ3jIRM1qjX5tVD Uob9GJC/RkEUOROKoX0ifIrRX0BOObCQq7fafeOG9dcFwaZQzNJLbZeNKA5qr6WLpoMZrdIPPnYYl 7Ubr2dNZMjKkQViPvMG+lw==; Received: from [87.69.77.57] (port=2143 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2yWt-0003D2-PL; Thu, 30 Dec 2021 11:43:52 -0500 Date: Thu, 30 Dec 2021 18:43:57 +0200 Message-Id: <837dbmhwky.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86v8z6t78i.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 30 Dec 2021 18:08:12 +0200) Subject: Re: bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse References: <868rw28qm3.fsf@mail.linkov.net> <83pmpeiisn.fsf@gnu.org> <86v8z6t78i.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52881 Cc: 52881@debbugs.gnu.org, ben.sferrazza@aeonsemi.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: ben.sferrazza@aeonsemi.com, 52881@debbugs.gnu.org > Date: Thu, 30 Dec 2021 18:08:12 +0200 > > >> Eli, is it ok to push this patch to the release branch > >> to support longer separators: > > > > Yes, but can you make it a bit cleaner? Like having a single function > > to do that, and also not calling next-single-property-change twice an > > a row? > > I could optimize this, but I wonder why there is no simple function > to find a text property and its first value in the string? I don't know. We could add something like that, but that would not be for the release branch. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 31 04:22:09 2021 Received: (at 52881) by debbugs.gnu.org; 31 Dec 2021 09:22:09 +0000 Received: from localhost ([127.0.0.1]:55071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3E6y-0002Wg-VF for submit@debbugs.gnu.org; Fri, 31 Dec 2021 04:22:09 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:40073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3E6x-0002W6-O5; Fri, 31 Dec 2021 04:22:07 -0500 Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id CC35D24000B; Fri, 31 Dec 2021 09:21:59 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse Organization: LINKOV.NET References: <868rw28qm3.fsf@mail.linkov.net> <83pmpeiisn.fsf@gnu.org> <86v8z6t78i.fsf@mail.linkov.net> <837dbmhwky.fsf@gnu.org> Date: Fri, 31 Dec 2021 11:21:22 +0200 In-Reply-To: <837dbmhwky.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 30 Dec 2021 18:43:57 +0200") Message-ID: <86k0flf7u5.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52881 Cc: 52881@debbugs.gnu.org, ben.sferrazza@aeonsemi.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 52881 28.0.90 quit >> >> Eli, is it ok to push this patch to the release branch >> >> to support longer separators: >> > >> > Yes, but can you make it a bit cleaner? Like having a single function >> > to do that, and also not calling next-single-property-change twice an >> > a row? >> >> I could optimize this, but I wonder why there is no simple function >> to find a text property and its first value in the string? > > I don't know. We could add something like that, but that would not be > for the release branch. Now fixed in Emacs 28 with an internal function. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 02 13:05:11 2022 Received: (at 52881) by debbugs.gnu.org; 2 Jan 2022 18:05:11 +0000 Received: from localhost ([127.0.0.1]:33628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n45EE-0004hf-RP for submit@debbugs.gnu.org; Sun, 02 Jan 2022 13:05:11 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:39709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n45EC-0004hK-QR for 52881@debbugs.gnu.org; Sun, 02 Jan 2022 13:05:09 -0500 Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 5856A200005; Sun, 2 Jan 2022 18:05:01 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse Organization: LINKOV.NET References: <868rw28qm3.fsf@mail.linkov.net> <83pmpeiisn.fsf@gnu.org> <86v8z6t78i.fsf@mail.linkov.net> <837dbmhwky.fsf@gnu.org> <86k0flf7u5.fsf@mail.linkov.net> Date: Sun, 02 Jan 2022 20:04:15 +0200 In-Reply-To: <86k0flf7u5.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 31 Dec 2021 11:21:22 +0200") Message-ID: <86zgoe580w.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52881 Cc: 52881@debbugs.gnu.org, ben.sferrazza@aeonsemi.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> >> Eli, is it ok to push this patch to the release branch >>> >> to support longer separators: >>> > >>> > Yes, but can you make it a bit cleaner? Like having a single function >>> > to do that, and also not calling next-single-property-change twice an >>> > a row? >>> >>> I could optimize this, but I wonder why there is no simple function >>> to find a text property and its first value in the string? >> >> I don't know. We could add something like that, but that would not be >> for the release branch. > > Now fixed in Emacs 28 with an internal function. Oh no, 'get-text-property' can't replace 'get-pos-property' because it fails after 'previous-single-property-change': (progn (insert (concat "(" (propertize "1" 'tab 1) ")")) (let ((pos (previous-single-property-change (point) 'tab))) (cons (get-text-property pos 'tab) (get-pos-property pos 'tab)))) in *scratch* it returns (nil . 1). So now the recent fix was fixed on emacs-28. From unknown Sat Jun 21 10:38:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 31 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator