GNU bug report logs - #52878
[PATCH] Fix display-comint-buffer-action default behavior

Previous Next

Full log

View this message in rfc822 format

From: Morgan.J.Smith <at> outlook.com
To: 52878 <at> debbugs.gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: bug#52878: [PATCH] Fix display-comint-buffer-action default behavior
Date: Wed, 29 Dec 2021 13:38:06 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* lisp/window.el (display-comint-buffer-action): Make it an alist.
---

This is my first real contribution to Emacs :)

My copyright papers are all good (not that it matters for this).

The recent change that added display-comint-buffer-action does not do what it was supposed to.  Since it is not a list, when it gets passed to display-buffer, display-buffer ignores the value.

I'm not 100% I did everything right, but I looked at gdb-display-buffer-other-frame-action for reference and verified the behavior of the change myself.


 lisp/window.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/window.el b/lisp/window.el
index d75dd9931b..34b2d0c78a 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7474,9 +7474,9 @@ display-buffer-base-action
   :version "24.1"
   :group 'windows)
 
-(defcustom display-comint-buffer-action 'display-buffer-same-window
-  "The action to display a comint buffer."
-  :type 'display-buffer--action-function-custom-type
+(defcustom display-comint-buffer-action '((display-buffer-same-window))
+  "`display-buffer' action for displaying comint buffers."
+  :type display-buffer--action-custom-type
   :risky t
   :version "29.1"
   :group 'windows
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.