GNU bug report logs - #52861
[PATCH] gnu: python-cssselect2: Fix build.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#52861: closed ([PATCH] gnu: python-cssselect2: Fix build.)
Date: Wed, 29 Dec 2021 23:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 30 Dec 2021 00:16:26 +0100
with message-id <874k6r80j9.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#52861] [PATCH] gnu: python-cssselect2: Fix build.
has caused the debbugs.gnu.org bug report #52861,
regarding [PATCH] gnu: python-cssselect2: Fix build.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
52861: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52861
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Morgan.J.Smith <at> outlook.com
To: guix-patches <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>
Subject: [PATCH] gnu: python-cssselect2: Fix build.
Date: Tue, 28 Dec 2021 16:37:07 -0500

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

* gnu/packages/python-web.scm (python-cssselect2)
[phases]: Add disable-linters phase.  Make check phase respect #:tests?
[native-inputs]: Remove python-pytest-flake8 and python-pytest-isort
---
 gnu/packages/python-web.scm | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 61a34bfc63..f424c6a103 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -4582,13 +4582,22 @@ (define-public python-cssselect2
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'disable-linters
+           ;; Their check fails; none of our business.
+           (lambda _
+             (substitute* '("setup.py" "pyproject.toml")
+               (("'pytest-flake8',") "")
+               (("'pytest-isort',") "")
+               (("--flake8") "")
+               (("--isort") ""))))
          (replace 'check
-           (lambda _ (invoke "pytest"))))))
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (lambda _ (invoke "pytest"))))))))
     (propagated-inputs
      (list python-tinycss2))
     (native-inputs
-     (list python-pytest-cov python-pytest-flake8 python-pytest-isort
-           python-pytest-runner))
+     (list python-pytest-cov python-pytest-runner))
     (home-page "https://cssselect2.readthedocs.io/")
     (synopsis "CSS selectors for Python ElementTree")
     (description "@code{cssselect2} is a straightforward implementation of
-- 
2.34.0

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Morgan.J.Smith <at> outlook.com
Cc: 52861-done <at> debbugs.gnu.org
Subject: Re: [bug#52861] [PATCH] gnu: python-cssselect2: Fix build.
Date: Thu, 30 Dec 2021 00:16:26 +0100

Hello,

Morgan.J.Smith <at> outlook.com writes:
>
> * gnu/packages/python-web.scm (python-cssselect2)
> [phases]: Add disable-linters phase.  Make check phase respect #:tests?
> [native-inputs]: Remove python-pytest-flake8 and python-pytest-isort

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.