From unknown Sat Jun 21 10:36:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52856 <52856@debbugs.gnu.org> To: bug#52856 <52856@debbugs.gnu.org> Subject: Status: 29.0.50; Problematic handling of webkit xwidget bookmarks Reply-To: bug#52856 <52856@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:36:22 +0000 retitle 52856 29.0.50; Problematic handling of webkit xwidget bookmarks reassign 52856 emacs submitter 52856 Stephen Berman severity 52856 normal tag 52856 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 28 14:19:32 2021 Received: (at submit) by debbugs.gnu.org; 28 Dec 2021 19:19:32 +0000 Received: from localhost ([127.0.0.1]:47435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2I0S-00006I-F1 for submit@debbugs.gnu.org; Tue, 28 Dec 2021 14:19:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:50752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2I0Q-00006B-V4 for submit@debbugs.gnu.org; Tue, 28 Dec 2021 14:19:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2I0Q-00035L-Q4 for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:19:30 -0500 Received: from mout.gmx.net ([212.227.15.19]:54405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2I0O-0001pz-Oa for bug-gnu-emacs@gnu.org; Tue, 28 Dec 2021 14:19:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640719166; bh=9zxSr6wBHDHmdun+UpQGc2bvCJDzF7G227hI+rSKry8=; h=X-UI-Sender-Class:From:To:Subject:Date; b=jI8iVjetl+p+Q6LoAsQkljFon4mfd51ltOLK2v1jjbKmeXRwjiN5EUh2ayGfRZi2u iidvZ9j4IvEF0csLp2N/2iyPer5pe3niaYsKLhGhRkZV1en5pYyiW51LujqGS5Y+Hz xV8NSd7ZgXf8daUOgxoHLDgo5wEtYhmOuRv22vRg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs ([89.246.36.122]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2V0H-1mIPbe3Y23-013vxp for ; Tue, 28 Dec 2021 20:19:25 +0100 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Problematic handling of webkit xwidget bookmarks Date: Tue, 28 Dec 2021 20:19:25 +0100 Message-ID: <875yr8wn9e.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:R2OglMxZz8KO0FIHhuKMlXK6FAfTWEzK8u4G4iQbhdn3mzx7Nvs zNZBYkJHYbgwbzMVdYmTraBR8WL9g8IJi8CD2QWSEAjUrLCbiLvFYcNQt4fAT8dy2QfZViy rrC+5lVH1QpdsXw6g04lUs1Z7dCAsX1XPczqqBPRLSlVUbw66Eq+ghJNedcbPXOS3+c9YK9 LqDcB+K4aNupjbomsdc8A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Ri8QP9GRJIE=:ly3SAQTy30JX4d01uifVbC W2/0W69VG/M/0d8T9k8gq1fDPOQpYePXNVo4iMIYNXOnIzG2sNW8r4CaUfwJWGXaI98+WxpJ9 Cpql9/hHQVfg+C+Vjfed7lRA7Q93II02i+kW5dzymhaYlGpD152RZQsZKgfpGc831Ax/qQal6 q/8qNd7GzbNz6DDIc71R0jQDq+6EqrBDIagFB2QsuZQqQpdVMW9p5XkuTa29FukkjFXrQ+VlC y1y3KHq3/OgUMynGHMV3f7a6ayhTxDZtxksFc78EijDKrITAH+6DWljJ4fxszOp/7j865Gm/C mDBDTnvNbIOEAaZOlWdMCaUfyXLSEdaxgAHuaBfECFzteV3q1WJ5hLZ6BOyBnCpluFSu3M3n6 lfAMNTuGk8fUePQ/QeVKvEKZnVfNmSbZjIWN+E1OSWascVjSnBIR/lfB0+3JJM+/xDd+cqolF DJvEoLSHNLUw3rBMLOiMuT/T7ZXew/WDtGY+DbdhlUNdrSXvZg3cw1mwUtla4sWFEXConkjKf E5imKCAj9XL2KwKGMDRNhC+cfp86vODYIadodUofHfWGLEo5GZaHXyx+30OGyLhghmCdyB3zq CPBB/5CEJ4hknjp/o+hpATMpB30WREFuds6VHmtXkqqSXnAXJmhroca8fq7RkIPX426fy8x61 d0a6XORz96J+9sytGF0lUuxmXqDOFD1hKWTCnypVwHPVDb91vUuaO0EBeFFUQEaN6sb7vG1uc WM9pnV3PXVvB5NGG/F3sUtjUZ1HV7g9jxmyLh3dfkWRC/67hRIAXwgx9hFloaG9Z0iNuJaYi1 0ZEuhVowNxUzSeAU30PxqwWYPO16zYfAA4WfQRGCjujXJkkJIaImorb6pnNmuPjMwOotxFz0w cKDfiA8Hs0Sf2FcrRCf4cebg1TnpjYHCLEHt6540vrggXXkHAiwaQaEOeaFJCJ5gBGOFZJGbD 7d1pIgxqU5BPAimJkKPm2xQiStY+wA9BkhT1hsNPLTOrp0dBTkiqd7X8o/36JcnseiXCJCLYh jpZwS4uS3UNx34FA5dz2ABwlIAfPKqyHmhH45Jx/+ZJDQWALv+XfRP4UnQaMUdwDvnbx3t/Q5 J/wY+Sn/FXopV4= Received-SPF: pass client-ip=212.227.15.19; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain If you make a bookmark to a webkit xwidget (i.e. to a URL displayed by the xwidget) and then use `bookmark-jump-other-window' or `bookmark-jump-other-frame' to jump to the bookmarked URL, the xwidget is displayed in both the original window and the other window or other frame. Also, if you try to jump to the bookmark in an Emacs session before loading xwidget.el, it fails with an unknown symbol error. The patch below fixes these issues for me. 2021-12-28 Stephen Berman Fix handling of webkit xwidget bookmarks Make jumping to a bookmarked webkit xwidget in another window or another frame show the xwidget only in that window or frame. Also make jumping to the bookmarked xwidget possible before explicitly loading xwidget.el (bug#xxxx). * lisp/xwidget.el (xwidget-webkit-bookmark-jump-handler): New autoloaded function. (xwidget-webkit-bookmark-make-record): Use it. --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: xwidget.el patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/xwidget.el b/lisp/xwidget.el index ce9839ebd3..eed35b7312 100644 =2D-- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -540,15 +540,26 @@ xwidget-webkit-bookmark-jump-new-session :type 'boolean) (defun xwidget-webkit-bookmark-make-record () - "Create bookmark record in webkit xwidget. -See `xwidget-webkit-bookmark-jump-new-session' for whether this -should create a new session or not." + "Create a bookmark record for a webkit xwidget." (nconc (bookmark-make-record-default t t) `((page . ,(xwidget-webkit-uri (xwidget-webkit-current-session))= ) - (handler . (lambda (bmk) - (xwidget-webkit-browse-url - (bookmark-prop-get bmk 'page) - xwidget-webkit-bookmark-jump-new-session)))))) + (handler . xwidget-webkit-bookmark-jump-handler)))) + +;;;###autoload +(defun xwidget-webkit-bookmark-jump-handler (bmk) + "Function for jumping to the webkit xwidget bookmarked by BMK. +If `xwidget-webkit-bookmark-jump-new-session' is non-nil, create +a new xwidget-webkit session, otherwise use an existing session." + (let* ((curbuf (current-buffer)) + (url (bookmark-prop-get bmk 'page)) + (xwbuf (if xwidget-webkit-bookmark-jump-new-session + (with-temp-buffer + (xwidget-webkit-new-session url) + (current-buffer)) + (xwidget-webkit-goto-url url) + (current-buffer)))) + (switch-to-buffer curbuf) + (set-buffer xwbuf))) ;;; xwidget webkit session --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.29, cairo version 1.17.4) of 2021-12-23 built on strobelfs Repository revision: 2fa7feca336dd16c57ffef072e0f0da6fffe4c5f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Linux From Scratch 10.2-rc1 Configured using: 'configure --with-xwidgets 'CFLAGS=-Og -g3' PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/opt/qt5/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 28 19:13:26 2021 Received: (at control) by debbugs.gnu.org; 29 Dec 2021 00:13:26 +0000 Received: from localhost ([127.0.0.1]:47732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Mar-00018h-Q9 for submit@debbugs.gnu.org; Tue, 28 Dec 2021 19:13:26 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:44007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Mab-00018D-38 for control@debbugs.gnu.org; Tue, 28 Dec 2021 19:13:24 -0500 Received: by mail-pl1-f177.google.com with SMTP id l16so2557868plg.10 for ; Tue, 28 Dec 2021 16:13:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=BX2LrTRRi5cLOuXA7G1NhK0LVhAviJEb5HB0yMTRDxc=; b=VTu/svCWq69f3Usi+nqmK6Znk8xMq6kXypQRzJnOJxWeyNXVA0zNmOtY5njD+hMEc5 mFAPUoyibtcIikokvfMz9PlgZpIUhbfibds0PMs9jWNKRCo+gheDuWAg6MEEpu6k/HYY roSA5qveSC/lvW5JbBy+WyLtodLZMDLbMgQlQMW4VcXNU73Gad0/B2xdzeOgFrSplWsA WSmtyjDCMSnc0c0HMMoo9DyYozrOSmYQObi4ng0QQ+QPFw0tMGCKyy/7UKwh+rBaSqMX 3xz1BJOkQMbBFhdWpUZijEjSNthh93LA+bMn3g0Qxny06If/0iWU90BB6HWNgYxirj6u w4hA== X-Gm-Message-State: AOAM5305YmXgGvNJXoF163OvkFoa5q2dWRzKx2atyNCggMk25ORdk0vZ WQ3Xeb7EThxWhIjlgZF8Y+RicHVWcrv2q7XMyf31UhHL X-Google-Smtp-Source: ABdhPJwubFH+bVQ8MbVdoHA0wBoLEdcFut/gSS5qNJ1fnWzZM10l4cIyDdtRlfgn5qifxaWtwMG5yGyguJXuHiv4NzA= X-Received: by 2002:a17:902:7615:b0:148:db50:6b9f with SMTP id k21-20020a170902761500b00148db506b9fmr23644565pll.102.1640736783544; Tue, 28 Dec 2021 16:13:03 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 28 Dec 2021 16:13:03 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 28 Dec 2021 16:13:03 -0800 Message-ID: Subject: control message for bug #52856 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 52856 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 02:26:29 2021 Received: (at 52856) by debbugs.gnu.org; 29 Dec 2021 07:26:29 +0000 Received: from localhost ([127.0.0.1]:47990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2TLw-0007o6-Ta for submit@debbugs.gnu.org; Wed, 29 Dec 2021 02:26:29 -0500 Received: from sonic308-56.consmr.mail.ne1.yahoo.com ([66.163.187.31]:38618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2TLu-0007nt-JK for 52856@debbugs.gnu.org; Wed, 29 Dec 2021 02:26:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640762780; bh=O493chWMTuNCpkGclT5pmOevR3VAGSZQuuzANsdhxaw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=bAS7Y+71qxbkMyVOuw8gm49HrZD76ELOIcjQjRM2xzVCxAr2oVyoPma7jw83Na1it1V7HwlZ/EkaAZyUXWjelKiPE3cE37sAlfxJZq+Pl9AIYOC2KZ3AMielSgY927UbF7QzCzRcZ3B8V6VaC2jbWyoLkgj3hE0/Em0oHzTlm5BIQtFz30FSNaoM33Hm3mf5N1va+7Q8JnTAy8oxelca/UfX8in0WtN1rjiGh6qW/pNuyzXCAugfY52uYtk4++ATTffGCob4t66WEmBP94BZHE50lPU9OKvSXGVU41Qn/wiQebEV4YlAoJvAMaBYPT0kTRHM4WvolDZZ3y+9STKSgw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640762780; bh=twtMBHV5Zp6aSNg301ZatZbt8moE24u8+1uf824Hg+K=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=pZwRz+IkOGeT9xKayPZ+PFes0A2cZpwtSRPyNQL4Xa44DIOaGFoMll9Qi7eEULlQ9+0ejUsXXAiFfv8mjKzIW62wly/i32lWEGuqYli1IP1KGl2KzZZLN+0M1k4JDGoQN81GWT6pN5Z/QDoqJr5a9AjzP4PSG6QuTGoVbn0KMi7E7v1HeXOt7QGODnlXFjXDLUI9GyI4bVZXmPS7lN89SEpbJ52OtqSO8iPWTgrWrTRIWlYViobgX9UAgswXkgKCPLiWfnxqRrJsmYH3Acc95VYU3xl8rF7tYQ+wxq9gaWCWkXL0AkBqOkjh7dNUkz87LjlVlaLF8I2IZo5Lksu29w== X-YMail-OSG: NOi.fkMVM1n4upiX7vpEtkYJqzMGOdLPGBIe4xIfyxqXv7iHYD_qyUJYU9HkfYr mUZSoyGht3IV9dGMcW2rvEawmPl12uK7RfgSSO2Q6MXbOleFx8UP0VzygA9j9SZBspUvsrbZlk8i HBFMCLA4FZ9em34rT7wpPFGKk.PM5Cmpl258jWG0xzrLOa_4f1PU4wwe0jrfU6CSLZYD9vJBJjG3 UBkuI1fBc9D21.MoVy2kMOu.ZlOQpX1hexnwRUWhMEckbuR4OEW.mHusJGqr.qqJlIuNQ6ucsNuQ 09NASlVNLiefooBKG1pBVKq25tM2xrFkOIfvWfR3UMx1hWvVWMBj4NCK.OlazlDjH.aSFAIiIDzn qUW.ci9cmXFe8zO0XSnFouI2Luh2gVU2lAVXLYAk3EZPcMNUrXQaOVa65Dy6qCpURq.ncvS_ww7y VPvNrR76eYz34PIK0eo7gkk3SR.clSzvcywgCPKloFtQIwrGApRy0Bf85NKKm_FYwAGYtyQCAQT8 B03Ku2CXlSrUJ6ukgqsGF6rw32DG9mLr9l9to27MfiGYe9o2cikNvwbXeI21DQotCF5Bvvup6mWQ TfXNbd1Ntk_PhVVCwlP3KSHAVmE9J1UM.cBj1EOu3zaIusMqlGOgrwm1jny0GSQmDb3as7mMmxWO kfVwZt5APjKvyOxUMDs4Ho8XnGtibWo9vgKAi4BNu4qMw.2WhWs6YUwImAY0t2KzwD8CE5vsIghZ dm..7JOCH2Ihy6nS4YedYiRZqo60qJ..NIa9xBVKrdZdLSLx._7Ji.WZvJOE0d8JNX1fi0E838TM gvMD1Q0NHHfq7cJKrX0TJz_R2G9ofV049qr6GAR8_6Bt6GpRBenc6hAQi8Kdd_gVmJmpuiD3aBVu IBbF0nnUp2l_n6YDzCpYPiVuHs86HKCj6yB32r2FeXuKM489mghpjbK.Ao7BjCkAy9ZrWX9MIuQ_ RbpwGLzgKAnFfOhpC5UQ2wx_JovROWzkneUkOlimqNXQsuRvhlwHlOtaH2RiDGaraXtIPqndstee 24psuM8EBJ6mTzWF0gncipAw6aboc5KnMWM3W_E_TiNaxxQt.DCFo6H7F2Odm2zEdHKEQXY0_D8o vysYfvNqn2cZM.1mjf0vOwEsi1fSUFYawS_3wWQbQRdl8WJ8S4ri8xAbGxH7RYDPtIhxJPSTe8oc JxBQCP77SdzJ7k69fADIyiFa2bZIUU8yzrky7Lm3m1tAUcxWgynHStOIw.elEC_n29L2stE.LYKn _.XcXTDsHgZr6O2rfIGcCwYHIe_M79dQ.ntUYSSvlUvCTp.CeU9c86gqICq1edkcFe9lY4GWaShP 4KRUgWwcrjCy1tqkQ9.F9yGLFojIWlBzxDD0oVTVVAFBIUM2Tc7PaiekaLqUgqn_0M41t5KquwYy nf7HPNJ_mFw4A1aLIK8JukXoLWjIZzfOj4GuAzCAtYczPrkuhKsXV345SC_QHVxVTk7V0_tmystQ Mu0puDAL7vIxNcK_ICEhPDuM7NWpDmS2c2W5hkjpgzA_PVfroLP9rNoysVLrS34.vnuDoBUkvEXi FtsrXaxjJ2GaW7nPJCbq2OQrToNYEC4dYSQETA6ya5ZMSTGxphqbO_SR45HtH1pgO7QyZ6kDPvzt J3cU.XkA3lyzZGe.VJdV6k6abkeI6j5_bl3dR9hubu0mpBaQVKR.H40tnyszcuPYDo3w77K21LIn PTA2pO0AjDlxInvmyfg.T.a.f6OSfAXmuz8ap2TDax_Q8mSXRYALP2Ed0btMJBaWNB56ZU1cs57l o5GSsay5qIe6z4ZFHzuLoyJoY893YapdIjT0FZvmjW3SctJbavHaXMmkS0hVis3aMV6N5UVtd6t1 rsROFZM2dINtduHzdpmTmO11Ve0FOXYYGIpbOLK4wSQvKlwYg1R.ILFUKFAa4Xr.e3hdQez71V2e CJaTSqT02RjSPMGwusDwDLxRYOTO.4ubBiFb6s0EsNRBtk.NLoTnEcoyxdIBDr7juQ587SGNV5QT x2nK3eP2OVYDa9DywdVjxrRaAVkmCQnyGM5GkVaksqYPsfqBOjUhWcdh2AbfKC_vpk8VZIxHLhLt oD23lRiPs5M5HE_tzGBz62SairhLgwGulkacx2SxHqUJWPzpNXSlXGmmDbrNMr32V54cn2.3eS.V 6ceA9_Qyjcc.fpXX7.H_nXrVCkXXppEUcLxaSzUH6U3aujrQhsh58wVJvM0cRtJDQw.fB7qssAC0 9R8l14oIiDggEoKfptnGjptCEUJxwcOrAF08kSJRZLkag5yq3.QmnA9a0 X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Wed, 29 Dec 2021 07:26:20 +0000 Received: by kubenode502.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 62eef0f404ed9097539348b968f31e3c; Wed, 29 Dec 2021 07:26:15 +0000 (UTC) From: Po Lu To: Stephen Berman Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> Date: Wed, 29 Dec 2021 15:26:11 +0800 In-Reply-To: <875yr8wn9e.fsf@gmx.net> (Stephen Berman's message of "Tue, 28 Dec 2021 20:19:25 +0100") Message-ID: <87ilv7ub1o.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 551 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52856 Cc: 52856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > If you make a bookmark to a webkit xwidget (i.e. to a URL displayed by > the xwidget) and then use `bookmark-jump-other-window' or > `bookmark-jump-other-frame' to jump to the bookmarked URL, the xwidget > is displayed in both the original window and the other window or other > frame. Does "original window" mean the window that was selected before you ran `bookmark-jump-other-window' (or frame)? If so, you should customize `xwidget-webkit-bookmark-jump-new-session' to a non-nil value instead. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 05:50:39 2021 Received: (at 52856) by debbugs.gnu.org; 29 Dec 2021 10:50:39 +0000 Received: from localhost ([127.0.0.1]:48104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2WXX-0004Hh-EY for submit@debbugs.gnu.org; Wed, 29 Dec 2021 05:50:39 -0500 Received: from mout.gmx.net ([212.227.15.19]:33789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2WXW-0004HU-1t for 52856@debbugs.gnu.org; Wed, 29 Dec 2021 05:50:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640775029; bh=ZHbbCSsboxZvgh2+uXxyHQJ+iAs6hjaIPDjGCBQhOiA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lmbMkHASodQlfsm985FmzuhQDULrejwfspvoDuqTxD7++0bZ92juqVpvS9wFF7Nkl VeXiAaeIFkBB+pPF51kp/P30OMmroxq2unikX98Z1izkuiJnTc3gork7g8zbk4E/eD qkREYiqfO1RRx5WllqJ3ZhDAhUY6wyZWKBbzCrvc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs ([89.246.38.30]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N49h5-1mKyMG0Vl3-01050N; Wed, 29 Dec 2021 11:50:29 +0100 From: Stephen Berman To: Po Lu Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> Date: Wed, 29 Dec 2021 11:50:26 +0100 In-Reply-To: <87ilv7ub1o.fsf@yahoo.com> (Po Lu's message of "Wed, 29 Dec 2021 15:26:11 +0800") Message-ID: <87sfubfzwt.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:UGCtx9aAfwQ9y80kM7/x16fDh/7jrfpNbdUghvxtDXlphxLQRjZ E6tgFsg0QAuxwTQHEW796N8ZVNwE7ulzxklkCQ9UOGvsMzB1jD8QLl42qWf3/YkYjcLgA6p fBwTDQgJQz8hkhRHGB9OVx/TN5vi3DvZfYnKpsA9rrUjZDnKAfl11yq2y2gjbYL9zMMScyX TAYGmz9uEXCp06NiODF/g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:9ZoUxhiwewU=:0uVq+G4Zh4p9H5kJRuJdr2 x8rNYjzxJp5xnEnjqbHkpDi/N6Mywwugx0JNDs7qMIYsBnh5RbNGVPc5DCDoR7vvsTiI4qEW2 O+y2bMbLpXU9ZqpqhxbGhPRDEHP1WLtWaKNlB9xTZXFLz7tdTKAeikJ3jSawWpHEEBOm6AmZK EhTe3HV3Is4Kpr1BjsY7Nx1C7AaxIBBPLiez4om+07V2UW+tUOdoxS/iFhkwzUdr+0ygbRL0o vPttIoUZeRaPWp2Nuv6Wio6Tk0TFMGx+Gf3PVjAjt7yCadpd+hdMeuWUJGx/nM+1eGibbB008 En1plBnrqacJ3FXda63/5f+P4DpEpIrKvQesTzFy8GgBfGyAq0QIvT3ZVnJbTI1ONHuMcK2Qz 4F5Un/juKqdntNxpl5MdKHOb9FjmBorvFqUADHjv8cjqGxXMPbPqQzk3grzoRxPDW4splYMeO Sdq7VY2caI1kNL+Y4naMJExHKmagiRZHoWQDyieR9QQxms1eZiJWX/bT5VW3JZ7U2949rIotP MbMc78OYuvSPF73S+Ay1c/C1dzbhOo+xAvuWT9tmU7ioFsSMW2fTO0oCT6pCGsAhK5zmIbnzB 2MkHzAt1vZ0lqWDCIprpnUaCrqZqzGMejKMle+qsqUO9m/puKnRfN+wA3Ez+Aoj6OAeuqDIBG KXuuYhp7n8qiK+9LviQQ/I0JxhR510V3ofdbvcEcKXd0A9EUaPZdBtfw8ImdJlOHwZeKAIoQu 0cHy0oSTjWYgQmZQD5XFaeOJfour2FXu0E2MM8BF7DPgrkAELFS/O0+eOI6Rx6f94m3GxoHoo fX02TX23i1D9/gJOe69tLKhgxoin3dNrvV6NnGyRLZcamEVCgqh8OHiSpWVH9NL3oufb4RpA4 bY0W3q4wrFiY8q/1aTqLqW9Bc765rTcuWI+hSQjo5HCVqwLjF4C8WlLJCSUB2JA26CZOh/d4T PKXetztCfdUOthHjcTErnxlIJKmc/CHJBKjNOs6cg2qyb0rFPqy6R7w7ZUkubpm9l7uP3Gfcr y+AbFQp8QpjvZiu/Bm/NaSgXm6ef0HeI/vfnEAR29lrrPXjFNXHHcXrbbfAytsfLeoKGXd6n5 lfqLRdE03s2GBc= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52856 Cc: 52856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 29 Dec 2021 15:26:11 +0800 Po Lu wrote: > Stephen Berman writes: > >> If you make a bookmark to a webkit xwidget (i.e. to a URL displayed by >> the xwidget) and then use `bookmark-jump-other-window' or >> `bookmark-jump-other-frame' to jump to the bookmarked URL, the xwidget >> is displayed in both the original window and the other window or other >> frame. > > Does "original window" mean the window that was selected before you ran > `bookmark-jump-other-window' (or frame)? Yes. > If so, you should customize `xwidget-webkit-bookmark-jump-new-session' > to a non-nil value instead. I did, but that just ensures that jumping to the bookmarked xwidget creates a new xwidget session -- it does not prevent the xwidget from being displayed both in the other window/frame and in the originally selected window. My patch ensures that the bookmarked xwidget is displayed only in the other window/frame, which is consistent with the behavior of `bookmark-jump-other-window' and `bookmark-jump-other-frame' with other types of bookmarks (e.g. to PDFs in the pdf-tools package), regardless of whether a new xwidget session is created. However, my bug report was mistaken in reporting that jumping to a bookmarked xwidget before loading xwidget.el raises an error -- with the existing code it succeeds, because there the bookmark uses `xwidget-webkit-browse-url', which is autoloaded. I must have tested that after applying my patch but before adding the autoload cookie (which is needed with my patch). Sorry for the confusion. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 06:26:12 2021 Received: (at 52856) by debbugs.gnu.org; 29 Dec 2021 11:26:12 +0000 Received: from localhost ([127.0.0.1]:48133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2X5w-0005JO-5R for submit@debbugs.gnu.org; Wed, 29 Dec 2021 06:26:12 -0500 Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:37147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2X5t-0005J8-DG for 52856@debbugs.gnu.org; Wed, 29 Dec 2021 06:26:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640777163; bh=NJSqyqXMSQ3fYc4sz6P5ZHurYvqbe1pDjswDr+WwBgE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=qMs/GLr3ZtLVhppU8BwZ4jzimJ0sRQ+JUVsldsK9H1xQvdIii/6QWNHmjHN6XmaPrcn4FmC2IiV9qJ66ouCjRaiNhvGVB0t/aIx4EIiv3OiJv3z9Dnht5Arv7xxCkDxx9BnEP1tTPF+OP+yp+7UIB7C69Tf4kpRcZNfluxFXSQpfTZV1iPWpoykcIlWJKC/9DAgrkzy6h5vfeaueLnZzXSvKw9y0aXtBFXLkSHxlGqOjXDHibH1OIEGDxgRFxh3ihN65HtoP6nmjuASlxb3J9l/GKdZEsvuywLG1QsP3HahbrWxjW65kx39M3eYA25wrJsoGFgBSvmV0FUKmkzNv1g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640777163; bh=c55wA5iKrDehV0WgYfV2UGKxZQY5RtxA4BT+8S7esGJ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=L3RFMyv6wRu03vpEa2UTGgkSoeZYVChNDIBfH+cNuVJl4+9tcyhiUQDRU+YyVO++u2nvpKb3wJECDRmOsu2DqYKvAvSUNdbHlS47zdA54wBJVI4aRYTRLUuBnXLOvGpPN+c5vdoPV3oA3rI2OWH3naTcQ7G7kt27rSTCAdiPZW+XRhoRUyy97ZuIy/9MoqC8ogW85iLS9TKPyX19XR4qi6WA5b+Ru4XHZeHcq9RF8CId0CY2+WZcAT5lm45WV68jL3UjuHL74jSjB7i/+9kuhpg+CHQG5TNutUxV3ug2/t+Z9DoOz+aioIvG1qUeOhiNwNlsMTEVkFFxvfjw4Tbo0Q== X-YMail-OSG: Z4NNMlYVM1ku.YqMj79kxBv4WijHjAfefrvHdgpHTXgHG2T6vvBfihm4TJv6z5o OwGoEbylbX3zZJzclbJmNMaEIxedNfASvvIM0vfHI3ABiOY_kgmjqQitmni3afz0wJR9N4Pra199 jtgZZ0SgRkivu8ip5f.ptViSDhGSCypF2d7Y.cmMGlGSIVzc0gXlnkkjq7Or4BWIGOQGSJtXQhF8 46dSaMHsTAJN39v7Y_EjfiK6PLMbxB3DCpP5X5DVa7dwqAF3CH.6NVdTi9VUFOem.CEjCvVxa7K. 0QmBOVaEd6vf4t1vXc9vr2vnAO67eOys21CxrK0tOB.4FszOmzqr5A2t4ncqfmB0x3kaMyeJh0Uo XOUwJC6Dwc4MwcieTmcnhCiSbnZW19qk7vUxvWOikhJqGvVOzNB2sQAqKHMH3ulJnAViy26ih_cU RwswrfYozJ0D0WRG4dD2r090nKVRClWghpxyMXonPdnobMUVsS.J2.twCAOu_74u0v4ehpgK1fWy JS3PZm2Ia19AhMqbUQb8L00aGFJtVThsZed2GeEVLk4QCUShAG945ixr6lbYjHgwk9fYN.ZaHT2U jdeuH0bICwMzjGJvJ_weburmh9.0OWWAgLt26IiHxCjTxRGL4KtsjMmeKtAUM8SeyJ2nRaqXNo7f dhMoAQOnIEyz5td7hVKi..YIgk8ns7FhoqRLMv3hrfPUzNsU7iCblWmAL2ME0tXock0MgZ1sg8Zr zmO2maXXqVRCmmIYxS5TnyiZXWCzpD.b.zzBHpX6Lfs_zqMtkclAQ76GorG0igjk3rxZLnsBTpUq 9.P4A1.aoujT_7z30WRmY3uAc1GuUrEPRKOaTbN0Y5BulvtaaP.Q94P5uG4guiuKoA2l5RH8JVdc Gr8gkGIVZLVVTj8BlbRwnzOYEEupYTeRG7ebhtAQGzViLnTVohXlp02kJHB1hzFBQqdC4T1hhuDo AdI1MKassql7crpElCZnl3CjL8nB2m.LqG6z8bJpOCK12JlHJyN0ezsnqy3c11.aiIR4dYU0BrIH 52U.ZMjEmod..UxA3IP0fdBcYaBatjveIAyAxCs3Cl5BVivm5VxmR2TjqHWVCmY70.iKaKDtz7lA Jv130mA3l57323_dRk.qFuhgTQFumbc7lQwzWZVYOGCSejZtVrHTkZPz2.A5jpSaI8unt7SC85Zs YyB.oTiVC57VDkTeoLFXk4KNDZEzIyUDoEtPU2qhKoSGO2eLzirTpgBW.Zmzo8OrjJwbOdHMIJuT K2amGOfh13fixbpatouqbHmfUoht4QH1dGVQBWQS7xxxE.IQ8Ez9BFuI5yUDVYxTjz3TDZMkM.ec qAYhq4.Gf380Qp85gXdsFLs5rqOy6O_bJr4Msn5KlDG_oWJ1kZDV1r5Hbu88nqlGrVorp7ee.7vh BxpQd6JCdevTRFgcummNmeuDsjgOM87JCUjzaTRC0XD0S5Pc75ClrnYpXKOOdcXPa.zNfF_FUyzm N2J1QlXcm33b68qk1VI0Ss0phGIiPfVLqQ8cAMLS_yNjySbbYpnZqbUbNvfjSYD.OUa_5ufytAsw _Bj0U1Jjp6FcogJ7_M0uMrRRUJHNtA1qgjJcsLpELEYdvaJZi9r0cIxDxq6bGSQFRE5r1c4uioLQ 2BBR7Ox9p.mk_h5gSoji2dLLE2YCKo87ZcI5aPzkqeSJNvJS9wowRLpsKLiUAGxP1Afl09oiKrIF TSEd50hLtcuSY_I.Kq2etXRJ3Mf5rYpzX7IcwlJMQUjlomfowk_1Jsq0S6mcn_czsw6MwdbjOukO 3OtoiISfXI.Bywx7B3xq0kAsFwuyZDpnxa__a7hrqQzWrX.jCcDZvRvu4.6qQC_ChmXhyeOMA2Ua zbvP622kCfHVQEE9EHKiwiU8T7XZuY5EfKpxsLAAxzxrH4Ir_N589Lo98E8qQtrJP3wCzwpYkGlB uR7o_NB2FAd9y_YDNFeEOyN2uJlXb3.fCfoU.4U2zFe3oDE5aYapVVrqgf.G0HWlXXq28GYe8uY0 Wcmo2fjX5Gkbb6Jz_JtCKY8bLKAYI0JtiIytBcng3EAz4KgyVH0ArUg.YuZDP3LG5SdtXg.B_SG0 xrEiZ0cCHJAtruqqaVhbntHnwEAc2ttJPU3b24oVG7C4SOsGrVmx3eMso8WhexENqG4wl.wiFUHz tzimjOpGP4R1k8_PjuzccpK1PxtIFGyv06nj7Z0uBAFs5Ytops9qfy8v8P8nGXpZR4Pg6fsYhzAX 5tA3T.tAvc4CX.685rs5a7FV7ryQHmwCZz67.ApWCpicFUaT6uQuOTRk- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Wed, 29 Dec 2021 11:26:03 +0000 Received: by kubenode513.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b040b37441ce86b35d7b026f3293d1e2; Wed, 29 Dec 2021 11:25:56 +0000 (UTC) From: Po Lu To: Stephen Berman Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> <87sfubfzwt.fsf@gmx.net> Date: Wed, 29 Dec 2021 19:25:52 +0800 In-Reply-To: <87sfubfzwt.fsf@gmx.net> (Stephen Berman's message of "Wed, 29 Dec 2021 11:50:26 +0100") Message-ID: <874k6rtzy7.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1181 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52856 Cc: 52856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > I did, but that just ensures that jumping to the bookmarked xwidget > creates a new xwidget session -- it does not prevent the xwidget from > being displayed both in the other window/frame and in the originally > selected window. My patch ensures that the bookmarked xwidget is > displayed only in the other window/frame, which is consistent with the > behavior of `bookmark-jump-other-window' and `bookmark-jump-other-frame' > with other types of bookmarks (e.g. to PDFs in the pdf-tools package), > regardless of whether a new xwidget session is created. Okay, thanks -- some comments below: > + (with-temp-buffer > + (xwidget-webkit-new-session url) > + (current-buffer)) Why with-temp-buffer? xwidget-webkit-new-session creates a new buffer and switches to it, which is not appropriate if you want to obtain a buffer containing the new xwidget. I suggest that you write a new function that creates the buffer, displays the xwidget, and returns the buffer, preferably also updating xwidget-webkit-new-session to use it as well. > + (switch-to-buffer curbuf) > + (set-buffer xwbuf))) See above. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 05:52:32 2021 Received: (at 52856) by debbugs.gnu.org; 30 Dec 2021 10:52:32 +0000 Received: from localhost ([127.0.0.1]:51494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2t2u-0002GC-1O for submit@debbugs.gnu.org; Thu, 30 Dec 2021 05:52:32 -0500 Received: from mout.gmx.net ([212.227.17.21]:59219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2t2s-0002Fx-4t for 52856@debbugs.gnu.org; Thu, 30 Dec 2021 05:52:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640861542; bh=BKmV+rqSNpSLnzX6nD9GcZTqsjRZuw4jlhjp5bOOMgE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date; b=LGD8qMgQHq7Fr3tE5KJEPVxzt9XK9GagpDgpHLwmlVCjJBlERzjXOzUntQ3tZHiez PTVkYYhYnSQD9tGWDxyGLBEn99MeCzZQcxdwm+vJY5FKezfwcxGY8V20n85TUxNs+h K9e1NCvEGKOqnpaBqci3Nktj8ywTyPujdJjDNzgw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs ([89.246.38.232]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N0oG5-1mF3gJ0BRV-00winq; Thu, 30 Dec 2021 11:52:22 +0100 From: Stephen Berman To: Po Lu Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> <87sfubfzwt.fsf@gmx.net> <874k6rtzy7.fsf@yahoo.com> Date: Thu, 30 Dec 2021 11:52:20 +0100 Message-ID: <877dbm1i1n.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:UurrdqrX/zhOhWpeydpWllKDGWnu27PyYJLnCU1fZs/ttnP8Rdm 8ACBopw0wrGsq86j7RKEwRfUGKSnQNVvQ16YXU0wRMpnpPeX5hWZXB6d1piEk3WnYDvtpdH ksiCtgQlimHm9mzNCIcTaoMzh5AEfH3LvnKtgBY0yCVzr8I7lfx+vXZA/vXDv//ymupkOth emYcCtbFp8InpAJJyW6jQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:D2X66cZpTrU=:Uw+ehocFwX4Ha+A9kxUtGo 5z468/sGLPhcO49oLbrJY5Joshpwg4mKPx0Uhkp+prMooiQAPNY+TRsJ+5Nyzu0Z+eEXUOEe1 nYM3nK/9n8JqyYVdGQE24KnwQ0BRmF1Sf4nK6ZanCt7vjBirFabGTwnZnde0wj81XP1lA6WOi qBhYxe3LqwgmsvAOi5tKB4he10vMwD9jLHCZiDxSC4gQXvaCxbGUE8ha2kOxiknwaBT2+qcUD QZkFk7hzVO4ZGMNFy0oFO9McHT1HUCL3jOsTycU9mQPOtqet24HDrtVPLEwd4OjkCyJ1nXZzf zZKQAAXbwFW259RThVqyk/KkkCMVElMcehBkOuuLTPuLwGUHS9yraVzpcX0ONLjiZfS4M6Yhd aDlnREkvdp/PcbTpa8UOszWTy8Alf1gmcnTIWtRvrajolgd57BPcoHIrQWrUure4mwMhjKERu TQ8/FnD+eonIUCQdRex/DmbIiqwy7iv5qccQmr2GyT7MJHArSLFzS0btAw/n7DCJzWUsBKNP8 XIy7fEjihwMBpMlB3B3AXI9lH5dZl9iBaZndE5YRUIj7Rvh+n8MLA94/zci4kQUG+fhZdIz5b UqYEI1Z3mA4w9hGxxmca80GsmtRp2L92EvkNzt73cxskOl8OCL9xPx5w01LpKStXKzfCzcygb 0hR7r4VlrWCQlA4wVAP93YvlC1Xb9MKOLmGI/fVFgqINyR62za7PYeyvZA2RwPblTKIXsr9j0 pBXvWFxpYQCD4bgKAg/ozVK9Kz+BcG18szeIhhtOIxZhwOIYj8H+9frhIYSX/VxGhF5brJNH1 ZYK+FhQPdzE4H6lk8YVSfBDZbWFJC2O9TjQRswbgPRl4p2C8mu69HLTkNFolt25J1ClUaAX6h ErKjd98wl0vLMSAWVVHK8QIlLS/ny5Ihcn/Rs+cOirjKrAdRwxigIl3QbV5qI7T9oAwMxOlh4 xjC0UhllUISGZ6wz8ui0yaX5njnEPa4EJ9pXQDDZz16w0TCHcfOj5Nn9UZyod/FcAMaLqax30 OQOs/PMouRlqDdkgGjNYGPHClrPBg1B6XarPrUGoe9kVGSARm7tIIRIKkicP07S0rcjO5hBzY dydRwnCTSjAfQU= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 52856 Cc: 52856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain On Wed, 29 Dec 2021 19:25:52 +0800 Po Lu wrote: > Stephen Berman writes: > >> I did, but that just ensures that jumping to the bookmarked xwidget >> creates a new xwidget session -- it does not prevent the xwidget from >> being displayed both in the other window/frame and in the originally >> selected window. My patch ensures that the bookmarked xwidget is >> displayed only in the other window/frame, which is consistent with the >> behavior of `bookmark-jump-other-window' and `bookmark-jump-other-frame' >> with other types of bookmarks (e.g. to PDFs in the pdf-tools package), >> regardless of whether a new xwidget session is created. > > Okay, thanks -- some comments below: > >> + (with-temp-buffer >> + (xwidget-webkit-new-session url) >> + (current-buffer)) > > Why with-temp-buffer? Oh, that's a faux pas, the residue of an earlier version; `progn' would have sufficed, but the new version below does it differently anyway. > xwidget-webkit-new-session creates a new buffer and switches to it, > which is not appropriate if you want to obtain a buffer containing the > new xwidget. I suggest that you write a new function that creates the > buffer, displays the xwidget, and returns the buffer, preferably also > updating xwidget-webkit-new-session to use it as well. > >> + (switch-to-buffer curbuf) >> + (set-buffer xwbuf))) > > See above. Thanks for the suggestion, see the patch below. Since the previous bookmark handler was the only user of `xwidget-webkit-browse-url''s `new-session' parameter, I removed that, and took the opportunity to make some other cleanups to that function, see the commit message. While testing the refactored `xwidget-webkit-new-session' I found that the xwidget-webkit-clone-* commands were broken because `xwidget-webkit-current-url' returned the message instead of the URL, so I fixed that. And I removed from the doc string of `xwidget-webkit-bookmark-jump-new-session' the suggestion to customize `xwidget-webkit-last-session-buffer', since, for one thing, it's not a defcustom, but more importantly, changing it has no effect, since it gets set by `xwidget-webkit--create-new-session-buffer' (previously by `xwidget-webkit-new-session'), overriding any user change to its value. 2021-12-30 Stephen Berman Fix handling of webkit xwidget bookmarks Make jumping to a bookmarked webkit xwidget in another window or another frame show the xwidget only in that window or frame. Adjust xwidget.el code accordingly. Make xwidget-webkit-clone-* commands work. (Bug#52856) * lisp/xwidget.el (xwidget-webkit-browse-url): Remove `new-session' parameter, since the bookmark handler, which was its only user, no longer calls this function. Remove superfluous `browse-url' require from interactive spec and discard the unused flag returned by `browse-url-interactive-arg'. Incorporate the code of the now removed `xwidget-webkit-goto-url', since this function was its only caller. (xwidget-webkit-goto-url): Remove. (xwidget-webkit-bookmark-jump-new-session): Adjust doc string, rephrasing and removing a customization suggestion that cannot take effect. (xwidget-webkit-bookmark-jump-handler): New autoloaded function. (xwidget-webkit-bookmark-make-record): Use it. (xwidget-webkit--create-new-session-buffer): New function extracted from `xwidget-webkit-new-session'. (xwidget-webkit-new-session): Use it. (xwidget-webkit-current-url): Return the URL instead of the message displaying it, since the xwidget-webkit-clone-* commands need it. --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: xwidget.el patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/xwidget.el b/lisp/xwidget.el index ce9839ebd3..42b5e08055 100644 =2D-- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -116,22 +116,21 @@ xwidget-webkit-cookie-file :version "29.1") ;;;###autoload -(defun xwidget-webkit-browse-url (url &optional new-session) - "Ask xwidget-webkit to browse URL. -NEW-SESSION specifies whether to create a new xwidget-webkit session. -Interactively, URL defaults to the string looking like a url around point= ." - (interactive (progn - (require 'browse-url) - (browse-url-interactive-arg "xwidget-webkit URL: "))) +(defun xwidget-webkit-browse-url (url) + "Prompt for a URL and display it in a webkit xwidget. +The URL defaults to the string looking like a url around point." + (interactive (list (car (browse-url-interactive-arg "xwidget-webkit URL= : ")))) (or (featurep 'xwidget-internal) (user-error "Your Emacs was not compiled with xwidgets support")) (when (stringp url) ;; If it's a "naked url", just try adding https: to it. (unless (string-match "\\`[A-Za-z]+:" url) (setq url (concat "https://" url))) - (if new-session - (xwidget-webkit-new-session url) - (xwidget-webkit-goto-url url)))) + (if (xwidget-webkit-current-session) + (progn + (xwidget-webkit-goto-uri (xwidget-webkit-current-session) url) + (switch-to-buffer (xwidget-buffer (xwidget-webkit-current-sessi= on)))) + (xwidget-webkit-new-session url)))) (defun xwidget-webkit-clone-and-split-below () "Clone current URL into a new widget place in new window below. @@ -531,24 +530,31 @@ xwidget-webkit-save-as-file ;;; Bookmarks integration (defcustom xwidget-webkit-bookmark-jump-new-session nil - "Control bookmark jump to use new session or not. -If non-nil, use a new xwidget webkit session after bookmark jump. -Otherwise, it will use `xwidget-webkit-last-session'. -When you set this variable to nil, consider further customization with -`xwidget-webkit-last-session-buffer'." + "Whether to jump to a bookmarked URL in a new xwidget webkit session. +If non-nil, create a new xwidget webkit session, otherwise use +the value of `xwidget-webkit-last-session'." :version "28.1" :type 'boolean) (defun xwidget-webkit-bookmark-make-record () - "Create bookmark record in webkit xwidget. -See `xwidget-webkit-bookmark-jump-new-session' for whether this -should create a new session or not." + "Create a bookmark record for a webkit xwidget." (nconc (bookmark-make-record-default t t) `((page . ,(xwidget-webkit-uri (xwidget-webkit-current-session))= ) - (handler . (lambda (bmk) - (xwidget-webkit-browse-url - (bookmark-prop-get bmk 'page) - xwidget-webkit-bookmark-jump-new-session)))))) + (handler . xwidget-webkit-bookmark-jump-handler)))) + +;;;###autoload +(defun xwidget-webkit-bookmark-jump-handler (bmk) + "Function for jumping to the webkit xwidget bookmarked by BMK. +If `xwidget-webkit-bookmark-jump-new-session' is non-nil, create +a new xwidget-webkit session, otherwise use an existing session." + (let* ((url (bookmark-prop-get bmk 'page)) + (xwbuf (if (or xwidget-webkit-bookmark-jump-new-session + (not (xwidget-webkit-current-session))) + (xwidget-webkit--create-new-session-buffer url) + (xwidget-buffer (xwidget-webkit-current-session))))) + (with-current-buffer xwbuf + (xwidget-webkit-goto-uri (xwidget-webkit-current-session) url)) + (set-buffer xwbuf))) ;;; xwidget webkit session @@ -796,37 +802,44 @@ xwidget-webkit-adjust-size-in-frame (add-to-list 'window-size-change-functions 'xwidget-webkit-adjust-size-in-frame)) -(defun xwidget-webkit-new-session (url &optional callback) - "Create a new webkit session buffer with URL." +(defun xwidget-webkit--create-new-session-buffer (url &optional callback) + "Create a new webkit session buffer to display URL in an xwidget. +Optional function CALLBACK specifies the callback for webkit xwidgets; +see `xwidget-webkit-callback'." (let* ((bufname - ;; Generate a temp-name based on current buffer name. it - ;; will be renamed by `xwidget-webkit-callback' in the - ;; future. This approach can limit flicker of buffer-name in - ;; mode-line. + ;; Generate a temp-name based on current buffer name. The + ;; buffer will subsequently be renamed by + ;; `xwidget-webkit-callback'. This approach can avoid + ;; flicker of buffer-name in mode-line. (generate-new-buffer-name (buffer-name))) (callback (or callback #'xwidget-webkit-callback)) (current-session (xwidget-webkit-current-session)) xw) - (setq xwidget-webkit-last-session-buffer (switch-to-buffer - (get-buffer-create bufname)= )) + (setq xwidget-webkit-last-session-buffer (get-buffer-create bufname)) ;; The xwidget id is stored in a text property, so we need to have ;; at least character in this buffer. ;; Insert invisible url, good default for next `g' to browse url. - (let ((start (point))) - (insert url) - (put-text-property start (+ start (length url)) 'invisible t) - (setq xw (xwidget-insert - start 'webkit bufname - (xwidget-window-inside-pixel-width (selected-window)) - (xwidget-window-inside-pixel-height (selected-window)) - nil current-session))) - (when xwidget-webkit-cookie-file - (xwidget-webkit-set-cookie-storage-file - xw (expand-file-name xwidget-webkit-cookie-file))) - (xwidget-put xw 'callback callback) - (xwidget-put xw 'display-callback #'xwidget-webkit-display-callback) - (xwidget-webkit-mode) - (xwidget-webkit-goto-uri (xwidget-webkit-last-session) url))) + (with-current-buffer xwidget-webkit-last-session-buffer + (let ((start (point))) + (insert url) + (put-text-property start (+ start (length url)) 'invisible t) + (setq xw (xwidget-insert + start 'webkit bufname + (xwidget-window-inside-pixel-width (selected-window)) + (xwidget-window-inside-pixel-height (selected-window)) + nil current-session))) + (when xwidget-webkit-cookie-file + (xwidget-webkit-set-cookie-storage-file + xw (expand-file-name xwidget-webkit-cookie-file))) + (xwidget-put xw 'callback callback) + (xwidget-put xw 'display-callback #'xwidget-webkit-display-callback= ) + (xwidget-webkit-mode)) + xwidget-webkit-last-session-buffer)) + +(defun xwidget-webkit-new-session (url) + "Display URL in a new webkit xwidget." + (switch-to-buffer (xwidget-webkit--create-new-session-buffer url)) + (xwidget-webkit-goto-uri (xwidget-webkit-last-session) url)) (defun xwidget-webkit-import-widget (xwidget) "Create a new webkit session buffer from XWIDGET, an existing xwidget. @@ -868,14 +881,6 @@ xwidget-webkit-display-callback (define-key special-event-map [xwidget-display-event] 'xwidget-webkit-dis= play-event) -(defun xwidget-webkit-goto-url (url) - "Goto URL with xwidget webkit." - (if (xwidget-webkit-current-session) - (progn - (xwidget-webkit-goto-uri (xwidget-webkit-current-session) url) - (switch-to-buffer (xwidget-buffer (xwidget-webkit-current-session= )))) - (xwidget-webkit-new-session url))) - (defun xwidget-webkit-back () "Go back to previous URL in xwidget webkit buffer." (interactive nil xwidget-webkit-mode) @@ -892,10 +897,12 @@ xwidget-webkit-reload (xwidget-webkit-goto-history (xwidget-webkit-current-session) 0)) (defun xwidget-webkit-current-url () - "Display the current xwidget webkit URL and place it on the `kill-ring'= ." + "Return current xwidget webkit URL and display it in a message. +Also place it on the `kill-ring'." (interactive nil xwidget-webkit-mode) (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session)))) - (message "URL: %s" (kill-new (or url ""))))) + (message "URL: %s" (kill-new (or url ""))) + url)) (defun xwidget-webkit-browse-history () "Display a buffer containing the history of page loads." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 06:19:15 2021 Received: (at 52856) by debbugs.gnu.org; 30 Dec 2021 11:19:15 +0000 Received: from localhost ([127.0.0.1]:51534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2tSl-00032j-4L for submit@debbugs.gnu.org; Thu, 30 Dec 2021 06:19:15 -0500 Received: from sonic303-21.consmr.mail.ne1.yahoo.com ([66.163.188.147]:35337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2tSi-00032T-57 for 52856@debbugs.gnu.org; Thu, 30 Dec 2021 06:19:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640863145; bh=uXJnAuMl2FL7TvGoK0WaYQQB7tbnfyQ2H6iHAgiwwNY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=uk+p37h/qifXZbhuMV3qKNKkRcTvmKkMHDQz7s3iwLS/ud3A5aHjAiQWAcMLkYzsvZVlSWrPJc0mK00SzlnoJQ4JVCBBsmLheESrUotsx6kfwuL/hgqC47Kha5p7jezgOWpfBjnS4zoSYHxT1vFRZttOQCD35oDxvjRwTt1ZSnAQN4t3VRRP6TnTfG8Y3DM9yZhAx7VtIvpWFGH5MBkvIxoS+1BgB6l217Bw6xXsxV0bfIQuQS+EmjR4YzUzjLsd8Nj5h4r3tedLvRQE1POhajHtbeB8Bt21xPC9RKEJmtu1TnaOxqR4aq1QhhFzqtoSjrarOPv+hQt/yvDVJ5opsw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640863145; bh=KG2o970wg199lyoYmqcIHlrvFLN9/x6w7FhAJ0V88qz=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=VsIB7ey+04JW49LOyHuBwTlIpXM81zfJXUYMH4L264s1oNz3ajIFNnkuHHQoGX/4vbZCa3D0AzgyAZ3EtZ2LC5zoTZ9uesoYLIjZxGq9dupvTT4Iin1vDUCDWA+Konggy6sfKjGbwn0FmutONH5Z0JvzH5ZVHLAGIMdei3B0RTigynf3hJdimgzJFzHP+7c9/7ddSRVN2591UrOdr4WF1jEwv4t7PH01dT+sIjj/IyJA4PadAKIgOusA2Ikku5uSgKI6mf20gjoxg3ovcCvLXnJNatuZorF+MyYbWQCg7YaHPlgQEB7M+ecsV1kBToxecoL85pdPHVITt5YGJggpUA== X-YMail-OSG: oCf0Lo8VM1lBnu2YeWahi.6Gsq9KIzGrRFEX4DFtZdy4Dugh3sWm1q_re01mKHY S_JWH8PZe2b604BtFv9rXOQc6IK8S1390BOS0ogzbTRBSujPMUDbLtE0JN3mawHV313_B2_SLqmO R2Td1VAa04T2t4E9BQSVdzxG0cZ..Ra0JRFRnKvdnmdVeBvA2qlKcBKcRTXgxWq.PfkqLdJ4ohKA r2jZ5GlK4f6xjrPedCFyQXKxMTsdMdqChzmVh5rrVuuzJFtLMm9A1msd0svmjb0L.kXYrdvL0PuV Af2iB7Uh9hKXjYsDcruWSdwS2kylmjMajPZvQRhPPzSM5gp5tx.kfjKQCe7fVdzZj0ScFGRLQIdB U4KsmNuAa6pOMXdCJrznYoZXDw2ExzfayWWA86QEK6dcKgSu6sz1EFRYSwUgOC1pKisRJ5M2Nllw PbZ7_GCvEfNX_bHTn6_StWEIbS2TKKB1rBMz2jzY0A7q868M8MbvRBCN_F6NXMgSjWzeecB0MuqN A8.Vrgyhp7HyD.mffle8otIeflWxf8EIVH_1lomL_2KYp7pEcjwpAwYy1hbiUIoh8p25k_vlbRGO _eELDxkcbSELDdWdQns8A2has41C0ZuBhDvIqwGW.KV429FoqhB4uYYzwSyNX6iDOMoVu44N_ajd yJ4OrByBRp10hFHPSz2c6nWJyoe63kEPJ2MmWWWdyGiMFiZudK3ZlcjPjJ_GePP6m1UKBJW2BP2s AtfLW0NMShj9C6eNvqXrCFFhdEGHZcafO3XDa09BYnFyLmJPx37yh1y2wcFftTTIBFfISf9106Wk eGAfUfEmugkdU.Lq6DwBMqQiJ7s9Jy2fRfxAGzq8qV10ltK8Z5vvkQKGTg64k.aJGIS4OEXMWjQb EstwNsU0KO1mbX6dh7dQ1ofnvc9NgDOKP_Mx7aXup8FoiQd6F.ZCbONGl2Li.QmjXldhr21V37J0 phh64zLLT60BaD_FSUs9ImPoI0Xm0lW9JlrIbEz2CP_z2F32C_RgofcK6yaqi628HzcvnQ6sabHY p9T1ADJoiNw2pYeT4bUQNPWJuOuyxwegzaLPiCzJusA4o4_.TprWiSQqUGNUX9FtikiCLQqOxin9 4Y.1sDMusdCwZxCXu1hauBz8OiQ_7Pb7eZKFNKsipLOcWBKdG6GxeH9Epwn6vAepwOFXnDYD7SZv qexVVeu9fwXZtD6UvKl2b2T1NAHG0XNgJljzuP6rnZljAkwZecuypCvkjuAn4OsS8w2OFVh8Ou.I HjygtCtlU49V23VzV5oZhjfHVu0MlRbEPyd_uhSGZkqYdULqiErTV5lfh6W7BOBejzkFEwZj6mtt qZeY5stPEjpFlH0poZoVkw9Wv5j0Vb7ClKRgfV4HrLhtggiLCv49gwNNBoU0VyqEvNrAGsKeUjm. xlAYEuQhR2_UbcCaqIu4n3SHwAGh4OqbDdrdgU0y0Jf_tnEO9JGjYJVTRoRc6QagaXPgOW8RDBid 4Np_A_LA3igCYjQZ4veCDAZpyw2dVs6exczdV7QV6eCKyw4sm6UhM9tD5kPz8eGMzjXDNBZ5P0E7 S3vz3D6qRMuRJhXESkUftco2JrO9ztwiAEkKvHNrY2E7vdl5KiL_vTakNNa0GBpEn8YCQutypUkR B7OSehrVTVIHTnx5pXE5A9VK4RxWrYIHrKtDWBGiIvWdtH9dY85rwXONhKRrCjNmkbZHszbVu3B1 IYIK5fMQMS0fxOxp.Uprlrp10Woqjom6F7SRIcTKNDSh5VUh_hAYw7mPzaUHYQPjPztWtK2y2g0r J8l85KclABQEYpI.J6qE3AD.dpvNcEn3l0FzYQXdDkgmS2YDXujr7t2XJ8TRVOk6wcLIh3OivUH_ xdhsN2XIWidUdlp4B_sHopySBMVp2Oq0aKgyDN9vuNemh0YLrQj9jMZSHBsOHYJTesaMOuWsD4Jy nvKmbjjqXux.Z7s44DP.5VagKA71m3TVHTOz6FK9I3zdqJKNB_FhPly36a_1YmB9NzGyQgoJ2dY4 FgvtNMIqtPFHeMuJv7nDPR2KoFPdEZeGuyKT6uO5iRt0IXoH1mfENCWWhO2exU.X_RolBJG3ssgC Vqw3WiVxL_qNo7Jj5ox2o.fDc.wCmKwghhZiQxUzY7HvB2I85MWEFxSpMvhvApm72iZRNQSb4v0U .w0lmLuGhN79m.EqNPEtOJ4ApO_ellnDujJYJqxoSauXS_MK3h51Raub5heNZA2_RRZjne59kyWa LVMeGOvz8asI4h_MsHXfHmPlVSfXqNAndfOj5QrkgODjFvaF1sUN6BN_6b_I- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Thu, 30 Dec 2021 11:19:05 +0000 Received: by kubenode516.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 56c3fbb7bc759970ab4189c0df576646; Thu, 30 Dec 2021 11:19:02 +0000 (UTC) From: Po Lu To: Stephen Berman Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> <87sfubfzwt.fsf@gmx.net> <874k6rtzy7.fsf@yahoo.com> <877dbm1i1n.fsf@gmx.net> Date: Thu, 30 Dec 2021 19:18:57 +0800 In-Reply-To: <877dbm1i1n.fsf@gmx.net> (Stephen Berman's message of "Thu, 30 Dec 2021 11:52:20 +0100") Message-ID: <87ee5unxwe.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19551 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3264 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52856 Cc: 52856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > Thanks for the suggestion, see the patch below. Since the previous > bookmark handler was the only user of `xwidget-webkit-browse-url''s > `new-session' parameter, I removed that, and took the opportunity to > make some other cleanups to that function, see the commit message. > While testing the refactored `xwidget-webkit-new-session' I found that > the xwidget-webkit-clone-* commands were broken because > `xwidget-webkit-current-url' returned the message instead of the URL, so > I fixed that. And I removed from the doc string of > `xwidget-webkit-bookmark-jump-new-session' the suggestion to customize > `xwidget-webkit-last-session-buffer', since, for one thing, it's not a > defcustom, but more importantly, changing it has no effect, since it > gets set by `xwidget-webkit--create-new-session-buffer' (previously by > `xwidget-webkit-new-session'), overriding any user change to its > value. Thanks, but there are a few problems with this change: > 2021-12-30 Stephen Berman > > Fix handling of webkit xwidget bookmarks > > Make jumping to a bookmarked webkit xwidget in another window or > another frame show the xwidget only in that window or frame. > Adjust xwidget.el code accordingly. Make xwidget-webkit-clone-* > commands work. (Bug#52856) > > * lisp/xwidget.el (xwidget-webkit-browse-url): Remove > `new-session' parameter, since the bookmark handler, which was its > only user, no longer calls this function. Remove superfluous > `browse-url' require from interactive spec and discard the unused > flag returned by `browse-url-interactive-arg'. Incorporate the > code of the now removed `xwidget-webkit-goto-url', since this > function was its only caller. While that might be the case in-tree, external packages and users might be using that parameter -- it should stay. > (xwidget-webkit-goto-url): Remove. The same goes for this. I think it's certain that some external code will be using this function, as the name is rather tempting. I also have some further comments below: > + (progn > + (xwidget-webkit-goto-uri (xwidget-webkit-current-session) url) > + (switch-to-buffer (xwidget-buffer (xwidget-webkit-current-session)))) Since you already define a replacement for `xwidget-webkit-new-session' below that also behaves like this, is there any reason you can't use that here instead? > +(defun xwidget-webkit-bookmark-jump-handler (bmk) > + "Function for jumping to the webkit xwidget bookmarked by BMK. > +If `xwidget-webkit-bookmark-jump-new-session' is non-nil, create > +a new xwidget-webkit session, otherwise use an existing session." I think it would be clearer to say "Jump to the page described by the bookmark record BMK." But I'm not good at writing documentation, so I won't insist. Also, `bmk' should be named `bookmark', or something else to that effect. > + "Return current xwidget webkit URL and display it in a message. > +Also place it on the `kill-ring'." I don't understand why this user command has to be called programmatically, and why it should return the URL. Can't you use `xwidget-webkit-uri' instead? And thanks for the work you've been doing. I really appreciate it. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 10:00:21 2021 Received: (at 52856) by debbugs.gnu.org; 30 Dec 2021 15:00:21 +0000 Received: from localhost ([127.0.0.1]:54235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2wui-0004Cv-VU for submit@debbugs.gnu.org; Thu, 30 Dec 2021 10:00:21 -0500 Received: from mout.gmx.net ([212.227.15.19]:58351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2wuh-0004Ca-Jh for 52856@debbugs.gnu.org; Thu, 30 Dec 2021 10:00:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640876410; bh=h92c7osc//aQUFM0QX8fSNt8sI6it9pVGkdxbLTjIEE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=cSqkUEAIreqC+p1+sZKwadUcY3YS+ylbaScxltrRwHM0UVf+Wb/DyJz5wvH15TxsB iCtBYo64Fy7uSnNghSkknRxWu8KsBQgZ2Lt7ihr9Q2widaYacyOccrL/IwFVvxts8l /JcU8ScmHq/ar+MdtvyR+0vDC+GtRFsOPkSha4+M= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs ([89.246.38.232]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N17Ye-1mJ7k82FFS-012YnK; Thu, 30 Dec 2021 16:00:10 +0100 From: Stephen Berman To: Po Lu Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> <87sfubfzwt.fsf@gmx.net> <874k6rtzy7.fsf@yahoo.com> <877dbm1i1n.fsf@gmx.net> <87ee5unxwe.fsf@yahoo.com> Date: Thu, 30 Dec 2021 16:00:09 +0100 In-Reply-To: <87ee5unxwe.fsf@yahoo.com> (Po Lu's message of "Thu, 30 Dec 2021 19:18:57 +0800") Message-ID: <8735ma16km.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:VvhRyJ18dTKw6D2Qgqx9+PzsPo4bjXYpeT1FiZym5fWKUVqlZtH uratD3vOlNeXVtJoeLIq/978eFrx7DCasDZbBz9B0WTYtT6CQiPUOtdJ4stQNFvkxKCoHUE m/QDUhOrmE+8w1EXDaxEmKo+uVTMVqxx5Jj8f90ABJt/Zbte0Jy9LyBUUbJn8LKEnpHaTiM 6+cEssy2sIfpZMdKRcWVA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:pfyw0QsGw/0=:tLgXdwAlVjBhr6hptv5IWR OlAzZLiGy/M/PoySXDiXMHFUXjJNZRsSPJ5LRCmPSfpZBWu2snSzF0/d4dcc+9QOWQHr71N9b q6JKxASiKU4iDtdddYUytYCjW7fNL/K8wOgEx3mcfizwMni+ZQCaVBHd8+I2pPf6oY9vYKdjp 7LdmMAtiUU8DB51JpZ8vvm31RE0lKh2ow8oDXdAGoWA0J3HLBRqU8qNnx3boDm6l0+3BWuPU2 vE3sArs/wdrmlgV78V6IVn6SSv5Ir8i//G43/qMlnIreITsuFbEw9pZMgwT+wOKAahZCcm5Nt zPJUip1Da4wU/eYWqw/PpbCCvB6DgS4ZJH6Lfv160YO5N+rrIIFHNAv4XCbWQGodc5FHVI+RE 936qwsjGBFXpeR5/8oM+hq/uFxSqiY/P+OU4rWSf9u90aVBhgb8HlzI2V5XPQ4znbTa75FVPb wiquOXf9Y/UmmUyvbsNYWr/a8ohRAUuizTjU4LnIIz97p1Gby4j2jbKdSZ0BFD4iWT8dJquIn m+PsbUuNyMJWV7k0uAJnPEpq5yv7QK/QsZ3aYEmHwPLzyrORJC9aKDRFz+jyDK1Mws4zEpSld kXC+Jy6OsTbQGZN2XfPQ8iXlsSF4VxBiq7dRS8k9MFRLduBp4TebO+Iu1eisoFymS/bn18Sml IHkp87o90lW08OnqjSgjvpUjr8fHnEgXsRTikUAeLsj0ykEpR7oZcslujzjjd3pv75aB+QKMb ghG81dWHKz6GUVzyJjcO1iK8IL8C3sWWClxx+Nb0Jt7dkWl6aY3ZSEZC5B7KhGJTa/4KzSN5d 2aAfjFR8qFPsPW++batkXR+1N6pdByaKj2CpZAcxeocpftwu0+jGOoVjmiyp5eAQUQbY8xOrN djTWHCHdQLpD/yvJOa4lp6FKkx87HShBILmn60Y5g66PGlYF6JFKVxHoUFB3EsYzKpjUzhCOo gyw90J4pTaEyAoYvk6q2mWxKmjF8CcckdUKA28xDE0EYYlDZqtf7PecTVL7b0drH8cavJAtFh mKPuxh1/+N+ZU5R5+NmZjnnaiQ4cC5VzHazYB9OBX8EMGkNR5p+v1S/Oo42/DFMEZUiBl0A4H FV6gAhscDP62gA= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52856 Cc: 52856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain On Thu, 30 Dec 2021 19:18:57 +0800 Po Lu wrote: >> 2021-12-30 Stephen Berman >> >> Fix handling of webkit xwidget bookmarks >> >> Make jumping to a bookmarked webkit xwidget in another window or >> another frame show the xwidget only in that window or frame. >> Adjust xwidget.el code accordingly. Make xwidget-webkit-clone-* >> commands work. (Bug#52856) >> >> * lisp/xwidget.el (xwidget-webkit-browse-url): Remove >> `new-session' parameter, since the bookmark handler, which was its >> only user, no longer calls this function. Remove superfluous >> `browse-url' require from interactive spec and discard the unused >> flag returned by `browse-url-interactive-arg'. Incorporate the >> code of the now removed `xwidget-webkit-goto-url', since this >> function was its only caller. > > While that might be the case in-tree, external packages and users might > be using that parameter -- it should stay. Ok. (The superfluous `browse-url' require can be removed by future code cleanup.) >> (xwidget-webkit-goto-url): Remove. > > The same goes for this. I think it's certain that some external code > will be using this function, as the name is rather tempting. Ok. > I also have some further comments below: > >> + (progn >> + (xwidget-webkit-goto-uri (xwidget-webkit-current-session) url) >> + (switch-to-buffer (xwidget-buffer (xwidget-webkit-current-session)))) > > Since you already define a replacement for `xwidget-webkit-new-session' > below that also behaves like this, is there any reason you can't use > that here instead? This is the code from the not-to-be-removed `xwidget-webkit-goto-url' for reusing the current xwidget-webkit session instead of creating a new session. This is the only occurrence of this sexp, so encapsulating it in a function seems like overkill. >> +(defun xwidget-webkit-bookmark-jump-handler (bmk) >> + "Function for jumping to the webkit xwidget bookmarked by BMK. >> +If `xwidget-webkit-bookmark-jump-new-session' is non-nil, create >> +a new xwidget-webkit session, otherwise use an existing session." > > I think it would be clearer to say "Jump to the page described by the > bookmark record BMK." > > But I'm not good at writing documentation, so I won't insist. > > Also, `bmk' should be named `bookmark', or something else to that > effect. How's this: "Jump to the web page bookmarked by the bookmark record BOOKMARK."? >> + "Return current xwidget webkit URL and display it in a message. >> +Also place it on the `kill-ring'." > > I don't understand why this user command has to be called > programmatically, and why it should return the URL. Can't you use > `xwidget-webkit-uri' instead? Sure. > And thanks for the work you've been doing. I really appreciate it. Thanks. Here's the latest version: 2021-12-30 Stephen Berman Fix handling of webkit xwidget bookmarks Make jumping to a bookmarked webkit xwidget in another window or another frame show the xwidget only in that window or frame and refactor new session code used by the bookmark code (bug#52856). In addition, make xwidget-webkit-clone-* commands work. * lisp/xwidget.el (xwidget-webkit-clone-and-split-below) (xwidget-webkit-clone-and-split-right): Unbreak these functions by passing just the URL to them, not the message displaying it. (xwidget-webkit-bookmark-jump-new-session): Adjust doc string, rephrasing and removing a customization suggestion that cannot take effect. (xwidget-webkit-bookmark-jump-handler): New autoloaded function. (xwidget-webkit-bookmark-make-record): Use it. (xwidget-webkit--create-new-session-buffer): New function extracted from `xwidget-webkit-new-session'. (xwidget-webkit-new-session): Use it. --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: xwidget.el patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/xwidget.el b/lisp/xwidget.el index ce9839ebd3..1f92966492 100644 =2D-- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -138,7 +138,7 @@ xwidget-webkit-clone-and-split-below Get the URL of current session, then browse to the URL in `split-window-below' with a new xwidget webkit session." (interactive nil xwidget-webkit-mode) - (let ((url (xwidget-webkit-current-url))) + (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session)))) (with-selected-window (split-window-below) (xwidget-webkit-new-session url)))) @@ -147,7 +147,7 @@ xwidget-webkit-clone-and-split-right Get the URL of current session, then browse to the URL in `split-window-right' with a new xwidget webkit session." (interactive nil xwidget-webkit-mode) - (let ((url (xwidget-webkit-current-url))) + (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session)))) (with-selected-window (split-window-right) (xwidget-webkit-new-session url)))) @@ -531,24 +531,31 @@ xwidget-webkit-save-as-file ;;; Bookmarks integration (defcustom xwidget-webkit-bookmark-jump-new-session nil - "Control bookmark jump to use new session or not. -If non-nil, use a new xwidget webkit session after bookmark jump. -Otherwise, it will use `xwidget-webkit-last-session'. -When you set this variable to nil, consider further customization with -`xwidget-webkit-last-session-buffer'." + "Whether to jump to a bookmarked URL in a new xwidget webkit session. +If non-nil, create a new xwidget webkit session, otherwise use +the value of `xwidget-webkit-last-session'." :version "28.1" :type 'boolean) (defun xwidget-webkit-bookmark-make-record () - "Create bookmark record in webkit xwidget. -See `xwidget-webkit-bookmark-jump-new-session' for whether this -should create a new session or not." + "Create a bookmark record for a webkit xwidget." (nconc (bookmark-make-record-default t t) `((page . ,(xwidget-webkit-uri (xwidget-webkit-current-session))= ) - (handler . (lambda (bmk) - (xwidget-webkit-browse-url - (bookmark-prop-get bmk 'page) - xwidget-webkit-bookmark-jump-new-session)))))) + (handler . xwidget-webkit-bookmark-jump-handler)))) + +;;;###autoload +(defun xwidget-webkit-bookmark-jump-handler (bookmark) + "Jump to the web page bookmarked by the bookmark record BOOKMARK. +If `xwidget-webkit-bookmark-jump-new-session' is non-nil, create +a new xwidget-webkit session, otherwise use an existing session." + (let* ((url (bookmark-prop-get bookmark 'page)) + (xwbuf (if (or xwidget-webkit-bookmark-jump-new-session + (not (xwidget-webkit-current-session))) + (xwidget-webkit--create-new-session-buffer url) + (xwidget-buffer (xwidget-webkit-current-session))))) + (with-current-buffer xwbuf + (xwidget-webkit-goto-uri (xwidget-webkit-current-session) url)) + (set-buffer xwbuf))) ;;; xwidget webkit session @@ -796,37 +803,44 @@ xwidget-webkit-adjust-size-in-frame (add-to-list 'window-size-change-functions 'xwidget-webkit-adjust-size-in-frame)) -(defun xwidget-webkit-new-session (url &optional callback) - "Create a new webkit session buffer with URL." +(defun xwidget-webkit--create-new-session-buffer (url &optional callback) + "Create a new webkit session buffer to display URL in an xwidget. +Optional function CALLBACK specifies the callback for webkit xwidgets; +see `xwidget-webkit-callback'." (let* ((bufname - ;; Generate a temp-name based on current buffer name. it - ;; will be renamed by `xwidget-webkit-callback' in the - ;; future. This approach can limit flicker of buffer-name in - ;; mode-line. + ;; Generate a temp-name based on current buffer name. The + ;; buffer will subsequently be renamed by + ;; `xwidget-webkit-callback'. This approach can avoid + ;; flicker of buffer-name in mode-line. (generate-new-buffer-name (buffer-name))) (callback (or callback #'xwidget-webkit-callback)) (current-session (xwidget-webkit-current-session)) xw) - (setq xwidget-webkit-last-session-buffer (switch-to-buffer - (get-buffer-create bufname)= )) + (setq xwidget-webkit-last-session-buffer (get-buffer-create bufname)) ;; The xwidget id is stored in a text property, so we need to have ;; at least character in this buffer. ;; Insert invisible url, good default for next `g' to browse url. - (let ((start (point))) - (insert url) - (put-text-property start (+ start (length url)) 'invisible t) - (setq xw (xwidget-insert - start 'webkit bufname - (xwidget-window-inside-pixel-width (selected-window)) - (xwidget-window-inside-pixel-height (selected-window)) - nil current-session))) - (when xwidget-webkit-cookie-file - (xwidget-webkit-set-cookie-storage-file - xw (expand-file-name xwidget-webkit-cookie-file))) - (xwidget-put xw 'callback callback) - (xwidget-put xw 'display-callback #'xwidget-webkit-display-callback) - (xwidget-webkit-mode) - (xwidget-webkit-goto-uri (xwidget-webkit-last-session) url))) + (with-current-buffer xwidget-webkit-last-session-buffer + (let ((start (point))) + (insert url) + (put-text-property start (+ start (length url)) 'invisible t) + (setq xw (xwidget-insert + start 'webkit bufname + (xwidget-window-inside-pixel-width (selected-window)) + (xwidget-window-inside-pixel-height (selected-window)) + nil current-session))) + (when xwidget-webkit-cookie-file + (xwidget-webkit-set-cookie-storage-file + xw (expand-file-name xwidget-webkit-cookie-file))) + (xwidget-put xw 'callback callback) + (xwidget-put xw 'display-callback #'xwidget-webkit-display-callback= ) + (xwidget-webkit-mode)) + xwidget-webkit-last-session-buffer)) + +(defun xwidget-webkit-new-session (url) + "Display URL in a new webkit xwidget." + (switch-to-buffer (xwidget-webkit--create-new-session-buffer url)) + (xwidget-webkit-goto-uri (xwidget-webkit-last-session) url)) (defun xwidget-webkit-import-widget (xwidget) "Create a new webkit session buffer from XWIDGET, an existing xwidget. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 19:57:16 2021 Received: (at 52856) by debbugs.gnu.org; 31 Dec 2021 00:57:16 +0000 Received: from localhost ([127.0.0.1]:54826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n36EN-0003X5-Ku for submit@debbugs.gnu.org; Thu, 30 Dec 2021 19:57:16 -0500 Received: from sonic308-10.consmr.mail.ne1.yahoo.com ([66.163.187.33]:36920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n36EL-0003Wk-Cd for 52856@debbugs.gnu.org; Thu, 30 Dec 2021 19:57:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640912227; bh=bcQrB9W27TaC96VoerbTWUKSfQr8wFBBhcWEWY7F2yM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=j5/fgNbB47wMFu54yFMSmV6U/qRtd2Gplxfx+Q+3+5j9jQ5iJWtH//g3sbMnOh8bDamxhNVFv33f0mfxZr5MOYW2DbRTi0020cHvzIPUVUv24sfQzpvYkIHOTPQjfrCgg4pBKOlpNOgaz11ELkJlKGCJZwGpGEQcFSS5HZPig99re+B+BBxnrn1UC2ZPxbd0cJ6O10NkQfH5Nh5/+3gieRNAUs9CMEJiZYp2hCdM6ek8h9NZjyv+P2KgbI7NEX7N/n/gfKvuZ33V6bkOs80VDLXbqfKqdpmmh4bvZLwubPjSXCoWTZeV60Bcw5t/s+THEuCtpY2BiIT0cLxJbP9qbw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640912227; bh=ZUH91nkzXzo844VmkAbfh7YcR64N26wQYjZSug4xO5Y=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=k8hvx5dd28LwUvEMCLfpt/sH4PYi2tDyf87A2SpVp6ycQtMWAHnNxLBo0WY8Uuz7V2g8YP9lBLMxEOb8DOOlRj01+gq/hzJEvBjMUqYfgEIYWMnMB1gmDN46LGE06qX+TTrB1NPgFAYJF6fCc65AO0Jy3U4WcmsyGMAE3uJdGxXp/9RRs5oJ69ruKcl1zG17FmZvWXHkwlPLCvK8AzndStLxXYBEwhiaS7ijMus4kBDIeZHQTKE9HeX5+93C+EzfOTG8iK15OnoD8F5pL7L29E2IRKZhkV1irRX93mJXHOD4KcbWOTtBGEEJfZyCDKSSqn0QRFjUxdbgjDjtM4hv6g== X-YMail-OSG: JDOQ0G8VM1mc2gbLsaXDMgHVDHJDJO5NxIXLORBoM27DvP_c.B8fSHyUlPdNPp2 2khDYRTPX25No18Y8RQZX9LjjyyB3qIrnlyKSynmfsdV5ZXsplbnm8MXQYq0f7L15vu0YGcqmirf Fw519F4pUSOyRw3KbkQXi6l3OgkAh8n3CAf6_5t0hVo1xta6vzfOQF9sdJeQmlMnnIC5Qrk8YC0t 4Zq4AsK0quFSS19koMAtYTXRPg2Gr5ac4uK.QfF.RlYtoIHTtvR_CszYI8peDscq5y3VuOfraKrd k_r6Gs_ej.GUSP6H8mUzIWta.riNo31M16jqIEuF.Mpg8dDhuGxr0.SJXvJYsBWhgSFenRJoeMrV Sn_uUj4nj0DNB.HM7cqW2iXV2umgI2G.4sS_70uHSZEKCsOw0jJve4toyH4.51UJap40GlrWgSSd Np_cxrLUMx_r2bLxvl_tInH1Y1ysIGP1oRDzpZHIlsaHo4G2NOj99bmKsnCtfFZC21AKBu4etx_9 y6wXPbziQdIROfMuBe7UquuVJntpxONogtmaobSPb1kqiCGopO186jh4S_N0APemJsv2NirFFBYr 85dV7IURFxhgo1j5rndbNeJCjAf_8Z9LWlsY4IRn__pmwLVs1jfmivqX0Wcibd1wOklWoGTklIw0 _nOEu2xYaz0uJAv3ECfo1SvAt4A_HmA9g.Y.CmcIr1OvYsa7Ixf30etQbY8QSrghLCvSljgwXrD2 wrRIo9jyuHM5W9LSFnJ4ZdPxCv1pX6G3lYnd93B.IEt5bQmzhpC70Yz77.GDe2EWVBpYDf0eraOK kyF6Ml5RWKGfGpYbBC4bqFAjGnCcAlIppRM5lF81FOaAHerfmkYO.OF1V.NWdJh_KMogME11JYln nWDjvoSrUDz71tVWhqlspfrmYP_Nr2c0apwNfuCPXPZC6nTVJAQBow0atlwDyeyAETiQfEN2NGrr _ZbiJtizv7eCjBIptBc.Xg8UZq599xE8E40w6u4Ec2frBF00cQQ2Gxp3Lxti72ZCmCzqHHHmK2Es kIW0YHl8_C6Z73eNR5Bgk6vpF.AVeslo5PHHDO3AK2HDm9pN4am7nWG1Jbgfbv8Mclj30QOP6O_A lqM7Gn_xNKj1Wp5Ns3bXknHOEe_eZUwH6mMy8lWdR26Veio9Yf9ynkD24nzy4KKg4O4BSHliIRV5 _cCOzathWLJOLzotu1mHWAT5iWNNV3Ut.KkicWf9mtIzMvCJrmt2e89EV4BjN5HFf4tz.HZGwdF8 u_npkJWqj9ydJ.qP22zHEJ3M1zybITZ84D.2ISTyJ9WwVWETKBYGkAQv0EQY0jOmLdEhm6oKpplH CTR0_UqwQrgByya.C6r7O0ZqeM3gWAyYkgX20oJcgHsNCodoy0ap2990NgeLUCoi9haTTKeGc5D7 kJXXYUfljthBAPEMabAkg81VxBQMOeropBJ5wG9jrURYSaGCXnIaj9UVvc.fXLIgopQ0cb3mhCFf 42zro.kF4m1dcviJ71UeMdioaKWEMKK43Msgd2Z9j88ng5yLFanUTiGC2CbnZptsZ7VjMCLikwkQ UFuN0bxqVGaVYRxrCwLdeN1TRDe4Ny8WokKLDMptk9BVK3W5DMgPLVec2N..GGV.0NJNEYbXeFYn ofdWOmlZGooPL2ind8Rpzn7h_OO1tvSLA1rNbTeSJyYhNXQNE0PBqsQplbx_8nZB4oYrpBVhUgUo dOlW7Ei8P.vsp4TSfCVyVAhcEquRh0veCaAa.RquNyuBN4fjXoP9JLPQeE8_IBAS2fnzb.3gVQsK Cv.6RmghXP96_1Dhpdvlgb2KtC9K3vEOR8vI.Jv21AeZYKahG5Qg1DotaO6sxZFhHpqWwTieZXew EEs368d8.udz0jOG8qSS.yxIXW5kgzU4OQ8Ho4pv.yOmXzdsqCtpG6q.hjIKyO50nlCHDQTK5B9b IZWjmLJE7Sx.vJKcPDp32jTDBi8bIJPX8.iD2ty8FqULkI9RVyYr9eiKykwtBJbCVFZBcF9THSnM xgVmh3QNqEU1igoIjUuTWpqnVUAilvq8yeYHn8stdEVkF2Q.6PDR596mgrEn_1E_lxj3DJqcLla3 pvVmWYwID_u8avtDs8x1H6xLVTEGCJIp4m7RrVET8CoUvTRFZXdThKh2xDs7WKTsZ1TGdw3t9sXW sicCKX07wwOS8QmNB7Qvt8JXKcqHo6I_IZEYwuCuXgpDHCp3dE8ndwjB8RY_BGj9c8gzPiPd6s1K kqfx3vjnHTLKhloe_Zge2AsWG7CZ1JsbMs6tvfNe.tvqXhOCe99zs6MQKjypg X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Fri, 31 Dec 2021 00:57:07 +0000 Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID ead3cf1019ae8f97012b63ce791cb0dd; Fri, 31 Dec 2021 00:57:03 +0000 (UTC) From: Po Lu To: Stephen Berman Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> <87sfubfzwt.fsf@gmx.net> <874k6rtzy7.fsf@yahoo.com> <877dbm1i1n.fsf@gmx.net> <87ee5unxwe.fsf@yahoo.com> <8735ma16km.fsf@gmx.net> Date: Fri, 31 Dec 2021 08:56:58 +0800 In-Reply-To: <8735ma16km.fsf@gmx.net> (Stephen Berman's message of "Thu, 30 Dec 2021 16:00:09 +0100") Message-ID: <87mtkhmw11.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19551 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 7945 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52856 Cc: 52856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > How's this: "Jump to the web page bookmarked by the bookmark record > BOOKMARK."? Sure. > Thanks. Here's the latest version: Thanks, LGTM. Have you signed the copyright papers yet? > 2021-12-30 Stephen Berman > > Fix handling of webkit xwidget bookmarks > > Make jumping to a bookmarked webkit xwidget in another window or > another frame show the xwidget only in that window or frame and > refactor new session code used by the bookmark code (bug#52856). > In addition, make xwidget-webkit-clone-* commands work. > > * lisp/xwidget.el (xwidget-webkit-clone-and-split-below) > (xwidget-webkit-clone-and-split-right): Unbreak these functions by > passing just the URL to them, not the message displaying it. > (xwidget-webkit-bookmark-jump-new-session): Adjust doc string, > rephrasing and removing a customization suggestion that cannot > take effect. > (xwidget-webkit-bookmark-jump-handler): New autoloaded function. > (xwidget-webkit-bookmark-make-record): Use it. > (xwidget-webkit--create-new-session-buffer): New function > extracted from `xwidget-webkit-new-session'. > (xwidget-webkit-new-session): Use it. > > diff --git a/lisp/xwidget.el b/lisp/xwidget.el > index ce9839ebd3..1f92966492 100644 > --- a/lisp/xwidget.el > +++ b/lisp/xwidget.el > @@ -138,7 +138,7 @@ xwidget-webkit-clone-and-split-below > Get the URL of current session, then browse to the URL > in `split-window-below' with a new xwidget webkit session." > (interactive nil xwidget-webkit-mode) > - (let ((url (xwidget-webkit-current-url))) > + (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session)))) > (with-selected-window (split-window-below) > (xwidget-webkit-new-session url)))) > > @@ -147,7 +147,7 @@ xwidget-webkit-clone-and-split-right > Get the URL of current session, then browse to the URL > in `split-window-right' with a new xwidget webkit session." > (interactive nil xwidget-webkit-mode) > - (let ((url (xwidget-webkit-current-url))) > + (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session)))) > (with-selected-window (split-window-right) > (xwidget-webkit-new-session url)))) > > @@ -531,24 +531,31 @@ xwidget-webkit-save-as-file > ;;; Bookmarks integration > > (defcustom xwidget-webkit-bookmark-jump-new-session nil > - "Control bookmark jump to use new session or not. > -If non-nil, use a new xwidget webkit session after bookmark jump. > -Otherwise, it will use `xwidget-webkit-last-session'. > -When you set this variable to nil, consider further customization with > -`xwidget-webkit-last-session-buffer'." > + "Whether to jump to a bookmarked URL in a new xwidget webkit session. > +If non-nil, create a new xwidget webkit session, otherwise use > +the value of `xwidget-webkit-last-session'." > :version "28.1" > :type 'boolean) > > (defun xwidget-webkit-bookmark-make-record () > - "Create bookmark record in webkit xwidget. > -See `xwidget-webkit-bookmark-jump-new-session' for whether this > -should create a new session or not." > + "Create a bookmark record for a webkit xwidget." > (nconc (bookmark-make-record-default t t) > `((page . ,(xwidget-webkit-uri (xwidget-webkit-current-session))) > - (handler . (lambda (bmk) > - (xwidget-webkit-browse-url > - (bookmark-prop-get bmk 'page) > - xwidget-webkit-bookmark-jump-new-session)))))) > + (handler . xwidget-webkit-bookmark-jump-handler)))) > + > +;;;###autoload > +(defun xwidget-webkit-bookmark-jump-handler (bookmark) > + "Jump to the web page bookmarked by the bookmark record BOOKMARK. > +If `xwidget-webkit-bookmark-jump-new-session' is non-nil, create > +a new xwidget-webkit session, otherwise use an existing session." > + (let* ((url (bookmark-prop-get bookmark 'page)) > + (xwbuf (if (or xwidget-webkit-bookmark-jump-new-session > + (not (xwidget-webkit-current-session))) > + (xwidget-webkit--create-new-session-buffer url) > + (xwidget-buffer (xwidget-webkit-current-session))))) > + (with-current-buffer xwbuf > + (xwidget-webkit-goto-uri (xwidget-webkit-current-session) url)) > + (set-buffer xwbuf))) > > ;;; xwidget webkit session > > @@ -796,37 +803,44 @@ xwidget-webkit-adjust-size-in-frame > (add-to-list 'window-size-change-functions > 'xwidget-webkit-adjust-size-in-frame)) > > -(defun xwidget-webkit-new-session (url &optional callback) > - "Create a new webkit session buffer with URL." > +(defun xwidget-webkit--create-new-session-buffer (url &optional callback) > + "Create a new webkit session buffer to display URL in an xwidget. > +Optional function CALLBACK specifies the callback for webkit xwidgets; > +see `xwidget-webkit-callback'." > (let* ((bufname > - ;; Generate a temp-name based on current buffer name. it > - ;; will be renamed by `xwidget-webkit-callback' in the > - ;; future. This approach can limit flicker of buffer-name in > - ;; mode-line. > + ;; Generate a temp-name based on current buffer name. The > + ;; buffer will subsequently be renamed by > + ;; `xwidget-webkit-callback'. This approach can avoid > + ;; flicker of buffer-name in mode-line. > (generate-new-buffer-name (buffer-name))) > (callback (or callback #'xwidget-webkit-callback)) > (current-session (xwidget-webkit-current-session)) > xw) > - (setq xwidget-webkit-last-session-buffer (switch-to-buffer > - (get-buffer-create bufname))) > + (setq xwidget-webkit-last-session-buffer (get-buffer-create bufname)) > ;; The xwidget id is stored in a text property, so we need to have > ;; at least character in this buffer. > ;; Insert invisible url, good default for next `g' to browse url. > - (let ((start (point))) > - (insert url) > - (put-text-property start (+ start (length url)) 'invisible t) > - (setq xw (xwidget-insert > - start 'webkit bufname > - (xwidget-window-inside-pixel-width (selected-window)) > - (xwidget-window-inside-pixel-height (selected-window)) > - nil current-session))) > - (when xwidget-webkit-cookie-file > - (xwidget-webkit-set-cookie-storage-file > - xw (expand-file-name xwidget-webkit-cookie-file))) > - (xwidget-put xw 'callback callback) > - (xwidget-put xw 'display-callback #'xwidget-webkit-display-callback) > - (xwidget-webkit-mode) > - (xwidget-webkit-goto-uri (xwidget-webkit-last-session) url))) > + (with-current-buffer xwidget-webkit-last-session-buffer > + (let ((start (point))) > + (insert url) > + (put-text-property start (+ start (length url)) 'invisible t) > + (setq xw (xwidget-insert > + start 'webkit bufname > + (xwidget-window-inside-pixel-width (selected-window)) > + (xwidget-window-inside-pixel-height (selected-window)) > + nil current-session))) > + (when xwidget-webkit-cookie-file > + (xwidget-webkit-set-cookie-storage-file > + xw (expand-file-name xwidget-webkit-cookie-file))) > + (xwidget-put xw 'callback callback) > + (xwidget-put xw 'display-callback #'xwidget-webkit-display-callback) > + (xwidget-webkit-mode)) > + xwidget-webkit-last-session-buffer)) > + > +(defun xwidget-webkit-new-session (url) > + "Display URL in a new webkit xwidget." > + (switch-to-buffer (xwidget-webkit--create-new-session-buffer url)) > + (xwidget-webkit-goto-uri (xwidget-webkit-last-session) url)) > > (defun xwidget-webkit-import-widget (xwidget) > "Create a new webkit session buffer from XWIDGET, an existing xwidget. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 31 04:30:08 2021 Received: (at 52856-done) by debbugs.gnu.org; 31 Dec 2021 09:30:08 +0000 Received: from localhost ([127.0.0.1]:55092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3EEi-0002vC-E8 for submit@debbugs.gnu.org; Fri, 31 Dec 2021 04:30:08 -0500 Received: from mout.gmx.net ([212.227.15.15]:40469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3EEg-0002mI-Nv for 52856-done@debbugs.gnu.org; Fri, 31 Dec 2021 04:30:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640942998; bh=0julmp7NIHB6sWoG16g6kTSQWGjatM3ab+9mxWdsNvE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=P4b3sZJ7hS1I2oWiA6Uuv8sY8XFaei7u4t5/LH/Sd2CoDaBGpKdltKgcA5Vtf2GzX XSFQKpYQ2hOWgaCpmQZQcVzAcvoFIISbYh6FckwKGh6PV/Nu+SHEQXEOLp+mXMvH/F HiBiPxRC6BBCBw/O0bqTNbTY4iqiadAONWrgVmfQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs ([89.246.38.171]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MryT9-1mgJU32zWH-00nvjX; Fri, 31 Dec 2021 10:29:58 +0100 From: Stephen Berman To: Po Lu Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> <87sfubfzwt.fsf@gmx.net> <874k6rtzy7.fsf@yahoo.com> <877dbm1i1n.fsf@gmx.net> <87ee5unxwe.fsf@yahoo.com> <8735ma16km.fsf@gmx.net> <87mtkhmw11.fsf@yahoo.com> Date: Fri, 31 Dec 2021 10:29:57 +0100 In-Reply-To: <87mtkhmw11.fsf@yahoo.com> (Po Lu's message of "Fri, 31 Dec 2021 08:56:58 +0800") Message-ID: <87bl0xazqi.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:YAUbDUxtKJ+zD8Yq+BSYESJ65gh2l3K4hP/GakuS23vNHK0ybiY fZY47+kophF2cVWYKHTraT4IsV1QrqY54MvfW4VUliRvVPwpgtZEqwaCVeizsX9HOrgB0YA ekhSBHsp3DBu01DsE/zl5klcayXD6uDvf6Gy2fvAAMfjpQnLNstO5Hv6QqfVnB4KzcjSnMo gq4vbJHkWTxcNvmIBr+cQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:pPLTEIiGINA=:ihtU0nbnXJi45pr0P+8CI9 R/G/gFwWQb68jx64uqsXNrt4lQjiVXmUYZvvm7vb9EPy4FjvfHWrITXnoWQdWl4DOoii9MFLA 2eFakmz/levs824CoQxIEhLz4jEiV3qnhZTjag5Np57Gdqyt0JX9yEUoPAjRjLM3lL5lk7QIw +iMhaSVWZewTkjnK1LoeGY6Ehq34Np2MrS1Y04Vp0vEG5f4bxQls1W8vCi4lI9T0QHUsf3JDu uOmVRwNWAkcRIFvImQNKLI3WRKNcxzowisRfaSWWdL6FKaY2gzEK4HFX9xmkYiHxzn+eac5Hs phGonQeP5beYApHYrMazag0HKoUFvncWddTVBCN2TCTXWpdcPhI2J4/mSsf3ZfbypHNeGjuYM PorhVFFXFk3kALonnb2ILoW6E37YxMtPBQYsvtExred9xcTKUUc2V/VhBZ5bYkRymmNnuQLs/ d7DgAISxV8Msz7L2N4L9FzbljOWK+NHbFlFR2m6dgDUImNOGm69FVKou5GRnJUVvKwFClshvj ks9dUn+dkX6GM8Ga4zcfsh3aHvI68ULCPBVMltEwShe5VOSpsofbedGcK6oGK2dB9EGuT6X7u PJJFa2tLO/hADvye8+DpgFNViz322jmi494udWXsfj3kUN75XpIYKaP+dPqbT+PIW5DnIxu3l eZmUjqhp3zkbcapbJto3OYa2ldkeTSHi01BOtOV/pR1bBk5ePrxGkaCQIvTejUFjNFi9Oafvh DrANSRTbAlJVDtYB/vH1aPj9002plmAGqSqOXiZtONm0YpRedq6F2Oo6Rg8Rx3Y9ibdjS4L5w rdJb+9CXGDMTAFDxeSkd6ojmZRyHVFJs7Dr4wfwufpAOjx09uxqVMdQKf56VnC7FI6v3cfL+V 6zzy6FsLu9htSA1NH6hyIPuagMlRLyp4pc1xUGluQk1WzhFqSylxhLJcZcVeyQ2k2X/lkAJCs 1B71tUmF8c3opv572UuYl0wK3MzqvW17uygqAThgRmY9FUBrQV/z8OIS5Lx46ldH1UyXV4Wio s0TELDjS/Pd0S7AMaWh44W1aoBZLgQxNCbjp6z1cpnfgHGW0oz5PHNnsoWDEwC9+07y3qhSTX 53MJ2yqEUZgWEM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52856-done Cc: 52856-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 31 Dec 2021 08:56:58 +0800 Po Lu wrote: > Stephen Berman writes: > >> How's this: "Jump to the web page bookmarked by the bookmark record >> BOOKMARK."? > > Sure. > >> Thanks. Here's the latest version: > > Thanks, LGTM. Have you signed the copyright papers yet? Yes, and I also have write access to the Savannah repo, so I went ahead and pushed the change to master as commit 95ee6e8b90 and am closing the bug. Thanks for your feedback and advice. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 31 04:46:13 2021 Received: (at 52856-done) by debbugs.gnu.org; 31 Dec 2021 09:46:13 +0000 Received: from localhost ([127.0.0.1]:55114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3EUH-0005Wk-E8 for submit@debbugs.gnu.org; Fri, 31 Dec 2021 04:46:13 -0500 Received: from sonic317-34.consmr.mail.ne1.yahoo.com ([66.163.184.45]:40963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3EUF-0005WR-H2 for 52856-done@debbugs.gnu.org; Fri, 31 Dec 2021 04:46:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640943965; bh=NlARAtuwVmEXkUB1PoCFhbGFxodbBHO8rRuCOZpTA/c=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=PUbm/cekpTFsJOHLSvOqO/nrjitSp45ZtiPAt9GLUFMBjrVN9RW9lmk8Mx/wGIEmb4Ae7eKKa2VFDAfRJGuX2DSIB6P2WAV+8t/7bidkmvT0nckvUG52iqXh2okkMnWkSbql/8wRRtMR/iuVGlpXiaipBOvKL2mbzpIBtOQLPrSeMNQl06af8nu1A/952nO69Y+GJ4vApkXk+qiydE88waQZ3AJ0eYPAwkmsBjzw8+9aJBFpD1JJm0g34Wy2Y7YLJRcUATZV/HKxcz6s46ORRBC9evmJfRhn8GG7t+1CKGOvQ9P8rCKTPKlhAgbRMZH9ETshIC1ax2wpnVTEsCufYw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640943965; bh=kj3I91UB3Hgqw62yGUH/6Y9L0F/KDN1X054pdKzfHUq=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XMFcbpGp6foyVwxxbTYubja6JvF356aCqb6nmR+6ny0qfsgUkv2xJNqtTTZKrOtmfbrGR0kAJzvZDBoa9JxrGPp/pw+209BznU/CIivfdufG8cU4xGjbl03xWtwS52HG+ezlx1TP6W21i6otKsKwezsW2naBcXe3zzgqcRvrr9X39dIrgYOfO9vVH4WKmOxpbNo8gs5typgGfEquJjknKOGrOAyIXfp1HGbgR53lJyj9Lgr4Yo3mweAA/EzKvvzZXrlJi+OBovL6TH+i8Oo8Xux93XXtpWgQR06+vKNpoEt6mlv0Sf2+Rg5tDeXIB/ED7bfUlhAFXV2CZOpIYJzowg== X-YMail-OSG: Q2pPqewVM1njr3WTFB.fypYlgRsiHWXG3.4ATDE2b7ZwO6buFwBsgmvVenT4IDw plMmVfCp6fKu5cFGtkfthR_yKe56vHHSAmYN0oNcDo1wj0EYBK74ZJ1t.pe36qtsli3TO7lg4np8 tlSJ9NFmnJ.EamoTZN_z8m7SEcCS7wFS_OaMZCLbDmtGCl.5XdPGPVSenbkl_paM2DFeC3SqCm61 W00uXhQXA9zpQd4yN8w0P6Hdg.gbSDSdEfw28e54.iP6yGoc9e0XjRRf0dp_PdN2o3DVmYZrcc.u zw1MSlvJA.XOR4e0rfR4E5kgBc3Q2UKuRnnXtkYRUrx4h1ODyR92MLl_4b1bI1H0OND5noSaj68k yFiM3y02YHEIv3PlB07QtMCi1gYRnzXpyH6vKFy05HonJGBJPiIQC5MbY6nWKnF18SOpvWJmFyOo YhJv9rIo9UopSKquusdWUs9xZt5C5nsztIGOvtaGTRGcc9LICgShDQLAhfOD93W8EdpoPuZE1Ooe iQeZRf0JSp0CoioiZRrHDO_Nbg3sq7f0Nmq0Np8HHZblHxUV7fW55bz2eTX_LHdb_L7CFZZYWXT. OjMmcD6bblTxy.vAEibIF85_4RwfwvzuSVEDs9N5.3YeWq4vjJ_XsCfz2Mp_9eEUjr8AQS9FFWTq u4DMWN3cpRO8yeNiW8bOswb3tondc51ORGiwNFg6nuH.QyjxTGESCx_3FOHki0ltV.TTyx9xZcnh _RcANYioZedNOmlfwFwqbkenwYK0MnS6Np_Uk8BKExW1zfhVOhGWenzyKbYqktwl.t1Jk.X4XBUy 6WIyQ5oJBwv42I6eTBgZYLdoZIfPu_zAmkNcrlFSl0Ho95zEuloZEq_EzGzqaH1pjqbBJjk45QOC pta1Zs.Zfdh4DaYf.ZpZRDTm3FUQJwNvuaDYCBgboH.9eN0CEPIbdHIIhHCEKn_S43qNZ880gVvy Uw245sGJ9S8Ta7XtaCYt45K50p6J9.J_.QW209WJ_a_QWYUqJ8z6eoqEBuXKW07GKJGer.aWjahL enmj37LNTxG8tUrsJtxSt8dox16w9h_enLhO7zMxsKeLPIBro5vPqed.5LAKvoGdVh7Kmi21xgxS fk5ZXX6vKGgAqB6EzGemlK95FJRAOs3ziqDDcSuqvZyG_MS1_mKvzqd8fiU7DzIITrZ9t.bnMtcO cvv_DzC_HexGgdX7q.YQJARf5rHRrwX4.82vgUuH11.biSXJeElFtjck3eh1plBpigfM13BXAT54 tlk9e.Sm42IAqzZden8gZyCjuAErA1mmmeyZGfxGAUNIjS3n2hTPBdSGJ4w15m97pw6ZtyDMDRyV v6WAOc71k9GuYFAoIzZIBakC5HK._ZSKo5dfV8LTP9UXjIkx4GMUQHl3EWImhMAze0KSmk9ZYWe4 2s9cSqtu_PXOW71QUpuf_BS1TUToAeaLD6MRw5E4ZAhJ2tKgGSmdDneBUX14omeTptOIBwCLZWzl VIsbuFVDWHXieyhHtQxv2EJMVUkm6NeRMeL5V92w7Q5dp818YkE.P25FEifSAODhnzzhoqQrwGK4 yUSsOWTUzTg6wCwRwz8ZzvaM3zc1wMlVKf5s_Dz6FYVAiYQ3iuO7RJDJEL55xb7L2Cc.TIjirCH_ btqqxX3zU2AnVpiXI0yjmIrSr4kWeFcxfAAyp7JTTdv2sjDl_J_JwnFZO09_uRAcrp05.1Nf2mDp ez4yUoT702yt9A1KTdmCRh8MC7vr1QcxyxSBLx_tNDhTeIFjHaZKDEgNd90b5K.u4PcEK6gIBGTd iYltpKCZ3gdK.jYPSSG329lnNiBh0krGLbYd9Rl9sS2ZOzGfAzn5vfl4c1Smr2Mcd10m2fSJiC2Z R3qK0KXuXgHWYijwqbLwbdNTlUO4tiD8VgLBrV5ZQYTlikFa9Rd1T1U7TFwOMQgZHxon.R71pQ5Q cIhssvGXJQUTfBJDfgDB8w77YZ2ZZuNz2Ikw5od_BLd9tR5YjApZhaHtEvTVNWsQqQLw8sJJIf2f 4V_JBjL2wceGDh4B6zv9W_COLSena3RnTkLaJxu6Pq0nC6J4ktFVV.uNXfQTzOJFd_GnJ8JsdA8Q egK34fbnMyU..2DsI1_wH4MZZy8cMZiKD7KZxA6cPEZDwvlwDVXHu3XjXFS0mTS0y28Y3y6OV8hL MAGo.NTZaDMlbTsZYr1UlARAMorrjYtHp1xtCnXAPAqp7amyjtFGmtGGFiws8EMLbYNiP4wnIdwf Yl3uS1ycUwf84PBiNflaU9JfYApnIdOCvgjra_0OKZORdqCSNdlNN.A-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Fri, 31 Dec 2021 09:46:05 +0000 Received: by kubenode502.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 897d5469d1f70ecb98e9884ad444d4fa; Fri, 31 Dec 2021 09:46:03 +0000 (UTC) From: Po Lu To: Stephen Berman Subject: Re: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> <87sfubfzwt.fsf@gmx.net> <874k6rtzy7.fsf@yahoo.com> <877dbm1i1n.fsf@gmx.net> <87ee5unxwe.fsf@yahoo.com> <8735ma16km.fsf@gmx.net> <87mtkhmw11.fsf@yahoo.com> <87bl0xazqi.fsf@gmx.net> Date: Fri, 31 Dec 2021 17:45:58 +0800 In-Reply-To: <87bl0xazqi.fsf@gmx.net> (Stephen Berman's message of "Fri, 31 Dec 2021 10:29:57 +0100") Message-ID: <87y241jeeh.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19551 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 251 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52856-done Cc: 52856-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > Yes, and I also have write access to the Savannah repo, so I went ahead > and pushed the change to master as commit 95ee6e8b90 and am closing the > bug. Thanks for your feedback and advice. Thanks! From unknown Sat Jun 21 10:36:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator