GNU bug report logs - #52832
[PATCH 1/3] gnu: Add android-platform-frameworks-native-headers.

Previous Next

Full log

Message #28 received at 52832 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 52832 <at> debbugs.gnu.org
Subject: Re: bug#52832: [PATCH 1/3] gnu: Add
 android-platform-frameworks-native-headers.
Date: Sat, 15 Jan 2022 22:36:34 +0100

Hi,

Some late comments:

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> * gnu/packages/android.scm (android-platform-development, etc1tools):
>   New variables.

[...]

> +         (add-before 'build 'fix-typos-in-help
> +           (lambda _
> +             (substitute* "tools/etc1tool/etc1tool.cpp"
> +               ((" apropriate ") " appropriate "))
> +             #t))

You can now omit trailing #t (yay!).

> +    (inputs
> +     `(("libetc1" ,libetc1)
> +       ("libpng" ,libpng)))

Make sure to run ‘./pre-inst-env guix style -S inputs’ on your packages.

> +    (synopsis "Encode and decode PNG images to resp. from the ETC1 compression
> +standard.")

Please follow the guidelines and ‘guix lint’ warnings.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.