From unknown Wed Aug 20 01:18:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52828 <52828@debbugs.gnu.org> To: bug#52828 <52828@debbugs.gnu.org> Subject: Status: [PATCH] Fix Disarchive fallback on Guix System Reply-To: bug#52828 <52828@debbugs.gnu.org> Date: Wed, 20 Aug 2025 08:18:07 +0000 retitle 52828 [PATCH] Fix Disarchive fallback on Guix System reassign 52828 guix-patches submitter 52828 Timothy Sample severity 52828 normal tag 52828 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 27 13:39:42 2021 Received: (at submit) by debbugs.gnu.org; 27 Dec 2021 18:39:43 +0000 Received: from localhost ([127.0.0.1]:44275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1uuM-0004fm-Jl for submit@debbugs.gnu.org; Mon, 27 Dec 2021 13:39:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:48998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1uuK-0004fe-RD for submit@debbugs.gnu.org; Mon, 27 Dec 2021 13:39:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1uuK-0004GH-Bb for guix-patches@gnu.org; Mon, 27 Dec 2021 13:39:40 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:47933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1uuH-0005tw-U6 for guix-patches@gnu.org; Mon, 27 Dec 2021 13:39:39 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E73AB3200645 for ; Mon, 27 Dec 2021 13:39:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 27 Dec 2021 13:39:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=VDALH5f5JIJ96Ef/cQRHRlevtdw8i /1fF1jq57bBEbY=; b=j5H2tLddtJ8OMYdRhBLiccfqSf4tM+EHuErFyAgGupg1h LvHcxLDTGakLyGbbKisa7vCgeNL9qTM1/T2iD6et9NJxPEo8Ywm1zzLcfL/hlL7n aVg7k7lovv4/xSJzS7VC0XrpBd5BZfd88jaH3B+QQJSJiBlEnjGYdZj/wZGwDcuL RoTWzcKP0IjxcqiWQsddzmy1WyBqBb+325EWuueUhrqze7kPUP0B0XLLsqCaQc2H m0DMkPozPmt3sMV6UrXynStzm/WKYHBGz14MKpWwFAYR+QlFzqD0h0zAEq0Uvx6a vcHi5XOtrJLuyiEX3a9SyAU98S+EF8ApQpTBaa2Qg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddujedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehmtderre dtreejnecuhfhrohhmpefvihhmohhthhihucfurghmphhlvgcuoehsrghmphhlvghtsehn ghihrhhordgtohhmqeenucggtffrrghtthgvrhhnpedvleelvdeiffffudefhfffhfekke fggfeftddugefhudegtdeklefggeffledvtdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 27 Dec 2021 13:39:29 -0500 (EST) From: Timothy Sample To: guix-patches@gnu.org Subject: [PATCH] Fix Disarchive fallback on Guix System Date: Mon, 27 Dec 2021 13:39:28 -0500 Message-ID: <877dbpuc2n.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.147.123.20; envelope-from=samplet@ngyro.com; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi everyone, I noticed recently that Disarchive fallback does not work on Guix System. This is because the =E2=80=98(guix swh)=E2=80=99 module shells out= to =E2=80=98tar=E2=80=99 to extract the tarball that it downloads from SWH. However, when used as part of =E2=80=98guix perform-download=E2=80=99 via the daemon, =E2=80=98ta= r=E2=80=99 is not available. AFAICS, that the daemon is run with no =E2=80=98PATH=E2=80=99 at all. You can confirm this by running (on Guix System): $ GUIX_DOWNLOAD_FALLBACK_TEST=3Ddisarchive-mirrors \ guix build --check -S python-flask You should see: [...] Downloading [...] from Software Heritage... In procedure fport_write: Broken pipe [...] This patch adds =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 to the dae= mon=E2=80=99s =E2=80=98PATH=E2=80=99. To me, this is the most straight-forward way to fix the issue, but there are others. Any opinions? -- Tim --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-services-guix-Add-tar-and-gzip-to-PATH.patch >From 2893252c16f3e447eccd0f8d216bfb44b1965c43 Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Thu, 23 Dec 2021 22:32:07 -0500 Subject: [PATCH] services: guix: Add tar and gzip to PATH. * gnu/services/base.scm (guix-shepherd-service): Add the PATH environment-variable and populate it with tar and gzip. --- gnu/services/base.scm | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 88869e40d2..2fad07097b 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -55,7 +55,8 @@ (define-module (gnu services base) #:select (alsa-utils crda eudev e2fsprogs fuse gpm kbd lvm2 rng-tools)) #:use-module (gnu packages bash) #:use-module ((gnu packages base) - #:select (coreutils glibc glibc-utf8-locales)) + #:select (coreutils glibc glibc-utf8-locales tar)) + #:use-module ((gnu packages compression) #:select (gzip)) #:autoload (gnu packages guile-xyz) (guile-netlink) #:autoload (gnu packages hurd) (hurd) #:use-module (gnu packages package-management) @@ -1709,7 +1710,14 @@ (define (guix-shepherd-service config) (string-append "GUIX_LOCPATH=" #$glibc-utf8-locales "/lib/locale") - "LC_ALL=en_US.utf8") + "LC_ALL=en_US.utf8" + ;; Make 'tar' and 'gzip' available so + ;; that 'guix perform-download' can use + ;; them when downloading from Software + ;; Heritage via '(guix swh)'. + (string-append "PATH=" + #$(file-append tar "/bin") ":" + #$(file-append gzip "/bin"))) (if proxy (list (string-append "http_proxy=" proxy) (string-append "https_proxy=" proxy)) -- 2.34.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 05 15:54:13 2022 Received: (at 52828) by debbugs.gnu.org; 5 Jan 2022 20:54:13 +0000 Received: from localhost ([127.0.0.1]:38994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5DIT-0004xI-2N for submit@debbugs.gnu.org; Wed, 05 Jan 2022 15:54:13 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5DIR-0004x4-7D for 52828@debbugs.gnu.org; Wed, 05 Jan 2022 15:54:11 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7B8882C1; Wed, 5 Jan 2022 21:54:04 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mxJJt4LJyGwV; Wed, 5 Jan 2022 21:54:03 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 4E5CB112; Wed, 5 Jan 2022 21:54:03 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: bug#52828: [PATCH] Fix Disarchive fallback on Guix System References: <877dbpuc2n.fsf@ngyro.com> Date: Wed, 05 Jan 2022 21:54:02 +0100 In-Reply-To: <877dbpuc2n.fsf@ngyro.com> (Timothy Sample's message of "Mon, 27 Dec 2021 13:39:28 -0500") Message-ID: <87mtk9kiol.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 7B8882C1 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 52828 Cc: 52828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi Timothy, Timothy Sample skribis: > I noticed recently that Disarchive fallback does not work on Guix > System. This is because the =E2=80=98(guix swh)=E2=80=99 module shells o= ut to =E2=80=98tar=E2=80=99 to > extract the tarball that it downloads from SWH. However, when used as > part of =E2=80=98guix perform-download=E2=80=99 via the daemon, =E2=80=98= tar=E2=80=99 is not available. > AFAICS, that the daemon is run with no =E2=80=98PATH=E2=80=99 at all. > > You can confirm this by running (on Guix System): > > $ GUIX_DOWNLOAD_FALLBACK_TEST=3Ddisarchive-mirrors \ > guix build --check -S python-flask > > You should see: > > [...] > Downloading [...] from Software Heritage... > In procedure fport_write: Broken pipe > [...] > > This patch adds =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 to the d= aemon=E2=80=99s =E2=80=98PATH=E2=80=99. To me, this is > the most straight-forward way to fix the issue, but there are others. > Any opinions? > >>>From 2893252c16f3e447eccd0f8d216bfb44b1965c43 Mon Sep 17 00:00:00 2001 > From: Timothy Sample > Date: Thu, 23 Dec 2021 22:32:07 -0500 > Subject: [PATCH] services: guix: Add tar and gzip to PATH. > > * gnu/services/base.scm (guix-shepherd-service): Add the PATH > environment-variable and populate it with tar and gzip. What about uses of guix-daemon on other distros? Perhaps we assume tar and gzip are already on PATH? I=E2=80=99d feel more comfortable with a solution at the package level. In= the =E2=80=98guix=E2=80=99 package, or perhaps in a Makefile.am, we could hard-= code absolute file names of tar and gzip in (guix scripts perform-download) and set PATH from there. We=E2=80=99d need to do the same in (guix self) though. Alternatively, we could change (guix swh) to use Guile-Zlib and the tar implementation of Gash-Utils or that of Disarchive. WDYT? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 13 05:55:58 2022 Received: (at control) by debbugs.gnu.org; 13 Jan 2022 10:55:58 +0000 Received: from localhost ([127.0.0.1]:60303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7xlu-0006Qm-0K for submit@debbugs.gnu.org; Thu, 13 Jan 2022 05:55:58 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:52838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7xls-0006QS-Fa for control@debbugs.gnu.org; Thu, 13 Jan 2022 05:55:56 -0500 IronPort-SDR: gtvJbLL50NBVnD20I81PQomhHFdBXrzqL3rCWek+ip2VGg9lap9wSD6Ve6O/vI0G/JTI0b9FKg maL2styfo4HpN6DFXMaLrEaQ16/Hb8Te7dntWpPaxKW3jt+FazCuBD3/j1NnxJvmNrBM6ktGNr JsaXVvTyX1kor0Mr5s7qGx00mjvM+Udrw8mK681kDJLBjrgmD6CTlTmBgZtwoIcOLWaBfQhJCv h9+g+Q8kK+w70xEwe7JhSvePLPLIdInTrNTa0pDotudaXDLB+iMC+5yddgBB94u4DIfP5UY3vA E7A= IronPort-Data: A9a23:wu6EraxTCLEqJ+DY6xR6t+cCxCrEfRIJ4+MujC+fZmUNrF6WrkVWn WtJXGqBPqmMYDD9eYtwbITg9EwFsJ7TyNIxG1Rq/nw8FHgiRejtVY3IdB+oV8+xBpSeFxw/t 512hv3odp1cokcxKH5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Us6wLZg6mJVqYPR7z2l6 IqaT/L3aAfNNw5cagr42orbwP9dlKyaVAAw4jTSUct2UGr2zBH5On6wyZaZdBMUSqEMdgKzq n2qILuRpgs19D91Yj+pfyqST6EEflLSFVDmZnt+QamoiB9EzsAw+vdicqNCMQEO0mrPxYgoo DlOncXYpQMBOrDAn8wSVQQeFDtxVUFD0OaafyDh7ZHIp6HBWz62qxl0N2k9OosE4OFzKW1D/ /YFJytLYRaeweWsz9qGpkNE7ig4BJiyedpB4jQ5lG6cV65/B4veSb6M/cVfzD48wMZDAZ7ji wMiQWIHRHz9j9dnYz/71LpWcD+Uu0TC IronPort-HdrOrdr: A9a23:RKLl4KD8uBJ1NxblHelW55DYdb4zR+YMi2TDtnoBKyC9F/by+v xG88526faKskdoZJhNo7+90dC7MArhHP1Oi7X5X43DYOCOggLBEGgF1+XfKlbbak7DH4BmtJ uJeMBFeabNJGk/o87m7BexA/YsqeP3ipyAtKP76FxqQBFBaql69QtlYzzrdHFedU1jIqAkH5 mR7NdspjK6Y3gLB/7LYUXs/oP41rj2fMKPW29jOyIa X-IronPort-AV: E=Sophos;i="5.88,284,1635199200"; d="scan'208";a="15606453" Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 11:55:50 +0100 Date: Thu, 13 Jan 2022 11:55:49 +0100 Message-Id: <87ilun9a6i.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #53214 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) block 53214 by 52828 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 10:33:32 2022 Received: (at 52828) by debbugs.gnu.org; 15 Jan 2022 15:33:32 +0000 Received: from localhost ([127.0.0.1]:41530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8l3V-00058s-En for submit@debbugs.gnu.org; Sat, 15 Jan 2022 10:33:32 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8l3Q-00058Z-MC for 52828@debbugs.gnu.org; Sat, 15 Jan 2022 10:33:24 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9165E5C00CD; Sat, 15 Jan 2022 10:33:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 15 Jan 2022 10:33:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=e95IXO CkHa+rxlUG96Bi/CYgeIdUiLEGzysQqCYdVrA=; b=OKg46fBBvmk2kugvmslFk9 gCAB0Dv0A2jeFNpdAKPA2T8h6zdBcOTBf/B5gwWQcLbi662qIVKTkt4nytqmTcrT s3LNwP45n1y29mpnVD1SDWoBvxcKVuuYCEvTlXM+o7pH0pvC7SrmA3rMlIzBrEtV HhvFt5GwMYDqb4gKrSXhs947nY8TKznjQ4U+ZamrgVQSDkF+qsM39nwDTYFW/VWB aplqh/pB0aK9V61/VIsUYN0SAXvjKvD+3+JcfXqY5hGbJ8Y30usawuaX8fFqhs3Q kz+YqP2MO1LuJ2NFw7d2Lssni3vQO4YhduFdK4vNoGtXQzFSJF9ATUjpxEd+wBHg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtdejgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgesmhdtreertderjeenucfhrhhomhepvfhimhhothhh hicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrfgrth htvghrnhepvdetjeevkefggfefgfevteehgffgledugfetudfggeeltdfhfeeuleejffeu ueffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh grmhhplhgvthesnhhghihrohdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 15 Jan 2022 10:33:15 -0500 (EST) From: Timothy Sample To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#52828: [PATCH v2] swh: Do not rely on $PATH for tar and gzip. References: <877dbpuc2n.fsf@ngyro.com> <87mtk9kiol.fsf@gnu.org> Date: Sat, 15 Jan 2022 10:33:14 -0500 In-Reply-To: <87mtk9kiol.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 05 Jan 2022 21:54:02 +0100") Message-ID: <8735lpxbd1.fsf_-_@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Ludovic, Ludovic Courtès writes: > What about uses of guix-daemon on other distros? Perhaps we assume tar > and gzip are already on PATH? Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [66.111.4.28 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.28 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 52828 Cc: 52828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, Ludovic Court=C3=A8s writes: > What about uses of guix-daemon on other distros? Perhaps we assume tar > and gzip are already on PATH? That=E2=80=99s my guess. And if those other weird distros don=E2=80=99t ha= ve =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 in =E2=80=9C/usr/bin=E2=80=9D, I=E2=80=99m sure they= =E2=80=99re plenty accustomed to liberally patching their packages. ;) > I=E2=80=99d feel more comfortable with a solution at the package level. = In the > =E2=80=98guix=E2=80=99 package, or perhaps in a Makefile.am, we could har= d-code absolute > file names of tar and gzip in (guix scripts perform-download) and set > PATH from there. We=E2=80=99d need to do the same in (guix self) though. > > Alternatively, we could change (guix swh) to use Guile-Zlib and the tar > implementation of Gash-Utils or that of Disarchive. > > WDYT? I=E2=80=99ve attached a new patch that mixes those two suggestions but gets= the first one a little wrong. It uses the absolute path for =E2=80=98tar=E2=80= =99, but uses Guile-zlib for decompression. I honestly don=E2=80=99t have a strong opinion about when and where to set =E2=80=98$PATH=E2=80=99 vs. using a configured, absolute path. My original= patch assumed that it=E2=80=99s the user=E2=80=99s job to make sure that =E2=80= =98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 are available to Guix at runtime. This patch assumes that that linkage happens at configure time. The main benefit I could see to setting =E2=80=98$PATH=E2=80=99 in =E2=80=98(guix scripts perform-download)=E2=80= =99 is that we could add our =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 as a suffix. This makes i= t work while allowing users to choose whatever =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 they pr= efer. The downside is that whenever we use =E2=80=98(guix swh)=E2=80=99 have to remember to make sure = that =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 are available. Basically, I can to change this to do the setup in =E2=80=98perform-downloa= d=E2=80=99, but I really want to understand why. Thanks! --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=v2-0001-swh-Do-not-rely-on-PATH-for-tar-and-gzip.patch Content-Transfer-Encoding: quoted-printable >From 010666376890b6adf6c14253b1e2651b5c2861e8 Mon Sep 17 00:00:00 2001 From: Timothy Sample Date: Fri, 14 Jan 2022 18:03:10 -0500 Subject: [PATCH v2] swh: Do not rely on $PATH for tar and gzip. Fixes . * configure.ac: Find the path of the tar utility. * guix/config.scm.in (%tar): New variable. * guix/self.scm (specification->package): Add "tar". (make-config.scm): Add a 'tar' keyword parameter and use it to set the '%tar' variable. (compiled-guix): Add a 'tar' keyword parameter, and pass it to 'make-config.scm'; add 'guile-zlib' as an extension for "guix-core". * guix/swh.scm (swh-download-archive): Use Guile-zlib to decompress "flat" archives, and use an absolute path when invoking 'tar'. --- configure.ac | 4 ++++ guix/config.scm.in | 7 ++++++- guix/self.scm | 18 ++++++++++++++---- guix/swh.scm | 13 ++++++++----- 4 files changed, 32 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index 341cff8fbd..78f599b2f4 100644 --- a/configure.ac +++ b/configure.ac @@ -198,6 +198,10 @@ AC_SUBST([GZIP]) AC_SUBST([BZIP2]) AC_SUBST([XZ]) =20 +dnl The '(guix swh)' module uses 'tar'. +AC_PATH_PROG([TAR], [tar]) +AC_SUBST([TAR]) + LIBGCRYPT_LIBDIR=3D"no" LIBGCRYPT_PREFIX=3D"no" =20 diff --git a/guix/config.scm.in b/guix/config.scm.in index d582d91d74..7b400a9ff8 100644 --- a/guix/config.scm.in +++ b/guix/config.scm.in @@ -37,7 +37,9 @@ (define-module (guix config) %system %gzip %bzip2 - %xz)) + %xz + + %tar)) =20 ;;; Commentary: ;;; @@ -118,4 +120,7 @@ (define %bzip2 (define %xz "@XZ@") =20 +(define %tar + "@TAR@") + ;;; config.scm ends here diff --git a/guix/self.scm b/guix/self.scm index 943bb0b498..3944f1a98d 100644 --- a/guix/self.scm +++ b/guix/self.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2017, 2018, 2019, 2020, 2021 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2020 Martin Becze +;;; Copyright =C2=A9 2022 Timothy Sample ;;; ;;; This file is part of GNU Guix. ;;; @@ -68,6 +69,7 @@ (define specification->package ("gzip" (ref '(gnu packages compression) 'gzip)) ("bzip2" (ref '(gnu packages compression) 'bzip2)) ("xz" (ref '(gnu packages compression) 'xz)) + ("tar" (ref '(gnu packages base) 'tar)) ("po4a" (ref '(gnu packages gettext) 'po4a)) ("gettext" (ref '(gnu packages gettext) 'gettext-minimal)) ("gcc-toolchain" (ref '(gnu packages commencement) 'gcc-toolchain)) @@ -749,6 +751,7 @@ (define* (compiled-guix source #:key (gzip (specification->package "gzip")) (bzip2 (specification->package "bzip2")) (xz (specification->package "xz")) + (tar (specification->package "tar")) (guix (specification->package "guix"))) "Return a file-like object that contains a compiled Guix." (define guile-avahi @@ -832,7 +835,9 @@ (define* (compiled-guix source #:key ,(local-file "../guix/store/schema.sql"))) =20 #:extensions (list guile-gcrypt - guile-json) ;for (guix swh) + ;; The following are for (guix swh) + guile-json + guile-zlib) #:guile-for-build guile-for-build)) =20 (define *extra-modules* @@ -964,6 +969,7 @@ (define* (compiled-guix source #:key =3D> ,(make-config.scm #:gzip gzip #:bzip2 bzip2 #:xz xz + #:tar tar #:package-name %guix-package-name #:package-version @@ -1071,7 +1077,7 @@ (define %default-config-variables (%storedir . "/gnu/store") (%sysconfdir . "/etc"))) =20 -(define* (make-config.scm #:key gzip xz bzip2 +(define* (make-config.scm #:key gzip xz bzip2 tar (package-name "GNU Guix") (package-version "0") (channel-metadata #f) @@ -1097,7 +1103,8 @@ (define* (make-config.scm #:key gzip xz bzip2 %config-directory %gzip %bzip2 - %xz)) + %xz + %tar)) =20 (define %system #$(%current-system)) @@ -1142,7 +1149,10 @@ (define* (make-config.scm #:key gzip xz bzip2 (define %bzip2 #+(and bzip2 (file-append bzip2 "/bin/bzip2"))) (define %xz - #+(and xz (file-append xz "/bin/xz")))) + #+(and xz (file-append xz "/bin/xz"))) + + (define %tar + #+(and tar (file-append tar "/bin/tar")))) =20 ;; Guile 2.0 *requires* the 'define-module' to be at the ;; top-level or the 'toplevel-ref' in the resulting .go fil= e are diff --git a/guix/swh.scm b/guix/swh.scm index c7c1c873a2..93bb023192 100644 --- a/guix/swh.scm +++ b/guix/swh.scm @@ -3,6 +3,7 @@ ;;; Copyright =C2=A9 2020 Jakub K=C4=85dzio=C5=82ka ;;; Copyright =C2=A9 2021 Xinglu Chen ;;; Copyright =C2=A9 2021 Simon Tournier +;;; Copyright =C2=A9 2022 Timothy Sample ;;; ;;; This file is part of GNU Guix. ;;; @@ -23,6 +24,7 @@ (define-module (guix swh) #:use-module (guix base16) #:use-module (guix build utils) #:use-module ((guix build syscalls) #:select (mkdtemp!)) + #:use-module (guix config) #:use-module (web uri) #:use-module (web client) #:use-module (web response) @@ -35,6 +37,7 @@ (define-module (guix swh) #:use-module (ice-9 regex) #:use-module (ice-9 popen) #:use-module ((ice-9 ftw) #:select (scandir)) + #:use-module (zlib) #:export (%swh-base-url %verify-swh-certificate? %allow-request? @@ -674,11 +677,11 @@ (define* (swh-download-archive swhid output swhid) #f) ((? port? input) - (let ((tar (open-pipe* OPEN_WRITE "tar" "-C" directory - (match archive-type - ('flat "-xzvf") ;gzipped - ('git-bare "-xvf")) ;uncompressed - "-"))) + (let ((input (match archive-type + ;; "flat" archives are compressed. + ('flat (make-zlib-input-port input #:format 'gzip)) + ('git-bare input))) + (tar (open-pipe* OPEN_WRITE %tar "-C" directory "-xvf" "-"))) (dump-port input tar) (close-port input) (let ((status (close-pipe tar))) --=20 2.34.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 15 16:33:31 2022 Received: (at 52828) by debbugs.gnu.org; 15 Jan 2022 21:33:31 +0000 Received: from localhost ([127.0.0.1]:42080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8qfz-00051e-Dw for submit@debbugs.gnu.org; Sat, 15 Jan 2022 16:33:31 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:36958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8qfy-00051Q-2Q for 52828@debbugs.gnu.org; Sat, 15 Jan 2022 16:33:30 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7EFAB2D7; Sat, 15 Jan 2022 22:33:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kiaUrmj_Ii3Y; Sat, 15 Jan 2022 22:33:22 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 75CB929C; Sat, 15 Jan 2022 22:33:21 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: bug#52828: [PATCH] Fix Disarchive fallback on Guix System References: <877dbpuc2n.fsf@ngyro.com> <87mtk9kiol.fsf@gnu.org> <8735lpxbd1.fsf_-_@ngyro.com> Date: Sat, 15 Jan 2022 22:33:21 +0100 In-Reply-To: <8735lpxbd1.fsf_-_@ngyro.com> (Timothy Sample's message of "Sat, 15 Jan 2022 10:33:14 -0500") Message-ID: <87a6fw3cri.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 7EFAB2D7 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 52828 Cc: 52828@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Timothy Sample skribis: > Ludovic Court=C3=A8s writes: > >> What about uses of guix-daemon on other distros? Perhaps we assume tar >> and gzip are already on PATH? > > That=E2=80=99s my guess. And if those other weird distros don=E2=80=99t = have =E2=80=98tar=E2=80=99 and > =E2=80=98gzip=E2=80=99 in =E2=80=9C/usr/bin=E2=80=9D, I=E2=80=99m sure th= ey=E2=80=99re plenty accustomed to liberally > patching their packages. ;) True. >> I=E2=80=99d feel more comfortable with a solution at the package level. = In the >> =E2=80=98guix=E2=80=99 package, or perhaps in a Makefile.am, we could ha= rd-code absolute >> file names of tar and gzip in (guix scripts perform-download) and set >> PATH from there. We=E2=80=99d need to do the same in (guix self) though. >> >> Alternatively, we could change (guix swh) to use Guile-Zlib and the tar >> implementation of Gash-Utils or that of Disarchive. >> >> WDYT? > > I=E2=80=99ve attached a new patch that mixes those two suggestions but ge= ts the > first one a little wrong. It uses the absolute path for =E2=80=98tar=E2= =80=99, but uses > Guile-zlib for decompression. > > I honestly don=E2=80=99t have a strong opinion about when and where to set > =E2=80=98$PATH=E2=80=99 vs. using a configured, absolute path. My origin= al patch > assumed that it=E2=80=99s the user=E2=80=99s job to make sure that =E2=80= =98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 are > available to Guix at runtime. This patch assumes that that linkage > happens at configure time. The main benefit I could see to setting > =E2=80=98$PATH=E2=80=99 in =E2=80=98(guix scripts perform-download)=E2=80= =99 is that we could add our > =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 as a suffix. This makes= it work while allowing users > to choose whatever =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 they = prefer. The downside is that > whenever we use =E2=80=98(guix swh)=E2=80=99 have to remember to make sur= e that =E2=80=98tar=E2=80=99 > and =E2=80=98gzip=E2=80=99 are available. > > Basically, I can to change this to do the setup in =E2=80=98perform-downl= oad=E2=80=99, > but I really want to understand why. Hmm yes, I guess you=E2=80=99re right, I prefer the initial patch after all. (In particular I=E2=80=99m not keen on adding things to (guix config).) Go for it? Longer-term, I think it would still be interesting to migrate to Guile-Zlib + Disarchive/Gash-Utils, but we can check that later=E2=80=94bet= ter fix the Disarchive fallback first. Thanks and sorry for the hesitations! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 16 20:00:32 2022 Received: (at 52828-done) by debbugs.gnu.org; 17 Jan 2022 01:00:33 +0000 Received: from localhost ([127.0.0.1]:44524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9GNs-0000Ie-NV for submit@debbugs.gnu.org; Sun, 16 Jan 2022 20:00:32 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9GNr-0000IR-2T for 52828-done@debbugs.gnu.org; Sun, 16 Jan 2022 20:00:31 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D56FA5C0103; Sun, 16 Jan 2022 20:00:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 16 Jan 2022 20:00:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PCO+jpX1Bu/9wBFUbj5ASVfs7vmK0+qAtxDLHvWeX /0=; b=nyWTJzmzQlIHODsS66oo8XH9SzIde3OlpMLWiXoi9SSmIYsQtrDGjjqqD xKUTt0+wzrRjHUmz44h4RtqYVQKwR2st4AJqRhHGzmTuv7mSgSWsOrCbgK3ZQms4 Xxo8uq8j4ShV2OFZxLlwjXXmElcPNAbOGrbbVsmG+AVsmcIUhRKDsgKAvMmcP/Mz wejopU3HwntNfI7Itmg9mpZLBoddUj0y/w6E/QZrH9bKFBOC+PZ4bFvA80xWBrSS Jr2wglzmqsAuSlzWd87QBSdy35bhEugsdUzk7JmvasD1zqTIX2BbHyzRQsEZgeL2 P75swAuF3nHzrIoiAY8vJ5NJqbxug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhmohht hhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtffrrg htthgvrhhnpeeiudeuhfeggeelleevheegudfguefhieekffdtveeilefglefhvddtgfei heetgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 Jan 2022 20:00:25 -0500 (EST) From: Timothy Sample To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#52828: [PATCH] Fix Disarchive fallback on Guix System References: <877dbpuc2n.fsf@ngyro.com> <87mtk9kiol.fsf@gnu.org> <8735lpxbd1.fsf_-_@ngyro.com> <87a6fw3cri.fsf_-_@gnu.org> Date: Sun, 16 Jan 2022 20:00:24 -0500 In-Reply-To: <87a6fw3cri.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Sat, 15 Jan 2022 22:33:21 +0100") Message-ID: <87iluj89cn.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52828-done Cc: 52828-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ludovic Court=C3=A8s writes: > Hmm yes, I guess you=E2=80=99re right, I prefer the initial patch after a= ll. > (In particular I=E2=80=99m not keen on adding things to (guix config).) > > Go for it? Pushed as 3b6755defe44c4795e134a46a7ef7b6009146872. > Longer-term, I think it would still be interesting to migrate to > Guile-Zlib + Disarchive/Gash-Utils, but we can check that later=E2=80=94b= etter > fix the Disarchive fallback first. For sure. Changing it to use zlib was pretty easy. Sadly, neither of those tarball libraries are slam dunks for Guix as of today. > Thanks and sorry for the hesitations! No worries. Thanks very much for the review! :) -- Tim From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 17 08:11:43 2022 Received: (at 52828-done) by debbugs.gnu.org; 17 Jan 2022 13:11:43 +0000 Received: from localhost ([127.0.0.1]:45099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9RnT-0004TK-BY for submit@debbugs.gnu.org; Mon, 17 Jan 2022 08:11:43 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:43384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9RnQ-0004T5-PT for 52828-done@debbugs.gnu.org; Mon, 17 Jan 2022 08:11:42 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 5742352F; Mon, 17 Jan 2022 14:11:34 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L1x37cyvlJJj; Mon, 17 Jan 2022 14:11:33 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 531D34C4; Mon, 17 Jan 2022 14:11:33 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Timothy Sample Subject: Re: bug#52828: [PATCH] Fix Disarchive fallback on Guix System References: <877dbpuc2n.fsf@ngyro.com> <87mtk9kiol.fsf@gnu.org> <8735lpxbd1.fsf_-_@ngyro.com> <87a6fw3cri.fsf_-_@gnu.org> <87iluj89cn.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 28 =?utf-8?Q?Niv=C3=B4se?= an 230 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 17 Jan 2022 14:11:32 +0100 In-Reply-To: <87iluj89cn.fsf@ngyro.com> (Timothy Sample's message of "Sun, 16 Jan 2022 20:00:24 -0500") Message-ID: <87sftmpkvv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: 5742352F X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 52828-done Cc: 52828-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Howdy! Timothy Sample skribis: > Ludovic Court=C3=A8s writes: > >> Hmm yes, I guess you=E2=80=99re right, I prefer the initial patch after = all. >> (In particular I=E2=80=99m not keen on adding things to (guix config).) >> >> Go for it? > > Pushed as 3b6755defe44c4795e134a46a7ef7b6009146872. Thanks! >> Longer-term, I think it would still be interesting to migrate to >> Guile-Zlib + Disarchive/Gash-Utils, but we can check that later=E2=80=94= better >> fix the Disarchive fallback first. > > For sure. Changing it to use zlib was pretty easy. Sadly, neither of > those tarball libraries are slam dunks for Guix as of today. I suppose they=E2=80=99re good enough for this use case, aren=E2=80=99t the= y? Here we=E2=80=99re only dealing with one tarball producer (the software beh= ind SWH), so the scope is much narrower compared to what Gash might need to support (tarballs of a variety of flavors.) Ludo=E2=80=99. From unknown Wed Aug 20 01:18:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Feb 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator