From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 27 12:06:43 2021 Received: (at submit) by debbugs.gnu.org; 27 Dec 2021 17:06:43 +0000 Received: from localhost ([127.0.0.1]:44168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1tSN-0001f7-6S for submit@debbugs.gnu.org; Mon, 27 Dec 2021 12:06:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:47704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1srG-0000Eq-GU for submit@debbugs.gnu.org; Mon, 27 Dec 2021 11:28:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1srG-0001Ny-0p for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 11:28:22 -0500 Received: from ark.scaleway.mowzer.co.za ([51.158.166.135]:49028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1srE-0005Oz-Dt for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 11:28:21 -0500 From: Yaseen Mowzer DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mowzer.co.za; s=mail; t=1640622496; bh=Z7jca1r3l3dTfD1UBa9PP5nEommEfGAtCDQ5kbARXoY=; h=From:To:Cc:Subject:Date:From; b=WR5RRIfJV+de8uHMlVywI/4FYUFHUfNCDnZEh9oyKektY2fqWAF9knUwxSsP7Q+p8 XtfcyUVGnCMjMTb1eSw0B4Rr91lJexG7NnI03BE7Uf0STtraUcL9TXnvIbUMknzglA tPi6N0Mfom+vo79QsjLgnWHLc6QV8HfN3HKi7cJnEHp/owkm9nNQCuEdoA6p1Bz8mo EgnZ+PhoJ8mYK/TD357/JMB/winnyIklXucbvPi+ulruSroNdEEPk71ASSMsHPysgB 4U6zAHczxi6rAqj1INyXX7IqHskRIpeq55hfxr9NM/+BP5ISDyjgYxzvj+c37RvX+8 Q8FjDPkwh5c8A== To: bug-gnu-emacs@gnu.org Subject: [PATCH] gnus-article: shr: Let user limit the line-width Date: Mon, 27 Dec 2021 18:28:06 +0200 Message-Id: <20211227162806.1547889-1-yaseen@mowzer.co.za> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=51.158.166.135; envelope-from=yaseen@mowzer.co.za; helo=ark.scaleway.mowzer.co.za X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 27 Dec 2021 12:06:41 -0500 Cc: Yaseen Mowzer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) As a user with a wide screen I want to limit the width of lines in gnus-article buffers so that articles are easier to read. This is configurable in the 'shr' backend by setting 'shr-width' to an integer. However, 'mm-shr' forces 'shr-width' to nil (by default) and 'fill-column' (when 'shr-use-fonts' is nil). * lisp/gnus/mm-decode.el (mm-shr): Let the user configure 'shr-width' instead of forcing it to nil (by default) or 'fill-column' (when 'shr-use-fonts' is nil). --- lisp/gnus/mm-decode.el | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lisp/gnus/mm-decode.el b/lisp/gnus/mm-decode.el index aca4bf2062..f3e498016c 100644 --- a/lisp/gnus/mm-decode.el +++ b/lisp/gnus/mm-decode.el @@ -1832,10 +1832,7 @@ shr-inhibit-images (defun mm-shr (handle) ;; Require since we bind its variables. (require 'shr) - (let ((shr-width (if shr-use-fonts - nil - fill-column)) - (shr-content-function (lambda (id) + (let ((shr-content-function (lambda (id) (let ((handle (mm-get-content-id id))) (when handle (mm-with-part handle -- 2.34.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 10:48:08 2021 Received: (at 52825) by debbugs.gnu.org; 29 Dec 2021 15:48:08 +0000 Received: from localhost ([127.0.0.1]:49981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2bBQ-0002lK-En for submit@debbugs.gnu.org; Wed, 29 Dec 2021 10:48:08 -0500 Received: from quimby.gnus.org ([95.216.78.240]:43088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2bBN-0002kH-Q2 for 52825@debbugs.gnu.org; Wed, 29 Dec 2021 10:48:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eEDHl974HQwjEbjKFmUzf7l+tMhqZYUdZ/Y5PIFwejA=; b=vJo6ygHoc6zKVHMGmJ57pIuq7i otUZGpX8O3zY7XxRVhGCmqkvWaPJiKOt23nnIyA5H5nuIejb3Ue5ZRz6VPxm5qP+Xgg6jkhGLqws0 5p8OqoaBqubaJuVMc/ZENNdxnMFczqdpZYXkocanz9GYHUnVTQJ7UIpK28oBMrcb4QWU=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2bBE-0007Jo-1h; Wed, 29 Dec 2021 16:47:58 +0100 From: Lars Ingebrigtsen To: Yaseen Mowzer Subject: Re: bug#52825: [PATCH] gnus-article: shr: Let user limit the line-width References: <20211227162806.1547889-1-yaseen@mowzer.co.za> X-Now-Playing: Four Tet's _Rounds_: "Hands" Date: Wed, 29 Dec 2021 16:47:52 +0100 In-Reply-To: <20211227162806.1547889-1-yaseen@mowzer.co.za> (Yaseen Mowzer's message of "Mon, 27 Dec 2021 18:28:06 +0200") Message-ID: <87lf035s5z.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Yaseen Mowzer writes: > As a user with a wide screen I want to limit the width of lines in > gnus-article buffers so that articles are easier to read. This is > configurable in the 'shr' backend by setting 'shr-width' to a [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52825 Cc: 52825@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Yaseen Mowzer writes: > As a user with a wide screen I want to limit the width of lines in > gnus-article buffers so that articles are easier to read. This is > configurable in the 'shr' backend by setting 'shr-width' to an > integer. However, 'mm-shr' forces 'shr-width' to nil (by default) and > 'fill-column' (when 'shr-use-fonts' is nil). [...] > - (let ((shr-width (if shr-use-fonts > - nil > - fill-column)) > - (shr-content-function (lambda (id) The point of filling when not using fonts is explained by the commit message: * lisp/gnus/mm-decode.el (mm-shr): Only pass the fill column when not using fonts, because limiting the width to what's appropriate for followups doesn't really help when not using proportional fonts. Your change would make Gnus disregard fill-column when not using fonts, thereby causing followups to use wider lines, which we want to avoid. But I think using shr-width instead of nil in the font case would be fine, so I've done that instead in Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 10:49:04 2021 Received: (at control) by debbugs.gnu.org; 29 Dec 2021 15:49:04 +0000 Received: from localhost ([127.0.0.1]:49985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2bCJ-0002nH-TY for submit@debbugs.gnu.org; Wed, 29 Dec 2021 10:49:04 -0500 Received: from quimby.gnus.org ([95.216.78.240]:43104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2bCI-0002mf-Ah for control@debbugs.gnu.org; Wed, 29 Dec 2021 10:49:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VdnCKNGyFF/R6VjhiKVCVY45+G9YQzY0I4Z3hYAaOww=; b=qlpIQivnsDXQg8fWNTCj+hB90D eucIxppQyePnNqiTIuTeW1n4lZ36Cp6jkJDCEsYUmbZNMOObXMBOx+x1uOUH2VsWAzDdaj5GhJhWO q3v+UQJ4QY5Drv7Fm1mZA0Je4vQfYRc5X0ilyzsC3rwfd3s1v9Ex4Vc6sZ+sKGQ+CvkA=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2bCA-0007K8-Dp for control@debbugs.gnu.org; Wed, 29 Dec 2021 16:48:56 +0100 Date: Wed, 29 Dec 2021 16:48:53 +0100 Message-Id: <87k0fn5s4a.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #52825 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 52825 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 52825 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 13:45:54 2021 Received: (at 52825) by debbugs.gnu.org; 29 Dec 2021 18:45:55 +0000 Received: from localhost ([127.0.0.1]:50364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2dxS-0004ih-Ns for submit@debbugs.gnu.org; Wed, 29 Dec 2021 13:45:54 -0500 Received: from ark.scaleway.mowzer.co.za ([51.158.166.135]:36792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2dxQ-0004iY-Bh for 52825@debbugs.gnu.org; Wed, 29 Dec 2021 13:45:52 -0500 References: <20211227162806.1547889-1-yaseen@mowzer.co.za> <87lf035s5z.fsf@gnus.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mowzer.co.za; s=mail; t=1640803550; bh=wCIkZzO+rczF9+pwUHCrWTg1VJrIqM3oCHZmtnkw7+8=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=iShGNIZNBxC3CSlXbCw4pZ2fxwBLStkS2LnthSZbbmWE/QDazUvsU69N3w9TmvBtw AW767UcfY6YBre8n1o4VwkG56TEZtSdGYLZu6OlXWoVzIZvsB1K+XSXeyqR/vxAi0H PSQz3Wn1ncmiy5jKiB0iPsyTNZ4JYLYQQdbCAgl0BBruBOYTNjH+/nJNrikTzC/9jH nNxzMhxyevuZVDjqpVxAYTl9/6g7P6APlFGZYow0cN1feLW0IFRkarwflI/0mYCDv6 HBPFDSIT9STfAkGhGE92JZeSjHAFwiUduOqGh5/sVCVK2WgRwQZGvMyhs1V9G6LndT SmAPzxcjKqmSA== User-agent: mu4e 1.6.10; emacs 27.2 From: Yaseen Mowzer To: Lars Ingebrigtsen Subject: Re: bug#52825: [PATCH] gnus-article: shr: Let user limit the line-width Date: Wed, 29 Dec 2021 20:43:42 +0200 In-reply-to: <87lf035s5z.fsf@gnus.org> Message-ID: <87czlfz1v7.fsf@mowzer.co.za> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52825 Cc: 52825@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Your change would make Gnus disregard fill-column when not using fonts, > thereby causing followups to use wider lines, which we want to avoid. > > But I think using shr-width instead of nil in the font case would be > fine, so I've done that instead in Emacs 29. Excellent! Thanks for your hard work. -- Kind regards Yaseen Mowzer From unknown Sun Jun 15 01:06:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator