GNU bug report logs - #52823
3 gx*lv2 packages fail to build in the same manner

Previous Next

Full log

Message #23 received at 52823 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Thorsten Wilms <t_w_ <at> freenet.de>, 52823 <at> debbugs.gnu.org
Subject: Re: bug#52823: [PATCH 1/2] gnu: gx-vbass-preamp-lv2: Update to latest
 commit to fix build issue.
Date: Sat, 23 Jul 2022 15:29:31 +0200

[Message part 1 (text/plain, inline)]

On 17-07-2022 20:00, Thorsten Wilms wrote:
> +      (arguments
> +       (substitute-keyword-arguments (package-arguments gx-guvnor-lv2)
> +         ((#:make-flags flags) `(cons (string-append "CC=" ,(cxx-for-target)) ,flags))))

This presumably works but is fragile -- if at some point in time, 
gx-guvnor-lv2 decides to change to a G-exp, this won't compile anymore. 
Instead, you can do #~(cons (string-append "CC=" #$(cxx-for-target)) 
#$flags), which works whether or not gx-guvnor-lv2 uses S-exps or G-exps.

Also, I don't understand why you are doing CC=g++. CC stands for 
c-compiler, not C++ compiler, so I would have expected "CC=" 
#$(cc-for-target) or "CXX=" #$(cxx-for-target) instead, unless 
gx-vbass-preamp-lv2 is not following these conventions.

Otherwise, these patches look reasonable to me, though TBC, I did not 
test them, I only looked at the patches theirselves.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.