GNU bug report logs - #52808
Guix home should not assume that all targets are dot files

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#52808: closed (Guix home should not assume that all targets
 are dot files)
Date: Fri, 08 Apr 2022 18:19:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 08 Apr 2022 20:18:41 +0200
with message-id <87ee27bfr2.fsf <at> gnu.org>
and subject line Re: bug#52808: Guix home should not assume that all targets are dot files
has caused the debbugs.gnu.org bug report #52808,
regarding Guix home should not assume that all targets are dot files
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
52808: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52808
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Nick Zalutskiy" <nick <at> const.fun>
To: bug-guix <at> gnu.org
Subject: Guix home should not assume that all targets are dot files
Date: Sun, 26 Dec 2021 12:17:27 -0500

[Message part 3 (text/plain, inline)]

The following configuration results in a `~/.run` symlink being created. My expectation is that a `~/run` symlink is created instead. (ie. not a dotfile)

> (home-environment
>   (services
>     (list (service
>             home-bash-service-type
>             (home-bash-configuration
>           (guix-defaults? #t)))
>       (simple-service 'my-files
>               home-files-service-type
>               `(("run" ,(local-file "run")))))))

This applies to all other targets. My expectation is that the configuration should expect the exact target and not make an assumption that all targets are hidden files, since that allows for more utility: 

> (home-environment
>   (services
>     (list (service
>             home-bash-service-type
>             (home-bash-configuration
>               (guix-defaults? #t)))
>           (simple-service 'config-files
>               home-files-service-type
>               `(("run" ,(local-file "run"))
>                 ("README.txt" ,(local-file "README.txt"))
>                 (".config/guix/channels.scm" ,(local-file "config/guix
>                 (".emacs.d/init.el" ,(local-file "emacs.d/init.el"))
>                 (".vimrc" ,(local-file "vimrc"))
>                 (".gitconfig" ,(local-file "gitconfig")))))))

Thank you,

-Nick

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 52808-done <at> debbugs.gnu.org, Nick Zalutskiy <nick <at> const.fun>
Subject: Re: bug#52808: Guix home should not assume that all targets are dot
 files
Date: Fri, 08 Apr 2022 20:18:41 +0200

Hi Andrew,

Andrew Tropin <andrew <at> trop.in> skribis:

> Those patches introduce a breaking change, but the surface and number of
> people affected should be small if everyone migrated to
> xdg-configuration-files.  It removes the special handling of dot files
> in symlink-manager and doesn't add a leading dot automatically.
>
> Please, merge them on April 8.
>
> From 1b556cda9716eba31a8a6dd9d3c263988de26ccf Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew <at> trop.in>
> Date: Tue, 29 Mar 2022 11:28:30 +0300
> Subject: [PATCH 1/2] home: symlink-manager: Remove appending of leading dot.
>
> * gnu/home/services.scm (xdg-configuration-files-directory): Add leading dot.
> * gnu/home/services.scm (xdg-configuration-files-service-type): Change name.
> * gnu/home/services/shells.scm (add-shell-profile-file,
> zsh-get-configuration-files, add-zsh-dot-configuration,
> add-zsh-xdg-configuration, add-bash-configuration): Add leading dots.
> * gnu/home/services/symlink-manager.scm (update-symlinks-script): Remove
> leading dot.

[...]

> From 5e1f45fa9ea1aca16843dc85d7d21fd46f3cfcb8 Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew <at> trop.in>
> Date: Tue, 29 Mar 2022 12:47:39 +0300
> Subject: [PATCH 2/2] home: Add home-xdg-data-files-service-type.
>
> * gnu/home/services.scm (home-xdg-data-files-service-type): New variable.
> * gnu/home/services/symlink-manager.scm (update-symlinks-script): Add a proper
> handling for XDG_DATA_HOME value.
> * gnu/home/services/xdg.scm (home-xdg-mime-applications-service-type): Use
> home-xdg-data-files service.

Pushed as 20645d8467852990413c1ea9cf81cec82d23defd.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.