GNU bug report logs - #52806
[PATCH] gnu: Add xinitrc-xsession.

Previous Next

Package: guix-patches;

Reported by: John Kehayias <john.kehayias <at> protonmail.com>

Date: Sun, 26 Dec 2021 16:47:01 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #26 received at 52806 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: control <at> debbugs.gnu.org, "52806 <at> debbugs.gnu.org" <52806 <at> debbugs.gnu.org>
Subject: Re: [bug#52806] [PATCH v5] gnu: Add xinitrc-xsession.
Date: Thu, 27 Jan 2022 16:56:02 +0100
[Message part 1 (text/plain, inline)]
user guix
usertag 52806 + reviewed-looks-good
thanks

John Kehayias schreef op do 27-01-2022 om 03:33 [+0000]:
> Hi Maxime,
> 
> Just wanted to see if you got a chance to see the updated patch I sent previously, where I made the change you suggested:
> 
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > 
> > On Tuesday, January 11th, 2022 at 5:24 PM, Maxime Devos wrote:
> > 
> > > 'outputs' is unused here, so you can simplify the lambda from
> > > (lambda * (#:key outputs #:allow-other-keys) ...)
> > > to
> > > (lambda _ ...).
> > 
> 
> Was there anything else I should take care of?

IIRC, no, the v5 patch appears to be fine, though IIRC I didn't look at
the source code of xinitrc-xsession.

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 167 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.