Subject: bug#52803: closed (Re: [bug#52803] [PATCH v2] gnu: Add headsetcontrol.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 27 Dec 2021 09:51:02 +0000

Your bug report

#52803: [PATCH] gnu: Add headsetcontrol.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
52803: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52803
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#52803] [PATCH v2] gnu: Add headsetcontrol.
From: Nicolas Goaziou <[email-masked]>
To: John Kehayias via Guix-patches via <[email-masked]>
Cc: John Kehayias <[email-masked]>, "[email-masked]" <[email-masked]>
Date: Mon, 27 Dec 2021 10:49:57 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

John Kehayias via Guix-patches via <[email-masked]> writes:

> Subject: [PATCH] gnu: Add headsetcontrol.
>
> * gnu/packages/hardware.scm (headsetcontrol): New variable.

Thank you. I pushed it with the changes detailed below.

> +(define-public headsetcontrol
> +  (package
> +    (name "headsetcontrol")
> +    (version "2.6")
> +    (source (origin
> +             (method git-fetch)

I moved `origin' below `source' and adjusted indentation.

> +             (uri (git-reference
> +                   (url "https://github.com/Sapd/HeadsetControl")
> +                   (commit version)))
> +             (file-name (git-file-name name version))
> +             (sha256
> +              (base32
> +               "0a7zimzi71416pmn6z0l1dn1c2x8p702hkd0k6da9rsznff85a88"))))

I moved hash on the same line as `base32'

> +    (build-system cmake-build-system)
> +    (inputs
> +      (list hidapi))
> +    (synopsis "Sidetone and Battery status for USB headsets")
> +    (description
> +      "A tool to control certain aspects of USB-connected headsets on Linux.

I started the description with the name of the package (guix lint
should warn you about this), and removed reference to Linux, since it is
not useful in Guix.

> +Currently, support is provided for adjusting sidetone, getting battery state,
> +controlling LEDs, and setting the inactive time.")
> +    (home-page "https://github.com/Sapd/HeadsetControl")
> +    (license license:gpl3)))

I used gpl3+ as "main.c" includes "or (at your option) any later
version" in its header.

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: Add headsetcontrol.
From: John Kehayias <[email-masked]>
To: Guix-patches <[email-masked]>
Date: Sun, 26 Dec 2021 16:16:13 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Attached is a patch to add the program headsetcontrol, which allows getting/setting properties for USB headsets. I've been using a previous version (2.4) locally for quite some time and it works well.

The package also builds udev rules, should a note be added to the description that it includes udev rules or anything about that?

Thanks!

John

From 1a22f60566e10b3ce391aa95f3b8b520556cb590 Mon Sep 17 00:00:00 2001
From: John Kehayias <[email-masked]>
Date: Sun, 26 Dec 2021 11:13:29 -0500
Subject: [PATCH] gnu: Add headsetcontrol.

* gnu/packages/hardware.scm (headsetcontrol): New variable.
---
 gnu/packages/hardware.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/hardware.scm b/gnu/packages/hardware.scm
index ddd0f5acc1..129ea7c20e 100644
--- a/gnu/packages/hardware.scm
+++ b/gnu/packages/hardware.scm
@@ -316,6 +316,30 @@ (define-public h-client
       (home-page "https://savannah.nongnu.org/projects/h-client/")
       (license license:gpl3+))))
 
+(define-public headsetcontrol
+  (package
+    (name "headsetcontrol")
+    (version "2.6")
+    (source (origin
+             (method git-fetch)
+             (uri (git-reference
+                   (url "https://github.com/Sapd/HeadsetControl")
+                   (commit version)))
+             (file-name (git-file-name name version))
+             (sha256
+              (base32
+               "0a7zimzi71416pmn6z0l1dn1c2x8p702hkd0k6da9rsznff85a88"))))
+    (build-system cmake-build-system)
+    (inputs
+      (list hidapi))
+    (synopsis "Sidetone and Battery status for USB headsets")
+    (description
+      "A tool to control certain aspects of USB-connected headsets on Linux.
+Currently, support is provided for adjusting sidetone, getting battery state,
+controlling LEDs, and setting the inactive time.")
+    (home-page "https://github.com/Sapd/HeadsetControl")
+    (license license:gpl3)))
+
 (define-public i7z
   (let ((revision "0")
         (commit "1a41ff13db747e962456ddbb5ccb2b7fc43ca0cb"))
-- 
2.34.1