GNU bug report logs - #52799
[PATCH] gnu: guile-udev: Update to 0.2.1

Previous Next

Full log

Message #8 received at 52799 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: poptsov.artyom <at> gmail.com (Artyom V. Poptsov)
Cc: 52799 <at> debbugs.gnu.org
Subject: Re: [bug#52799] [PATCH] gnu: guile-udev: Update to 0.2.1
Date: Sun, 26 Dec 2021 16:23:26 +0100

Hey Artyom,

You may prefer to use AC_PATH_PROG to locate guile_snarf, you can have a
look the configure.ac file of Guile-Avahi for instance.

> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'patch
> +                    (lambda* (#:key inputs outputs #:allow-other-keys)
> +                      (substitute* "build-aux/am/snarf"
> +                        (("\\$\\(shell whereis guile-snarf \\| cut -d' ' -f2\\)")
> +                         (format #f "~a/bin/guile-snarf"
> +                                 (assoc-ref inputs "guile")))))))))

Otherwise, outputs seems to be unused in this snippet. We also now try
to avoid relying on inputs labels. So using "search-input-file" or
(string-append #$(this-package-input guile) "/bin/snarf") would be
preferred.

You can have a look to:
https://guix.gnu.org/en/blog/2021/the-big-change/ for more details.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.