From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 25 13:23:18 2021 Received: (at submit) by debbugs.gnu.org; 25 Dec 2021 18:23:18 +0000 Received: from localhost ([127.0.0.1]:39821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1BhO-00016Q-6u for submit@debbugs.gnu.org; Sat, 25 Dec 2021 13:23:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:47332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1BhK-00016G-Fs for submit@debbugs.gnu.org; Sat, 25 Dec 2021 13:23:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1BhK-0007Ht-Aa for bug-gnu-emacs@gnu.org; Sat, 25 Dec 2021 13:23:14 -0500 Received: from [2001:470:142:3::e] (port=56058 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1BhJ-0002L5-OP; Sat, 25 Dec 2021 13:23:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=QsrRzHTHTplpaWyvdM6MarJko8Lm5f+/a/wqet5aAN0=; b=kYaKcBVemKD2nW IA336r7KHTID7y+Y2Q+b01JwPJbqzpjzYVFh6yVC9jg+CnSmBD5369J7fqoE31gIFdheOliu/A2IU j48Px6HmDpKfzemiIVkS2m7US0nhupzPIXFnQOtnhhcSPePJlvFMYz+LYuWrbwxlsOt4frS9tZoia ZVk5XJN7KxIhqwT7C8rVHRPKL8Q6LeC7UFLuEU3Raj3O9bbD9kWV5aLCPOwTjFNQQWLICLCgn/OdA tRczbsMJEsxq0OAeYyZZ8LBvPPy2f0F3aCe1YIhVDML7TJOGCCYCpxMlmrl82p76x8Ts8/EsnuWCJ ddqZ+aCaSRESzqLz8mug==; Received: from [87.69.77.57] (port=4524 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1BhJ-0005Bi-MO; Sat, 25 Dec 2021 13:23:14 -0500 Date: Sat, 25 Dec 2021 20:23:25 +0200 Message-Id: <831r20r1b6.fsf@gnu.org> From: Eli Zaretskii To: bug-gnu-emacs@gnu.org Subject: 28.0.90; Incorrect CC Mode fontification in frame.c X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Alan Mackenzie X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From: eliz@HOME-C4E4A596F7.mail-host-address-is-not-set --text follows this line-- To reproduce: emacs -Q C-x C-f src/frame.c C-u 1262 M-g g Observe a bunch of function and macro calls fontified as if they were function names in function definitions. For example, the call to create_tty_output, init_frame_faces, and (some) calls of FRAME_LINES. In GNU Emacs 28.0.90 (build 35, i686-pc-mingw32) of 2021-12-25 built on HOME-C4E4A596F7 Repository revision: c09ad0cabde922374c1a34350595a3141ab7f806 Repository branch: emacs-28 Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --with-modules --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: C/*l Minor modes in effect: bug-reference-prog-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t abbrev-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-git diff-mode easy-mmode vc vc-dispatcher bug-reference seq byte-opt gv bytecomp byte-compile cconv cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 87450 7574) (symbols 48 10155 1) (strings 16 29926 2708) (string-bytes 1 1028871) (vectors 16 17847) (vector-slots 8 222745 9949) (floats 8 26 116) (intervals 40 1420 239) (buffers 888 11)) From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 28 15:30:27 2021 Received: (at 52796) by debbugs.gnu.org; 28 Dec 2021 20:30:27 +0000 Received: from localhost ([127.0.0.1]:47534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2J74-00047U-UK for submit@debbugs.gnu.org; Tue, 28 Dec 2021 15:30:27 -0500 Received: from colin.muc.de ([193.149.48.1]:25201 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1n2J73-00047I-K4 for 52796@debbugs.gnu.org; Tue, 28 Dec 2021 15:30:26 -0500 Received: (qmail 26074 invoked by uid 3782); 28 Dec 2021 20:30:19 -0000 Received: from acm.muc.de (p4fe1552f.dip0.t-ipconnect.de [79.225.85.47]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 28 Dec 2021 21:30:19 +0100 Received: (qmail 7622 invoked by uid 1000); 28 Dec 2021 20:30:18 -0000 Date: Tue, 28 Dec 2021 20:30:18 +0000 To: Eli Zaretskii Subject: Re: bug#52796: 28.0.90; Incorrect CC Mode fontification in frame.c Message-ID: References: <831r20r1b6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <831r20r1b6.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52796 Cc: 52796@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli. On Sat, Dec 25, 2021 at 20:23:25 +0200, Eli Zaretskii wrote: > From: eliz@HOME-C4E4A596F7.mail-host-address-is-not-set > --text follows this line-- > To reproduce: > emacs -Q > C-x C-f src/frame.c > C-u 1262 M-g g > Observe a bunch of function and macro calls fontified as if they were > function names in function definitions. For example, the call to > create_tty_output, init_frame_faces, and (some) calls of FRAME_LINES. Sorry about that. There was an error in a cache, the cache that tracks whether or not braces are at the top level. In particular, this error was triggered by the first "struct" keyword in static struct frame * make_terminal_frame (struct terminal *terminal) { where it was failing to recognise the "*" as "cancelling" the expectation of braces as part of the struct construct. The patch below should fix the problem. If you want to try it out, please do. Otherwise I'll commit it to the release branch if I don't hear from you within a few days. > In GNU Emacs 28.0.90 (build 35, i686-pc-mingw32) > of 2021-12-25 built on HOME-C4E4A596F7 > Repository revision: c09ad0cabde922374c1a34350595a3141ab7f806 > Repository branch: emacs-28 > Windowing system distributor 'Microsoft Corp.', version 5.1.2600 > System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) [ .... ] diff --git a/lisp/progmodes/cc-engine.el b/lisp/progmodes/cc-engine.el index d37a50997a..d289148874 100644 --- a/lisp/progmodes/cc-engine.el +++ b/lisp/progmodes/cc-engine.el @@ -6139,7 +6139,7 @@ c-update-brace-stack (setq s (cons -1 (cdr s)))) ((and (equal match ",") (eq (car s) -1))) ; at "," in "class foo : bar, ..." - ((member match '(";" "," ")")) + ((member match '(";" "*" "," "(")) (when (and s (cdr s) (<= (car s) 0)) (setq s (cdr s)))) ((c-keyword-member kwd-sym 'c-flat-decl-block-kwds) diff --git a/lisp/progmodes/cc-langs.el b/lisp/progmodes/cc-langs.el index 53f6206a82..85cc887110 100644 --- a/lisp/progmodes/cc-langs.el +++ b/lisp/progmodes/cc-langs.el @@ -3180,8 +3180,8 @@ c-populate-syntax-table (append (c-lang-const c-flat-decl-block-kwds) (if (c-lang-const c-recognize-<>-arglists) - '("{" "}" ";" "," ")" ":" "<") - '("{" "}" ";" "," ")" ":"))))) + '("{" "}" ";" "*" "," ")" ":" "<") + '("{" "}" ";" "*" "," ")" ":"))))) (c-lang-defvar c-brace-stack-thing-key (c-lang-const c-brace-stack-thing-key)) (c-lang-defconst c-brace-stack-no-semi-key -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 28 19:29:35 2021 Received: (at control) by debbugs.gnu.org; 29 Dec 2021 00:29:35 +0000 Received: from localhost ([127.0.0.1]:47741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2MqV-0003jH-Eh for submit@debbugs.gnu.org; Tue, 28 Dec 2021 19:29:35 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:41892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2MqU-0003iu-N4 for control@debbugs.gnu.org; Tue, 28 Dec 2021 19:29:35 -0500 Received: by mail-pf1-f174.google.com with SMTP id m1so17377460pfk.8 for ; Tue, 28 Dec 2021 16:29:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=7IOqixDj2UpVdHVBqKaciWOTF+6DZ1G9sVv5BN+F3Gs=; b=aAaW6OO9TiXt7hbkeNWFEw7GJ/k4UvodRevjj4jalVilTkSQ05SgDav+f0ooYALkb/ SXQldyYJwvirC25PgLVWiPKfMrYsghhmL1v1F8bZ55GjrLGJW438FI7WkuCZxOIjjF7C dc3DPeKSjjZ3rS0141eFslRYgEyZrED/OPHapaxO+y+wlbe1ZyQ1LR3Ne8AEgX5kMTI9 8S9qCspcuCVNuyn1bq8BfKKZWqTMgjl4SEv0JN7i5i+EtyyQunUtmxN/TlM6wy5ajw+h CtQGZWberQFwVBUAewqc+zVvPFTqvDIFvismIiJLR68ArjxU9DMk6jEmFidofl2Uiv3i rhwA== X-Gm-Message-State: AOAM530QEBNgUDSLh/rvZrPVddXK7ed41L/G6AN6OGqIrr12UypRbt17 FoSsXVqYUJmSWO1MAeVIoT/eHVm3QCExPuFkam3kNYc1 X-Google-Smtp-Source: ABdhPJwi2L0ScChVaXo/gWUezVM3RuvGMj09VtDfBU+pKcI7FXiibORpC6Q7uUstOWT0l3M+1fAxSiE+ZVfm203eWxE= X-Received: by 2002:a62:7745:0:b0:4ba:7251:d559 with SMTP id s66-20020a627745000000b004ba7251d559mr24487391pfc.35.1640737768976; Tue, 28 Dec 2021 16:29:28 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 28 Dec 2021 16:29:28 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 28 Dec 2021 16:29:28 -0800 Message-ID: Subject: control message for bug #52796 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 52796 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 08:47:31 2021 Received: (at 52796) by debbugs.gnu.org; 29 Dec 2021 13:47:32 +0000 Received: from localhost ([127.0.0.1]:48262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2ZIh-0002oB-IL for submit@debbugs.gnu.org; Wed, 29 Dec 2021 08:47:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2ZIf-0002nx-5f for 52796@debbugs.gnu.org; Wed, 29 Dec 2021 08:47:29 -0500 Received: from [2001:470:142:3::e] (port=38944 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2ZIZ-0005A6-O0; Wed, 29 Dec 2021 08:47:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OhRzDBe1nqmjB/HPKfiBdsioze/ozW9lg2DX84E1M5I=; b=iJ5hBkikwKPT PTke7fZsGMxZx/8ZgsMCSKf8rPzYC4vxXEU55cx/c/4w6WkwMmYq4zS5R+xvvYl1R04o2M2brSz8L 3I5kNlhLo/gVatTShG2J8kLl4jO7uAvv/7PoRaET719XKFIT0B/dsmTsfh49Pc0cQT7a2TYVX8iz1 Q2gOxB2jYfkL1UYVbi0YXclact8wzzYkf1tdCiTQ07pRcoXyWn1fFQ232hXNLFhipmcm2bF61sdIe kIM9mYA9yyv26sgOccDj1fMnBs7dpdiaSFl2QlpjeFShJYwBE1RVwZKvK4b5e2jh8NZN/ld+0spuv 9+e2Nwxv4IN4oPL0CAXk3Q==; Received: from [87.69.77.57] (port=1719 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2ZIZ-0005tW-K6; Wed, 29 Dec 2021 08:47:23 -0500 Date: Wed, 29 Dec 2021 15:47:26 +0200 Message-Id: <83sfubjzf6.fsf@gnu.org> From: Eli Zaretskii To: Alan Mackenzie In-Reply-To: (message from Alan Mackenzie on Tue, 28 Dec 2021 20:30:18 +0000) Subject: Re: bug#52796: 28.0.90; Incorrect CC Mode fontification in frame.c References: <831r20r1b6.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52796 Cc: 52796@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 28 Dec 2021 20:30:18 +0000 > Cc: 52796@debbugs.gnu.org > From: Alan Mackenzie > > The patch below should fix the problem. If you want to try it out, > please do. Otherwise I'll commit it to the release branch if I don't > hear from you within a few days. Thanks, this fixes the problem. Please install. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 14:23:58 2021 Received: (at 52796-done) by debbugs.gnu.org; 29 Dec 2021 19:23:59 +0000 Received: from localhost ([127.0.0.1]:50391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2eYI-00081E-KT for submit@debbugs.gnu.org; Wed, 29 Dec 2021 14:23:58 -0500 Received: from colin.muc.de ([193.149.48.1]:61776 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1n2eYG-00080u-8O for 52796-done@debbugs.gnu.org; Wed, 29 Dec 2021 14:23:56 -0500 Received: (qmail 45710 invoked by uid 3782); 29 Dec 2021 19:23:49 -0000 Received: from acm.muc.de (p4fe15949.dip0.t-ipconnect.de [79.225.89.73]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 29 Dec 2021 20:23:49 +0100 Received: (qmail 30478 invoked by uid 1000); 29 Dec 2021 19:23:48 -0000 Date: Wed, 29 Dec 2021 19:23:48 +0000 To: Eli Zaretskii Subject: Re: bug#52796: 28.0.90; Incorrect CC Mode fontification in frame.c Message-ID: References: <831r20r1b6.fsf@gnu.org> <83sfubjzf6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83sfubjzf6.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52796-done Cc: acm@muc.de, 52796-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Eli. On Wed, Dec 29, 2021 at 15:47:26 +0200, Eli Zaretskii wrote: > > Date: Tue, 28 Dec 2021 20:30:18 +0000 > > Cc: 52796@debbugs.gnu.org > > From: Alan Mackenzie > > The patch below should fix the problem. If you want to try it out, > > please do. Otherwise I'll commit it to the release branch if I don't > > hear from you within a few days. > Thanks, this fixes the problem. Please install. Done. I'm closing the bug with this post. -- Alan Mackenzie (Nuremberg, Germany). From unknown Tue Jun 17 01:50:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 Jan 2022 12:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator