From unknown Thu Jun 19 14:03:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52794 <52794@debbugs.gnu.org> To: bug#52794 <52794@debbugs.gnu.org> Subject: Status: 28.0.90; Eshell: error while completing Reply-To: bug#52794 <52794@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:03:46 +0000 retitle 52794 28.0.90; Eshell: error while completing reassign 52794 emacs submitter 52794 =C3=93scar Fuentes severity 52794 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 25 12:51:10 2021 Received: (at submit) by debbugs.gnu.org; 25 Dec 2021 17:51:10 +0000 Received: from localhost ([127.0.0.1]:39809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1BCF-00008a-Ud for submit@debbugs.gnu.org; Sat, 25 Dec 2021 12:51:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:37958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1BCB-00008I-BI for submit@debbugs.gnu.org; Sat, 25 Dec 2021 12:51:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1BCA-0006kH-6o for bug-gnu-emacs@gnu.org; Sat, 25 Dec 2021 12:51:02 -0500 Received: from relayout03-redir.e.movistar.es ([86.109.101.203]:16769) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1BC7-0002IX-O6 for bug-gnu-emacs@gnu.org; Sat, 25 Dec 2021 12:51:01 -0500 Received: from sky (234.red-88-17-68.dynamicip.rima-tde.net [88.17.68.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 981711563@telefonica.net) by relayout03.e.movistar.es (Postfix) with ESMTPSA id 4JLs0t3C3szMl9l for ; Sat, 25 Dec 2021 18:50:54 +0100 (CET) From: =?utf-8?Q?=C3=93scar_Fuentes?= To: bug-gnu-emacs@gnu.org Subject: 28.0.90; Eshell: error while completing Date: Sat, 25 Dec 2021 18:50:53 +0100 Message-ID: <8735mgshdu.fsf@telefonica.net> MIME-Version: 1.0 Content-Type: text/plain X-TnetOut-Country: IP: 88.17.68.234 | Country: ES X-TnetOut-Information: AntiSPAM and AntiVIRUS on relayout03 X-TnetOut-MsgID: 4JLs0t3C3szMl9l.A6049 X-TnetOut-SpamCheck: no es spam, clean X-TnetOut-From: ofv@wanadoo.es X-TnetOut-Watermark: 1641059454.97006@uVfAnGLdxj0TvkKqT4ykHw X-Spam-Status: No Received-SPF: softfail client-ip=86.109.101.203; envelope-from=ofv@wanadoo.es; helo=relayout03-redir.e.movistar.es X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) emacs -Q M-x eshell Go to a directory with two or more files with the same prefix. The Emacs build directory, for instance. Let's suppose the prefix is `c'. mv c* foo[TAB] Debugger entered--Lisp error: (wrong-type-argument stringp ("config.log" "config.log~" "config.status")) string-match("\\.\\.\\.+/" ("config.log" "config.log~" "config.status")) #f(compiled-function (arg) #)((eshell-extended-glob (eshell-convert (concat "c" "*")))) mapcar(#f(compiled-function (arg) #) ("mv" (eshell-extended-glob (eshell-convert (concat "c" "*"))) "l")) eshell-complete-parse-arguments() pcomplete-parse-arguments(nil) pcomplete-completions() pcomplete-completions-at-point() completion--capf-wrapper(pcomplete-completions-at-point all) run-hook-wrapped(completion--capf-wrapper pcomplete-completions-at-point all) completion-at-point() funcall-interactively(completion-at-point) call-interactively(completion-at-point nil nil) command-execute(completion-at-point) The patch below fixes the problem, which if my analysis is correct, was introduced by: commit 9224a863192b1317ef307bcc76abfdfbad73b796 Author: Michalis V Date: Fri Aug 27 18:46:04 2021 +0200 Fix completion of extended "..." syntax in eshell * lisp/eshell/em-cmpl.el (eshell-complete-parse-arguments): Expand "..." (bug#19626). emacs/lisp/eshell/em-cmpl.el @@ -380,7 +380,7 @@ (setq val (number-to-string val))) ;; expand .../ etc that only eshell understands to ;; standard ../../ - ((string-match "\\.\\.\\.+/" val) + ((and (stringp val) (string-match "\\.\\.\\.+/" val)) (setq val (eshell-expand-multiple-dots val)))) (or val ""))) args) The problem is that `val' is a list when more than one file matches the glob, and then `string-match' errors-out. Ok to commit in emacs-28 ? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 27 09:50:15 2021 Received: (at 52794) by debbugs.gnu.org; 27 Dec 2021 14:50:16 +0000 Received: from localhost ([127.0.0.1]:42436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1rKJ-0002tQ-MP for submit@debbugs.gnu.org; Mon, 27 Dec 2021 09:50:15 -0500 Received: from relayout03-redir.e.movistar.es ([86.109.101.203]:43503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1rKG-0002sy-T2 for 52794@debbugs.gnu.org; Mon, 27 Dec 2021 09:50:15 -0500 Received: from sky (234.red-88-17-68.dynamicip.rima-tde.net [88.17.68.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 981711563@telefonica.net) by relayout03.e.movistar.es (Postfix) with ESMTPSA id 4JN0vK3z7nzMlx4 for <52794@debbugs.gnu.org>; Mon, 27 Dec 2021 15:50:05 +0100 (CET) From: =?utf-8?Q?=C3=93scar_Fuentes?= To: 52794@debbugs.gnu.org Subject: Re: bug#52794: 28.0.90; Eshell: error while completing References: <8735mgshdu.fsf@telefonica.net> Date: Mon, 27 Dec 2021 15:50:04 +0100 In-Reply-To: <8735mgshdu.fsf@telefonica.net> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Sat, 25 Dec 2021 18:50:53 +0100") Message-ID: <87fsqeqezn.fsf@telefonica.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TnetOut-Country: IP: 88.17.68.234 | Country: ES X-TnetOut-Information: AntiSPAM and AntiVIRUS on relayout03 X-TnetOut-MsgID: 4JN0vK3z7nzMlx4.A4956 X-TnetOut-SpamCheck: no es spam, clean X-TnetOut-From: ofv@wanadoo.es X-TnetOut-Watermark: 1641221405.64626@57sMfpEBjChVfl6dEE242g X-Spam-Status: No X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 52794 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ping. > Ok to commit to emacs-28 ? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 27 09:52:34 2021 Received: (at 52794) by debbugs.gnu.org; 27 Dec 2021 14:52:34 +0000 Received: from localhost ([127.0.0.1]:42440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1rMY-0002xQ-3v for submit@debbugs.gnu.org; Mon, 27 Dec 2021 09:52:34 -0500 Received: from quimby.gnus.org ([95.216.78.240]:42182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1rMW-0002xB-95 for 52794@debbugs.gnu.org; Mon, 27 Dec 2021 09:52:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5criufZA2ExsTnI00v5eE4Oa5Pl89YvtRZ8OINvGbPQ=; b=nujX3YNtGZrV9s6kVjbBkSaCy0 kmXTkgm5jHSLUhedS+fyIsKaABCoUNDZLOmpm8XFU3LqoNdKHoacRlv3F+LkGbo+S2h+Ghd4ETntk rS9jD0WwqVduuFoYCAsMupi6ZrLfv9o5g091mmYxCoXmJ/PtUAgTEnWLhYed9KJIbYpE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1rMK-0006NO-PF; Mon, 27 Dec 2021 15:52:25 +0100 From: Lars Ingebrigtsen To: =?utf-8?Q?=C3=93scar?= Fuentes Subject: Re: bug#52794: 28.0.90; Eshell: error while completing References: <8735mgshdu.fsf@telefonica.net> X-Now-Playing: William Basinski's _Lamentations_: "Please, This Shit Has Got To Stop" Date: Mon, 27 Dec 2021 15:52:18 +0100 In-Reply-To: <8735mgshdu.fsf@telefonica.net> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Sat, 25 Dec 2021 18:50:53 +0100") Message-ID: <87o852ayn1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Óscar Fuentes writes: > The problem is that `val' is a list when more than one file matches the > glob, and then `string-match' errors-out. > > Ok to commit in emacs-28 ? Yup. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52794 Cc: 52794@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) =C3=93scar Fuentes writes: > The problem is that `val' is a list when more than one file matches the > glob, and then `string-match' errors-out. > > Ok to commit in emacs-28 ? Yup. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 27 10:07:53 2021 Received: (at 52794-done) by debbugs.gnu.org; 27 Dec 2021 15:07:53 +0000 Received: from localhost ([127.0.0.1]:43814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1rbN-0003lM-Gc for submit@debbugs.gnu.org; Mon, 27 Dec 2021 10:07:53 -0500 Received: from relayout04-redir.e.movistar.es ([86.109.101.204]:36549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1rbL-0003l4-TM for 52794-done@debbugs.gnu.org; Mon, 27 Dec 2021 10:07:52 -0500 Received: from sky (234.red-88-17-68.dynamicip.rima-tde.net [88.17.68.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 981711563@telefonica.net) by relayout04.e.movistar.es (Postfix) with ESMTPSA id 4JN1Hh4HYSz110K; Mon, 27 Dec 2021 16:07:44 +0100 (CET) From: =?utf-8?Q?=C3=93scar_Fuentes?= To: Lars Ingebrigtsen Subject: Re: bug#52794: 28.0.90; Eshell: error while completing References: <8735mgshdu.fsf@telefonica.net> <87o852ayn1.fsf@gnus.org> Date: Mon, 27 Dec 2021 16:07:43 +0100 In-Reply-To: <87o852ayn1.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 27 Dec 2021 15:52:18 +0100") Message-ID: <87bl12qe68.fsf@telefonica.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TnetOut-Country: IP: 88.17.68.234 | Country: ES X-TnetOut-Information: AntiSPAM and AntiVIRUS on relayout04 X-TnetOut-MsgID: 4JN1Hh4HYSz110K.A93F5 X-TnetOut-SpamCheck: no es spam, clean X-TnetOut-From: ofv@wanadoo.es X-TnetOut-Watermark: 1641222464.81323@HTrJwJk7mFOZNj406bfNSA X-Spam-Status: No X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 52794-done Cc: 52794-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Lars Ingebrigtsen writes: >> Ok to commit in emacs-28 ? > > Yup. Thanks. Pushed as ea65de757766fa4cb5a090012e2f6a0aeef0b9f8. From unknown Thu Jun 19 14:03:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 25 Jan 2022 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator