GNU bug report logs - #5277
23.1.90; cus-load.el path for cedet/semantic/bovine/c.el

Previous Next

Package: emacs;

Reported by: Kevin Ryde <user42 <at> zip.com.au>

Date: Tue, 6 Oct 2009 18:55:07 UTC

Severity: normal

Tags: patch

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#5277: closed (23.1.90; cus-load.el path for cedet/semantic/bovine/c.el)
Date: Sun, 12 May 2013 00:01:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 11 May 2013 20:00:26 -0400
with message-id <4eobchrrs5.fsf <at> fencepost.gnu.org>
and subject line Re: bug#5277: 23.1.90; cus-load.el path for cedet/semantic/bovine/c.el
has caused the debbugs.gnu.org bug report #5277,
regarding 23.1.90; cus-load.el path for cedet/semantic/bovine/c.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
5277: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5277
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Kevin Ryde <user42 <at> zip.com.au>
To: emacs-pretest-bug <at> gnu.org
Subject: bug#5277: 23.1.90; cus-load.el path for cedet/semantic/bovine/c.el
Date: Thu, 31 Dec 2009 07:43:51 +1100
[Message part 3 (text/plain, inline)]
In the current cvs cus-load.el has

    (put 'c 'custom-loads '("cc-vars" cmacexp cpp hideif "c"))

I think the "c" there is cedet/semantic/bovine/c.el.  I believe it won't
load under that name as the cedet subdirs aren't in the load-path.

That c.el file has

    generated-autoload-load-name: "semantic/bovine/c"

which I presume is designed for its autoloads.  I wonder if it should be
used for the custom loads too.  Seems a bit like hard work to remember
it in every sub-file, but building a load-path relative name might go
wrong in worse ways if making deps from files not yet in a loadable tree
or whatnot.

cus-load.el.subfiles.diff below is the what's changed by using
`generated-autoload-load-name'.  Notice for instance the "ede/locate"
one was previously loading "locate", which would mean the wrong
locate.el -- a danger of duplicate names among .el files I suppose.


2009-12-30  Kevin Ryde  <user42 <at> zip.com.au>

	* cus-dep.el (custom-make-dependencies): Add hack-local-variables
	to pick up generated-autoload-load-name from
	cedet/semantic/bovine/c.el and similar.  This ensures
	"semantic/bovine/c" gets into custom-loads, instead of bare "c"
	which is no good as the bovine subdir is not in load-path.

[cus-dep.el.local-vars.diff (text/x-diff, attachment)]
[cus-load.el.subfiles.diff (text/x-diff, attachment)]
[Message part 6 (text/plain, inline)]

In GNU Emacs 23.1.90.2 (i586-pc-linux-gnu, GTK+ Version 2.18.5)
 of 2009-12-27 on blah.blah
configured using `configure  'CFLAGS=-O -g' '--prefix=/down/emacs/b/inst' '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: t
[Message part 7 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 5277-done <at> debbugs.gnu.org
Subject: Re: bug#5277: 23.1.90; cus-load.el path for cedet/semantic/bovine/c.el
Date: Sat, 11 May 2013 20:00:26 -0400
Version: 24.4

Thanks; applied. I don't totally like reusing
generated-autoload-load-name for this, but in practice it works, and it
doesn't seem worth adding another variable for this.


This bug report was last modified 12 years and 15 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.