GNU bug report logs - #52763
[PATCH] etc: Match define-public only at line start.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: bug#52763: closed (Re: bug#52763: [PATCH] etc: Match
 define-public only at line start.)
Date: Wed, 19 Jan 2022 20:18:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#52763: [PATCH] etc: Match define-public only at line start.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 52763 <at> debbugs.gnu.org.

-- 
52763: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52763
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 52763-done <at> debbugs.gnu.org
Subject: Re: bug#52763: [PATCH] etc: Match define-public only at line start.
Date: Wed, 19 Jan 2022 21:17:42 +0100

Am Mittwoch, dem 05.01.2022 um 23:25 +0100 schrieb Ludovic Courtès:
> Hi,
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> skribis:
> 
> > The current regexp simply matches the first occurence, which more
> > often than not points to the *previous* variable.
> > 
> > * etc/snippets/text-mode/guix-commit-message-update-package ($1):
> > Restrict match to beginning of line with optional indentation.
> 
> LGTM, thanks!
The manual says 14 days after no review, not 14 days after review. 
Pushed now :)

[Message part 3 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] etc: Match define-public only at line start.
Date: Fri, 24 Dec 2021 01:33:14 +0100

The current regexp simply matches the first occurence, which more often than
not points to the *previous* variable.

* etc/snippets/text-mode/guix-commit-message-update-package ($1): Restrict
match to beginning of line with optional indentation.
---
 etc/snippets/text-mode/guix-commit-message-update-package | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/snippets/text-mode/guix-commit-message-update-package b/etc/snippets/text-mode/guix-commit-message-update-package
index f187419aa2..b08df74a0b 100644
--- a/etc/snippets/text-mode/guix-commit-message-update-package
+++ b/etc/snippets/text-mode/guix-commit-message-update-package
@@ -8,7 +8,7 @@ gnu: ${1:`(with-temp-buffer
            (magit-git-wash #'magit-diff-wash-diffs
              "diff" "--staged")
            (goto-char (point-min))
-           (when (re-search-forward "(define-public \\(\\S-+\\)" nil 'noerror)
+           (when (re-search-forward "^[ ]*(define-public \\(\\S-+\\)" nil 'noerror)
              (match-string-no-properties 1)))`}: Update to ${2:`(with-temp-buffer
     (magit-git-wash #'magit-diff-wash-diffs
       "diff" "--staged")
-- 
2.34.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.