Subject: bug#52763: closed (Re: bug#52763: [PATCH] etc: Match define-public only at line start.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 19 Jan 2022 20:18:02 +0000

Your bug report

#52763: [PATCH] etc: Match define-public only at line start.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
52763: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52763
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#52763: [PATCH] etc: Match define-public only at line start.
From: Liliana Marie Prikler <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Wed, 19 Jan 2022 21:17:42 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Am Mittwoch, dem 05.01.2022 um 23:25 +0100 schrieb Ludovic Courtès:
> Hi,
> 
> Liliana Marie Prikler <[email-masked]> skribis:
> 
> > The current regexp simply matches the first occurence, which more
> > often than not points to the *previous* variable.
> > 
> > * etc/snippets/text-mode/guix-commit-message-update-package ($1):
> > Restrict match to beginning of line with optional indentation.
> 
> LGTM, thanks!
The manual says 14 days after no review, not 14 days after review. 
Pushed now :)

Subject: [PATCH] etc: Match define-public only at line start.
From: Liliana Marie Prikler <[email-masked]>
To: [email-masked]
Date: Fri, 24 Dec 2021 01:33:14 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

The current regexp simply matches the first occurence, which more often than
not points to the *previous* variable.

* etc/snippets/text-mode/guix-commit-message-update-package ($1): Restrict
match to beginning of line with optional indentation.
---
 etc/snippets/text-mode/guix-commit-message-update-package | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/snippets/text-mode/guix-commit-message-update-package b/etc/snippets/text-mode/guix-commit-message-update-package
index f187419aa2..b08df74a0b 100644
--- a/etc/snippets/text-mode/guix-commit-message-update-package
+++ b/etc/snippets/text-mode/guix-commit-message-update-package
@@ -8,7 +8,7 @@ gnu: ${1:`(with-temp-buffer
            (magit-git-wash #'magit-diff-wash-diffs
              "diff" "--staged")
            (goto-char (point-min))
-           (when (re-search-forward "(define-public \\(\\S-+\\)" nil 'noerror)
+           (when (re-search-forward "^[ ]*(define-public \\(\\S-+\\)" nil 'noerror)
              (match-string-no-properties 1)))`}: Update to ${2:`(with-temp-buffer
     (magit-git-wash #'magit-diff-wash-diffs
       "diff" "--staged")
-- 
2.34.0