From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 22 10:02:25 2021 Received: (at submit) by debbugs.gnu.org; 22 Dec 2021 15:02:25 +0000 Received: from localhost ([127.0.0.1]:59498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n038L-0007kG-6i for submit@debbugs.gnu.org; Wed, 22 Dec 2021 10:02:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:53694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n038K-0007k9-4T for submit@debbugs.gnu.org; Wed, 22 Dec 2021 10:02:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n038J-00041u-Ux for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 10:02:23 -0500 Received: from [2607:f8b0:4864:20::72c] (port=39771 helo=mail-qk1-x72c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n038H-0008K2-W5 for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 10:02:23 -0500 Received: by mail-qk1-x72c.google.com with SMTP id 69so2533350qkd.6 for ; Wed, 22 Dec 2021 07:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=iB/0QPMmRMf8iFBJxXv3+1wHhy6YnYoXplKwNqHY59A=; b=V8yQlBSNgaOtQxMkwBrlTKH36cdDLzNTl05nSWauQZxTsQZOm6aNHfkQJNgCPSG3uk u4OBfP8R/IbMHvt1rjmoDQdWAmFmupZjkOQE3SuC41Z/s0xY8rVT0yTWoKzZ0SSHd0xQ ZVXEeQNqaBULlakSVGx3p15IvddjNXIbOtO0obzg34501PUI5M4trtvcWAZEabDQHcuj Og2UodG4HAGTEZtbLH5Xdd1H8IYmN+bBtszJfaGrOYo6KwmZUaZ9XlOXa8Sg0cH2mHtF DGE62/KBgoQicqjRV8OZey782xS/k5dQYBPj9J8iB6pM6pfxWnSyivoFcSqBz5gTFYol QYBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=iB/0QPMmRMf8iFBJxXv3+1wHhy6YnYoXplKwNqHY59A=; b=OKJ2fuoWA0W8Z/CqQG0jN/NeKLfk0P+mrOpoay5Pu8LgEB1rtEpgzlseNOA8r0uojE NCHS2WWzLDmzAJGsWEE7jXrFz8BeEMfbop1Gh0BCxSpl5Pokqzxn3i3ifEzGRl4PLa9H knoJDj/u7k6dc2K79Hm4jX12/TuBxorl7ErRMXTMDKVlN5lC0d07ykuP8P7Rk/AFb2J/ 4W/NF7i93Z1JxWHXq6Lf+cyGCYRpuaRs3bdar4wHe1scP06PjOCRuM9X5Ynilnp27sya lQSHtwbs1g2SQYhWvr6ga0VuOul/sFtkg9y8+zi5dGTqZJMe/YcJvImCg/bzOb1FDPB5 Qv3g== X-Gm-Message-State: AOAM532NdQNOTTsNsz7H/WDAmUzCHP5epQS9qoQTNtQsS2Ouv/Gqh+rm 0UCeM4WDC2oXg8ZqwRLoSfZ1AFBOF15XpemTnoziQq9Q7zl+HA== X-Google-Smtp-Source: ABdhPJwkDPhGRjSrhmuCU3XMXUPfsMueWnxUVuUWXcECElE7qnVojTWYgun65p89zGGRbsz+snRBr8jh63sFyFLhi74= X-Received: by 2002:a37:9b82:: with SMTP id d124mr968734qke.487.1640185340361; Wed, 22 Dec 2021 07:02:20 -0800 (PST) MIME-Version: 1.0 From: David Fussner Date: Wed, 22 Dec 2021 15:01:54 +0000 Message-ID: Subject: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000942dd005d3bd685a" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::72c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=dfussner@googlemail.com; helo=mail-qk1-x72c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000942dd005d3bd685a Content-Type: text/plain; charset="UTF-8" When `etags-xref-prefer-current-file' is t and only the current file contains (multiple) definitions of the same function, the list returns each tag twice. To reproduce: cd src/ ../lib-src/etags term.c ./emacs -Q term.c C-s tty_free_frame_resources RTN M-. RTN src/term.c 3786: tty_free_frame_resources 3798: tty_free_frame_resources (setq etags-xref-prefer-current-file t) M-. src/term.c 3786: tty_free_frame_resources 3798: tty_free_frame_resources 3786: tty_free_frame_resources 3798: tty_free_frame_resources The variable is new in 28.1, so I thought the bug might want fixing on this branch. In my testing, cl-delete appears not to delete ITEMs from SEQ if such deletion would leave SEQ empty. I can't find this behavior documented anywhere, but I may be looking in the wrong places. Patch attached, which just tests for equality of the two lists of definitions, and only returns one of them in that case. Thanks, David. In GNU Emacs 28.0.90 (build 3, i686-pc-linux-gnu, GTK+ Version 3.18.9, cairo version 1.14.6) of 2021-12-22 built on newfont Repository revision: ce7ec828f15446c1218614d083da489c76e9b37d Repository branch: cl-del-again Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 System Description: Slackware 14.2 Configured using: 'configure PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LANG: en_US.ISO8859-1 locale-coding-system: iso-latin-1-unix Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Load-path shadows: /home/dfussner/.emacs.d/elpa/transient-20210426.2141/transient hides /home/dfussner/src/emacs/emacs/lisp/transient Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date help-fns radix-tree help-mode misearch multi-isearch vc-git diff-mode easy-mmode vc-dispatcher bug-reference doom-opera-theme doom-themes doom-themes-base edmacro kmacro server preview-latex auto-loads tex-site finder-inf info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 275188 34213) (symbols 24 15726 0) (strings 16 79597 3815) (string-bytes 1 2052213) (vectors 8 24263) (vector-slots 4 365962 27260) (floats 8 208 168) (intervals 28 819 0) (buffers 564 14) (heap 1024 25437 912)) --000000000000942dd005d3bd685a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-xref-backend-definitions-in-etags.el.patch" Content-Disposition: attachment; filename="0001-Fix-xref-backend-definitions-in-etags.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kxhnxwxt0 RnJvbSBjZTdlYzgyOGYxNTQ0NmMxMjE4NjE0ZDA4M2RhNDg5Yzc2ZTliMzdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBGdXNzbmVyIDxkZnVzc25lckBnb29nbGVtYWlsLmNv bT4KRGF0ZTogVHVlLCAyMSBEZWMgMjAyMSAxNzozODo1MiArMDAwMApTdWJqZWN0OiBbUEFUQ0hd IEZpeCB4cmVmLWJhY2tlbmQtZGVmaW5pdGlvbnMgaW4gZXRhZ3MuZWwKCiogbGlzcC9wcm9nbW9k ZXMvZXRhZ3MuZWwgKHhyZWYtYmFja2VuZC1kZWZpbml0aW9ucyk6IFdoZW4KJ2V0YWdzLXhyZWYt cHJlZmVyLWN1cnJlbnQtZmlsZScgaXMgdCwgdGVzdCB3aGV0aGVyICdkZWZpbml0aW9ucycgYW5k CidzYW1lLWZpbGUtZGVmaW5pdGlvbnMnIGFyZSBlcXVhbCBiZWZvcmUgY29uY2F0ZW5hdGluZyB0 aGVtLgotLS0KIGxpc3AvcHJvZ21vZGVzL2V0YWdzLmVsIHwgNSArKystLQogMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3By b2dtb2Rlcy9ldGFncy5lbCBiL2xpc3AvcHJvZ21vZGVzL2V0YWdzLmVsCmluZGV4IGY1M2IwOWQ5 ZTguLjBlNzBlN2VlN2EgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2V0YWdzLmVsCisrKyBi L2xpc3AvcHJvZ21vZGVzL2V0YWdzLmVsCkBAIC0yMDkyLDggKzIwOTIsOSBAQCB4cmVmLWJhY2tl bmQtZGVmaW5pdGlvbnMKICAgICAgICAgICAgKHB1c2ggZGVmaW5pdGlvbiBzYW1lLWZpbGUtZGVm aW5pdGlvbnMpCiAgICAgICAgICAgIHQpKQogICAgICAgIGRlZmluaXRpb25zKQotICAgICAgKHNl dHEgZGVmaW5pdGlvbnMgKG5jb25jIChucmV2ZXJzZSBzYW1lLWZpbGUtZGVmaW5pdGlvbnMpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVmaW5pdGlvbnMpKSkKKyAgICAgIChzZXRx IHNhbWUtZmlsZS1kZWZpbml0aW9ucyAobnJldmVyc2Ugc2FtZS1maWxlLWRlZmluaXRpb25zKSkK KyAgICAgICh1bmxlc3MgKGVxdWFsIGRlZmluaXRpb25zIHNhbWUtZmlsZS1kZWZpbml0aW9ucykK KyAgICAgICAgKHNldHEgZGVmaW5pdGlvbnMgKG5jb25jIHNhbWUtZmlsZS1kZWZpbml0aW9ucyBk ZWZpbml0aW9ucykpKSkKICAgICBkZWZpbml0aW9ucykpCiAKIChjbC1kZWZtZXRob2QgeHJlZi1i YWNrZW5kLWFwcm9wb3MgKChfYmFja2VuZCAoZXFsICdldGFncykpIHBhdHRlcm4pCi0tIAoyLjE3 LjYKCg== --000000000000942dd005d3bd685a-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 23 04:12:36 2021 Received: (at 52734) by debbugs.gnu.org; 23 Dec 2021 09:12:36 +0000 Received: from localhost ([127.0.0.1]:60356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0K9L-00025Z-NQ for submit@debbugs.gnu.org; Thu, 23 Dec 2021 04:12:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0K9J-00025K-Vq for 52734@debbugs.gnu.org; Thu, 23 Dec 2021 04:12:34 -0500 Received: from [2001:470:142:3::e] (port=47986 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0K9E-0007AQ-M4; Thu, 23 Dec 2021 04:12:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lBLjZUSAeKgcmS5pYsbdEipZzzytBp+T4GzH9hYEAGM=; b=r3fBB6Z5blu/ 1Gc6jasC/UKQExpwKOrS/aAblT0C6Q7ThsuAPH2YdlAOAD3Rqabeef1idwNb7mIhWrtNfOO7knBBg Ni+/zVFXs/STy8l6RGGc4Vl138ebVTVXIM6qJdp3wZtUVOuVNhBKrySzTmaNDHBpxlgjV5vwS+F6g o37Y4l8oQ+UtFjKI0VR0Tt7paaJ05Ida92x30EBeioyiiU22zSrflTIEYpTla2lAtcad25+OS6Fq6 Kzz/X6WqZpEzTplAwwyyJWFg0dznzJNPYx3ze48hrtsgOa2BRK6rORpS5b8Gsyc0vXijFinfIl9Is EeMY+JwHPAi1yMgDo7l74g==; Received: from [87.69.77.57] (port=1672 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0K9E-0000k6-Jq; Thu, 23 Dec 2021 04:12:28 -0500 Date: Thu, 23 Dec 2021 11:12:33 +0200 Message-Id: <831r23wupq.fsf@gnu.org> From: Eli Zaretskii To: David Fussner , Dmitry Gutov In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52734 Cc: 52734@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 22 Dec 2021 15:01:54 +0000 > From: David Fussner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > When `etags-xref-prefer-current-file' is t and only the current file > contains (multiple) definitions of the same function, the list returns > each tag twice. To reproduce: > > cd src/ > ../lib-src/etags term.c > ./emacs -Q term.c > C-s tty_free_frame_resources RTN > M-. RTN > > src/term.c > 3786: tty_free_frame_resources > 3798: tty_free_frame_resources > > (setq etags-xref-prefer-current-file t) > M-. > > src/term.c > 3786: tty_free_frame_resources > 3798: tty_free_frame_resources > 3786: tty_free_frame_resources > 3798: tty_free_frame_resources > > The variable is new in 28.1, so I thought the bug might want fixing on > this branch. In my testing, cl-delete appears not to delete ITEMs from > SEQ if such deletion would leave SEQ empty. I can't find this behavior > documented anywhere, but I may be looking in the wrong places. > > Patch attached, which just tests for equality of the two lists of > definitions, and only returns one of them in that case. Dmitry, any comments? The patch LGTM, FWIW. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 23 19:27:05 2021 Received: (at 52734) by debbugs.gnu.org; 24 Dec 2021 00:27:05 +0000 Received: from localhost ([127.0.0.1]:35269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0YQL-0007jI-7Y for submit@debbugs.gnu.org; Thu, 23 Dec 2021 19:27:05 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:45704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0YQK-0007im-9l for 52734@debbugs.gnu.org; Thu, 23 Dec 2021 19:27:04 -0500 Received: by mail-wr1-f50.google.com with SMTP id v7so14369409wrv.12 for <52734@debbugs.gnu.org>; Thu, 23 Dec 2021 16:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CVsB0kEGSjnvQpIrosbMZjZAkyFqC/LUvEuUjUQMXEI=; b=SVlBbwuhoBNFvP+Nq3Iu4jty8cl8KEfolZzhwMz78LarEmNzY0GcWFCExY7eTPmV3f 44t+0oaIbUKy+mrnnab6byXZSPK9usC1XiZ7i3EnYw+rxbwAeM6r8wZzJtvV2UTK3dEb dIYBYpWsoKcKHmiGs/Iog5YVBZYTAy9uDsh4suj210IoWPk9h03iDx/X8fY6ZxA3qppt A1cyCSgf3EIiaOjctu8I6Jb8a0am8ECzQQ6ZK7CZAFfc13LtFdCx4MCfIEutG6UeD6zt F3FGItCCnHqYo7/nbRVkObwvC7t4tnTEy7bV1rxICCSYzeG6lZ+4oYOd36bnXoLeNjrh 0mAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CVsB0kEGSjnvQpIrosbMZjZAkyFqC/LUvEuUjUQMXEI=; b=w08ci3Pld4xJRyWcjtOCl2ybnzJv1+YbEeIASLshvrl2EUAxc3qCdaeWICzncpsiLz ldHCDTaYf1ubEwUPAU1NY2hgI/aI6o/ERno5GBh0cSNISJOGOujHtIDrnJpHFccb10wq 1c9028Sm7/eQlKfdnw6MNhleDIwyWVxzoalSyBhA0Q4KciM9/kcFF3Otcu8Ml4mXXIZY YAXXRDWuHVUe8Kf+7zH+QoGDKsk7OmLzPBdgkKhk27wTX91elLGm/HQ/9Qs+J48kWUO/ 4eftTDzhdMBcXCj7eRhwaM67hQKGCyKmt7+oxgEhSjPQthldAV17NRwgWxGbwXlMjHs2 AJ/A== X-Gm-Message-State: AOAM533kVn0tbLUC78l3qOqalmwCXnFnUa4DKhGmyfcPPqIfeoiJisJ1 x5Nqtrw6LWhaEwLz2lpqnSEGN1038ZA= X-Google-Smtp-Source: ABdhPJwxxi8gTftZaJffoHdwCSTMArp7XyQaHAWDX93gyuRDUU/vmBjTf5mYfCrDPnKZrHx7+GDnqA== X-Received: by 2002:a5d:4e46:: with SMTP id r6mr3097761wrt.161.1640305618335; Thu, 23 Dec 2021 16:26:58 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l4sm7098287wry.85.2021.12.23.16.26.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Dec 2021 16:26:57 -0800 (PST) Subject: Re: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list To: David Fussner , 52734@debbugs.gnu.org References: From: Dmitry Gutov Message-ID: <1d482bb8-41fc-5446-b655-cd41fb23e8a5@yandex.ru> Date: Fri, 24 Dec 2021 02:25:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 52734 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hi! On 22.12.2021 18:01, David Fussner via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > The variable is new in 28.1, so I thought the bug might want fixing on > this branch. In my testing, cl-delete appears not to delete ITEMs from > SEQ if such deletion would leave SEQ empty. I can't find this behavior > documented anywhere, but I may be looking in the wrong places. The thing about cl-delete-if is it (like other sequence functions) has the changed sequence in its return value (which the piece of code under discussion leaves unused -- a brain fart on my part). As a destructive function, it also modifies the original structure, but when the variable is still pointing at the first link of the linked list, the behavior is basically unpredictable. Even though it might look right most of the time under usual conditions. See a different patch in the other email. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 23 19:29:03 2021 Received: (at 52734) by debbugs.gnu.org; 24 Dec 2021 00:29:03 +0000 Received: from localhost ([127.0.0.1]:35273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0YSF-0007mN-JY for submit@debbugs.gnu.org; Thu, 23 Dec 2021 19:29:03 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:52080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0YSD-0007lp-PJ for 52734@debbugs.gnu.org; Thu, 23 Dec 2021 19:29:02 -0500 Received: by mail-wm1-f43.google.com with SMTP id e5so4259857wmq.1 for <52734@debbugs.gnu.org>; Thu, 23 Dec 2021 16:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rD+xrmWpYxFB9Y3qj0EnQBSkFdvKBq2EmcRi1QzCoak=; b=I4OXZIoJ2YAvZuZmGn3A1qSnwKeKpGvXh7qO1cV9gdQY26dh9Xb/XoTSRTFRMRCQHN db3qKXhKVMjiol1gOqrflC8N990PKR9+PFmSkIOepYJBLSGP5LE6h23VuXbqK7AIJ3gs QMj3U9tQss4uzWSRp6OBXkBw2m3KO/EzyfDJTIiZUTCBzTat496UDIj4cdgTo9Ex55vc C3JbXzRMuBLFZ8xDjvTM+AfY5XWnHtKgVtrumygiMR0yMXxBCaf75OiGGbLuLTWQhMsT HtQw3HVdl0Qh2KoqT6hGnpHxK9V/WWqzYE8If27RpIGRAZVqo4oLmqLJR09jjibrFi0Y 5pww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rD+xrmWpYxFB9Y3qj0EnQBSkFdvKBq2EmcRi1QzCoak=; b=1NmW0xp/5bQrSbEDww8p7cajuDPBfez0BCAzy6bA0h5VYwvXWqp6DCIMdfdbI3q3M/ /LVR7PxA1WW+UNrReH4+Xhq3tcUJNDjc3ADDQSc72ihnqkP94h2p7LoJZBjWDpPqfTT9 1ezPnTGAhAIKXP050nn8biILSMM2bZIGON9YuYrIeS3Xj4cnF05CwGVR7wUPp3AlkiS9 prSP7+wU7hjJPLNlnKVxzXZ+EJKIHOP9jbwqCxae2P09L6ev5Qyb5cgpTR41tQbkxfmd o4z3vdlL/015oJiB4UXKT541EGUO2g+8xjDg2dBcAhqIOdy7jt4leDnIKxmIbUpz9X+O VH7g== X-Gm-Message-State: AOAM533GCeR6ui6OXX8LGXtmKFIyItJNRaZHq3wrzmbp7nqDTaf+7DE4 JHER+VnmETTisF++R4TEdKR/HPNzlmQ= X-Google-Smtp-Source: ABdhPJwl/aQ5ghEn9KgWr0+Z8iQFFR+3gZbFvW0pCoCg72G33vZstfka98LrxjEVe3jg1Cx7/cZVAQ== X-Received: by 2002:a1c:5445:: with SMTP id p5mr3221186wmi.137.1640305736038; Thu, 23 Dec 2021 16:28:56 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m17sm6155733wrw.11.2021.12.23.16.28.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Dec 2021 16:28:55 -0800 (PST) Subject: Re: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list To: Eli Zaretskii , David Fussner References: <831r23wupq.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 24 Dec 2021 02:27:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <831r23wupq.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 52734 Cc: 52734@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hi Eli, On 23.12.2021 12:12, Eli Zaretskii wrote: > Dmitry, any comments? The patch LGTM, FWIW. How about the patch below instead? And I'd like to apply it to emacs-28. diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el index f53b09d9e8..a63c3f3397 100644 --- a/lisp/progmodes/etags.el +++ b/lisp/progmodes/etags.el @@ -2084,14 +2084,15 @@ xref-backend-definitions (definitions (etags--xref-find-definitions symbol)) same-file-definitions) (when (and etags-xref-prefer-current-file file) - (cl-delete-if - (lambda (definition) - (when (equal file - (xref-location-group - (xref-item-location definition))) - (push definition same-file-definitions) - t)) - definitions) + (setq definitions + (cl-delete-if + (lambda (definition) + (when (equal file + (xref-location-group + (xref-item-location definition))) + (push definition same-file-definitions) + t)) + definitions)) (setq definitions (nconc (nreverse same-file-definitions) definitions))) definitions)) From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 24 02:09:07 2021 Received: (at 52734) by debbugs.gnu.org; 24 Dec 2021 07:09:08 +0000 Received: from localhost ([127.0.0.1]:35544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0ehP-0000si-M8 for submit@debbugs.gnu.org; Fri, 24 Dec 2021 02:09:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0ehL-0000sA-5P for 52734@debbugs.gnu.org; Fri, 24 Dec 2021 02:09:06 -0500 Received: from [2001:470:142:3::e] (port=51198 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0eh4-0002gb-Bb; Fri, 24 Dec 2021 02:08:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/jzxchkLavPLrAlULewPocii+Uo34/Wckv8tEMAdy3o=; b=bKf/j5JtfhLj BwE6XmmAFY2eikxa4wEaaBnjmHS/iyrEKhT0hWuylBvvW0avKHZm3t9AXsXJyX2bhZEj5XeTDeXFl AGaNQbfNJ7d7M9fNPL3gyNBwp27bOEfL9ZjAEO5Q3htAzamNuIee9n10jHo6qr3BhuX543m7NurKy bA9wgxWQbEqF5/l3IXkiFx9GtCsTvZBsUrom/YJSjDDo37pjFFRch5fgXTPJhfIZfyn97mJcXex/0 irc0n4HJdyt2LlVGR45LYYApKHe2bN+tu5XPxituL96HJ2Qiclv2fQeR+ffgCkULyzwsrjEs18Bih jDCN/5M79XgVfIp5SHuOQQ==; Received: from [87.69.77.57] (port=3841 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0eh4-00061G-8z; Fri, 24 Dec 2021 02:08:46 -0500 Date: Fri, 24 Dec 2021 09:08:54 +0200 Message-Id: <838rwatr7d.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Fri, 24 Dec 2021 02:27:45 +0200) Subject: Re: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list References: <831r23wupq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52734 Cc: 52734@debbugs.gnu.org, dfussner@googlemail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 52734@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 24 Dec 2021 02:27:45 +0200 > > On 23.12.2021 12:12, Eli Zaretskii wrote: > > Dmitry, any comments? The patch LGTM, FWIW. > > How about the patch below instead? > > And I'd like to apply it to emacs-28. Fine with me, on both counts. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 24 08:09:53 2021 Received: (at 52734) by debbugs.gnu.org; 24 Dec 2021 13:09:53 +0000 Received: from localhost ([127.0.0.1]:35858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0kKT-0001un-Qq for submit@debbugs.gnu.org; Fri, 24 Dec 2021 08:09:53 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:45616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0kKP-0001uX-7K for 52734@debbugs.gnu.org; Fri, 24 Dec 2021 08:09:48 -0500 Received: by mail-qk1-f178.google.com with SMTP id e25so2565676qkl.12 for <52734@debbugs.gnu.org>; Fri, 24 Dec 2021 05:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J6t0CImCtwMj6n8MgUQZp77jWO24n5Bocp0WP3Wk6fE=; b=WdTfMl/Jwjx9/r4T291Dvw96FhZKM1tm3qdMmvHU91UaENdF7aJgsng36gJWkyJvR6 lPo8aajNhapebNx8LJz4IkSzY3Nl6gEwqQyLUr1aKio4Sk+2ahT/T+UzXytxH4UFRVBa dlKeOviuUp30L6DbnNNtpouJWA4IWh7WpAERbXj/MliWE91cwTTOGfKiXnef+l3LgPPh rhmMidF3lHduIr9IrN9eCDtltDx/ceuzUKvOtjpe5Gy6oDS29QJegI9CeTB97H8DHK/D NGO9xc5otBdHsSCu0knRJGXYEN/wiXK+tmVR08TttTwxflNLodc94i3/pHcVawhSlbXB KVlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J6t0CImCtwMj6n8MgUQZp77jWO24n5Bocp0WP3Wk6fE=; b=X3HDBiEqTKNXnpwOk9c2l++RA/VmTVguPl8TL0AWm74aUD1bEI+kPUZo15ayjs4FaZ 68sxlHcZJUZt27MTGFF7nHpMq/QF+YhGeJoDr40JtSZ8cPopN5fwaCyC963UR0IdQN+X f32Tkfx4knLwCfyQ6Y4ul+YTAnsOsq/ks+ldHs/YNqjrdYLmhZxth81RT0xwFlOwZ6o9 JgKU1wR2d/btQzr/R6Jpdop1dCrdHUgIJsQPRjofneS7ubVCtF3kX1I6WP97yw/v0N0w gIlwIQSsT7tFd1YragjM25trKSNBfg1twVV//bPrlPeNjP6SdU4bhQhD3bDzHP+8y5tW m/Jw== X-Gm-Message-State: AOAM5316bxnAcVzJO5JDzeRVpZob98MgeF8W9EKmWNqGOq/U1CQcImpM UeheX1HBEYr8bZ6wP2u3hh96uZwKZGkyvJTFDCk= X-Google-Smtp-Source: ABdhPJyZYTXl6ne3eSZg0InEULELjuoimOvgKBWI/l2FkF2P9XPeOEjCJQl7croSckT4lB7jPCcsVmBed0hY6tnp59Q= X-Received: by 2002:a05:620a:290d:: with SMTP id m13mr4658337qkp.267.1640351379725; Fri, 24 Dec 2021 05:09:39 -0800 (PST) MIME-Version: 1.0 References: <831r23wupq.fsf@gnu.org> <838rwatr7d.fsf@gnu.org> In-Reply-To: <838rwatr7d.fsf@gnu.org> From: David Fussner Date: Fri, 24 Dec 2021 13:09:14 +0000 Message-ID: Subject: Re: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52734 Cc: 52734@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks, Dmitry, both for the explanation and for the (much superior) patch. I've tried it on the emacs-28 branch and it works well, so please close the bug whenever it's convenient. All best, David. On Fri, 24 Dec 2021 at 07:08, Eli Zaretskii wrote: > > > Cc: 52734@debbugs.gnu.org > > From: Dmitry Gutov > > Date: Fri, 24 Dec 2021 02:27:45 +0200 > > > > On 23.12.2021 12:12, Eli Zaretskii wrote: > > > Dmitry, any comments? The patch LGTM, FWIW. > > > > How about the patch below instead? > > > > And I'd like to apply it to emacs-28. > > Fine with me, on both counts. > > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 24 08:20:47 2021 Received: (at 52734-done) by debbugs.gnu.org; 24 Dec 2021 13:20:47 +0000 Received: from localhost ([127.0.0.1]:35868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0kV5-0002Bx-Hv for submit@debbugs.gnu.org; Fri, 24 Dec 2021 08:20:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0kV2-0002Bj-VG for 52734-done@debbugs.gnu.org; Fri, 24 Dec 2021 08:20:46 -0500 Received: from [2001:470:142:3::e] (port=53870 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0kUs-00043J-7U; Fri, 24 Dec 2021 08:20:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zihsLkHTz1CX5mA4ZuMRlAvA3qnV3DSKSfguhS+C3ko=; b=qBJ3our2DbgK KC56l3U+C7m6ovYPq2C72Aq1WxZndTvM8yhKu+pDz02/BJpebTHHj7VruWUWQ3rwDN9erULnWRNMi V9a0t3RUpRRumkTWqWrV0uh28ow8l13aRrK/3PZcQcA2xNY+Sa+Vib/cBM2DI5r9Hhui2LlrdN3DG ncbFabJAlDM/SK/KyW4H8qCELN6zakkfiA8WF6AvqJlkY5vhK/vA4bZg3cKqrmlRImxLXNEsn0Bal vKQVpU4LswgEbMpvoQPWTlg9ayu8U+7U2bi7KVM1QahvUgwDrnaqXTs6ofZeCsiUI3qNVUic5r+c7 o2AFuyP8mN2qVci0pKvfyg==; Received: from [87.69.77.57] (port=2969 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0kUr-0001Vz-Bm; Fri, 24 Dec 2021 08:20:34 -0500 Date: Fri, 24 Dec 2021 15:20:41 +0200 Message-Id: <83k0furvfa.fsf@gnu.org> From: Eli Zaretskii To: David Fussner In-Reply-To: (message from David Fussner on Fri, 24 Dec 2021 13:09:14 +0000) Subject: Re: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list References: <831r23wupq.fsf@gnu.org> <838rwatr7d.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52734-done Cc: 52734-done@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: David Fussner > Date: Fri, 24 Dec 2021 13:09:14 +0000 > Cc: Dmitry Gutov , 52734@debbugs.gnu.org > > Thanks, Dmitry, both for the explanation and for the (much superior) > patch. I've tried it on the emacs-28 branch and it works well, so > please close the bug whenever it's convenient. Thanks for testing the patch, I'm therefore closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 24 08:28:47 2021 Received: (at 52734-done) by debbugs.gnu.org; 24 Dec 2021 13:28:47 +0000 Received: from localhost ([127.0.0.1]:35875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0kcp-0002Nz-CJ for submit@debbugs.gnu.org; Fri, 24 Dec 2021 08:28:47 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:42835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0kck-0002Ng-QJ for 52734-done@debbugs.gnu.org; Fri, 24 Dec 2021 08:28:46 -0500 Received: by mail-wr1-f43.google.com with SMTP id w20so8553939wra.9 for <52734-done@debbugs.gnu.org>; Fri, 24 Dec 2021 05:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0BF3QYO7PTNVE3mpmy0JaMm6U+qfmZ8RTB1GC3LyjU4=; b=DleX/0bc3hIMSXTuLBVIxe1XWJOtQVaRQ28bs+L03ZK+yUX5tXucJkYNAGsBdLn+U/ mTSl+/rZsRsNVpTnM5T8gJttfgqPBcjEQaZNWURXR3chIzTaYX3/zd7vKA6ZCzwDNG9O tOLf+uyjzpAEuuvaw8zgKdtL46ljGQTW7ld7z3zxS2rViunWr9ecYz/lhJ+u3vfxaywz UBBhLj18SE92gjg52yNGxkGGb5bEDwGfpHfxGYphReRPb+Vg+zgRxDNHgCmUQiHZgNsm s0Nhde52Az2KpTv+rloFHBbKwOJCemVCWcyKZ5OsEOnmhxzZhOUj+kcj0T68lDtnRDnW tEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0BF3QYO7PTNVE3mpmy0JaMm6U+qfmZ8RTB1GC3LyjU4=; b=1wi+B/Hxr54tO88dG5BVQdmxhMY6B5q7jGUaROeV9VR0XJPwnTHCc8wBZBW4QAy90P Y1MpsSt4dXU/0PrXAAYaB51Kj3wwG6N9SnI2GFEDjM0+R3QAsvLbVPR+DgvjnwqNOgN5 JPaMCUxT2vL18P5eUPrsMc3efG1K42xdfZsYaNpFd6GS4sR0Jm66J1ijLUg70fFN4Njv yIUfxjD3Gs5aUO/qNcyrqxeqvgarCoc0IZlZYF9lPVpSUfaRK22KIA122l42zHQxG6MI ObUoVXpnrDIpAkOd/3KMzsNd59m2r2+xwUTBQZJh8miZF4LZ+e0ET40CTYBpwEKG6ZxZ DVlA== X-Gm-Message-State: AOAM533wd/L9TW1Qk9vyIfX5Lxxz8++f5jemo115UUsARyBaLZleTH/e Liq2sEVhUzOw/PxuSEkw14P0u1l49Og= X-Google-Smtp-Source: ABdhPJx3SmSOhzUZjJkyXBSqRKieKaFJoQg1Hp7nloGhD+UD2E3s8/y3Ul8mSign1xdw7xOz0rvVRg== X-Received: by 2002:a05:6000:1883:: with SMTP id a3mr4770337wri.59.1640352517031; Fri, 24 Dec 2021 05:28:37 -0800 (PST) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c187sm10881773wme.33.2021.12.24.05.28.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Dec 2021 05:28:36 -0800 (PST) Subject: Re: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list To: Eli Zaretskii , David Fussner References: <831r23wupq.fsf@gnu.org> <838rwatr7d.fsf@gnu.org> <83k0furvfa.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 24 Dec 2021 15:27:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <83k0furvfa.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 52734-done Cc: 52734-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 24.12.2021 16:20, Eli Zaretskii wrote: >> From: David Fussner >> Date: Fri, 24 Dec 2021 13:09:14 +0000 >> Cc: Dmitry Gutov,52734@debbugs.gnu.org >> >> Thanks, Dmitry, both for the explanation and for the (much superior) >> patch. I've tried it on the emacs-28 branch and it works well, so >> please close the bug whenever it's convenient. > Thanks for testing the patch, I'm therefore closing this bug. I guess I should install the patch then! (Revision c09ad0cabd) From unknown Thu Aug 14 21:54:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 Jan 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator