From unknown Fri Jun 13 11:23:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Dec 2021 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52730@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164014410510867 (code B ref -1); Wed, 22 Dec 2021 03:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Dec 2021 03:35:05 +0000 Received: from localhost ([127.0.0.1]:56365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzsPA-0002pC-M5 for submit@debbugs.gnu.org; Tue, 21 Dec 2021 22:35:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:55096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzsP6-0002oh-3h for submit@debbugs.gnu.org; Tue, 21 Dec 2021 22:35:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzsP5-0001WJ-Uf for guix-patches@gnu.org; Tue, 21 Dec 2021 22:34:59 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:37506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzsP2-0005GW-0v for guix-patches@gnu.org; Tue, 21 Dec 2021 22:34:59 -0500 Received: from [2001:470:8:9f5:e878:315c:5ed6:89d] (helo=leyden.home.eronel.org) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzsOy-00080z-CB for guix-patches@gnu.org; Tue, 21 Dec 2021 22:34:52 -0500 From: Jack Hill Date: Tue, 21 Dec 2021 22:34:42 -0500 Message-Id: <20211222033442.14793-1-jackhill@jackhill.us> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@jackhill.us; helo=minsky.hcoop.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the empyt list as a default value for #:configure-flags. --- gnu/packages/gstreamer.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index 87adb7c92a..1f6a56e30d 100644 --- a/gnu/packages/gstreamer.scm +++ b/gnu/packages/gstreamer.scm @@ -1034,7 +1034,7 @@ (define-public gst-editing-services (license license:gpl2+))) (define-public gst-plugins/selection - (lambda* (pkg #:key plugins configure-flags) + (lambda* (pkg #:key plugins (configure-flags '())) "Build PKG with only PLUGINS enabled. Optionally, if CONFIGURE-FLAGS are given, also pass them to the build system instead of the ones used by PKG." (package/inherit pkg -- 2.34.0 From unknown Fri Jun 13 11:23:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 00:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill , 52730@debbugs.gnu.org Received: via spool by 52730-submit@debbugs.gnu.org id=B52730.164030667231369 (code B ref 52730); Fri, 24 Dec 2021 00:45:02 +0000 Received: (at 52730) by debbugs.gnu.org; 24 Dec 2021 00:44:32 +0000 Received: from localhost ([127.0.0.1]:35287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0YhE-00089s-Av for submit@debbugs.gnu.org; Thu, 23 Dec 2021 19:44:32 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0YhC-00089g-8d for 52730@debbugs.gnu.org; Thu, 23 Dec 2021 19:44:30 -0500 Received: by mail-wr1-f66.google.com with SMTP id e5so14507077wrc.5 for <52730@debbugs.gnu.org>; Thu, 23 Dec 2021 16:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=wFb0wYVb7glTcSJ4NQbZWhEgOuAZx0eSg2WCEmY2sMI=; b=QiWHOwxR+a+0DzFLEwQfza95Oq44suX0ZSKhAJzdFfnYiu/l2P7JzXAn5Qad0iGkGd 899NHOgKW0Jl52AXKbioJtuyAjNnqOHoOokJ///jXJ+NReAHDeo2dXhAVXKAjs13TyKn YNzkS8ux8+79e0AMnFFuOCkZlOvmCk9djtWz1CfrC11R0UnzAgUDRtRkeb17T63UX3Ql 8koGYZWf5ub8VBpH8F2g1J4ETeuLBmJXitC1VoHUX6sdNc6UpbBsCJ/DR120G/KtKwSR wmhCOXQYdsiWdU+gzMmf7gvQ6VXNcB9+HEIrVOE0u1yUy4cLznb6t+DszdcdwmOf8srl 1WCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=wFb0wYVb7glTcSJ4NQbZWhEgOuAZx0eSg2WCEmY2sMI=; b=Rzgr5Xh23yf1QqgMbOYCdxiabSE8bd8o0jgPX3cuMOz2Yqb5XV971i1pgfcgP099o8 +Qwn3oy+tTbkV5w09eA4zZ5OfCuxqcL6tU3NfmY3ikRuC6ElYcMs4rxRwzajVaOcRP1W 4AXyVgFZ/JYiDkfQwBdzFRLi18EAqVTyRO+QNYTgszVoWYHzZqu6cTF55glAD7Q2gKml RHhE9ABnh6jppJCOlxZZQDkdmK3lGp7//cfOOcdLpVFokyDXBaG9FpWhpBf4+SAHwk27 RFHuRbuWYxc9HLGJeQYAooB7ymgANkK01iz8QXUvPGPQr9xbj79Kz8+2jO0bdAlh8Qah kCng== X-Gm-Message-State: AOAM531iU4Hnb3R0aaXQ4HK46uWRhblHwwsZazFgS/t7RE1Xyp6TZda/ LtoIbemq0knwEmbyo+HSZ+Y= X-Google-Smtp-Source: ABdhPJz7xlChXETQ8Tfz2WNtGGpkJZXrxKkKphZWD17S6xiFFBbDMDQbRz+9fwMSzojnBVgdXZIFbg== X-Received: by 2002:adf:fdc9:: with SMTP id i9mr3205599wrs.660.1640306664404; Thu, 23 Dec 2021 16:44:24 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id m10sm6365305wms.25.2021.12.23.16.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Dec 2021 16:44:24 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Fri, 24 Dec 2021 01:44:22 +0100 In-Reply-To: <20211222033442.14793-1-jackhill@jackhill.us> References: <20211222033442.14793-1-jackhill@jackhill.us> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill: > * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the > empyt list as a default value for #:configure-flags. The current implementation ought to copy pre-existing configure-flags as-is if you don't supply flags on your own. I personally believe that's preferable over an empty value, that will probably be reset. WDYT? From unknown Fri Jun 13 11:23:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 05:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 52730@debbugs.gnu.org Received: via spool by 52730-submit@debbugs.gnu.org id=B52730.164032304224472 (code B ref 52730); Fri, 24 Dec 2021 05:18:02 +0000 Received: (at 52730) by debbugs.gnu.org; 24 Dec 2021 05:17:22 +0000 Received: from localhost ([127.0.0.1]:35438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0cxG-0006Me-DZ for submit@debbugs.gnu.org; Fri, 24 Dec 2021 00:17:22 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:35430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0cxF-0006MQ-K6 for 52730@debbugs.gnu.org; Fri, 24 Dec 2021 00:17:21 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0cxA-0006Ur-8J; Fri, 24 Dec 2021 00:17:16 -0500 Date: Fri, 24 Dec 2021 00:17:16 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: <20211222033442.14793-1-jackhill@jackhill.us> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, 24 Dec 2021, Liliana Marie Prikler wrote: > Hi, > > Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill: >> * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the >> empyt list as a default value for #:configure-flags. > The current implementation ought to copy pre-existing configure-flags > as-is if you don't supply flags on your own. I personally believe > that's preferable over an empty value, that will probably be reset. > WDYT? Yes, I agree that the current implementation ought to, but it doesn't. Instead it complains: """ ice-9/psyntax.scm:2794:12: In procedure syntax-violation: Syntax error: unknown location: quote: bad syntax in form quote """ I'll see about a v2. Thanks! Jack From unknown Fri Jun 13 11:23:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 06:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 52730@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 52730@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1640327860380 (code B ref -1); Fri, 24 Dec 2021 06:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Dec 2021 06:37:40 +0000 Received: from localhost ([127.0.0.1]:35507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0eCs-00005z-Uv for submit@debbugs.gnu.org; Fri, 24 Dec 2021 01:37:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:36542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0eCq-00005q-08 for submit@debbugs.gnu.org; Fri, 24 Dec 2021 01:37:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0eCp-0006HR-Ji for guix-patches@gnu.org; Fri, 24 Dec 2021 01:37:31 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:59494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0eCe-0002yu-KB for guix-patches@gnu.org; Fri, 24 Dec 2021 01:37:30 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0eCb-0000dF-OH; Fri, 24 Dec 2021 01:37:17 -0500 Date: Fri, 24 Dec 2021 01:37:17 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: <20211222033442.14793-1-jackhill@jackhill.us> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@jackhill.us; helo=minsky.hcoop.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Fri, 24 Dec 2021, Jack Hill wrote: > > > On Fri, 24 Dec 2021, Liliana Marie Prikler wrote: > >> Hi, >> >> Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill: >>> * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the >>> empyt list as a default value for #:configure-flags. > >> The current implementation ought to copy pre-existing configure-flags >> as-is if you don't supply flags on your own. I personally believe >> that's preferable over an empty value, that will probably be reset. >> WDYT? > > Yes, I agree that the current implementation ought to, but it doesn't. > Instead it complains: > > """ > ice-9/psyntax.scm:2794:12: In procedure syntax-violation: > Syntax error: > unknown location: quote: bad syntax in form quote > """ > > I'll see about a v2. I've looked at it for a little bit now, but I'm afraid that I'm stuck. I tried setting the default to #f (which may have been happening implicitly anyway): ``` (define-public gst-plugins/selection (lambda* (pkg #:key plugins (configure-flags #f)) "Build PKG with only PLUGINS enabled. Optionally, if CONFIGURE-FLAGS are given, also pass them to the build system instead of the ones used by PKG." (package/inherit pkg (arguments (substitute-keyword-arguments (package-arguments pkg) ((#:configure-flags flags `(,@(or configure-flags '()))) `(append (list ,@(map (lambda (plugin) (string-append "-D" plugin "=enabled")) plugins)) (list ,@(or configure-flags flags)))) ((#:phases phases) `(modify-phases ,phases (add-after 'unpack 'disable-auto-plugins (lambda _ (substitute* "meson_options.txt" (("'auto'") "'disabled'"))))))))))) ``` but that still gives me the "bad syntax in form quote" message. I can keep thinking about it, but if someone else knows the solution, I'd be happy to learn from you :) Best, Jack From unknown Fri Jun 13 11:23:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Dec 2021 07:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 52730@debbugs.gnu.org Received: via spool by 52730-submit@debbugs.gnu.org id=B52730.164033259316379 (code B ref 52730); Fri, 24 Dec 2021 07:57:02 +0000 Received: (at 52730) by debbugs.gnu.org; 24 Dec 2021 07:56:33 +0000 Received: from localhost ([127.0.0.1]:35582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0fRJ-0004G7-6t for submit@debbugs.gnu.org; Fri, 24 Dec 2021 02:56:33 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0fRF-0004Fr-Bn for 52730@debbugs.gnu.org; Fri, 24 Dec 2021 02:56:31 -0500 Received: by mail-wr1-f68.google.com with SMTP id t26so16103202wrb.4 for <52730@debbugs.gnu.org>; Thu, 23 Dec 2021 23:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=4FUp5nkWDGbvquyQk9ulLOb1H3wQIM7HdYqNh8ET8CY=; b=YWlhAGgcsRtQWAhirTsBob+WTYg7dmwILjVp4LdPeglD45dw10op+A9GQS2KVxFMAj ggdEm3bq+Pt75PJ7su40TVvoy9efP7ExFII62pHGxwhUAKqcTX/LuwxvP8UrHxiVkZzG DnS7Ohkca/36TBYxeqsVpBClJFoP09FAh8ncxWX11QZW5LTzL3dPlNKW2WE6E7m8QwQR jBdSWMRj+ST9qAPEj+aubpFEMJk9eRHwHJoFt3QkbJmGv29qDbwZG5lbEYvGQnsWQW0C HITPjsBLFNZIrJXFU9ayMPuS4jP7JQrtB1uqi1kpdoDw1BOz67kTSvsIHjuzHErZCIaK A28A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4FUp5nkWDGbvquyQk9ulLOb1H3wQIM7HdYqNh8ET8CY=; b=fklWnWI/ud7t3GYJr7rBEU0sMGGRLEBwRY7EfucUqYpUwKxyhh7XijJ07HpDyR5W1j 594Vb/hH8bU+PVaTPmFAMJCteT2q1crkCxPrRSGbtEB52qXRsBiVB6rWCZPn1ugoHIt/ 2iQefoMgPPc3X6KQGTU/reQXyVsmKztnWXk311dhiadKDVOPM+AYb3E7St0arvKk/9Li JrG8d7FBaH4hgfND+hc4f1o3ykXNjW09nnevygfMuzd2/1IZ+WBezO5g1+/R2MVr3O3f GbdsdB3GQWdEijH+6r+svJ06ms20yaORrvb2JnN4hb1xJ/W5ODEApe0Hiwcu8UpN0f/z kgfA== X-Gm-Message-State: AOAM533nDPb6d3ojtFlX6eNFKVrMnenqh0xiwUTXPjkusKYSfy/T0llP +FSD/bY8WdG/7kq10A6O+Xk= X-Google-Smtp-Source: ABdhPJwnuArmWQaaJyZBnxmOWUZv6AB3YINpwBh+lSjEPfvGCrpnEdh7hNM865R3P+A9OPZujud86g== X-Received: by 2002:a05:6000:18a2:: with SMTP id b2mr4034174wri.277.1640332583338; Thu, 23 Dec 2021 23:56:23 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d143sm6606784wmd.6.2021.12.23.23.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Dec 2021 23:56:22 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Fri, 24 Dec 2021 08:56:21 +0100 In-Reply-To: References: <20211222033442.14793-1-jackhill@jackhill.us> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jack, Am Freitag, dem 24.12.2021 um 01:37 -0500 schrieb Jack Hill: > On Fri, 24 Dec 2021, Jack Hill wrote: > > I've looked at it for a little bit now, but I'm afraid that I'm > stuck. I tried setting the default to #f (which may have been > happening implicitly anyway): Yes, if you don't supply an optional argument in Guile (or I guess in Scheme generally), that argument gets #f as value. > ``` > (define-public gst-plugins/selection >    (lambda* (pkg #:key plugins (configure-flags #f)) >      "Build PKG with only PLUGINS enabled.  Optionally, if CONFIGURE- > FLAGS are > given, also pass them to the build system instead of the ones used by > PKG." >      (package/inherit pkg >        (arguments >         (substitute-keyword-arguments (package-arguments pkg) >           ((#:configure-flags flags `(,@(or configure-flags '()))) >            `(append >              (list >               ,@(map (lambda (plugin) >                        (string-append "-D" plugin "=enabled")) >                      plugins)) >              (list ,@(or configure-flags flags)))) >            ((#:phases phases) >             `(modify-phases ,phases >                (add-after 'unpack 'disable-auto-plugins >                  (lambda _ >                    (substitute* "meson_options.txt" >                      (("'auto'") "'disabled'"))))))))))) > ``` > > but that still gives me the "bad syntax in form quote" message. I can > keep thinking about it, but if someone else knows the solution, I'd > be happy to learn from you :) I swear this used to work before the c-u-f merge. There might be a problem mixing this with gexps or something I didn't account for back then. From unknown Fri Jun 13 11:23:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Aug 2022 19:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 52730@debbugs.gnu.org Received: via spool by 52730-submit@debbugs.gnu.org id=B52730.166067920330196 (code B ref 52730); Tue, 16 Aug 2022 19:47:02 +0000 Received: (at 52730) by debbugs.gnu.org; 16 Aug 2022 19:46:43 +0000 Received: from localhost ([127.0.0.1]:48429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO2WR-0007qx-99 for submit@debbugs.gnu.org; Tue, 16 Aug 2022 15:46:43 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:43687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO2WN-0007qi-3I for 52730@debbugs.gnu.org; Tue, 16 Aug 2022 15:46:41 -0400 Received: by mail-ed1-f67.google.com with SMTP id o22so14823693edc.10 for <52730@debbugs.gnu.org>; Tue, 16 Aug 2022 12:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc; bh=/eiKaUQPLjzQwitxMgVmXt7W+UeuM+8/xDOKCnXyVU4=; b=ilHIqxI7G1R+knE/iz2dVMBsfNsDXvkbCkMoZFgUd80sIPMdB1xERwlDC7M+T5zlaD 1hH8WNyjHxZktAnDt2AGjE2zGT1HcNNBBbmHsWv0rk9K7Y2LdiKC7nakkwDbd4WRdID1 VCIRM9GkTp7VxLuI8SwFfJ2Cj6SDT+R5VaM/UidF27vX8uwEzELkT2AWGx+jyL/7iwTz RxPdwsOOn3Ic//vObOP+MVEaNvaDIYGalsarfBherXy84BGeM6Z9XRo2aO69sAs/gVyG Tda4OD2Q3LYO19IOb1mcitRCEcUjjbsgLawnf2cqj6EG3oWfiyaFDOGVfvw9GPOKWy+g JbcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc; bh=/eiKaUQPLjzQwitxMgVmXt7W+UeuM+8/xDOKCnXyVU4=; b=j0A+WHmfjmnTRKavhUcGItLcYFw+gnFTbEkeQQEwKGwg+nYijmq2F5At8aMux0UB/o 7cgkF7NqatLD6XBrovPllIO/jXYqqQmgDdVMDwR74h9cKYVf1xiK6f6tLHr15M6Zp+Rd 6Rl2qmENPJZpIkkQLicMZIWWY6fzRPkiUJHADlY30SVB3DGgt2nhks7QW29jNsL9Kop5 BRmTD5+EjPBnJn0g8SO2iyvIN1EPzKCUz/F0W4NYRMa3WCcavxq3vUh7AM7zRbm23ceA kahNhfW7H4B/3x6fSSGotb2G/R5chA3w5XJq5DvphsijouMyXm7bYAnth3AL/+GhLyRa 4m/A== X-Gm-Message-State: ACgBeo3JQr6I1LOgKhFrNPL5ajV2ftAdA8o06H3txmzumdyj88MDrZ46 9PlBrsTYgVULTGWQS+PnKRa22lBi4i8= X-Google-Smtp-Source: AA6agR6pcLPEKvWrlSgm9P9onqfGQyXuzAWcprsPnIt5XerhEL5In6GefqPAGz+T2ifZbXGh/vVmKA== X-Received: by 2002:a05:6402:90a:b0:443:8b10:bcad with SMTP id g10-20020a056402090a00b004438b10bcadmr13332838edz.416.1660679193284; Tue, 16 Aug 2022 12:46:33 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id w25-20020a17090633d900b0072b1bc9b37fsm5633705eja.22.2022.08.16.12.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 12:46:32 -0700 (PDT) Message-ID: <3da5b151a9e9312953660549fbbf5fa9153ac275.camel@gmail.com> From: Liliana Marie Prikler Date: Tue, 16 Aug 2022 21:46:31 +0200 In-Reply-To: References: <20211222033442.14793-1-jackhill@jackhill.us> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Jack, Am Freitag, dem 24.12.2021 um 00:17 -0500 schrieb Jack Hill: > On Fri, 24 Dec 2021, Liliana Marie Prikler wrote: > > > Hi, > > > > Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill: > > > * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the > > > empyt list as a default value for #:configure-flags. > > > The current implementation ought to copy pre-existing configure- > > flags > > as-is if you don't supply flags on your own.  I personally believe > > that's preferable over an empty value, that will probably be reset. > > WDYT? > > Yes, I agree that the current implementation ought to, but it > doesn't. > Instead it complains: > > """ > ice-9/psyntax.scm:2794:12: In procedure syntax-violation: > Syntax error: > unknown location: quote: bad syntax in form quote > """ Is this still an issue? Also try staging, which has gstreamer 1.20 and some gexp-improvements for gst-plugins/selection. Cheers From unknown Fri Jun 13 11:23:53 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#52730] [PATCH] gnu: gst-plugins/selection: Make #:configure-flags optional. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Jan 2024 16:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52730 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: Liliana Marie Prikler , 52730@debbugs.gnu.org Received: via spool by 52730-submit@debbugs.gnu.org id=B52730.17059414382551 (code B ref 52730); Mon, 22 Jan 2024 16:38:01 +0000 Received: (at 52730) by debbugs.gnu.org; 22 Jan 2024 16:37:18 +0000 Received: from localhost ([127.0.0.1]:41633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRxIR-0000f0-5Z for submit@debbugs.gnu.org; Mon, 22 Jan 2024 11:37:18 -0500 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:56655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rRxIK-0000ee-Pi for 52730@debbugs.gnu.org; Mon, 22 Jan 2024 11:37:13 -0500 Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3bd6581bc66so2662644b6e.1 for <52730@debbugs.gnu.org>; Mon, 22 Jan 2024 08:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705941419; x=1706546219; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OAC4dm7fxgU1h3ASeqbBhDKvRLRLaMqd1VFS78AezCc=; b=gWzDuQYaR2YxsR2GnG6kLnb7L+enF9gEdVzVPiVVQueCDO+yoQeVSK9/MSlt4BFGwp 7sAsvsaPlOh2VwCEJF7TNOTJGQ1aiagIGyt+BSvKJkJmeT3Emw098+kq0lc3TiM4nHde OsiiWCjr7cFPP9g4DK79oefyoEBpNznvAYXtFquffrWWfJgXAH6Od8+/tDFUgqfPq3D/ H6f3p0FzfITWlIsbpQ0aALx6ywvzMDJBMYhgqB2K98+36kCQ2Pzmep4xjAxDYSKXtKX+ BEp32faDLXzBewtLKOprVKqNa7HBuVKVvQZUzlsANnKRb880U6scV+fcSA0rkcIh9V7n jkgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705941419; x=1706546219; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OAC4dm7fxgU1h3ASeqbBhDKvRLRLaMqd1VFS78AezCc=; b=n5eDXeBzoFhLkKLfJvUOXqYySXCA5Noy7H5lyw6pRg9t315B0E/KzDJxNPwEoUVh53 NkDnmGgdF+F/UJVdzD9QKG0nZIW5ObUme7G7bhjxeTyKgF/52xYyHFn8XgGaywHDxQDT 3QLF7HBCmNvYnJapAGltRLu2VsbLZIZnAGjoPfPYbot/Rja0qVuPAXBvPneXkNO5wUBq 1kEEAYVcin32bxv7gInc+dwZulCE0wdR718U6f7dlX7dHhqiPwHT5toGhLSojuxQ+2Vi 6/Qocc+KVbqA71iUzBDOLkr+5fr3d2Kqy5BRSwU6Q6kF3fv3JEln54OPdc7jOBT6FJKV lHAQ== X-Gm-Message-State: AOJu0YxwROWxk+RhtvCx1vRhrMTeaR/zSD3IeONJzlHCO6/RPA7+SLAl lEPMnTU82g8jOvtmVnXdBtuNDebSqLGvVWkvi/BMpadRUBUshQNF1mRX6zE9hX0= X-Google-Smtp-Source: AGHT+IFBvBMlKI+0xt8IQxsLleuUI7hSMfuH1VEdIpyW+yfOIUl9d+WxaC3pk8XHVkIZKslPLDYyqg== X-Received: by 2002:a05:6870:d8d3:b0:210:852a:4cad with SMTP id of19-20020a056870d8d300b00210852a4cadmr203238oac.21.1705941418710; Mon, 22 Jan 2024 08:36:58 -0800 (PST) Received: from hurd (dsl-158-18.b2b2c.ca. [66.158.158.18]) by smtp.gmail.com with ESMTPSA id cp8-20020a05622a420800b0042a4691f8dasm415271qtb.8.2024.01.22.08.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 08:36:57 -0800 (PST) From: Maxim Cournoyer In-Reply-To: <3da5b151a9e9312953660549fbbf5fa9153ac275.camel@gmail.com> (Liliana Marie Prikler's message of "Tue, 16 Aug 2022 21:46:31 +0200") References: <20211222033442.14793-1-jackhill@jackhill.us> <3da5b151a9e9312953660549fbbf5fa9153ac275.camel@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 22 Jan 2024 11:36:56 -0500 Message-ID: <87mssx2ul3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Jack, Liliana Marie Prikler writes: > Hi Jack, > > Am Freitag, dem 24.12.2021 um 00:17 -0500 schrieb Jack Hill: >> On Fri, 24 Dec 2021, Liliana Marie Prikler wrote: >>=20 >> > Hi, >> >=20 >> > Am Dienstag, dem 21.12.2021 um 22:34 -0500 schrieb Jack Hill: >> > > * gnu/packages/gstreamer.scm (gst-plugins/selection): Provide the >> > > empyt list as a default value for #:configure-flags. >>=20 >> > The current implementation ought to copy pre-existing configure- >> > flags >> > as-is if you don't supply flags on your own.=C2=A0 I personally believe >> > that's preferable over an empty value, that will probably be reset. >> > WDYT? >>=20 >> Yes, I agree that the current implementation ought to, but it >> doesn't.=20 >> Instead it complains: >>=20 >> """ >> ice-9/psyntax.scm:2794:12: In procedure syntax-violation: >> Syntax error: >> unknown location: quote: bad syntax in form quote >> """ > Is this still an issue? Also try staging, which has gstreamer 1.20 and > some gexp-improvements for gst-plugins/selection. Ping :-) --=20 Thanks, Maxim