GNU bug report logs - #52716
[PATCH] channels: Add 'branch' to 'channel->code' output.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#52716: closed ([PATCH] channels: Add 'branch' to
 'channel->code' output.)
Date: Sat, 25 Dec 2021 18:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 25 Dec 2021 19:50:34 +0100
with message-id <87h7awcydh.fsf_-_ <at> waegenei.re>
and subject line Re: bug#52716: [PATCH] channels: Add 'branch' to 'channel->code' output.
has caused the debbugs.gnu.org bug report #52716,
regarding [PATCH] channels: Add 'branch' to 'channel->code' output.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
52716: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52716
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: guix-patches <at> gnu.org
Subject: [PATCH] channels: Add 'branch' to 'channel->code' output.
Date: Tue, 21 Dec 2021 21:56:01 +0100

* guix/channels.scm (channel->code): Add 'branch' to output.
---
 guix/channels.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/channels.scm b/guix/channels.scm
index e4e0428eb5..5f47834c10 100644
--- a/guix/channels.scm
+++ b/guix/channels.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2018, 2019, 2020, 2021 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2018 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2019 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
+;;; Copyright © 2021 Brice Waegeneire <brice <at> waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1009,7 +1010,8 @@ (define* (channel->code channel #:key (include-introduction? #t))
     `(channel
       (name ',(channel-name channel))
       (url ,(channel-url channel))
+      (branch ,(channel-branch channel))
       (commit ,(channel-commit channel))
       ,@(if intro
             `((introduction (make-channel-introduction

-- 
2.34.0

[Message part 3 (message/rfc822, inline)]

From: Brice Waegeneire <brice <at> waegenei.re>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 52716-close <at> debbugs.gnu.org
Subject: Re: bug#52716: [PATCH] channels: Add 'branch' to 'channel->code'
 output.
Date: Sat, 25 Dec 2021 19:50:34 +0100

Hello Mathieu,

Mathieu Othacehe <othacehe <at> gnu.org> writes:

>> * guix/channels.scm (channel->code): Add 'branch' to output.
>
> Seems fine!

Thank you for the review, pushed as b891f8519dbea5457d9ad154974b1ab1459b4b8b.

Cheers
- Brice

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.