GNU bug report logs - #52697
29.0.50; pgtk: wrong initial frame parameter values

Previous Next

Full log

Message #19 received at 52697-done <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 52697-done <at> debbugs.gnu.org
Subject: Re: bug#52697: 29.0.50; pgtk: wrong initial frame parameter values
Date: Tue, 08 Feb 2022 15:12:26 +0100

On Tue, 08 Feb 2022 21:39:17 +0800 Po Lu <luangruo <at> yahoo.com> wrote:

> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
>> Thanks very much, I confirm your patch essentially fixes the bug, except
>> for mistakenly switching the top and left parameters:
>>
>> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
>> index e9fd5f83b7..8faffe94d4 100644
>> --- a/src/pgtkterm.c
>> +++ b/src/pgtkterm.c
>> @@ -5552,7 +5552,7 @@ configure_event (GtkWidget *widget,
>>
>>        if (f->win_gravity == NorthWestGravity)
>>  	gtk_window_get_position (GTK_WINDOW (widget),
>> -				 &f->top_pos, &f->left_pos);
>> +				 &f->left_pos, &f->top_pos);
>>        else
>>  	{
>>  	  f->top_pos = event->configure.y;
>>
>>
>> Steve Berman
>
> Thanks, should be fixed now on master.

Thanks, with that I'm closing the bug.

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.