GNU bug report logs - #52676
28.0.50; [PATCH] Rationalize window-text-pixel-size

Previous Next

Package: emacs;

Reported by: dick <dick.r.chiang <at> gmail.com>

Date: Mon, 20 Dec 2021 02:33:01 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Done: Po Lu <luangruo <at> yahoo.com>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 52676-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: dick <dick.r.chiang <at> gmail.com>
Cc: 52676-done <at> debbugs.gnu.org
Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size
Date: Mon, 20 Dec 2021 11:26:32 +0800
dick <dick.r.chiang <at> gmail.com> writes:

> Even if 43c4cc2 did anything (it doesn't), it was obviously the wrong
> way to go about it.

On the contrary, it does.  The pixel-scrolling code works on a line with
a line-prefix because of it.

> +	    (car (window-text-pixel-size
> +                  nil (line-beginning-position) (line-end-position)))))))))

This suggests that it will not work for the usecase that the option was
intended to support, because the position `line-beginning-position'
might not be on the start of the visual line.  Trust me, I tried quite a
few options including precisely this before implementing this option.

Closing.




This bug report was last modified 3 years and 148 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.