From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 21:32:26 2021 Received: (at submit) by debbugs.gnu.org; 20 Dec 2021 02:32:26 +0000 Received: from localhost ([127.0.0.1]:48588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz8TQ-0000Ew-J8 for submit@debbugs.gnu.org; Sun, 19 Dec 2021 21:32:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:50254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz8TN-0000En-KZ for submit@debbugs.gnu.org; Sun, 19 Dec 2021 21:32:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mz8TN-0006n2-5v for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 21:32:21 -0500 Received: from [2607:f8b0:4864:20::732] (port=34658 helo=mail-qk1-x732.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mz8TJ-0007pp-Mv for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 21:32:20 -0500 Received: by mail-qk1-x732.google.com with SMTP id t6so8109429qkg.1 for ; Sun, 19 Dec 2021 18:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=EPMebf/VFZ78zkEbFBK6Q6zE4gZLxtYb5jfNhp6Lq5g=; b=FQpQD4VikSjeS3pXh5cQYWtkff3pSRQvA4D5Np0Nk2eN8JhD3oGNfY9F0IOJTnR3OZ e/8npP4gelcCXNkyTUpKNkB70rY6MtB0/Ug479REptsSPZAYcNNS4TW/f8+fvXEWxz15 H/oeS8wd/ZxWagTHIkJM8H7LwQL2pKjrSUNnxXF3UL+O/O3LTD2gW+3EYd14buCExB1T luy+IeTRrLLiBj5LqDK715cdO3OxOKsmgGuE0jOzW+JTCWu/r2Lwy3GVYeCDXKxL5POb 6/CNMAlSeGxyRKsFlY+q0lq2/lz7LIEyQfqqyG7mW9buLfdXJ5CX+5fysgo6kDoE/2PJ MTPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=EPMebf/VFZ78zkEbFBK6Q6zE4gZLxtYb5jfNhp6Lq5g=; b=fKexNpuV1QjyyBbRyCAC8QI+DBFEh9fsCB1/gh23Io/94wnvUE7V+XSXafi6O60vtQ aoSrhDFrspSH+ZEFdl+PYxos04fz3ttXFrYH4/wlRbKy88CtvDnwdKKsrRhCs4M1E/UC TEMDC7CoNtTkB2BvWbhdmtUuVpAhhk2GT5ZpRfJ/5fJHR3wH4DxZzXHat7fbpKhkoWLB zCOa7X/JkwnZasy9BeMPl1ZRQY1qycAmCYABx/4fyw0jJfhFnRMY/9pg7ZnPdWHU/2sk BXjeFAEn61Hu1Up1eanBeCBnH8AzUJX2wRbGqCXec0Scmt64IxA7vxYPCDsatoOnSkmE SrQQ== X-Gm-Message-State: AOAM5338XqzrV1CiQQqT5U85gIWKDsDTHGPGLKrgsV47qgiBcL84BWGR zl8NUM0e7y1aHEjuJM8xJO8xtvJIhkU= X-Google-Smtp-Source: ABdhPJze1vaSjvIHO9Je+m8flUtBZxUoYfVQG1RcHwEUYwMkuCLzFMr4kuGU9SjmUi7dWCyAZXsKnA== X-Received: by 2002:a37:b142:: with SMTP id a63mr8285431qkf.704.1639967536358; Sun, 19 Dec 2021 18:32:16 -0800 (PST) Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id bl16sm10548170qkb.44.2021.12.19.18.32.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 19 Dec 2021 18:32:15 -0800 (PST) From: dick To: bug-gnu-emacs Subject: 28.0.50; [PATCH] Rationalize window-text-pixel-size Date: Sun, 19 Dec 2021 21:32:15 -0500 Message-ID: <87wnk0xaz4.fsf@dick> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::732 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::732; envelope-from=dick.r.chiang@gmail.com; helo=mail-qk1-x732.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-Rationalize-window-text-pixel-size.patch Content-Transfer-Encoding: quoted-printable >From 11ce84b93df374e43d91b46cc84cede12893d1b0 Mon Sep 17 00:00:00 2001 From: dickmao Date: Sun, 19 Dec 2021 21:23:15 -0500 Subject: [PATCH] Rationalize window-text-pixel-size Even if 43c4cc2 did anything (it doesn't), it was obviously the wrong way to go about it. Then I saw 914cb7a, I had to do something about it. * doc/lispref/display.texi (Size of Displayed Text): Revert. * src/pgtkfns.c (Fx_show_tip): Revert. * src/xdisp.c (window_text_pixel_size): De-obfuscate. (Fwindow_text_pixel_size): Revert. (Fbuffer_text_pixel_size): Revert. * src/xfns.c (Fx_show_tip): Revert. * test/lisp/emacs-lisp/multisession-tests.el (multi-test--on-conflict-p, multi-test-sqlite-simple, multi-test-sqlite-busy, multi-test-files-simple, multi-test-files-busy, multi-test-files-some-values): You gotta do what you gotta do. * test/src/xdisp-tests.el (xdisp-tests--visible-buffer): `with-temp-buffer` won't cut it for xdisp tests. (xdisp-tests--reconnoiter-image-height, xdisp-tests--scroll-down-leaves-cursor-behind, xdisp-tests--window-text-pixel-size-single-sline, xdisp-tests--window-text-pixel-size-display-property): Test stuff. --- doc/lispref/display.texi | 8 +- src/pgtkfns.c | 3 +- src/w32fns.c | 3 +- src/xdisp.c | 154 +++++---------------- src/xfns.c | 3 +- test/lisp/emacs-lisp/multisession-tests.el | 81 +++++++---- test/src/xdisp-tests.el | 66 +++++++++ 7 files changed, 152 insertions(+), 166 deletions(-) diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi index 98a15404f9..dd996fbe4a 100644 --- a/doc/lispref/display.texi +++ b/doc/lispref/display.texi @@ -2086,7 +2086,7 @@ Size of Displayed Text (@pxref{Resizing Windows}) to make a window exactly as large as the text it contains. =20 -@defun window-text-pixel-size &optional window from to x-limit y-limit mod= e-lines ignore-line-at-end +@defun window-text-pixel-size &optional window from to x-limit y-limit mod= e-lines This function returns the size of the text of @var{window}'s buffer in pixels. @var{window} must be a live window and defaults to the selected one. The return value is a cons of the maximum pixel-width @@ -2136,12 +2136,6 @@ Size of Displayed Text height of all of these lines, if present, in the return value. @end defun =20 -The optional argument @var{ignore-line-at-end} controls whether or -not to count the height of text in @var{to}'s screen line as part of -the returned pixel-height. This is useful if your Lisp program is -only interested in the dimensions of text up to and excluding the -visual beginning of @var{to}'s screen line. - @code{window-text-pixel-size} treats the text displayed in a window as a whole and does not care about the size of individual lines. The following function does. diff --git a/src/pgtkfns.c b/src/pgtkfns.c index 44e3d2a37e..1a4f08ca7d 100644 --- a/src/pgtkfns.c +++ b/src/pgtkfns.c @@ -3474,8 +3474,7 @@ DEFUN ("x-show-tip", Fx_show_tip, Sx_show_tip, 1, 6, = 0, try_window (window, pos, TRY_WINDOW_IGNORE_FONTS_CHANGE); /* Calculate size of tooltip window. */ size =3D Fwindow_text_pixel_size (window, Qnil, Qnil, Qnil, - make_fixnum (w->pixel_height), Qnil, - Qnil); + make_fixnum (w->pixel_height), Qnil); /* Add the frame's internal border to calculated size. */ width =3D XFIXNUM (Fcar (size)) + 2 * FRAME_INTERNAL_BORDER_WIDTH (tip_f= ); height =3D XFIXNUM (Fcdr (size)) + 2 * FRAME_INTERNAL_BORDER_WIDTH (tip_= f); diff --git a/src/w32fns.c b/src/w32fns.c index 02a6d78b51..65463b5261 100644 --- a/src/w32fns.c +++ b/src/w32fns.c @@ -7525,8 +7525,7 @@ DEFUN ("x-show-tip", Fx_show_tip, Sx_show_tip, 1, 6, = 0, try_window (window, pos, TRY_WINDOW_IGNORE_FONTS_CHANGE); /* Calculate size of tooltip window. */ size =3D Fwindow_text_pixel_size (window, Qnil, Qnil, Qnil, - make_fixnum (w->pixel_height), Qnil, - Qnil); + make_fixnum (w->pixel_height), Qnil); /* Add the frame's internal border to calculated size. */ width =3D XFIXNUM (Fcar (size)) + 2 * FRAME_INTERNAL_BORDER_WIDTH (tip_f= ); height =3D XFIXNUM (Fcdr (size)) + 2 * FRAME_INTERNAL_BORDER_WIDTH (tip_= f); diff --git a/src/xdisp.c b/src/xdisp.c index 0c35d24c26..d5101457c7 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -10827,22 +10827,22 @@ in_display_vector_p (struct it *it) && it->dpvec + it->current.dpvec_index !=3D it->dpend); } =20 -/* This is like Fwindow_text_pixel_size but assumes that WINDOW's buffer - is the current buffer. Fbuffer_text_pixel_size calls it after it has - set WINDOW's buffer to the buffer specified by its BUFFER_OR_NAME - argument. */ +/* Return cons pair of WINDOW's cartesian dimensions. */ + static Lisp_Object window_text_pixel_size (Lisp_Object window, Lisp_Object from, Lisp_Object = to, Lisp_Object x_limit, Lisp_Object y_limit, - Lisp_Object mode_lines, Lisp_Object ignore_line_at_end) + Lisp_Object mode_lines) { struct window *w =3D decode_live_window (window); struct it it; ptrdiff_t start, end, bpos; struct text_pos startp; void *itdata =3D NULL; - int c, max_x =3D 0, max_y =3D 0, x =3D 0, y =3D 0; - int doff =3D 0; + int c, x =3D 0, y =3D 0, start_x =3D 0, start_vpos =3D 0; + + int max_x =3D (RANGED_FIXNUMP (0, x_limit, INT_MAX)) ? XFIXNUM (x_limit)= : INT_MAX; + int max_y =3D (RANGED_FIXNUMP (0, y_limit, INT_MAX)) ? XFIXNUM (y_limit)= : INT_MAX; =20 if (NILP (from)) { @@ -10902,121 +10902,29 @@ window_text_pixel_size (Lisp_Object window, Lisp= _Object from, Lisp_Object to, else end =3D clip_to_bounds (start, fix_position (to), ZV); =20 - if (RANGED_FIXNUMP (0, x_limit, INT_MAX)) - max_x =3D XFIXNUM (x_limit); - else if (!NILP (x_limit)) - max_x =3D INT_MAX; - - if (NILP (y_limit)) - max_y =3D INT_MAX; - else if (RANGED_FIXNUMP (0, y_limit, INT_MAX)) - max_y =3D XFIXNUM (y_limit); - itdata =3D bidi_shelve_cache (); + start_display (&it, w, startp); - int start_y =3D it.current_y; - /* It makes no sense to measure dimensions of region of text that - crosses the point where bidi reordering changes scan direction. - By using unidirectional movement here we at least support the use - case of measuring regions of text that have a uniformly R2L - directionality, and regions that begin and end in text of the - same directionality. */ - it.bidi_p =3D false; - - /* Start at the beginning of the line containing FROM. Otherwise - IT.current_x will be incorrectly set to zero at some arbitrary - non-zero X coordinate. */ + it.last_visible_x =3D min (it.last_visible_x, max_x); + reseat_at_previous_visible_line_start (&it); it.current_x =3D it.hpos =3D 0; - if (IT_CHARPOS (it) !=3D start) - move_it_to (&it, start, -1, -1, -1, MOVE_TO_POS); - - /* Now move to TO. */ - int start_x =3D it.current_x; - int move_op =3D MOVE_TO_POS | MOVE_TO_Y; - int to_x =3D -1; - it.current_y =3D start_y; - /* If FROM is on a newline, pretend that we start at the beginning - of the next line, because the newline takes no place on display. */ - if (FETCH_BYTE (start) =3D=3D '\n') - it.current_x =3D 0; - if (!NILP (x_limit)) - { - it.last_visible_x =3D max_x; - /* Actually, we never want move_it_to stop at to_x. But to make - sure that move_it_in_display_line_to always moves far enough, - we set to_x to INT_MAX and specify MOVE_TO_X. */ - move_op |=3D MOVE_TO_X; - to_x =3D INT_MAX; - } - - void *it2data =3D NULL; - struct it it2; - SAVE_IT (it2, it, it2data); - - x =3D move_it_to (&it, end, to_x, max_y, -1, move_op); - - /* We could have a display property at END, in which case asking - move_it_to to stop at END will overshoot and stop at position - after END. So we try again, stopping before END, and account for - the width of the last buffer position manually. */ - if (IT_CHARPOS (it) > end) - { - end--; - RESTORE_IT (&it, &it2, it2data); - x =3D move_it_to (&it, end, to_x, max_y, -1, move_op); - /* Add the width of the thing at TO, but only if we didn't - overshoot it; if we did, it is already accounted for. Also, - account for the height of the thing at TO. */ - if (IT_CHARPOS (it) =3D=3D end) - { - x +=3D it.pixel_width; - - /* DTRT if ignore_line_at_end is t. */ - if (!NILP (ignore_line_at_end)) - doff =3D (max (it.max_ascent, it.ascent) - + max (it.max_descent, it.descent)); - else - { - it.max_ascent =3D max (it.max_ascent, it.ascent); - it.max_descent =3D max (it.max_descent, it.descent); - } - } - } - else - bidi_unshelve_cache (it2data, true); + move_it_to (&it, start, -1, -1, -1, MOVE_TO_POS); + start_x =3D it.current_x; + start_vpos =3D it.vpos; =20 - if (!NILP (x_limit)) - { - /* Don't return more than X-LIMIT. */ - if (x > max_x) - x =3D max_x; - } + x =3D move_it_to (&it, end, -1, max_y, -1, MOVE_TO_POS | MOVE_TO_Y); + x =3D min (x, max_x); =20 - /* If text spans more than one screen line, we don't need to adjust - the x-span for start_x, since the second and subsequent lines - will begin at zero X coordinate. */ - if (it.current_y > start_y) - start_x =3D 0; - - /* Subtract height of header-line and tab-line which was counted - automatically by start_display. */ - if (!NILP (ignore_line_at_end)) - y =3D (it.current_y + doff - - WINDOW_TAB_LINE_HEIGHT (w) - - WINDOW_HEADER_LINE_HEIGHT (w)); - else - y =3D (it.current_y + it.max_ascent + it.max_descent + doff - - WINDOW_TAB_LINE_HEIGHT (w) - WINDOW_HEADER_LINE_HEIGHT (w)); - - /* Don't return more than Y-LIMIT. */ - if (y > max_y) - y =3D max_y; + /* Subtract header- and tab-line included by start_move_it(). */ + y =3D it.current_y + it.max_ascent + it.max_descent + - WINDOW_TAB_LINE_HEIGHT (w) - WINDOW_HEADER_LINE_HEIGHT (w); + y =3D min (y, max_y); =20 if ((EQ (mode_lines, Qtab_line) || EQ (mode_lines, Qt)) && window_wants_tab_line (w)) - /* Add height of tab-line as requested. */ { + /* Add height of tab-line as requested. */ Lisp_Object window_tab_line_format =3D window_parameter (w, Qtab_line_format); =20 @@ -11052,10 +10960,15 @@ window_text_pixel_size (Lisp_Object window, Lisp_= Object from, Lisp_Object to, =20 bidi_unshelve_cache (itdata, false); =20 - return Fcons (make_fixnum (x - start_x), make_fixnum (y)); + /* X is widest line seen by move_it_forwards() */ + return Fcons (make_fixnum + (it.vpos =3D=3D start_vpos + ? x - start_x /* START to END same sline */ + : x), + make_fixnum (y)); } =20 -DEFUN ("window-text-pixel-size", Fwindow_text_pixel_size, Swindow_text_pix= el_size, 0, 7, 0, +DEFUN ("window-text-pixel-size", Fwindow_text_pixel_size, Swindow_text_pix= el_size, 0, 6, 0, doc: /* Return the size of the text of WINDOW's buffer in pixels. WINDOW must be a live window and defaults to the selected one. The return value is a cons of the maximum pixel-width of any text line @@ -11102,12 +11015,9 @@ DEFUN ("window-text-pixel-size", Fwindow_text_pixe= l_size, Swindow_text_pixel_siz height of the mode-, tab- or header-line of WINDOW in the return value. If it is the symbol `mode-line', 'tab-line' or `header-line', include only the height of that line, if present, in the return value. If t, -include the height of any of these, if present, in the return value. - -IGNORE-LINE-AT-END, if non-nil, means to not add the height of the -screen line that includes TO to the returned height of the text. */) +include the height of any of these, if present, in the return value. */) (Lisp_Object window, Lisp_Object from, Lisp_Object to, Lisp_Object x_lim= it, - Lisp_Object y_limit, Lisp_Object mode_lines, Lisp_Object ignore_line_at= _end) + Lisp_Object y_limit, Lisp_Object mode_lines) { struct window *w =3D decode_live_window (window); struct buffer *b =3D XBUFFER (w->contents); @@ -11120,8 +11030,7 @@ DEFUN ("window-text-pixel-size", Fwindow_text_pixel= _size, Swindow_text_pixel_siz set_buffer_internal_1 (b); } =20 - value =3D window_text_pixel_size (window, from, to, x_limit, y_limit, mo= de_lines, - ignore_line_at_end); + value =3D window_text_pixel_size (window, from, to, x_limit, y_limit, mo= de_lines); =20 if (old_b) set_buffer_internal_1 (old_b); @@ -11171,8 +11080,7 @@ DEFUN ("buffer-text-pixel-size", Fbuffer_text_pixel= _size, Sbuffer_text_pixel_siz set_marker_both (w->old_pointm, buffer, BEG, BEG_BYTE); } =20 - value =3D window_text_pixel_size (window, Qnil, Qnil, x_limit, y_limit, = Qnil, - Qnil); + value =3D window_text_pixel_size (window, Qnil, Qnil, x_limit, y_limit, = Qnil); =20 unbind_to (count, Qnil); =20 diff --git a/src/xfns.c b/src/xfns.c index 30ed358fb2..dc25d7bfca 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -7169,8 +7169,7 @@ DEFUN ("x-show-tip", Fx_show_tip, Sx_show_tip, 1, 6, = 0, try_window (window, pos, TRY_WINDOW_IGNORE_FONTS_CHANGE); /* Calculate size of tooltip window. */ size =3D Fwindow_text_pixel_size (window, Qnil, Qnil, Qnil, - make_fixnum (w->pixel_height), Qnil, - Qnil); + make_fixnum (w->pixel_height), Qnil); /* Add the frame's internal border to calculated size. */ width =3D XFIXNUM (Fcar (size)) + 2 * FRAME_INTERNAL_BORDER_WIDTH (tip_f= ); height =3D XFIXNUM (Fcdr (size)) + 2 * FRAME_INTERNAL_BORDER_WIDTH (tip_= f); diff --git a/test/lisp/emacs-lisp/multisession-tests.el b/test/lisp/emacs-l= isp/multisession-tests.el index 1bf0a533a7..981557fd9e 100644 --- a/test/lisp/emacs-lisp/multisession-tests.el +++ b/test/lisp/emacs-lisp/multisession-tests.el @@ -26,6 +26,15 @@ (require 'ert-x) (require 'cl-lib) =20 +(defsubst multi-test--on-conflict-p () + "The 'on conflict' is only supported in sqlite3 v3.24.0 +https://stackoverflow.com/a/51531835/5132008" + (when (bound-and-true-p multisession--db) + (let ((result (with-sqlite-transaction multisession--db + (sqlite-select multisession--db "select sqlite_version()")))) + (version-list-<=3D (version-to-list "3.24.0") + (version-to-list (seq-find #'stringp (cl-first resu= lt))))))) + (ert-deftest multi-test-sqlite-simple () (skip-unless (sqlite-available-p)) (ert-with-temp-file dir @@ -38,6 +47,7 @@ multi-test-sqlite-simple (define-multisession-variable multisession--foo 0 "" :synchronized t) + (skip-unless (multi-test--on-conflict-p)) (should (=3D (multisession-value multisession--foo) 0)) (cl-incf (multisession-value multisession--foo)) (should (=3D (multisession-value multisession--foo) 1)) @@ -56,11 +66,12 @@ multi-test-sqlite-simple :synchronized t) (cl-incf (multisession-value multisession--foo= )))))) (should (=3D (multisession-value multisession--foo) 2))) - (sqlite-close multisession--db) + (when multisession--db + (sqlite-close multisession--db)) (setq multisession--db nil))))) =20 (ert-deftest multi-test-sqlite-busy () - (skip-unless (and t (sqlite-available-p))) + (skip-unless (sqlite-available-p)) (ert-with-temp-file dir :directory t (let ((user-init-file "/tmp/foo.el") @@ -72,6 +83,7 @@ multi-test-sqlite-busy (define-multisession-variable multisession--bar 0 "" :synchronized t) + (skip-unless (multi-test--on-conflict-p)) (should (=3D (multisession-value multisession--bar) 0)) (cl-incf (multisession-value multisession--bar)) (should (=3D (multisession-value multisession--bar) 1)) @@ -93,45 +105,53 @@ multi-test-sqlite-busy (cl-incf (multisession-value multisess= ion--bar)))))))) (while (process-live-p proc) (ignore-error 'sqlite-locked-error - (message "multisession--bar %s" (multisession-value multis= ession--bar)) - ;;(cl-incf (multisession-value multisession--bar)) - ) - (sleep-for 0.1)) - (message "multisession--bar ends up as %s" (multisession-value= multisession--bar)) + (message "multisession--bar %s" (multisession-value multis= ession--bar))) + (accept-process-output nil 0.1)) + (message "bar ends up as %s" (multisession-value multisession-= -bar)) (should (< (multisession-value multisession--bar) 1003))) - (sqlite-close multisession--db) + (when (process-live-p proc) + (kill-process proc)) + (when multisession--db + (sqlite-close multisession--db)) (setq multisession--db nil))))) =20 (ert-deftest multi-test-files-simple () + (skip-unless (sqlite-available-p)) (ert-with-temp-file dir :directory t (let ((user-init-file "/tmp/sfoo.el") (multisession-storage 'files) (multisession-directory dir)) - (define-multisession-variable multisession--sfoo 0 - "" - :synchronized t) - (should (=3D (multisession-value multisession--sfoo) 0)) - (cl-incf (multisession-value multisession--sfoo)) - (should (=3D (multisession-value multisession--sfoo) 1)) - (call-process - (concat invocation-directory invocation-name) - nil t nil - "-Q" "-batch" - "--eval" (prin1-to-string - `(progn - (require 'multisession) - (let ((multisession-directory ,dir) - (multisession-storage 'files) - (user-init-file "/tmp/sfoo.el")) - (define-multisession-variable multisession--sfoo 0 - "" - :synchronized t) - (cl-incf (multisession-value multisession--sfoo)))))) - (should (=3D (multisession-value multisession--sfoo) 2))))) + (unwind-protect + (progn + (define-multisession-variable multisession--sfoo 0 + "" + :synchronized t) + (skip-unless (multi-test--on-conflict-p)) + (should (=3D (multisession-value multisession--sfoo) 0)) + (cl-incf (multisession-value multisession--sfoo)) + (should (=3D (multisession-value multisession--sfoo) 1)) + (call-process + (concat invocation-directory invocation-name) + nil t nil + "-Q" "-batch" + "--eval" (prin1-to-string + `(progn + (require 'multisession) + (let ((multisession-directory ,dir) + (multisession-storage 'files) + (user-init-file "/tmp/sfoo.el")) + (define-multisession-variable multisession--sf= oo 0 + "" + :synchronized t) + (cl-incf (multisession-value multisession--sfo= o)))))) + (should (=3D (multisession-value multisession--sfoo) 2))) + (when multisession--db + (sqlite-close multisession--db)) + (setq multisession--db nil))))) =20 (ert-deftest multi-test-files-busy () - (skip-unless (and t (sqlite-available-p))) + (skip-unless (sqlite-available-p)) (ert-with-temp-file dir :directory t (let ((user-init-file "/tmp/foo.el") @@ -168,6 +188,7 @@ multi-test-files-busy (should (< (multisession-value multisession--sbar) 2000))))) =20 (ert-deftest multi-test-files-some-values () + (skip-unless (sqlite-available-p)) (ert-with-temp-file dir :directory t (let ((user-init-file "/tmp/sfoo.el") diff --git a/test/src/xdisp-tests.el b/test/src/xdisp-tests.el index ae4aacd9c7..dd99b28320 100644 --- a/test/src/xdisp-tests.el +++ b/test/src/xdisp-tests.el @@ -21,6 +21,14 @@ =20 (require 'ert) =20 +(defmacro xdisp-tests--visible-buffer (&rest body) + (declare (debug t) (indent 0)) + `(progn + (switch-to-buffer (symbol-name (ert-test-name (ert-running-test)))) + (progn ,@body) + (let (kill-buffer-query-functions) + (kill-buffer (symbol-name (ert-test-name (ert-running-test))))))) + (defmacro xdisp-tests--in-minibuffer (&rest body) (declare (debug t) (indent 0)) `(catch 'result @@ -170,4 +178,62 @@ test-get-display-property (should (equal (get-display-property 2 'height) 2.0)) (should (equal (get-display-property 2 'space-width) 20)))) =20 +(ert-deftest xdisp-tests--reconnoiter-image-height () + "C-v on image extending beyond window should not signal +end-of-buffer." + (skip-unless (not noninteractive)) + (skip-unless (> (window-pixel-height) 300)) + (xdisp-tests--visible-buffer + (dotimes (_ (/ (- (window-pixel-height) 100) (line-pixel-height))) + (insert "line" "\n")) + (insert-image (create-image (expand-file-name + "test/data/image/blank-100x200.png" + source-directory))) + (insert "\n") + (redisplay) + (goto-char (point-min)) + (scroll-up) + (redisplay))) + +(ert-deftest xdisp-tests--scroll-down-leaves-cursor-behind () + "When first line contains accented, and therefore taller +character, e.g., =C3=93scar, scrolling down (moving window-start up) +has resulted in a no-op." + (xdisp-tests--visible-buffer + (insert "=C3=93scar" "\n") + (dotimes (_ (/ (1+ (window-pixel-height)) (line-pixel-height))) + (insert "line" "\n")) + (goto-char (point-max)) + (redisplay) + (scroll-down) + (redisplay) + (should (=3D (window-start) 1)))) + +(ert-deftest xdisp-tests--window-text-pixel-size-single-sline () + "Verify `window-text-pixel-size' handles one screen line spanned." + (xdisp-tests--visible-buffer + (save-excursion + (insert "xxxx")) + (should (=3D (* 2 (frame-char-width)) + (car (window-text-pixel-size + nil (1+ (point-min)) (1- (point-max)))))))) + +(ert-deftest xdisp-tests--window-text-pixel-size-display-property () + "Verify `window-text-pixel-size' returns dimensions including +width of display property." + (xdisp-tests--visible-buffer + (let ((disp-string "ornery")) + (save-excursion + (insert "xxxx")) + (should + (=3D (+ (1- (length disp-string)) + (car (window-text-pixel-size + nil (line-beginning-position) (line-end-position)))) + (progn + (put-text-property (1- (line-end-position)) + (line-end-position) + 'display disp-string) + (car (window-text-pixel-size + nil (line-beginning-position) (line-end-position))))))))) + ;;; xdisp-tests.el ends here --=20 2.26.2 --=-=-= Content-Type: text/plain In Commercial Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2021-12-19 built on dick Repository revision: fa52e7eee7a9fe2a4b01ce631370a760d46a5c9e Repository branch: dev Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.4 LTS Configured using: 'configure --prefix=/home/dick/.local --with-tree-sitter --enable-dumping-overwrite CC=gcc-10 'CFLAGS=-g3 -O2 -I/home/dick/.local/include/' LDFLAGS=-L/home/dick/.local/lib PKG_CONFIG_PATH=/home/dick/.local/lib/pkgconfig CXX=gcc-10' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON TREE_SITTER LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Magit Minor modes in effect: async-bytecomp-package-mode: t global-git-commit-mode: t shell-dirtrack-mode: t projectile-mode: t flx-ido-mode: t override-global-mode: t winner-mode: t tooltip-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/dick/gomacro-mode/gomacro-mode hides /home/dick/.emacs.d/elpa/gomacro-mode-20200326.1103/gomacro-mode /home/dick/.emacs.d/elpa/hydra-20170924.2259/lv hides /home/dick/.emacs.d/elpa/lv-20191106.1238/lv /home/dick/.emacs.d/elpa/magit-3.3.0/magit-section-pkg hides /home/dick/.emacs.d/elpa/magit-section-3.3.0/magit-section-pkg /home/dick/org-gcal.el/org-gcal hides /home/dick/.emacs.d/elpa/org-gcal-0.3/org-gcal /home/dick/.emacs.d/elpa/tree-sitter-20211211.1220/tree-sitter hides /home/dick/.local/share/emacs/28.0.50/lisp/tree-sitter /home/dick/.emacs.d/lisp/json hides /home/dick/.local/share/emacs/28.0.50/lisp/json /home/dick/.emacs.d/elpa/transient-0.3.6/transient hides /home/dick/.local/share/emacs/28.0.50/lisp/transient /home/dick/.emacs.d/elpa/hierarchy-20171221.1151/hierarchy hides /home/dick/.local/share/emacs/28.0.50/lisp/emacs-lisp/hierarchy /home/dick/.local/share/emacs/28.0.50/lisp/emacs-lisp/eieio-compat hides /home/dick/.local/share/emacs/28.0.50/lisp/obsolete/eieio-compat Features: (shadow sort footnote mail-extr gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr pixel-fill kinsoku svg dom gnus-group mm-url gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win emacsbug sendmail goto-addr mule-util magit-extras misearch multi-isearch texinfo texinfo-loaddefs tramp-archive tramp-gvfs tramp-cache zeroconf dbus xml tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp ag vc-svn find-dired s vc cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs benchmark vc-git vc-dispatcher bug-reference face-remap magit-patch-changelog magit-patch magit-submodule magit-obsolete magit-popup async-bytecomp async magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode git-commit log-edit message yank-media rmc puny dired-x dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader pcvs-util add-log magit-core magit-margin magit-transient magit-process with-editor shell pcomplete server magit-mode transient format-spec paredit-ext paredit subed subed-vtt subed-srt subed-common subed-mpv subed-debug subed-config inf-ruby ruby-mode smie company pcase haskell-interactive-mode haskell-presentation-mode haskell-process haskell-session haskell-compile haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation haskell-string haskell-sort-imports haskell-lexeme haskell-align-imports haskell-complete-module haskell-ghc-support noutline outline flymake-proc flymake warnings etags fileloop generator xref project dabbrev haskell-customize hydra lv use-package-ensure solarized-theme solarized-definitions projectile lisp-mnt mail-parse rfc2231 rfc2047 rfc2045 ietf-drums ibuf-ext ibuffer ibuffer-loaddefs thingatpt magit-autorevert autorevert filenotify magit-git magit-section magit-utils crm dash rx grep compile comint ansi-color gnus nnheader mail-utils mm-util mail-prsvr gnus-util text-property-search time-date flx-ido flx google-translate-default-ui google-translate-core-ui facemenu color ido google-translate-core google-translate-tk google-translate-backend use-package-bind-key bind-key auto-complete easy-mmode advice edmacro kmacro popup cus-edit pp cus-load wid-edit emms-player-mplayer emms-player-simple emms emms-compat cl-extra help-mode use-package-core derived winner ring finder-inf json-reformat-autoloads json-snatcher-autoloads sml-mode-autoloads tornado-template-mode-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map url-vars seq gv subr-x byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tree-sitter tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 616961 37623) (symbols 48 34377 4) (strings 32 129257 16009) (string-bytes 1 4378137) (vectors 16 79659) (vector-slots 8 2079074 30314) (floats 8 479 2293) (intervals 56 4800 940) (buffers 992 19)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 22:26:49 2021 Received: (at 52676-done) by debbugs.gnu.org; 20 Dec 2021 03:26:49 +0000 Received: from localhost ([127.0.0.1]:48596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz9K5-0001ZT-1I for submit@debbugs.gnu.org; Sun, 19 Dec 2021 22:26:49 -0500 Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:44786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz9K3-0001ZE-FI for 52676-done@debbugs.gnu.org; Sun, 19 Dec 2021 22:26:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639970801; bh=7BYYzT+wOJLi7mKg/h+Obced8UFSPZHZYdraWJDIntk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=K9e1dLMipGXoXy6wsAc6QC1TXxMUR5aLV3hV9EdUY+CKp0ssopUTSXq1U29FiqNbx95AByofhOZudibNG+HIsvMO6WAoC1P92UQHmiJhR2bJ1nYqYdtTjfpnzzl2VsEvG4HR0wAor/CfzrNzdPPB21yQY2b19sZFp9oOj0um8II1pgElEb9zj+44WC+8UfQp4GdnvMXcyjZYDWJx7vs1Tv7iMKj2Fmy6yNzpITQAUFCmWUfT4vMnAfOH4dra74nwR02Ah+lzcqw9aU5O8MaH0bqPcVVrdpOdmS6tJaCVbAmr0jG1VA1yAzj5KNNStM8GeXN6qsOOzfiChVgnzL0Bwg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1639970801; bh=hCnPFKutrpuywiO3biZGuqvAIwV7oXIeYs9/IP8JVLG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Jaua5rh9QTUs1gpIvbWspoQUu9Wwl58kWAMsW88gp+HPLNmK34Qxs+t9plWnMB97piC5QR0LQ7USWvIbbIPDn/SHSGx94hERIcYDOakM7Umvt+k8h5cuFpHHrehNsjVrOK4qf7ncZmd3wqrdq1Klkj2RdKc07EBPYtMBW69azz+qlvWlUj/OeoQ32jjQ+nUddtnpWKcQnYGCvstG08d7RlS+6h0Yu3YYf5aqbi6ytCNtZVLwyTymAakrEB+ifCuxwnwh25K/WfhGxenY4cvTCmn4xqLCbxKAJ48yxXxHHgIyf/H7y1pzZpNJF0UpJ5lA8cYesQ7qLixxgY7xB5fTvQ== X-YMail-OSG: I9Oze3gVM1lO9VI5oM922amCS.HQftj2sKfSHS0Sp9P_igqFxytlxJjIkTvG5Hf 1ghTS_U9OUHuPH7jMA1XGFmg1qYG85N09zYp5LLmN9AMp.zQGH8lxOvFlNFf.Ivji734WvoGQYrT 0bSvYEBFhmoMrDDAnL3jRMBrdXf2yJcFX_P67xPi6ugA.uPWWSZCnZtTWyR9BIq2eOJLH8KQ.MH7 4TriP720frIfp141Rk7FiYeyOEwuFjAS_5DrbWkC9SLHj9Ew2Yg3Wzst1yNnCwzqF2EgQABx258V X_pJCV4xaSntR15FeB2Gm_6rLqj4f.ifk.lGOM71Ztb9CE9y_c3Y6Y3ED.fKQowkrwBlsC8p51Hm xMyrKrhzP3iPbrJn8fkxvS9hApdL4KQnwAQZJrfIJfkMEN.4kU7RLxCdpCE4mZiLbBlCIhzvdBiO uVqEBJkWMjwGLzQ3WWVRhd9YnsgAu7e8xfLq9NXknZVwNMUCXHflmlGiDe3.OLDovAlC5s_37tou bCjLyYBPaeMx6Oua7oi__8gHDNfb2.intqynIL030nyYM2w6uQVSwDP_EQgERwgiShUuXJMmBngQ BL2DJAInX0LKbzg9Eg_I99bpV_soO6.FQb8t_5CT8q0TP7pHtaDfmiR99B1UC0Rq9NHGDl1nANmr yFtWhFha8pHcEdopuc8PVWGHJEUavbtmPjzJZhWp3gD8c96npX0LM_pxxf22aTt1gzo3GMO28XA6 GTZMP0fQXPd0zhNu2V0zA0z6Nal87JrWyGWeStvyPiWE3iVYV4crj2wtBcWq1h54rYPX946Nx4F7 _wIaupvUXJLJOR23EXa0V32CBI7OCZBtX7BD3WWoBqqosmPdu8Q9lttIdfHTAFPUOcUnKS.XlNwH Fq831hmn07m1j1Ty4bpqWDMk_B0vAXJPp.7pN2BZrMh7WNAtcp7ZAsmH.GCwOve5e_ABLIW8B.RE daYAompodahkVwePymBpB2mwgzvzCqOa5FWjIp3vjlp8P0BruKHyxFv98hMF2ROuB4evyHi_cwaE zQSbWykPp2YzyaEyz4f_XbK3ztMr8v2ll_JbdQ6lJukSKgfWzotOYUaSN2mPSRiN6Wheq4ex36HM manVZL.9Q0GR.wnLORG2xv7A7Zl8.JaT5oB_3QETvNgpIfPg0EszYt5ToSWdzejMLv0CDMM7gpo2 e82Gb1N77JSsdliaWSEYMBsdHG5hotvYXP__Uodn71R1ddf4cfMa4N2iGaKgP86oH5Nx93L6.6s6 5BqhOp2tPhYC9okwVTtVA8SkKmF_Lu_YpfNwhlChpOGLfT.iwu0sSYm9o2l.GGQyF46wbWu4M3bB 9s.8lmCEMJGwHReTh.LPVvV_nsm8OVAlddO7SmI34KMdpHCCw.HzEqGepi3LoOKwri2Io2uNQOQ5 jyCM9SNG31vMhbuMOD.6X8vCBnoKRTIHOi4IDeBR0MJzCJXbKp2Ap2jsy8pXFjqOf16R8F8bewla P0XSuLz5vb_butz5viNykAk4UpqgiX7zEKjqwU6HeuLfOK7bnItNiaySnxPPfS1LVTL_XxdmDq0M vx_K8imoL12Ot8.6xEeUVrSei1Be4OqbhUovpSUbv3qhZTANIBzjY983XclmmKakxW35dp0Girpr UuhNf0UQXBnhkTfFk_eTlUUQ7kaNm4SthubOUQAiIfNAGsySm4wqLO5liy3DOJhYR_JYCfNPC_SH Y8NTprl1I6PQEB3wPun7wD9Sp5dgTTd48_yVFscj63OS_Z9OdVy6QNqAgVyzeNRAKQQoBv9u_CL4 Y3CB7VnMtrHd5ptP04GTuWPR9a3e5Ef.YmJ.BhZIryL8bwc1Eon9LqB0ie832pvmzUBNbncgD3eL fCt7RHSImuMM92CSeakEMjZUBYceFCMMXLRUf5FjOKuPFMRJM.pEr2WxnNmBBU7jctcWW2ncNgId 5oUISwsZW3k043nvCbXw9SMgrlozWe4K.Crh3mlzv05oeNk1UIGqc3LmJ9AMR.mt9T4fxgt64mGP ut4WbgH0RIiJo2V8MahUDkP3reVAIEB60EOl1ejK0VBzyU6Qw154p9bLuTnt8dP20HP7v4I9aT0y PGkMPzqWGVzue.aLP5E8yebJ_P8o49sx1BE.4BErUKYD8YVN4A1FY9YwfyP4ssIc1MHyGDgDr9Hp 9yuDDait2JjOYQZbwXjQl7FoiVsciTlm9IBG8RVXNGTWguVDlf6vECTXqCcvBVBWSsoiUNRhYhFb BHLdRxKat.nN2xVb9sf9VYlIneImIQngYH5m9dEV7QCEKPjA0FEuZ_0L1cm4- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Mon, 20 Dec 2021 03:26:41 +0000 Received: by kubenode518.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 50122396893179d2b30e313d2a6d673f; Mon, 20 Dec 2021 03:26:36 +0000 (UTC) From: Po Lu To: dick Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> Date: Mon, 20 Dec 2021 11:26:32 +0800 In-Reply-To: <87wnk0xaz4.fsf@dick> (dick's message of "Sun, 19 Dec 2021 21:32:15 -0500") Message-ID: <87h7b43qjb.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 648 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676-done Cc: 52676-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) dick writes: > Even if 43c4cc2 did anything (it doesn't), it was obviously the wrong > way to go about it. On the contrary, it does. The pixel-scrolling code works on a line with a line-prefix because of it. > + (car (window-text-pixel-size > + nil (line-beginning-position) (line-end-position))))))))) This suggests that it will not work for the usecase that the option was intended to support, because the position `line-beginning-position' might not be on the start of the visual line. Trust me, I tried quite a few options including precisely this before implementing this option. Closing. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 00:21:04 2021 Received: (at 52676-done) by debbugs.gnu.org; 20 Dec 2021 05:21:05 +0000 Received: from localhost ([127.0.0.1]:48714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzB6e-0006gE-NT for submit@debbugs.gnu.org; Mon, 20 Dec 2021 00:21:04 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:40800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzB6c-0006fQ-35 for 52676-done@debbugs.gnu.org; Mon, 20 Dec 2021 00:21:03 -0500 Received: by mail-qk1-f178.google.com with SMTP id p4so8338339qkm.7 for <52676-done@debbugs.gnu.org>; Sun, 19 Dec 2021 21:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:cc:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=oJ9pvAjPVqtNUAkBoKykwKhg79Rt0HChrWayNXPWu38=; b=Wpv4N5r6oNGzdElVlUnMsXRaujKgf0cLWIrU4wQtoTckelhtBaRKlVSbwmoBZua3YQ 5PK2rXxW/kUF5xebY+qhkJ1QiSl1zf4ZLMOrXanVNbfmpRV48FvHuAmgMgPI4lLwNKXw byWTMqPbiMAF8WKaAp6cZSDfhz37h7qLuB2eKPyw17cphEOsAopoNh/uDv5cYcsvpWf5 2XzEW7JsPqA6BFImqsQPSZaNtGH+te7PODU8CPMwfJG0Nz5UANUbs4UL2fjnf0jKrofN o235RdqM3u9pNO2rRxxdT+fPzW4lge1SwJCLfY/v+BgtApD3mIE0zmHDkBaQwlfLxshe 1Yog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oJ9pvAjPVqtNUAkBoKykwKhg79Rt0HChrWayNXPWu38=; b=w6yKSt6QKKZJBKk7PP2O4zpnea24F1cxX89PUIHE00o2hO4YGZu0To4wbLmw+vS4vm 7pPC/3RhdU62gCvKV5RqZzwYdxYdlxnsmNidFeeOv9zRfXcT/g6QtzCgDRuv/o1lbIeW XFtcbIJqvwiJlKKPY5chgH3PVSDD585U0odC1mN7aK+0yWqAEAaxW9J6P6b4tIr6udcx kBEcBhAGs4A3vdvmDl4I163ipMXwMdz0vY4JAzJUStYO67GbiGdQEQunTbVL6Vc4Tqva vIrrYRn44Y3DeuhTVbLmH8Jr2l8/XMYc1tFM4OiVLvv32V/N2d1Zm4D/a1vyY69tDeOK TZCw== X-Gm-Message-State: AOAM530jOISHyH7lVCBqZ+7k6iaMsaQkGZXplGx+GQzxpiwZp6EyKkQV HXFC6BKkNf/fiS+z2NebJ86uthg1Ru8= X-Google-Smtp-Source: ABdhPJzhmPtCTLbznd4xD5L84dQ1mWCcIBEodENIWtjEuaQXXiMfd6itrFtx5W2SvVBybhE9I+qJ1A== X-Received: by 2002:ae9:e80b:: with SMTP id a11mr8551988qkg.716.1639977656318; Sun, 19 Dec 2021 21:20:56 -0800 (PST) Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id h22sm10130785qkk.14.2021.12.19.21.20.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 19 Dec 2021 21:20:56 -0800 (PST) From: dick Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> Date: Mon, 20 Dec 2021 00:20:55 -0500 In-Reply-To: <87h7b43qjb.fsf@yahoo.com> (Po Lu's message of "Mon, 20 Dec 2021 11:26:32 +0800") Message-ID: <87o85byhqg.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I am sure there was a way to do what you wanted without resorting to what you did. Perhaps I've been too harsh on you. You've gotten a lot of poor (but earnest) counsel from emacs-devel. What sucks is the statute of limitations on function signature changes is short. Once released, that jank, incomprehensibly specific parameter "ignore-line-at-end" is here to stay. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (dick.r.chiang[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.2 MISSING_HEADERS Missing To: header -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.222.178 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.222.178 listed in list.dnswl.org] X-Debbugs-Envelope-To: 52676-done Cc: 52676-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) I am sure there was a way to do what you wanted without resorting to what you did. Perhaps I've been too harsh on you. You've gotten a lot of poor (but earnest) counsel from emacs-devel. What sucks is the statute of limitations on function signature changes is short. Once released, that jank, incomprehensibly specific parameter "ignore-line-at-end" is here to stay. (defmacro xdisp-tests--visible-buffer (&rest body) (declare (debug t) (indent 0)) `(progn (switch-to-buffer "his-fooness") (unwind-protect (progn ,@body) (let (kill-buffer-query-functions) (kill-buffer "his-fooness"))))) (xdisp-tests--visible-buffer (cl-flet ((test-it (what from to) (erase-buffer) (save-excursion (insert what)) (let ((dims (window-text-pixel-size nil from to nil nil nil t)) (dims* (window-text-pixel-size nil from to))) (cl-assert dims (cons (car dims*) (- (cdr dims*) (save-excursion (goto-char to) (if (> (line-end-position) (line-beginning-position)) (line-pixel-height) 0)))))))) (let ((text "foo\nbar")) (test-it text 1 (1+ (length text)))) (let ((text "foo\nbar\n")) (test-it text 1 (1+ (length text)))) (let ((text "foo\nbar\nbaz")) (test-it text 1 (1+ (length text)))) (let ((text "foo\nbar\n")) (test-it text 1 (1+ (length "foo\nbar")))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 10:20:03 2021 Received: (at 52676) by debbugs.gnu.org; 20 Dec 2021 15:20:03 +0000 Received: from localhost ([127.0.0.1]:51116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzKSI-00038p-Ep for submit@debbugs.gnu.org; Mon, 20 Dec 2021 10:20:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzKSH-00038I-94 for 52676@debbugs.gnu.org; Mon, 20 Dec 2021 10:20:01 -0500 Received: from fencepost.gnu.org ([209.51.188.10]:53308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzKS1-00079v-5w; Mon, 20 Dec 2021 10:19:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Gm7YriUUqlIwVpNQkqIfC2bccc4f0K+4QORg3qNiMAw=; b=S9QvcGbAmMyG rG1gkdMmzl4LSDpjosQqXwWAM9D8UnVa7vCdq58z+IKSIrSMBpJCmhanYmQGp0FA8lWp9vEAbU6CJ gKqjIBLsOW6YZwMg7ttFSeacaZVycpPk9F8xEMuPlFK/xCpFqHS6SSWaSUT9g1mHXtr0C9HeQ0f3X HBlUcRhaQp+ueiowWkcoUFBr1FP8SNfWPqJwdBXuw6vOvozM38WUyjHGAgAd3gPOmSPzqCsx5oicJ PNWQ5wjmhbgdD30hNO3jeJL1+cGHLBJu/5n2qr9vMLs59sccXeyv/Uee4qejSuXVRTXgreq/dUbvO c7KXyDpQuKjm4JvPCH9n+w==; Received: from [87.69.77.57] (port=2852 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzKS0-0002OS-Ki; Mon, 20 Dec 2021 10:19:45 -0500 Date: Mon, 20 Dec 2021 17:19:43 +0200 Message-Id: <83zgov1ey8.fsf@gnu.org> From: Eli Zaretskii To: dick In-Reply-To: <87wnk0xaz4.fsf@dick> (message from dick on Sun, 19 Dec 2021 21:32:15 -0500) Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52676 Cc: 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: dick > Date: Sun, 19 Dec 2021 21:32:15 -0500 > > Even if 43c4cc2 did anything (it doesn't), it was obviously > the wrong way to go about it. It's WIP. It's too early IMNSHO to judge it, because alone it does very little. > start_display (&it, w, startp); > - int start_y = it.current_y; > - /* It makes no sense to measure dimensions of region of text that > - crosses the point where bidi reordering changes scan direction. > - By using unidirectional movement here we at least support the use > - case of measuring regions of text that have a uniformly R2L > - directionality, and regions that begin and end in text of the > - same directionality. */ > - it.bidi_p = false; Why was this removed? what's the rationale? Did you understand the underlying problem about which the comment hints? > - /* If FROM is on a newline, pretend that we start at the beginning > - of the next line, because the newline takes no place on display. */ > - if (FETCH_BYTE (start) == '\n') > - it.current_x = 0; And why was this removed? > - if (!NILP (x_limit)) > - { > - it.last_visible_x = max_x; > - /* Actually, we never want move_it_to stop at to_x. But to make > - sure that move_it_in_display_line_to always moves far enough, > - we set to_x to INT_MAX and specify MOVE_TO_X. */ > - move_op |= MOVE_TO_X; > - to_x = INT_MAX; > - } And this? > - /* We could have a display property at END, in which case asking > - move_it_to to stop at END will overshoot and stop at position > - after END. So we try again, stopping before END, and account for > - the width of the last buffer position manually. */ > - if (IT_CHARPOS (it) > end) > - { > - end--; > - RESTORE_IT (&it, &it2, it2data); > - x = move_it_to (&it, end, to_x, max_y, -1, move_op); > - /* Add the width of the thing at TO, but only if we didn't > - overshoot it; if we did, it is already accounted for. Also, > - account for the height of the thing at TO. */ And this? So basically, you removed code which was there to handle real problems, with no explanations and with log messages whose content includes no useful information. The Git history should have pointed you to the bug reports and discussions which caused us to add those code fragments you removed, with recipes to create those problematic situation; did you try those recipes? did you find them not reproducible, or thought that the fixes are no longer needed, or have better ideas for how to fix them? If so, how about including all that information in your patch submissions? Without all this information, how can you expect us to use your patches? All I see is that you delete code that is there for a reason. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 12:11:54 2021 Received: (at 52676) by debbugs.gnu.org; 20 Dec 2021 17:11:54 +0000 Received: from localhost ([127.0.0.1]:51324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzMCY-0006TJ-HD for submit@debbugs.gnu.org; Mon, 20 Dec 2021 12:11:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzMCX-0006Sr-07 for 52676@debbugs.gnu.org; Mon, 20 Dec 2021 12:11:53 -0500 Received: from [2001:470:142:3::e] (port=46498 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzMCR-0000nC-QZ; Mon, 20 Dec 2021 12:11:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FT3VTpTMQrPPDXBWTN/2QvTiH4tawlBZbwCGF6KUB7A=; b=InKXH2iUYRQt 0YpxSL3pxVcuZPvq9lvWAlIwDEmhCge4meUgufdnxkqQXUoL5/6sRt0k/3gEV2cxP+GaXMWB/5SRf mu/j+ThCZZoKaT97b9KEBEoEEQ32h6yvlbBNoPMM1q4eZLQi4IsF6ZxFBbmiI3eCGAW2Z+saI1I3A zkBBX4hbwB6HbOwwQxd4tIW6oXUAmGUOn5InTeTC8JtmMj5GPtIESgTZQkpoHEHTb4CD9SCLf5hVT jCMRSb+PwQjqjuWcYb7IJbIZ6/KEOOkoTo+aOw6zefkCxK8Tie/V70bzS3ZV3AbJcPScFAz8QJTLX r5axJjvUXknDrO1cd5TuJA==; Received: from [87.69.77.57] (port=1957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzMCR-0006pp-Ku; Mon, 20 Dec 2021 12:11:48 -0500 Date: Mon, 20 Dec 2021 19:11:45 +0200 Message-Id: <83pmpr19ri.fsf@gnu.org> From: Eli Zaretskii To: dick In-Reply-To: <87o85byhqg.fsf@dick> (message from dick on Mon, 20 Dec 2021 00:20:55 -0500) Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52676 Cc: 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: dick > Date: Mon, 20 Dec 2021 00:20:55 -0500 > Cc: 52676-done@debbugs.gnu.org > > (defmacro xdisp-tests--visible-buffer (&rest body) > (declare (debug t) (indent 0)) > `(progn > (switch-to-buffer "his-fooness") > (unwind-protect > (progn ,@body) > (let (kill-buffer-query-functions) > (kill-buffer "his-fooness"))))) > > (xdisp-tests--visible-buffer > (cl-flet ((test-it > (what from to) > (erase-buffer) > (save-excursion > (insert what)) > (let ((dims (window-text-pixel-size nil from to nil nil nil t)) > (dims* (window-text-pixel-size nil from to))) > (cl-assert > dims > (cons (car dims*) > (- (cdr dims*) > (save-excursion > (goto-char to) > (if (> (line-end-position) (line-beginning-position)) > (line-pixel-height) > 0)))))))) > (let ((text "foo\nbar")) > (test-it text 1 (1+ (length text)))) > (let ((text "foo\nbar\n")) > (test-it text 1 (1+ (length text)))) > (let ((text "foo\nbar\nbaz")) > (test-it text 1 (1+ (length text)))) > (let ((text "foo\nbar\n")) > (test-it text 1 (1+ (length "foo\nbar")))))) This produces no assertions here (with the current master), if that's what you wanted to hear. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 20:34:53 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 01:34:53 +0000 Received: from localhost ([127.0.0.1]:51848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzU3J-00054j-10 for submit@debbugs.gnu.org; Mon, 20 Dec 2021 20:34:53 -0500 Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:38744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzU3H-00054O-3g for 52676@debbugs.gnu.org; Mon, 20 Dec 2021 20:34:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640050485; bh=WCBEy/PuaLwMKZH7v9WYRY+SWNYF/yINrzjJRb+fsg8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=txGVKLpMCqNvxJ8Hj6+vv8al92vFAf0WbO6wF1R6SJ9Wep3Rd0nzdMenfbsjp3yrGyBVtK8ybrWY7MeZPpVvXdRH5Fjpltdvyg+Ppds70Y7P6jh1J0lfNxOosR6kDZi9z12rmu8BpQgKnupaYIppOTki6dBBYnxILfCWOxnOqOOZTZIpquWh5BNcfKDZrfOqKFVn9PDBv8UTqCyCRQLbOvprqnRHmbcNfe8SY5EftGlQTx6xpSqeDdT6HyGIpEhdiWqSvs5ZbkhiYMPbj3k8hBwmAjQeTeI/sQjz8SjvIRdkOszNa2VxK2NcqOOstzAPCTUzxb7ghUegFmxsnvV5cg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640050485; bh=u6AYhtQvnGVYhStxXPEIY+nB9UIN2tO5zljxpY2ceuA=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ImSqWk9H9akaFlFOcTLXMdFKfbAkGnKo85rXlZAPuH2Q8F0BOWLUpKEOPerhCDf/SBilblRlQBNkZqn0pBUQrYpv25/ArPKM1GSjvxxZU01TqDr1i+mv+oiK3pBW+6YWBToLw3Zjozi9CokUHmDP//VJNnVpNrroethuw45qtAnL+wdw0mPDLc3zIG0814Xb6uEHkbckO1fh+9MkBowTvXAbGTbfNDsw3yykWjh07XmLvOwgMh51hWRP+EL8yQd+xPstE0ukfzxFiYrQconsZLA3nLqWyXqbpZvT1egNkcUJKEa6udsvRtdqIOFI183IDP/t69pgT5Ixtu8arTYf9Q== X-YMail-OSG: 2fvgEDsVM1kf37Ny1RMGhGwlqNevc8uNDa29QXanXKMdSNXbhbRGSvpYpF1A85G zopoUX8qCNBp5tps.uNlZAzG.SwnFMy_9hnXtgW56kkDrVT9dGORAi3WH.ZWhWL4zL2NgTNEq1UW PVE0TGBEpqvDy7vG7yCp0BG2IFtTc7QXMhE5StUtVaF0b0Fmft_uRqdd_aRqMuck0fWl_8Rc9Taf nvsxIyzAGJMsfmCcx2FQE5bat32yPNkckTciAw_8n_nvucidysiIkjLASiDcU_2huPpqUegRGMRA 9Q2wcXk4mrFk2uwc88F5.64lm5HZbK_fjsabgYCJG_zC8TSnSuQVmRfKgSZTdl4cpTqwTPRK_I3g dSQ1dvlmHSjlehiOMGMNDLejGScXWFTl1iBui2KMEJl5bqauYu__oMDDeoD63MDtmI9Sujd_6caK uV7Q0xjvbubctcOg8wN1myypSn9J_n2QJKRnIWEVSBIodexmg.9r3tubyRv0pwf5pIbnWddMYsRE nUs7C49KI_J9ah3r3Mb8deYFmzBPw.j2tHJAPp3hZ4zOp8SFoLwJ2fzsOyyiNdOIq4Sw3URmuY3y XowmpI5SXSFnVB.vX91ulsdufWnVMxn09qCdfs.mhiOjjjmsYrOuiV.0JmKbU3wY66I36YfAG6RL UFRHN0VjiZWzI6xomc7QanLPISBM0xTjME11FwFg5bWT2J6E.JU01PlLMdsnuXxQc1pf7LVeYJOG 7QGYv1sgIL7wljq3bYxfK0m3Nj2FKjy.aJHVWpWDRuVcc.hvqEwjbAdrzBfWwIypWifayqIaRHCS ajx6.OhG_6o_9MSuys.OwQFf3rXv6fd46halski4TTocpMMbahLwi6Kr6954vZXpB5JsSK7jdJ6k CZ6z15g29uCbiYOjB4jhq1mmgW8zgO3WkyBS_iGQoJZvQ2rRaK.FzWtbG422sxD9Es3aNRjYquXP 32zzrg_E0zKYszhTna5gqKR3wXK3JGWf3wwtaYOcxstCeGB0Z0CedgMftkwgZajTBgQ6HKiouP3k ipjrXNdwKWuuhPFf7lqhYaO1cNZuwdVa4g4PEWrC33kMJdWauKYjazom.DC_3YugaUHXRT11Ki9o nosSKAVyYuwQmo3DOLPumrKdjx.UT2YSBH1iRD3apR.Wa9CYMtyy7shBhDxxXXVn56OMqIwpX_z3 a0fn8Xsl8atTA4FfQ2JAWv4kLry.ogaHnuYmpbo6wuh82NjgdOWIlNkKmlUb8YWH5blbc6xcuCW2 3SavuiKMHIiN4KwWMlTyGBHp8CGyKxIZGSk.E88kuYlZAGsYEj_1Upa8QkB1YTx8jGp3V.c41BsW ijeRH1yx0NZ35m4c.JS_yPhpg_Xm72B6VwMmBsE169__Zsx75_SKfWSql0o_KwNmkVT5lXsWH_Yu FY1WdDh7PcmtoRwvA0XN6ieMRS_6eEV.A2w9iOFgwhvdKDXixtaOeFY7Ur1yaINeBnRSgvNXpK_U 9aZ.2M2jdg8M3MMPKGwqhzq9vi.UKCPKtdWK.pbiTbks4PDlm_FO9zLlxJkbkCi61PYIhYD9d0KL Ox6MI0P3i1BGSd_kWjhvEzwb4IfMbr5Y7j58i7N2O6yQI_1rMB0i9YMIX0cxsKeEV5_c5.yj3_t4 zFXTjPwsCrV9XL9Asv9l_hK_d546LIhczl0VRVjow9JZQZQJyB94aT8.5dNTOsVENRmQcB38m8VF fy9zK_6erVRKcY9AGTS7exTex56FI7_bL6nLpGqy8rqML4plYtnpelU8gvG0zRjCKG63gLh.YDPx ub1.m_jesiExYl.wPwF9D9oGMO7wsPM4fC09iymT_dmT8rGpy3LCTrn6oiXxbteP4lbPcWXJELOZ 8ndhqhCzg73bUdvYWhwrOqxtcyp_mjGfreM9sfKKjC6k2V3UYnKJs9Y3x8Vn94V1C5RicLPAxeve qv0QjvbxUTH5fMKIyTFQgkVOv7U3C0xqRIhg5ZH5g37a7tot6od4M2dtak5SiFZN5mIHftoS9XRr ubC4dSiV_OPC.pFovaH9zx7unAgrp1Pelo2W54P90vNs5AnNerpHxziGbF.JuyqeLBeCx0RyogCg I.yhLgYP_eJ9dv7gmUywcL_XXNt_tOScydu_jKu4Uo0i66LMP8NXq2qIE5HmyL4tI9hXk.qAH9UE cUSPv5jfiFO767CHKc45yDWo96mWSqfyAF6PpeAepn6m7LKo6mzFoDnjY9XK3Q_bNuzkqtdvUedj ZG_MxsyYD9ijKd8hHpZC5_dpZqSaRnOx75tZ62TSIZ2TyT3pxXDBNC8B4Pg-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Tue, 21 Dec 2021 01:34:45 +0000 Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID ea741d55c687bd5ca95ffb7e6a0a3132; Tue, 21 Dec 2021 01:34:42 +0000 (UTC) From: Po Lu To: dick Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size In-Reply-To: <87o85byhqg.fsf@dick> (dick's message of "Mon, 20 Dec 2021 00:20:55 -0500") References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Date: Tue, 21 Dec 2021 09:34:37 +0800 Message-ID: <8735mmzqoi.fsf@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1236 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676 Cc: 52676@debbugs.gnu.org, 52676-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) dick writes: > I am sure there was a way to do what you wanted without resorting to > what you did. Perhaps I've been too harsh on you. You've gotten a lot > of poor (but earnest) counsel from emacs-devel. None of the counsel was "poor". If you have anything real to add to the discussion, please quit the rhetoric and say what the problem is out loud. > (cons (car dims*) > (- (cdr dims*) > (save-excursion > (goto-char to) > (if (> (line-end-position) (line-beginning-position)) > (line-pixel-height) > 0)))))))) There goes the part of the performance problem that change was supposed to solve: if you take a look at `pixel-point-and-height-at-unseen-line' in its current slow state, that is similar to what is already being done there. (And once again, your test simply does not work when there is a line-prefix, unlike `pixel-point-and-height-at-unseen-line'.) So before you come to the conclusion that it is ok to remove a change, please take a minute to at least try to understand the logic behind that change. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 20:37:00 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 01:37:00 +0000 Received: from localhost ([127.0.0.1]:51856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzU5M-000584-Lu for submit@debbugs.gnu.org; Mon, 20 Dec 2021 20:37:00 -0500 Received: from sonic305-22.consmr.mail.ne1.yahoo.com ([66.163.185.148]:34305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzU5J-00057q-62 for 52676@debbugs.gnu.org; Mon, 20 Dec 2021 20:37:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640050611; bh=vI+udYrZjEItshrYDXPGKRNMtHobc2o7U9dzWPuX74E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Z/M6G0V9eWFxfvzEepAWEd5+iXJrKPNRO1IN9qY4aoN7dS2+kvRu+b1zypCv9imcs1NkgGRVwkvqu/MQU1gp1FY5udDKIcE+9QOujSoDGKNjO/TF+4Cmj+Nj97BP+4LxCwV9a37bM12XOe2JmEfoBVP8WI1k6PF2qSWTJ69LLe1pf3GOGGjUL1MHPu6B+0GIEEQGMCzY2rq2Hcw1YGVmIkE7C7XIxqx9Z11+ec6QAtguboXDLWiQDobWu2XPg+ARszoEgbIAOLmn+MLugVNhCoGOIfpt0DB5oNQQXWd5yjUyqXhYuVWKBE94Y82LaMFHFaLFn9Ep6AGFTz2uy3rJ4g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640050611; bh=lkbnwiV+uJjJRTr/jyxkR3a8ZIdsQQmb7fNAl1ysl+Q=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=UBS1N9LxFOPs+ktXM3THd07GCUc/Qe4p/wJfguzd6x9Fb5h9JuLIT0eBx26qtoHdQUX7YBUm3RgWZsTFWDx3arYUvXpg2bigGD/11LyePrQ1QvIguvaYdrmAk1R+ENrfwYtZsP6rfY+kdwlkS//ePHeY01nQebh6/2Eo8vp1gA3zH0V7FZDUX9vlXLJIVkSmyuge97tIK7aA1W+v6zY/yH2d9fQ3q4oabqnLxGvJUQH+Hdzme6TmkN0+RXgcPmx/jtVRf4dHaGXeyVfpcsL6FWxYBLmAlGQ5h/fKryQejT1qTSq8gf0fAWKzanAN0EVoyF8EkNtk4G83H6gDJ/lhkQ== X-YMail-OSG: 6WPwmOEVM1mnbmjuzYa2oLj5Z48rbGFSF6xBtprVUZQQR3.KLO68vXLFr0qcNte 1meAY1TvdloHJM72DAOU4wZ5FiO112H2rnLk9e1ILHVY1NzqsT8YRREn9Pqt_wpqcXCvUjk1EQDk 6PhAVTY3OLK2YmaMSlrHMOHRbGj6IjnvDoYdm2InXqH97a0TIavQwNSFDxTg8Xb_QiGT29TnBn94 6Xn1IDWqTJgjJq1IntEg7RLXkOwkTzQ20Zzgr6LHf8gf1G52S4evTSiy7QJ9aThLWJFe2oEaceK2 jh2PQ81sIsc.KxH4e4qwv8RA1qNZlYwO5ptQNDPgoeIyMQ3Mo1Z5lFQ0i1YQN.ciwe2.6mAyclKB cSdPRbv7mZyVMnk56tBdrW.cSg5rtbG1WvJ07IyU8hHMkqcNseDy2Hl0bSzd6iQMMzSvhn4UZG5. 6Y_K0mrhbEQDz5PjEzrrwrH8.vOdeTWHqCdI9TBYby7SdFXQ55kUd7cKPeSYK3Tr2xQQf85JGqRV ZiAvXZP_Mq1pk0t0VWbAhBwa2J54G2c7T_T0p.gIG2HiC1GY_wCKaopCm5_hvGZTdOhFxOCFj8IR ZJR18S9cAsDjELBNsmmiYY03PXq2Fsyl.sY_1rUhtIiKxu9V_G82Ok2goWUH3DqZPKINexfbkEwP 6WBdmleujSmGK88EwONtj2NAmzcWvW6t2_9by2aLsFWDBUE3nGoYhhfwd24K355z945B5Wv4wQqY 44Ih.pRagCktpKBeCytTzMPsCaLlbqpzyft1zXCqM2wX8eQT.DimvQsZt0f.cCypBJzJ0t5H9JJE ___ItDB9lYtmc63d4pSofzJovHh9wv7dPt0.QDT3vDj_r5LB7uf2O7rPboNWtD0YncWOxeLFofm1 pcpUq3RHDBqvif468NZcoW_OcBYzdfb2005iTLUyjEhNIc4rP.7FDJ8SxIlgG.nwl.5UYWd_9nax _E9ut.ckmMN0LAIPBF_Sfj25mVA2c.ihHsE7hpYuwLBrrhpdJV.ZxBCUTIojiAfA2cNyVFc8k6wk IGfAnWEEGRXMi7iynU_NRPb_bcXbll79tv7zrbX987U_3nFKetoRrHjRjdLU80jAAVV0PUsX4xg. jw.ETazp0H9ia1JIwRV6dlByyGNhHwakNtCkDQm9pHQbcWpS31XERdiqqyDXzHPgfaHkQO8JlJNR yq8Gl1slNDGsZ9eDcEJdnnzYbQLE95N.xYPh1X7tUDg5uocmwPhh0IF73AM.lS7VPiDeGyF33iTd oJrHkBgx0gm0pT.SzNqlscKrMP4VBJEzy7NbQThO4xdosR2Piaf8RHLarkcBK_A1VYxzzqFxjHm3 q_jYv0m9YoBLRbzoubwuTchXg5c7S4opacZE226BGdJMtJFzhx4EVDy.LWTOzrQKPfMr3z1YpEFh Kly1q2fch7yEVWT_uVrjEec_qC1Y3.iTUpAeq1WaBS3Oko7JCsg70g9PWA1TYC2vIIxmrkBvVMuc mlgVKs254CY2aeClIJL3EtpmmdcEJos3xT965nPixPireimg9hsOiif4sjhp08wFzOxtCT7tyfka ygQV3zo30lpLHG5Q7QK5LR4zexaETSTGHCBaFcKuJ.MPgEOwsWVtKZWBQAy_kSOXeeq.a6S4kFgv lboxylFMC_u5nn7YNXu68wT_65WCANEwK6mCS9iI3KLYycw59clbc9yL36ITOvtSamJqolUjhYo3 SjQqHxgf_pgz3ggTQO8nTso7iZs2vIMYntJ8JuCWXt51Mj4VGV67LsemTM_X5kT2IEqfcPtEZXD0 Wfa97ZHJHDAvSOw1wf5zNQPswMBxXqnVXCPKPD2VwJI.F6XBu9HCcjERLWfaPNh0caGRafybXddW C_5twJ9j5pQDlw9mSAydPPiCLZBSRfTMl.4ttqjBNV0O3iuHXIHGJhfA8y9DgETRr8Tu8nUVtj_X MXTTITjjLF7zqm45qQRlO4Qtz2SYfHrN6jklWMY1jncJlQXH.ob8zHieSuZaYZVYAlbcfgHNC2Ua Eid4eSukAsqq_BdK4I2Fdrba2LHglTFnp1g7baOWWdOHKUqu0w8i6Xuskgh93CYbsIzTSeZBLt0T gH.7wFNDufuFpOrTE.xyUcd28QaZzxBNz8t7kLefAKa2SIyc_9oNYZ6rAo.AHhh62T1lucGcU4kc xhOl7nZ9KLzcTu0VtzGahXqhBrzFek1NxYcgAZbINRcVfBm_jrzFQz9tUrb1MS7o.0omWWShvnWy WgwwIp8f5Z1thcxFES0VU6bli2w7U9lfpKBJsbZyR90YnGCW6TDzEFoC7Ag-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Tue, 21 Dec 2021 01:36:51 +0000 Received: by kubenode513.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 75077e03d2e08040619ff0db1ae1e42b; Tue, 21 Dec 2021 01:36:45 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> Date: Tue, 21 Dec 2021 09:36:40 +0800 In-Reply-To: <83pmpr19ri.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 20 Dec 2021 19:11:45 +0200") Message-ID: <87v8ziyc0n.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 213 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676 Cc: dick , 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > This produces no assertions here (with the current master), if that's > what you wanted to hear. It fails (for example) when there is a line-prefix, and that code is slow. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 22:30:38 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 03:30:38 +0000 Received: from localhost ([127.0.0.1]:51921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzVrK-0007tH-7L for submit@debbugs.gnu.org; Mon, 20 Dec 2021 22:30:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzVrH-0007t3-AD for 52676@debbugs.gnu.org; Mon, 20 Dec 2021 22:30:36 -0500 Received: from [2001:470:142:3::e] (port=34384 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzVrC-0004No-36; Mon, 20 Dec 2021 22:30:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dlrFg+fLaLpq+nD68VkIQCg68n2p9of4d59t7gelFYU=; b=mACd7UJwwJZg s0i98K5D8xyeIa5oYUcK5aBI74ttQ5nWJiUiWkLGmLyz6einfWk0pZADQmQJcAfH/JvuIYNFgQXJ5 7AhJ1Fn/l4b2FFLpTG/wlLCvxtopul7liE3duSx7t78vYgf7db6lKFdrxOksHKYxpS83Eqz4HnHCc YkAuG0MfnHVzJ9wtGeTdH1KmrQE9ynVSq9sYJ6b+EozadVsfko5SqlKWTHksI9lmOsYNpMcaaXJDI V0DDbQKTEvpr4kerlweZ6CnHfUhuAqfxzQodGYw/7vZiSZVWY0mFekVpSXRsyqCXBLpPBYIvapxwA 8iYPh45qZHPrPuhijYr4QQ==; Received: from [87.69.77.57] (port=1099 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzVrB-0006Lk-UM; Mon, 20 Dec 2021 22:30:30 -0500 Date: Tue, 21 Dec 2021 05:30:29 +0200 Message-Id: <8335mm1voq.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87v8ziyc0n.fsf@yahoo.com> (message from Po Lu on Tue, 21 Dec 2021 09:36:40 +0800) Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52676 Cc: dick.r.chiang@gmail.com, 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: dick , 52676@debbugs.gnu.org > Date: Tue, 21 Dec 2021 09:36:40 +0800 > > Eli Zaretskii writes: > > > This produces no assertions here (with the current master), if that's > > what you wanted to hear. > > It fails (for example) when there is a line-prefix, and that code is > slow. Can you show a recipe? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 22:39:01 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 03:39:01 +0000 Received: from localhost ([127.0.0.1]:51926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzVzR-000856-1o for submit@debbugs.gnu.org; Mon, 20 Dec 2021 22:39:01 -0500 Received: from sonic313-10.consmr.mail.ne1.yahoo.com ([66.163.185.33]:37972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzVzM-00084q-86 for 52676@debbugs.gnu.org; Mon, 20 Dec 2021 22:39:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640057930; bh=etHuTN0OlQCV+heVcCULTnRsx/3w3MXqbkb7km75sp8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=qFAn3pjy5xNaXxV15HQdRZrlkqq+dQBDeIlmJvhZgps90MbzYzmro7AonaMB6AOpID0wZoJaDe1qwOO7crTpLpCQeO4XZEj/RjT+nS6qBIcXcFBuhsaOi3eqiA7YL6ITaU/d76eg46M04qTV1n9IVjnK2goNQZgeIPfEtTgtL31S78vFAjNNIS+we8NLsoyiSMjMWCOBp1t4V1UfwCWdHO7z9YOBaAbe+g2nYUVJu024Tlw15AmI3wwvC/DynBf6GrvujKAJ/TrRt9WegVF3Vv9PiSD9KjQVRdJPDKuHe8FDEswlSyzLkGmgtwUyq+b2EBo/Vu9N2DtBBuNwhpZ+3g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640057930; bh=L5yYvcvbPpJQECYD+SwcJTwpnsk3tJ5Zr01ncZM7WQ8=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Y6r4bcdkGTxuw9atGuRfdKVuwXBReDFstnVa7BrEeSr5SNQwQUvVFhf/UQhZvNr3jq60X4bVV4B0A0jWNF5d5BkS7KHg0QNyd3wTQ3Q+8Df9VHGxA5YCBCH947MTdKvxDdjwnYFChg8RfkgTuymkBNKgw+QSsBzsLYvA2M0i+cNWHdHaJouaLXdcCabunPuZtTLJm6cGXNbINAoCYMe0DOldBtl0PDSV2hhvopdjbG5cvGRIAUTmy5imb4IjL3mM8eoQWoTMrDvKBkOVtSZedu+n3mC/+safkiNxy7Oekow33Rd/GyrP9fos1eonPVU2ZiyAkt9rK+3XbDC8zAdzzg== X-YMail-OSG: RaX1rTwVM1lizUSySav2PtXC0Mpnc.aiszm9McvBENhzChc2WBxcZhgHFZIlnw3 iM3Zt2Vnjy6jfmpyEbYoecJFsaBumf4_Tb1ixfWxXVTG4puhHl.Bo2pqnErgnBihCSg0mygk7tRv Gu1522CSuBM88oO.Eo8zSD7QSvKQAWhjosUkVtYNAA__VLGA47OTcEi6zYgIvsc1E2woyNSqBHBT ok.sD3w9Z.0VHQJbUxzkjHfaM.c57XWQLBJXRvG09eZLevL_rEWHnis4aP.rO5pQBlMYjvTzjUFr 4FtF6.tsjJIa2PlqOknheyPQtFsvPp_yJnOWfsXiBWe2S1XORtU.yNX6RPbZdTZSRgOU_OUmp8cd sAz3ECXKaRs9Fft37qyiEuetUfzgTmuCNhqmPlOaVc7VpLOHP2vdz__Z.sDb_UakY744lL210WKD ceOcskOSD_fNftlmA8fQNAhIAUXb.wIvaDlNAedmblU_d0w5wRGmujHMF.DLLC5T810A3PNsFxMi tCAGip1VeCIZdistc3FRSsLNDMeI6bl_tsCaMB3qpyrcLHHUKt7N2An6FtpVPSm8x_Dj2BFTuIKW A6FVTD9BNcW.cMiPKYLpSXRqEe8zgVcV1dQ9azT_L2tmt3nV_T42jDSUdzn7MPRDqmg9Tx7wunSw ndkjDu67wFewapq8c.OEvMGL7XxDpI6UL7LzdHMis_Zo75RERLa5mYnGP2f77uCLNpOoYM2AAoRL 7nOnqNdY6CQs0v8v5oTwI.lQyjmgx7mWWAG8vnTnfxQingsq5Pr.2hOjhqWzYwQ8Wv_8oO9VdrcO 91F5BbZLX9rcniUdijb0qR_LW0TzvjasemosyVoN2Yps4jM9ZCbyOJtChMLUcFb2WWMDuIMvu3IV AwlTXFHpS_S2Vos3W1r_OS6mYdt8mhYz5m58CWildgAtPK9P8nMINVhxe9IKBTgFTiDlR03TH4lA R.Cqti5moJwrZkEQTkN0x.AVftLy1o.Z1yTN6b1_qXWzEB2vNM1lTD8eBb2Vb69bGNUs2nqSBcV0 w5kZR_Bn3.9FsbnrXDAHOQB7hkBiLq07I0y9gx6ptwFJAO2VvTQ1oMkUvD45U7Iox8ObxezUgOsC _G8dbuu.2cvK3qh.6mcACJnQvEnEZqt81yBDVHb6HKvRFn.yTndgRmUbD0K2RM6NjHzA0kbEw3KF fzRS2X3wlvlDje67VM6WKwilizCsgftdOM73f8nJCNd28yjY8nIfvbML8vD9xnba_yeWDmZSFatL S7B113tFya1UYUf_az_hL72sam95dRuihBWbXZhicnKj9VIJq0V0G9LBX3nnuyFCEERx.ye8mAd1 CNHEHTHuzSk_ZCgZzjSFLvT2LG3r.fDF690UNsl75p4Tc17OKe16FgrHplFCBzrYytT4jHHIq_Gd sYD0fbVMpBaDcaaImzb4q6dXZdB.JgwrR0WnHNpWcXjqeWf6I67dqtyNp1qMJFVGbdVFp807_jwc h2O6vC2bE8MNcSBKESpYG1K.uho_LbezWF4PZV1PyKK63LiwxUQo3eTx3C6EfHEx4FU32LMBpXPF jXgAyRnJcsocc_41fnJbAZpKmFN3P64VqmxPvlkBf_d9TPn3HW_nPIZa6LMxFZCYOchWErHEGfnD ltOKUyMddY7WWc0FAgSv353t5PurUhAqV5ft5l41lZ.YsM7UjgJWURVwchnyM.e0uZesXUnkrJFA WkuHiWbV3dUOcU5lUvNaR9IYKO79soJPvQTSJbNrKYkFDPQU7x8I.z2OHmrPOi.t0xTDyCexCjdY T6b00.bc2idtoOtQ1H_UUHojn2cr5o7fWdEwaHtC2hnhih5YKjm5m_1anmYtXjXVicqo04eTy8jY MBgu.U.825O8o5HPc.t2XggZ4KW0bahwNTn9ytDiMDX.Hz5zNDbgKpFWBl_aNyEbDjTR9d67Gnl4 WCT.a8tVzdAbzQxFU4s7pGR_3AR3L2MBFsycYzbC8Lnilbi6tP9KIt4T6skYL30oX_aCogwMStUO _7b3O2PdY5nuRa46FgaOoWxgc4Zr_yzs5kiBE7zWKZfI_0VGtPtt9G5HAuXjsSFrn6avWpN1I6L5 AgAKJu8XcdK4mtgvFmyR6nUaOgMs5p_BGLn.yfsPQ7IrvJOOMd5_5kviQokMpzZ7XynlVNrjK1XP 5B8w9tQayrNpqBhPjjmeekFzzSeDKwx6MoXlZ6v59kmc5bJ5Zn91vNK6E8aRPkAXtDWoCrbj5k4C m1mUUe6V52aGRy6O0MrpZAPNa_xPYzkx.tQ8ghlEn5rsnDd.ogBmrEOgfVg-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Tue, 21 Dec 2021 03:38:50 +0000 Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 8db8197303ad6f6da28299728af6abfc; Tue, 21 Dec 2021 03:38:47 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> <8335mm1voq.fsf@gnu.org> Date: Tue, 21 Dec 2021 11:38:42 +0800 In-Reply-To: <8335mm1voq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Dec 2021 05:30:29 +0200") Message-ID: <87mtkuy6d9.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 640 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676 Cc: dick.r.chiang@gmail.com, 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Po Lu >> Cc: dick , 52676@debbugs.gnu.org >> Date: Tue, 21 Dec 2021 09:36:40 +0800 >> >> Eli Zaretskii writes: >> >> > This produces no assertions here (with the current master), if that's >> > what you wanted to hear. >> >> It fails (for example) when there is a line-prefix, and that code is >> slow. > > Can you show a recipe? I didn't write one, but that's precisely the code we had in pixel-point-and-height-at-unseen-line at some point, and it didn't work with overlays with a before-string, line-prefix and wrap-prefix. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 07:12:34 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 12:12:34 +0000 Received: from localhost ([127.0.0.1]:52620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mze0Q-0007zu-8m for submit@debbugs.gnu.org; Tue, 21 Dec 2021 07:12:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mze0N-0007zf-Sn for 52676@debbugs.gnu.org; Tue, 21 Dec 2021 07:12:32 -0500 Received: from [2001:470:142:3::e] (port=46492 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mze0I-0006RV-Lp; Tue, 21 Dec 2021 07:12:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=m2azpBg8KhCZCxRguJ962t1/JNuFPq5D/PDztAuD5VE=; b=DhpN3SfXSG3/ c4CB/mG6lqOdHR46BOOwBn1VthI4tM9Ia4UuFOt0Xi66Hp/3L41gRQy/JiVT0tPjqpWLdrEI4rmIa p3ZT9u2GjOn1eVt97Qsu7ZZC2SaMCa24qtGWOfiTgPgetgkuczMwPEdyGQIgt7kVquUwPPdcAlYn+ 1fp7jy2YFzUWarm5onoMqN1HZf7tiHxW1wh/zE7p9x4CC8sL0TN2fBPV4D25joboMyUVeH+3+xM78 tJwsg8s8ENpDgWNPjaMBhWw5xJrfXjxNwZEuRlcI6ZS34/KZJU8ACf8tdrz96+HEIV83KPlLEpKq5 fRIY2VeuiQtV/+1TJirZVw==; Received: from [87.69.77.57] (port=1475 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mze0I-0000M7-Jl; Tue, 21 Dec 2021 07:12:26 -0500 Date: Tue, 21 Dec 2021 14:12:26 +0200 Message-Id: <83zgouyx5h.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87mtkuy6d9.fsf@yahoo.com> (message from Po Lu on Tue, 21 Dec 2021 11:38:42 +0800) Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> <8335mm1voq.fsf@gnu.org> <87mtkuy6d9.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52676 Cc: dick.r.chiang@gmail.com, 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: dick.r.chiang@gmail.com, 52676@debbugs.gnu.org > Date: Tue, 21 Dec 2021 11:38:42 +0800 > > Eli Zaretskii writes: > > >> From: Po Lu > >> Cc: dick , 52676@debbugs.gnu.org > >> Date: Tue, 21 Dec 2021 09:36:40 +0800 > >> > >> Eli Zaretskii writes: > >> > >> > This produces no assertions here (with the current master), if that's > >> > what you wanted to hear. > >> > >> It fails (for example) when there is a line-prefix, and that code is > >> slow. > > > > Can you show a recipe? > > I didn't write one, but that's precisely the code we had in > pixel-point-and-height-at-unseen-line at some point, and it didn't work > with overlays with a before-string, line-prefix and wrap-prefix. Well, if you or someone else could produce a "emacs -Q" recipe, I'd be interested to take a look. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 07:20:16 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 12:20:16 +0000 Received: from localhost ([127.0.0.1]:52630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mze7s-0008Db-Bi for submit@debbugs.gnu.org; Tue, 21 Dec 2021 07:20:16 -0500 Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]:42693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mze7p-0008DC-MV for 52676@debbugs.gnu.org; Tue, 21 Dec 2021 07:20:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640089208; bh=0fk6B4jxOS/wGthRC1YVyLHK0tJ15Vc+v3GqH5aK7lw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=rieL5baAZyrG8mtcK6CCTkmgHzdYra2PePT51EruGiWpQJIjgcTCjtYX2FHmEhCnUxI3/cRopCI6O6Abh/FJXw4Dscz1PO5UB7X2NeVLJeP/oeLqsB/nFwo5SDAdByQ7sX/nrM5rOTdoyzwiZ6kKI0sKCcEJ2FO9e2Q6TmhzPakiqzwd2wip0u1BAJd6w51iEjFesHGkH+JTa/Lar/UX/J0EEsTExZlO6VUzERYhDubYVnrqY+eO6sVD49vb1XSWX0lYmlVKJ/0PXc9sxXYOCvYpgxRZyaB4ejJgzotnGjkFhEZ1CrAP1q6MBtusELmhn3lsy9YP98toPEJvTGpGUw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640089208; bh=opEunYRuB0zWOy1CktuiE5wa/vs7bGlo2MW9b+IQxd9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Hs3JiT8H11FcOtBeyznhqI8lHskM9Hc/ZqiHVYqYjpn5eJBHPHXVXwwGeS9Fz6jvjcEFLRLTtEP4EBlmReZJ+25S1AziBvNIQHhzum2F1NCpN2+UPrf5+ZwXIwU5ZjQfjn/oLCkTjN3rUHuyT/oBThS/RS4676nBu41163zC9tX2Ji8UyurQZAq98DZHHAqJpr/rFs707dMNMEmqg0JrcuZckjzbJVQx6HtEdHof2w0McakQXHehBSCFnZwhyEMskPWjE+7O7ECJNfUPyX7d5s8wJUe0b22o4p/9R9/kKotEM1oZeB2/dABIc+7h8hZhe1s3YBeZ13sGn/bCdpnvZQ== X-YMail-OSG: 6JoUWGUVM1mHL0bm8Oi2lGSvwUkkb_Jf89lLZhP9gM5LbxXl3Qq4mdIVEXlu4uO 4tlRTttlM26HP2RLyrT5qQUhmvrLRrs9CQ6RjegqLkOK60ThTaL.rOu6E6dxJe_dB8UG2bkQ3nMm SdntNw0t.dQ7tmin_cO6XWSqmbuSfu3M0rC_wZbDlcpc9bWted_NQGdIi8jfOMY2hMaUU_Njddpk 7bASrizl0eh2rMu5mDTLLz9SskZauzJSL8Ec9QOoCGQQgRtJcq0hbrZp6vvKF.6yep8Ts9yuYS49 .7e7S1mznk0XnehUX.ZAhEVkGERfDECMgpe9q.yoEhM4NSiMPRT6tYxdGwXX4LaE3iGePpa3oral RCpOb5S7G0E2vwosscWlyqRCaGlVRmLMk4BAk23MI5xu4JJvFeaDlLd2wbFJpTGRRMcvT1ryteag AVY1YlBc20QugMl0K.XGkE98vsWJ9AfQiFREodvyZ31zlqw5gutNxY8TSte_oLJm.0cxac9GTIC8 5mKk9hYHFpaADjJ6bJRsEUnlLK.CulK.mj.b0TYkU_CVY12MRnMdcmfgg2aZwEchBpbZ9nAGvzd8 1Zhj6DtYqqXg8lcPevbSMEpFiZCDmCyYGS6ND3cWcPqrz6bzH8KQ86qCoNra2._qJQx2DJk9UtTa zQvdgKStv2ukYmy1IwMA7zDWe2q6.ZfwHxNIlezeFYqS3zqlw8u_2p3nKSab7r7_vFYeXdwqzaO3 hF0LzfBhrSlQVdVH5OXh4W4uD8ixOVyUzWk2bJAAzdf2waLyyQE7Kknt9AIw8dCTwP.BpU6GaO3A NKE2IZ5O4eWRJTAy6BBwW0oGe5Hk7.7KxjCzkcFNoE8Q8rCSi1F9z_waHqUTCo4dmMzUokwyjmmS V5oxwq8Nf7ntv.yjEA_OJnlgRKrB8HiqlqGky5aTqvxjR3U8O98z2Yc.dnU89mQ6pSctaI2XpZy1 Erde.eArAH50vZNGvCUeYI78hNjwaNf1kpLkH8gDktdYiLLdQRV29YrnTJUlhK.mFracr.KeDRd9 fXNuZ.o2uIcNaVWcAWhHE1LZVEbQ0_KOrF9k3CrO82BKqRAYNUz7GaY1hzvo4doiswsxXzxlVfY7 ZzZIu5uhY8hHRXoy_kdL6pT5NLSjPQK5PKmVad5bpIUPEdf6rAnS.HU57u9eU7phmFixqFRXq4ZK CcZxNuQGbp53kNas.hJ5.BO3BVNE5gUb2MJzHS9Z4pQprhV.dF4U7Mh.I0nMnm5NsM4W7qj4_Znx U3r9mW1a6407XeT.xiySjDMrym2KigqSTLVPd1tJr4rYwRCPl12fMjxTrYmzIBARuQZ7jOxkyGNE VTdP6O5WwXKiKiPBlWEmTmjnPcuATo3VW5Kz2BVlJnDHzxtpWkCybJd1jxB_154jB7GV0057jcRK aRDZVuCqaNPN.Dr7fXILQ0HHDn3vUHD9Xxo_WuILWmQmqB2h_ozhmI0Iu4b2vsSEMTpv3dGU0QmX zeVVJqb4XWOKjnBunP31GuOlCdD9zRxio8ZwZuvOR9k7lE.jXx3GZDT8xqc2Y8hczEsK0cdp77JX BmgN9g_Ifvl5d6gaaN3K23QA6o3Bxj61pvivxGQ6iRF.t4_UikTEgQrmHG5efrL.sI6_IBJ.6WOb FZKDL5OnReLqLj98iGZi5_D.zsXSWr2Yt.QBio7Bxy3DtUXEh0LK0Hsh8tEw8oCou5bOJxNykGe0 sL1xHO8Cq0pPA3H19XfDPmFicnSEGNARWccoEiabHsE5Z1EOQfc_VF07x_dBTSeoAulQZfYpmN5T q35BBBx4y1V6Z32A6_JfacUpsreRkSohnnfvdhwjnfOYcPd16D4NLabM5y5kE2q1OtKjzNyZtwwK CEmX1RUYWU_vcPmL_Eudl1V8g7g2nigdoJaL3IC2mOCuS4jEtrZ89gLZ6aNu.ktA.peSDayB_t0z KXSg5h7him.mdHrH2QUW_VnDGpI6cWERLl0mAhL5p15biSf8zyQh_m_RfpPrPrOqmZiF56yVksGH DdeDLDvtnCN0gLZsd1zmESWi0ijDP.KZG2yk.ELcCPAmVXF5Ek0Q3UUDZP1SAb6bsFxEfJMMG_Nw cnwtI.DT5SH9OXZFETWAkwPEofctdRa8_DzaANoRCaZdsAAi7H27kVMh1cLa0omb0WNZYZ2aT8ld f_GynaNfMa6aPjl6e3q6Fevef.o2wstNoRYlU90m7v7jbB3UmFyDPaWydg9Yc0tXp6BKkwCoy0w_ FIhlZYf2eOtTE0d9R4pSgv8lD0SEHlIuefCixClLcUR1wPExGKblFRP7bdCiQ X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Tue, 21 Dec 2021 12:20:08 +0000 Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 25eb779dfa5a227883ff67fe20872934; Tue, 21 Dec 2021 12:20:05 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> <8335mm1voq.fsf@gnu.org> <87mtkuy6d9.fsf@yahoo.com> <83zgouyx5h.fsf@gnu.org> Date: Tue, 21 Dec 2021 20:19:48 +0800 In-Reply-To: <83zgouyx5h.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Dec 2021 14:12:26 +0200") Message-ID: <87czlqw3ob.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 532 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676 Cc: dick.r.chiang@gmail.com, 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Well, if you or someone else could produce a "emacs -Q" recipe, I'd be > interested to take a look. There's no need for you to take a look, because the code in `window-text-pixel-size' behaves correctly. dickmao is saying that his code is the equivalent to calling `window-text-pixel-size' with `ignore-line-at-end' set to t, which is not true in the presence of a line-prefix or an overlay with a before-string, which are both use cases that pixel-scroll-precision has to handle. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 12:56:23 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 17:56:23 +0000 Received: from localhost ([127.0.0.1]:55535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzjN8-0006NC-WD for submit@debbugs.gnu.org; Tue, 21 Dec 2021 12:56:23 -0500 Received: from mail-qk1-f169.google.com ([209.85.222.169]:42734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzjN6-0006Mv-Th for 52676@debbugs.gnu.org; Tue, 21 Dec 2021 12:56:21 -0500 Received: by mail-qk1-f169.google.com with SMTP id g28so13306711qkk.9 for <52676@debbugs.gnu.org>; Tue, 21 Dec 2021 09:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SHsRFJ/mIynlkMtw6ucPG0qx1OOJ9RE1qqY5vewyDhc=; b=iSgTqtvs6a3cAY9NsIyEjzHWceeyhVJSNPX/DTOtv+6qpmb87Z+63pVReApldUX0HH QOy7kHjefb7TJGe+o7AFsmvYR+JXr6GBoRYsEGT0xPqomR3VBnDHZBs8Sr4Hl+o/ZnQb crOnr2uKv5YFBrIM+eBz3BJEqD9X9f7QjJbZB8cD57QZa/Up6ODdCYHMW/jyhjVN/liP FkMIQ6goZpnB24pAzwc4+z4g4fxqzGXlOlYeCb2uZ8WsPgJnIWEh3U8yItB0DNdE99Iv H15Bc7tyz8u7bmjkU2IX8Ou+2y5ojT6sgD0rLxOayzIeLtVB3yYXq0Ak09CyD0t10z8C /jeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=SHsRFJ/mIynlkMtw6ucPG0qx1OOJ9RE1qqY5vewyDhc=; b=U4vHjutgAy+4a4nWLzXL2KKifsXQ57gSRa+g06M7lvPJEnrDbphHkVQeGk3HkeZ17p fetTNnoSIIG4whKWGCqZ6bNormCe86soPZwKmp+Tc+EWkugn7BBl3l/Vsjt5MF0ZBEeR OMWg0JODLZnroYGoCpHGOKKnTTw/FSHkmJDfC5E7dWmHnpa2nBsTjgDLDTFOciabQHgA Q1pYKVh1QCZcJ499KTQmLV5BF7ndiITDTcbUpTkVM19JpS+zM3x5KVgEWN/ko/9i6vY7 Bo/3C3qI2cpBo/WbR2LsXbAKpYLwK0+/Iqc84i1kl3m6HzUtoaoC94jgEVRAjFs7561V WS2w== X-Gm-Message-State: AOAM532Ggw9RtfhZ7jIuvF1zj2/9zcNg9leNh6+OAJom00u2byuptZ3K Z9jw5YyIYphqSoA16vF9CNw3QaJ8j6A= X-Google-Smtp-Source: ABdhPJxd3dqWLiusg+tHiEZU3LHUjXz5H9+ToJJA2y5N9NjbRBa+m0iMPTkJq0scGb0sIrcf9NX03g== X-Received: by 2002:a37:a893:: with SMTP id r141mr2881377qke.156.1640109375386; Tue, 21 Dec 2021 09:56:15 -0800 (PST) Received: from localhost ([68.237.93.126]) by smtp.gmail.com with ESMTPSA id f9sm1065966qkp.94.2021.12.21.09.56.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Dec 2021 09:56:15 -0800 (PST) From: dick To: Po Lu Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> <8335mm1voq.fsf@gnu.org> <87mtkuy6d9.fsf@yahoo.com> <83zgouyx5h.fsf@gnu.org> <87czlqw3ob.fsf@yahoo.com> Date: Tue, 21 Dec 2021 12:56:14 -0500 In-Reply-To: <87czlqw3ob.fsf@yahoo.com> (Po Lu's message of "Tue, 21 Dec 2021 20:19:48 +0800") Message-ID: <87pmppg7up.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676 Cc: 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Your transposition of "up" and "down" in pixel-scroll-precision contradicts the existing understanding of those two directions. Minimally you could have kept pixel-scroll-precision in a separate module to avoid conflating the original `pixel-scroll.el`. Even better, you might have quarantined it in ELPA. You remind me Chong Yidong, another spaghetti coder who was inexplicably given free reign over the code base, and proceeded to spray the master with indecipherable crudities still being unwound today. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 13:06:00 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 18:06:00 +0000 Received: from localhost ([127.0.0.1]:55568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzjWS-0000Po-2Y for submit@debbugs.gnu.org; Tue, 21 Dec 2021 13:06:00 -0500 Received: from mail-wr1-f42.google.com ([209.85.221.42]:41745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzjWQ-0000Pb-EM for 52676@debbugs.gnu.org; Tue, 21 Dec 2021 13:05:59 -0500 Received: by mail-wr1-f42.google.com with SMTP id a9so28553335wrr.8 for <52676@debbugs.gnu.org>; Tue, 21 Dec 2021 10:05:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=PEj59e6tarb9b51aX5R6cTsT6zzzVWOjncXf4JGNojA=; b=L0aQSaG6aYJLsuGxUgs+4CBHsZq3PDBTMHMtvGEuaIk+Sa+XMzeBrxlkYcTlnwGxKP Jt4Tr2hy6fs/kbGJ95QSrzJioKaT9NYKK0OmlaYTw2Ws/9ZKvKPav3ncS/Zx7fB8l+Hk YdUmNeKTpyHj1kE6uxqbDUTswlkTmM1C8WOj9dz9+zXHH6AmBdWnMz3YYOEAZYSPYqI7 7bFDMN9TzHH1k8IkApM620onrpzavEhASv8REAGrdZhReKuu/DJqyoy787K4Zzq/5ObB 4Mjyb0r5J1VpWG6h00PjBBoC+nT0CQyHN7WQ2O5oiH4vA8oyFkSNZCOiTiZJhCbXB5x1 oU8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=PEj59e6tarb9b51aX5R6cTsT6zzzVWOjncXf4JGNojA=; b=IZ4ROMzQpXx3ZqAGaLUXqLJci8j8EnMZW7hPe8h7AEuN9S2A4/Q9hKUYcypNHp5+OO KRhuVuaxO8AwoO3aUt6CFPY6rxQFO+99mmK1vfxFOO1s2LwCERuCWhNASFUg/na33f+W nmkdLywdXTowbtHPQfn1SBNz0yGSt2wKMDtkKAdJvEmvni+cWH3z/rPxuUHaEoIzFcSj wkaO2ni9Re71LvRCRdMvDZVcw2/YGWwmyjo8sNtaNGFhAR/1Adbws25NZ/WP6sNp0QA1 ky5XwA+TexgRwaAZYXCBCJwkTy4HGa4Tz5ydAq8aA6oBRed0RE7n+m5IGEHgsJCUUNgD kTMg== X-Gm-Message-State: AOAM530iOx4f2Frdy4JRrDz0PcjPZjWOSy7/pUnGPP7qqyFJa2ir3fHw eqLMRV3/wkqJV28ZLcJ03TdsjCfQENo= X-Google-Smtp-Source: ABdhPJw5BP8vqtX4FVZzrLNZtsbdJ3kpoMu/od9NUK63irNm7ftqg5bquxSjMt11RWz76Xw2Lt4VIg== X-Received: by 2002:adf:f188:: with SMTP id h8mr3513991wro.663.1640109952186; Tue, 21 Dec 2021 10:05:52 -0800 (PST) Received: from rltb ([2a01:e0a:3f3:fb50:8ce7:6d97:56b8:1018]) by smtp.gmail.com with ESMTPSA id c8sm3606088wmq.34.2021.12.21.10.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 10:05:51 -0800 (PST) From: Robert Pluim To: dick Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> <8335mm1voq.fsf@gnu.org> <87mtkuy6d9.fsf@yahoo.com> <83zgouyx5h.fsf@gnu.org> <87czlqw3ob.fsf@yahoo.com> <87pmppg7up.fsf@dick> Date: Tue, 21 Dec 2021 19:05:51 +0100 In-Reply-To: <87pmppg7up.fsf@dick> (dick's message of "Tue, 21 Dec 2021 12:56:14 -0500") Message-ID: <87y24dygsg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676 Cc: Po Lu , 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 21 Dec 2021 12:56:14 -0500, dick said: Eli, Lars, how close are we to banning this individual from the emacs mailing lists? Because that would have my full support. Robert -- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 13:06:48 2021 Received: (at 52676) by debbugs.gnu.org; 21 Dec 2021 18:06:48 +0000 Received: from localhost ([127.0.0.1]:55575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzjXE-0000RT-A5 for submit@debbugs.gnu.org; Tue, 21 Dec 2021 13:06:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzjXA-0000R8-FH for 52676@debbugs.gnu.org; Tue, 21 Dec 2021 13:06:46 -0500 Received: from [2001:470:142:3::e] (port=60092 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzjX5-0000oh-7w; Tue, 21 Dec 2021 13:06:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZmlPA3LxU+jMKnn/vn3eFKV80tgSClqVcd619VbLOeA=; b=Ns+XNbG5qOol j+A1DcdGbGu/GzSd1fVtV7cDshNSKi6wQYAA17GxewjoDRrjW4TSYa2tieyxplC4sMBC7LiE3DcIp Yn2cNe61bFU5UYdJV/6WqWeZSry+uYC+gzmHOpgfxjxhTBFOiUMuxYorGJKxrd7ZliK9sbiH2deZe WYgWwHz08cYsFisCW8dQzhLIdrAkqh+gP4sCdH55xmZgHniFNs6Ow3168UUtxhwbeLZQ2V7MFNoxR 4/uATsARk5mgws71v42Ad57ev+hWH7nPSC3D0mZhcDsnMMGbgVSvRACMKcGffSEjkoeXY9ehDV0Uf a10BUZJt9TYqZ/jcdDNvFA==; Received: from [87.69.77.57] (port=3930 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzjX5-0003HK-5n; Tue, 21 Dec 2021 13:06:39 -0500 Date: Tue, 21 Dec 2021 20:06:40 +0200 Message-Id: <838rwdzvbj.fsf@gnu.org> From: Eli Zaretskii To: dick In-Reply-To: <87pmppg7up.fsf@dick> (message from dick on Tue, 21 Dec 2021 12:56:14 -0500) Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> <8335mm1voq.fsf@gnu.org> <87mtkuy6d9.fsf@yahoo.com> <83zgouyx5h.fsf@gnu.org> <87czlqw3ob.fsf@yahoo.com> <87pmppg7up.fsf@dick> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52676 Cc: luangruo@yahoo.com, 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: dick > Date: Tue, 21 Dec 2021 12:56:14 -0500 > Cc: 52676@debbugs.gnu.org > > Your transposition of "up" and "down" in pixel-scroll-precision > contradicts the existing understanding of those two directions. Which existing understanding is that? where does it exist? And what do you presume is being scrolled "up": the text or the window? should C-v be regarded as scrolling "up" or "down"? should PageDown be bound to scroll-down-command or scroll-up-command? > Minimally you could have kept pixel-scroll-precision in a separate > module to avoid conflating the original `pixel-scroll.el`. Even better, > you might have quarantined it in ELPA. Thank you for your valuable advice regarding file and package organization in Emacs, but we have other ideas, so no, thanks. > You remind me Chong Yidong, another spaghetti coder who was inexplicably > given free reign over the code base, and proceeded to spray the master > with indecipherable crudities still being unwound today. Hogwash. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 19:59:14 2021 Received: (at 52676) by debbugs.gnu.org; 22 Dec 2021 00:59:14 +0000 Received: from localhost ([127.0.0.1]:56244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzpyM-0007Kt-1k for submit@debbugs.gnu.org; Tue, 21 Dec 2021 19:59:14 -0500 Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]:44653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzpyI-0007Ke-Jj for 52676@debbugs.gnu.org; Tue, 21 Dec 2021 19:59:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640134744; bh=0KiqlU1SbsRBXRXoIbDx0ap4wKhD0iY9ZKh80onMfQU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=mOURGMETmlowRaO9JX5l6D378AKSF8DnGbe99f5Pv/s0eErgbCVoy3Q/ukc4Rt7fnyRmUHa+QKVXWFkuwtn8+QFwi7hZY3Ldx126cHcZozgXq9J7IOBrSCsZldCoIL0arC8vM8/hDGimDKzhWQMmwYem65wF1Bi0kkg/IlwiHut4q44jsqhElOUw3EwuXlbjoP/tozar7XJkbkj1hYo+do1tGROaKGrnkdfQZyPgNep0LQ+ZhSH4OVSiOvg2ngwu7/hYtKTA3Xw2yFZsme9IBMqWs6sJ7ZEyp6EQsBsqQE3g7QfbWHVSuR7bCFi6qSxFMj9R+VDKByEpHO9tkNFntA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640134744; bh=JFwFqAZh5FbsqehW1eSXGdriN4f0n8K8RADVjyBV8d+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XhUkB+JLulAjwSdFh6wTvI3rV3nVW1NSUE6Ne1x39yYbF6RKgJ2TVSVDZdGQpk6zKzhBboe2C7AFjD2dV9nGJdeoecVKNvV4e2ZOc6LvAOwmsq74FOflLBDXVRwNSou80DcvVEOo6womKiw+sTsYRpm37Ze8k85mZ/YVVWFSjn8M6FGwflHh+4MjIS4BLMlcrkFCmqT4jeQVZtfzdZiW+jsUFsBEqDAlZPnK+ihrlW7M9dRoy4Ogi+0Ky4uV/lco38WOI3vKCTCGPjnAKEFzboC+JjbAZAW9h5JfW+KDrEGau8kurcg/dRzCEpi/eKyLBbkcTvyLAujKd2kRNoNw0g== X-YMail-OSG: _KzitY0VM1mmWiK_R3O34IbrXRlopBcx0PW5MVpC7qJ6YIfoztt2qdhVzOOd6sr 7bEnFDvD3gGTTRTK6Ujo8wS44S_a6JQ1Ki4z2siJshyHUTW2YTNeWlhmBCVE1m5gb5vLBWKqKMqB uFBIAe1mLlsUHfW9Wq4V5jk43JzsJ0GpzsyMBbS2OJbu_C1CvEn3fBiS6huLYMgh.8XeRTZ3bS70 C5RtoHch41a6SnEKpS0ds90_3WgI7HFtSZEGYYZHqGnNQoag4Gxu1ejSXcO2ppcnhYEmY6YOOmf7 D8ELmWiThbWMtruSjWAKcuOOUjkMvun2eUWu.DWJygRfGfbSZmgeIROGYA2H9khWJzafj51et3Xk c.ij1prrIWmlHVCA3ep1HBwFL29PDIfW177fKmUOyBprHe6LwreHgYPgMK6_3LAs0s4_vpsWVmxw E.kCBXg59ON1zWSaPuCH07LeuiJS_EvBFdgJoPS.9qOC7ulDsvQDGsVPnkdj2nY7414DUuo7uDSZ cL4A0nVvXmQ2ul..H8gjXlSC8i6..xaxzGvoK_KkeAW.KQjDc51fZ4weDW.JPG2WyCCy22lnCxBi 0q8e.RZ75Z7jpyWNI4zFCKiVtCCyoPs.WDGuzwHh4E2UXt_XwnT0koEWA8_Z._eIIyEnGXxEMWAt h3h5iDqRqcQT.6zEtTWSNzSO2KAleKuNGKWmT.PE22jhdCDtJKpXEMh69Niji_xY8SwJrC2vDeLc bOYnc9WpPpvVlZWumYr2DBrYrPcqmNWAufn7Kp.SdMYdqomQc__D_F4cRPL4pKnN21RJSHbsFk6W oe9mmzO2jfB9grSp6FG9B_XGgZXR2cDkwjiKFXfizhf7MGUnk1lmGXqvzsdzHMVTd9xcgHdCNtgT uSrfSCuBzbQ9Uq0XQMrbULY4v5O7le9C4DCIQ0sDItLeE4ebkoV.vApCVhhCO4t9QDwH.F6zXPNj 3DRsgIElWcNWLMHWVTBQjp53zMnYUmTN0OI9wmtlqlyIgTp46xPNC4doHTBzKIXxixqT1l042m_X 8bEYDfvIwvKHa74bvFXfB14I8ZUUYxdLLOtqkNdXqGbT1pKKv.aGOiTgYXK1U13y0PN1fObhomu4 rolEJYAWvZXam6761346sDTo_vSsW7_4dNBCJXCB8T0axvwFk.jgq0Rv55kmF6LqPe2iybvXJb45 2cfAGgIwRFPN27nJA8ZWUT0_19gAQwBGYjgCC_Qlx68swVy1ghI24O7chkQNjFfUZPQaRm7LkSTS 8nws0gw.GGk..P8D8tmDHhsaibbtxjvxKCzktzUgtvLeHQKGMyXXhYXKNcatQ5MEUo232ZSP650b qgqMDYBqZg883f2akLDbK308TgrEfMEsAZZjE.8BfmsXPEkO_nRzi3nZGaPcJhy_.pj8B9ehzeOw Pj4vS0FEbilJi3eLibsjWfnmXeIw2bsaH3S.mJ9LsJMUsLfnNsO3Dve5iw8vdUOmS_KUhsBOwfB. jKh8atmzudKAV1QFZXd2vw__2O2P4Jx2K055H6v_2NKNgwHS61ryBnZ5yGMBSaFkD_XeUFItrlNL uVpaqRQhdYiwgRufOCCWKav5pqR6BLjEWIBhUyI4FyPhzaU8MSr5_kNB_e.aYBv6K8wEp8BdluMe 93pH.uvzEzUU.CvS.H.Q0UcWrys6U5UJgHfGCAYwOzCntyKRkzy1RjcSwJeGkCksEXNNOraFPtyB oohbEWyb.viDnK1d5GkU4_b15KrOLZti09n9kpuIX204ZchBXeBhB3d_G7vwEJ4mILYH5m1FLRrt x5GErWWVSHiLuPRIn7UbYG7Q3aqeEN0CcEIcCf_danHwI0GC6P7yoII0PYGNvgu2r08peUqpz.sQ 7N9Yvw6A0lwwMbRsss7nx5kXdK.Nns7_knqH.FaacMdxVXkAXKhjekHe8wUABElnaQcWGwH2YmWV EzORcwiqm0rRv05jUOt6RFE6PyT8g7O9layJ4cU64j3YCJT77PcgVox5CVKNTMW._9fK4aGmAjPU H8xJNaRCGJl1VjTw51A8P2xkIYja.GTgB9bf_TTE8A5mmBpYYcIqtln5d0ufkECSMFy5Lo6vd.1c sgGObdodFIfB66NddkCbGrRbO8zNoqO5PQN9kmmvNVawAuKMutG7vd0F7eSvgNL3aaPcOObPhmjc GXTH1ie6i6SWmLmuLs9Mcj.s5HioOEyYZnvE6XYccqImayzQOYl0ebpP_zGPG9dqhUdE0BJJTU_j gP_64STezHAkX7vIihs01tXK_XekGudJyFQE4Jy4tVNACN3vWSMZt3kIe_kKDNoc- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Wed, 22 Dec 2021 00:59:04 +0000 Received: by kubenode513.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 2956f24ef9c89e492bf3b0defaf4fd8d; Wed, 22 Dec 2021 00:59:00 +0000 (UTC) From: Po Lu To: dick Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> <8335mm1voq.fsf@gnu.org> <87mtkuy6d9.fsf@yahoo.com> <83zgouyx5h.fsf@gnu.org> <87czlqw3ob.fsf@yahoo.com> <87pmppg7up.fsf@dick> Date: Wed, 22 Dec 2021 08:58:56 +0800 In-Reply-To: <87pmppg7up.fsf@dick> (dick's message of "Tue, 21 Dec 2021 12:56:14 -0500") Message-ID: <87bl19v4j3.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 386 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676 Cc: 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) dick writes: > Your transposition of "up" and "down" in pixel-scroll-precision > contradicts the existing understanding of those two directions. Those directions are for scrolling based on text lines. In applications that scroll based on pixel lines, those two directions are correct. This was an intentional choice that I explained several times already. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 19:59:44 2021 Received: (at 52676) by debbugs.gnu.org; 22 Dec 2021 00:59:44 +0000 Received: from localhost ([127.0.0.1]:56248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzpyp-0007Le-8a for submit@debbugs.gnu.org; Tue, 21 Dec 2021 19:59:43 -0500 Received: from sonic304-22.consmr.mail.ne1.yahoo.com ([66.163.191.148]:42094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzpym-0007LM-Lr for 52676@debbugs.gnu.org; Tue, 21 Dec 2021 19:59:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640134774; bh=VXwR0W8c+Et/7glvInhRVPuul+E58RYPGIFdB4a9i5I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=EOT5qKPxWo+2nT29xwfkGm6yEwg8QPys2QQOiUZr9ZDp14gdPnSJCCyJVdwPcw2pyXHciZYVOqHHn3+ih7kXWCa3LYXqPcFAXq6uZ+yjy1lHDptBctgvld7CcV5urKjYGGbDibvFyRKNhf8Le8Ck33Si+Sj7+FQsL9XKGVvePQCMWoX6k9JFffUheIAlAiIf9PrM67lEHpdZS3CuNgyTzLs/wogp9VEjqYLSYsu4rgGHq+1Y6lSo2G2YcvLAAnvYHcjkG/B7KpEphKDbcGEPp6NzZptG57qsrpVu8nhFYDJ1qJ1UainKP01ky6GWfbNxH6pO0lXx75V68XKlt+GSxw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640134774; bh=hN+a3E4/owTFUcs5p3zLYZ0ziezU/cTYrcQRfWKnPtj=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=VmiEIctypxahqLoFl0RN86JTrqQ6fJcasjoQeFZk5UZC5Y9AQHnqL+yLJeg29mH1E2EpuMdhtoD+luxYnCgNlQBO9rEWOTUMUEIOVGM3GU+h1X4vTwDAUhxIs6qmW1dpAOBE5UyfqQhvSDXACS+DgNe+X+oo6paPiVSoAfcHSrXwiSShvGBY/4Il9+yFOTI/9Td5cx5LC45glh0Cixm3DE1OOuv9JZoz9n96WGN2n1vkypVRPHaiIKN3Rjshgt1Mc3FqPSQ7VyP3uDmdHsWnUeLh6U2usd6KbPdOzliuLdjyvgNXoSYBdlmlM0dQEkBEDmmeLW057G72QBCH21ipiQ== X-YMail-OSG: zleaI9gVM1mAkDqjZdbIryXMc99XnC66tPauDNmvidbOpED1wVwjnoj3EVjtt2t Qn.LXTi_.dsVOsQURoqgDglZFykrYWZGEEWZcOUF3BkWpz5gub0YK4NKS7pabehg__iO7in6LmkM FTDr7boxssEffUSbe.0MAQ.V3OQQJ2J42_gyVPrEJOota2.OfegGotWltdJfPSoy6aIxTYat5O4R JjNf986vsxc.0hBJihkhBWTM1TYhsDGx_mRPEFVl2TnregU3X6tZO3l.Vy5t17CPr8mRkIJfWJbR B2sh1dJ2sXkqkPK2_P8ueOGsTSJSKe1nBlHIPDw5Q96zVnLL9wtbkxU7czpshcy.tHQ0f4vvVIJN IppC0b58wubP1KICqr5SWF1emC8v.bQn0YyZw9inOpHiPQ0MEhD..ipYN3i80949ze2RJKivmyFr zY61Isnt5douwCtB1B8BYPP4VMGmpktui2gVN1GUKdvlZC73WQGq5TPOhdZ8xr0exdV9BjboMlbk E3gg5N5g05Y2ZXX2oj26Jzh0MLRo.NxoPALf_Rn_.hpzeWeXBsv79rRghwfNACAf8TpBO.fgGA9E jslgdJ0UR5dC5EdIIoy7jyjY6xE59TxGVl90cqQByhVba5UgwecIDkuoJ4tKFJHemn0V1LKTx6WI s2nhPZ0MEdgc9g9mN787u7F0XYT1NnDYPE1ds9v8citiGdpMQBd.aeAg3QGN6cK82RIvlOww7FxG kv560C9QJgLYKP8vRVInxZ0G2kYnib_lXQI3WLoeurcnGcmyeltt_2rsN0Vs3w9myVbHAK1v9R8z .EaYrgYN0STLxwyZn_b4ePAYzD1__GVxELtMdGJFVLOVbeAFUAXGL5PchYyWYL8vvFHAlOBfm.bh S68KBYHUfwLmP.yCrf8UJ70Qh5yDxuYoSvIupJEwTmyaWlSQofmXJBkQ5e1Wj5pBPcDfl.WbVUvF dtVqopFuneez3qS5IMAW6T_wkdsKrfH.F6uI8.O70HsjGirXLwsG97TTeTPWwMLIdY.gpYanmpQO HciHJMZOURY7FRfZY8NpD57mO9WFxUy9JEnqZnb4l1iLq5NNzY3zfdUQ0CpVjjSl_kWNF_GXbXHa c6dAHkmJZa.DT9ejwsDDuwU6_dQeljSIDI3XpuI_2dgEtq7.W3iLW_PoEdiEc_PjGEeihD4kx2Ab brUJh14Yoa0BEsXY61bquuRRzvjlZZB8VZBgYhVybc6t8M205Vg.uqCe.J2ciw9yyZ0LIiz.MoEz 91GVQ2Q3.Trv51wunHrKnx33MqLZA8uD_hwGtGbmLD0NlUNNziCHgGUmW2TFP8e6i8yIZ8flOvKs nLfediH4n6j5VLF1F3ShNwJK6Jf84EfG5Y1myjjpUXDtSTDFEs9OgcMzu2uo8hSnbxLTgxVA0R3E 8vd1Q0REuNRzOQf2vEHDXzE2BNwn_a9QRl5bLDMHL_QQgdlpU.2Rjsk3yBdFGOfsdiAi6Vi4XRQ9 56Z8EzXo84xgAj2mOq.2Z3ze7YMGcB6nnk6XjWfbRFOrdeqsNSDsm0.zvTczgGgpcnU8RQrH85dv YzhJPKRGfE_JCo8hW5kjeHtvT4KCmxown7vGDE6fRsoi2jtTsrXXIa9x5plSoypBC97Y8OPVWAzf 0DYBybMi9z8PglVQEeqt5mQDKKWG1Qj_AQNWOzY7i7uI_zmsHExa4Gp7C7Z.2.u_Ks6CdYuprHCO G.JcD0DdLjmaVw1zlfJkvAxy6qIUi3uLPxiJkp9wFQpnKhXmEY0p8a6vU0RRJ34MA_gj_73Cnpit 4QyBBPCLkZM0eaL_Z3efzJ5zX7MIrBa6C0K1XCnV6NfkwneWeiYw5hZ7XkIvuou_8u2aU32zbfpf msaPj_Y20bEH0G197VYfEwP.dVVkKp93vY33FU65HZvpfdVkzqm4p_GIaVdzYHV_NH4_VIU4S_wi F5mcyMyzx1UAXQY5Vnw.aRog.._mgmXVHZ8v8uudlo9IU.xn7MH7nG_uXri8S65BRKjypF1H9gUG dNVCzngnEk.ZgAFZSAzpzofNcAHyyQs99BYlrqnqRKrh2EzB3Y_UL34lhWBsj8dcV6eYUyPO3C_S HNYK2T5DxZYaHUgqQFrmFydkZ8rhRNnu5DDshUUD6urStJctA.msAyZFOy9v77_7eFIyuMSeo1EQ 9emP_ISPsn.Xb8d._VxbHVG373t81VB5dRV3a2wpVggWPjkDiu7RRw24VG9J7fPb2ngPbPUrxsSc Cg8NEA.0BQtkyymS63fZ526sxNek1VvrGnD0IE39ODB0GOSZLlQxIvqkAN1koMA-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Wed, 22 Dec 2021 00:59:34 +0000 Received: by kubenode512.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID e095afbb32df1834e23c64d071dd7ce4; Wed, 22 Dec 2021 00:59:31 +0000 (UTC) From: Po Lu To: Robert Pluim Subject: Re: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size References: <87wnk0xaz4.fsf@dick> <87h7b43qjb.fsf@yahoo.com> <87o85byhqg.fsf@dick> <83pmpr19ri.fsf@gnu.org> <87v8ziyc0n.fsf@yahoo.com> <8335mm1voq.fsf@gnu.org> <87mtkuy6d9.fsf@yahoo.com> <83zgouyx5h.fsf@gnu.org> <87czlqw3ob.fsf@yahoo.com> <87pmppg7up.fsf@dick> <87y24dygsg.fsf@gmail.com> Date: Wed, 22 Dec 2021 08:59:27 +0800 In-Reply-To: <87y24dygsg.fsf@gmail.com> (Robert Pluim's message of "Tue, 21 Dec 2021 19:05:51 +0100") Message-ID: <877dbxv4i8.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 175 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 52676 Cc: dick , 52676@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Eli, Lars, how close are we to banning this individual from the emacs > mailing lists? Because that would have my full support. +1 From unknown Mon Jun 16 23:54:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 Jan 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator