From unknown Fri Jun 20 18:19:22 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52670 <52670@debbugs.gnu.org> To: bug#52670 <52670@debbugs.gnu.org> Subject: Status: legacy base64 encoding of latin-1 Reply-To: bug#52670 <52670@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:19:22 +0000 retitle 52670 legacy base64 encoding of latin-1 reassign 52670 emacs submitter 52670 mattiase@acm.org severity 52670 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 16:47:39 2021 Received: (at submit) by debbugs.gnu.org; 19 Dec 2021 21:47:39 +0000 Received: from localhost ([127.0.0.1]:48387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz41r-0007t4-Da for submit@debbugs.gnu.org; Sun, 19 Dec 2021 16:47:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:42094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz41q-0007sv-4w for submit@debbugs.gnu.org; Sun, 19 Dec 2021 16:47:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mz41p-0001s9-U4 for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 16:47:37 -0500 Received: from mail1472c50.megamailservers.eu ([91.136.14.72]:44586 helo=mail102c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mz41n-0003VV-07 for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 16:47:37 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1639950438; bh=5IRwzk44AAS2faA1ZFiauzhIec9/cZ1OGvlO1CxAPzU=; h=From:Subject:Date:To:From; b=n6ubGsCFU80juDZanJl5Xdt1Dh9R+N5g/6Y6pAXRYfqAuH2DtYO1vZLMcTR6vSmVu rWsFc4fwWOgf/2fRjwmRZwID/03fF2vJ/HiFErEBFXE4iPXmaeWbKn+kgnAFsXGUqP MHoSyUB92lMjjiHLcjqt4PKHzxVa2QLDgYCWcLrs= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 1BJLlGJp003709 for ; Sun, 19 Dec 2021 21:47:17 +0000 From: mattiase@acm.org Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: legacy base64 encoding of latin-1 Message-Id: <7AAE6196-B9B9-4367-87EC-80DD6304CBCE@acm.org> Date: Sun, 19 Dec 2021 22:47:15 +0100 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F21.61BFA866.0007, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=Pr3w0yA3 c=1 sm=1 tr=0 ts=61bfa866 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=IkcTkHD0fZMA:10 a=mDntQ5YlRbmrT1kDOWQA:9 a=QEXdDO2ut3YA:10 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.72; envelope-from=mattiase@acm.org; helo=mail102c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) For what appears to be historical reasons, the base64 encoding functions = (base64-encode-string etc) treat characters in the range U+0080..U+00FF = as if they were raw bytes in the 127..255 range. This means that (base64-encode-string "=C3=BF") and (base64-encode-string "\xff") return the same result although the strings are completely different. = Attempts to encode other multibyte characters fail (correctly). For = example, (base64-encode-string "=C5=B8") signals an error, as expected. I propose we tighten up the behavior by eliminating the legacy handling = of characters in the U+0080..U+00FF range. Letting the bug stay in = place enables incorrect, brittle and error-prone usage: the functions = are clearly intended to be fed encoded text only and should signal an = error when not, as stated in the manual. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 12:26:28 2021 Received: (at 52670) by debbugs.gnu.org; 20 Dec 2021 17:26:28 +0000 Received: from localhost ([127.0.0.1]:51354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzMQe-0006tX-54 for submit@debbugs.gnu.org; Mon, 20 Dec 2021 12:26:28 -0500 Received: from mail212c50.megamailservers.eu ([91.136.10.222]:35602 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzMQb-0006tF-Hr for 52670@debbugs.gnu.org; Mon, 20 Dec 2021 12:26:27 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1640021178; bh=ns/gYIV14jBd5DiToo5drSJfHAQqAfm8IcYcZ9CP4Ng=; h=From:Subject:Date:To:From; b=UUbeS1HiFv5H21E7DAxd61EevZXaE62vbWm7PacD+xbEbiReGgK1JsQFYXrTxd/ws r9vW6bd+9D2IM/FstqI4FyMfl5RlGnFGLDSL7d2rcHO35JJOQZvVv35GTfnytmIX1d NpFP7Rsu9EtiF1vULH+PZdP/JxzMr9t7Vhbsf6IE= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 1BKHQFTe017287 for <52670@debbugs.gnu.org>; Mon, 20 Dec 2021 17:26:17 +0000 From: mattiase@acm.org Content-Type: multipart/mixed; boundary="Apple-Mail=_3350BD54-E5A1-4E1B-8A43-5A0451D8906C" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: [PATCH] legacy base64 encoding of latin-1 Message-Id: <8D4B415F-DC16-456C-AC7E-0D8CE538EB5D@acm.org> Date: Mon, 20 Dec 2021 18:26:15 +0100 To: 52670@debbugs.gnu.org X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F23.61C0BCBA.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=Dv41REz+ c=1 sm=1 tr=0 ts=61c0bcba a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=01rKV5jzBg74_vTQjmwA:9 a=CjuIK1q_8ugA:10 a=kyLEW_mjE0qwRmBch9YA:9 a=B2y7HmGcmWMA:10 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 52670 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_3350BD54-E5A1-4E1B-8A43-5A0451D8906C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii It really looks like the erroneous behaviour was an unintended effect of = commit 680d4b87f3d88a8b79f883cf3635036747588250. Anyway, here is a = patch. --Apple-Mail=_3350BD54-E5A1-4E1B-8A43-5A0451D8906C Content-Disposition: attachment; filename=0001-Fix-sloppy-base64-acceptance-of-some-multibyte-chara.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-sloppy-base64-acceptance-of-some-multibyte-chara.patch" Content-Transfer-Encoding: quoted-printable =46rom=20c979c063a96711b8dea018e7486b05a5a192bfd2=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=2020=20Dec=202021=2018:17:23=20+0100=0A= Subject:=20[PATCH]=20Fix=20sloppy=20base64=20acceptance=20of=20some=20= multibyte=20characters=0A=0AThe=20base64=20encoding=20functions=20= incorrectly=20accepted=20some=20multibyte=0Acharacters;=20stop=20doing=20= that=20(bug#52670).=0A=0A*=20src/fns.c=20(base64_encode_1):=20Reject=20= all=20multibyte=20characters.=0A*=20test/src/fns-tests.el=20= (fns-tests-base64-encode-string)=0A(fns-test-base64url-encode-region)=0A= (fns-test-base64url-encode-string):=20Add=20tests.=0A*=20= doc/lispref/text.texi=20(Base=2064):=20Rephrase=20outdated=20manual=20= text.=0A---=0A=20doc/lispref/text.texi=20|=20=205=20++---=0A=20src/fns.c=20= =20=20=20=20=20=20=20=20=20=20=20=20|=20=206=20+++---=0A=20= test/src/fns-tests.el=20|=2016=20+++++++++++++---=0A=203=20files=20= changed,=2018=20insertions(+),=209=20deletions(-)=0A=0Adiff=20--git=20= a/doc/lispref/text.texi=20b/doc/lispref/text.texi=0Aindex=20= 5ab5e5715f..9771d8a7ed=20100644=0A---=20a/doc/lispref/text.texi=0A+++=20= b/doc/lispref/text.texi=0A@@=20-4793,9=20+4793,8=20@@=20Base=2064=0A=20= This=20function=20converts=20the=20region=20from=20@var{beg}=20to=20= @var{end}=20into=20base=0A=2064=20code.=20=20It=20returns=20the=20length=20= of=20the=20encoded=20text.=20=20An=20error=20is=0A=20signaled=20if=20a=20= character=20in=20the=20region=20is=20multibyte,=20i.e.,=20in=20a=0A= -multibyte=20buffer=20the=20region=20must=20contain=20only=20characters=20= from=20the=0A-charsets=20@code{ascii},=20@code{eight-bit-control}=20and=0A= -@code{eight-bit-graphic}.=0A+multibyte=20buffer=20the=20region=20must=20= contain=20only=20ASCII=20characters=20or=20raw=0A+bytes.=0A=20=0A=20= Normally,=20this=20function=20inserts=20newline=20characters=20into=20= the=20encoded=0A=20text,=20to=20avoid=20overlong=20lines.=20=20However,=20= if=20the=20optional=20argument=0Adiff=20--git=20a/src/fns.c=20= b/src/fns.c=0Aindex=2076c76c92ba..23721334f7=20100644=0A---=20= a/src/fns.c=0A+++=20b/src/fns.c=0A@@=20-3653,7=20+3653,7=20@@=20= base64_encode_1=20(const=20char=20*from,=20char=20*to,=20ptrdiff_t=20= length,=0A=20=09=20=20c=20=3D=20string_char_and_length=20((unsigned=20= char=20*)=20from=20+=20i,=20&bytes);=0A=20=09=20=20if=20(CHAR_BYTE8_P=20= (c))=0A=20=09=20=20=20=20c=20=3D=20CHAR_TO_BYTE8=20(c);=0A-=09=20=20else=20= if=20(c=20>=3D=20256)=0A+=09=20=20else=20if=20(c=20>=3D=20128)=0A=20=09=20= =20=20=20return=20-1;=0A=20=09=20=20i=20+=3D=20bytes;=0A=20=09}=0A@@=20= -3696,7=20+3696,7=20@@=20base64_encode_1=20(const=20char=20*from,=20char=20= *to,=20ptrdiff_t=20length,=0A=20=09=20=20c=20=3D=20= string_char_and_length=20((unsigned=20char=20*)=20from=20+=20i,=20= &bytes);=0A=20=09=20=20if=20(CHAR_BYTE8_P=20(c))=0A=20=09=20=20=20=20c=20= =3D=20CHAR_TO_BYTE8=20(c);=0A-=09=20=20else=20if=20(c=20>=3D=20256)=0A+=09= =20=20else=20if=20(c=20>=3D=20128)=0A=20=09=20=20=20=20return=20-1;=0A=20= =09=20=20i=20+=3D=20bytes;=0A=20=09}=0A@@=20-3721,7=20+3721,7=20@@=20= base64_encode_1=20(const=20char=20*from,=20char=20*to,=20ptrdiff_t=20= length,=0A=20=09=20=20c=20=3D=20string_char_and_length=20((unsigned=20= char=20*)=20from=20+=20i,=20&bytes);=0A=20=09=20=20if=20(CHAR_BYTE8_P=20= (c))=0A=20=09=20=20=20=20c=20=3D=20CHAR_TO_BYTE8=20(c);=0A-=09=20=20else=20= if=20(c=20>=3D=20256)=0A+=09=20=20else=20if=20(c=20>=3D=20128)=0A=20=09=20= =20=20=20return=20-1;=0A=20=09=20=20i=20+=3D=20bytes;=0A=20=09}=0Adiff=20= --git=20a/test/src/fns-tests.el=20b/test/src/fns-tests.el=0Aindex=20= bec5c03f9e..63423f622f=20100644=0A---=20a/test/src/fns-tests.el=0A+++=20= b/test/src/fns-tests.el=0A@@=20-318,7=20+318,10=20@@=20= fns-tests-base64-encode-string=0A=20=20=20(should=20(equal=20= (base64-encode-string=20"fooba")=20"Zm9vYmE=3D"))=0A=20=20=20(should=20= (equal=20(base64-encode-string=20"foobar")=20"Zm9vYmFy"))=0A=20=20=20= (should=20(equal=20(base64-encode-string=20"\x14\xfb\x9c\x03\xd9\x7e")=20= "FPucA9l+"))=0A-=20=20(should=20(equal=20(base64-encode-string=20= "\x14\xfb\x9c\x03\xd9\x7f")=20"FPucA9l/")))=0A+=20=20(should=20(equal=20= (base64-encode-string=20"\x14\xfb\x9c\x03\xd9\x7f")=20"FPucA9l/"))=0A+=0A= +=20=20(should-error=20(base64-encode-string=20"=C6=92"))=0A+=20=20= (should-error=20(base64-encode-string=20"=C3=BC")))=0A=20=0A=20= (ert-deftest=20fns-test-base64url-encode-region=20()=0A=20=20=20;;=20url=20= variant=20with=20padding=0A@@=20-360,7=20+363,11=20@@=20= fns-test-base64url-encode-region=0A=20=20=20(should=20(equal=20= (fns-tests--with-region=20base64url-encode-region=20= (fns-tests--string-repeat=20"\x14\xfb\x9c\x03\xd9\x7e"=2010)=20t)=0A=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (fns-tests--string-repeat=20"FPucA9l-"=2010)))=0A=20=20=20(should=20= (equal=20(fns-tests--with-region=20base64url-encode-region=20= (fns-tests--string-repeat=20"\x14\xfb\x9c\x03\xd9\x7f"=2010)=20t)=0A-=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(fns-tests--string-repeat=20= "FPucA9l_"=2010))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (fns-tests--string-repeat=20"FPucA9l_"=2010)))=0A+=0A+=20=20= (should-error=20(fns-tests--with-region=20base64url-encode-region=20= "=C6=92"))=0A+=20=20(should-error=20(fns-tests--with-region=20= base64url-encode-region=20"=C3=BC")))=0A+=0A=20=0A=20(ert-deftest=20= fns-test-base64url-encode-string=20()=0A=20=20=20;;=20url=20variant=20= with=20padding=0A@@=20-394,7=20+401,10=20@@=20= fns-test-base64url-encode-string=0A=20=20=20(should=20(equal=20= (base64url-encode-string=20(fns-tests--string-repeat=20"fooba"=2015)=20= t)=20(fns-tests--string-repeat=20"Zm9vYmFmb29iYWZvb2Jh"=205)))=0A=20=20=20= (should=20(equal=20(base64url-encode-string=20(fns-tests--string-repeat=20= "foobar"=2015)=20t)=20(concat=20(fns-tests--string-repeat=20= "Zm9vYmFyZm9vYmFy"=207)=20"Zm9vYmFy")))=0A=20=20=20(should=20(equal=20= (base64url-encode-string=20(fns-tests--string-repeat=20= "\x14\xfb\x9c\x03\xd9\x7e"=2010)=20t)=20(fns-tests--string-repeat=20= "FPucA9l-"=2010)))=0A-=20=20(should=20(equal=20(base64url-encode-string=20= (fns-tests--string-repeat=20"\x14\xfb\x9c\x03\xd9\x7f"=2010)=20t)=20= (fns-tests--string-repeat=20"FPucA9l_"=2010))))=0A+=20=20(should=20= (equal=20(base64url-encode-string=20(fns-tests--string-repeat=20= "\x14\xfb\x9c\x03\xd9\x7f"=2010)=20t)=20(fns-tests--string-repeat=20= "FPucA9l_"=2010)))=0A+=0A+=20=20(should-error=20(base64url-encode-string=20= "=C6=92"))=0A+=20=20(should-error=20(base64url-encode-string=20"=C3=BC")))= =0A=20=0A=20(ert-deftest=20fns-tests-base64-decode-string=20()=0A=20=20=20= ;;=20standard=20variant=20RFC2045=0A--=20=0A2.32.0=20(Apple=20Git-132)=0A= =0A= --Apple-Mail=_3350BD54-E5A1-4E1B-8A43-5A0451D8906C-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 14:11:20 2021 Received: (at 52670) by debbugs.gnu.org; 20 Dec 2021 19:11:20 +0000 Received: from localhost ([127.0.0.1]:51468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzO46-0001Jv-Nv for submit@debbugs.gnu.org; Mon, 20 Dec 2021 14:11:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzO40-0001Jc-Ol for 52670@debbugs.gnu.org; Mon, 20 Dec 2021 14:11:17 -0500 Received: from [2001:470:142:3::e] (port=50726 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzO3s-0007sj-27; Mon, 20 Dec 2021 14:11:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4Bo0KYr39LrHnptw2XEeIHnP5ejYAAPauqg9PWKVl10=; b=bRHRMgJDDUia OzDAQQpVl4RJLEixcZ3TWeFElqXx1mN+9ge7ETZMnWeaN97umn9yaNHAQ+EFAdS83UT3tW8D6fDVk sDLPqhkt0Ow2xmpIHya15SePccmALudfFsVLz9P3DW6YNVC054O9hdtvm4KEZd+zDycqbpFloEwRA iVB7qqbmgzo9KMOj8fvwZnq1fMMQqq9KKMSM9HKo3YJPJlK3UADpG5rk/HzPDXwCLj7UvEzS7CjYF +yvlSCMOw9tnv5HEMH3ht6310sq2WVWa6rZuT28l+rhfaXQeik53jCiUKMbDmMqk+BaFFuhaPMpFD D6gPCaR8SGmvjbEPKQw8Qw==; Received: from [87.69.77.57] (port=1639 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzO3o-0000it-M3; Mon, 20 Dec 2021 14:11:03 -0500 Date: Mon, 20 Dec 2021 21:10:56 +0200 Message-Id: <83h7b3148v.fsf@gnu.org> From: Eli Zaretskii To: mattiase@acm.org In-Reply-To: <8D4B415F-DC16-456C-AC7E-0D8CE538EB5D@acm.org> (mattiase@acm.org) Subject: Re: bug#52670: [PATCH] legacy base64 encoding of latin-1 References: <7AAE6196-B9B9-4367-87EC-80DD6304CBCE@acm.org> <8D4B415F-DC16-456C-AC7E-0D8CE538EB5D@acm.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52670 Cc: 52670@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: mattiase@acm.org > Date: Mon, 20 Dec 2021 18:26:15 +0100 > > It really looks like the erroneous behaviour was an unintended effect of commit 680d4b87f3d88a8b79f883cf3635036747588250. I think that patch was correct at the time it was done, but it wasn't undone/fixed when we switched to Unicode. > Anyway, here is a patch. Thanks, but this should at the very least be announced as an incompatible Lisp change in NEWS. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 14:24:30 2021 Received: (at 52670-done) by debbugs.gnu.org; 20 Dec 2021 19:24:30 +0000 Received: from localhost ([127.0.0.1]:51484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzOGr-0001fG-VB for submit@debbugs.gnu.org; Mon, 20 Dec 2021 14:24:30 -0500 Received: from mail229c50.megamailservers.eu ([91.136.10.239]:36952 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzOGp-0001f4-AM for 52670-done@debbugs.gnu.org; Mon, 20 Dec 2021 14:24:28 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1640028264; bh=SBoY+aVHtkvpXcSdEORGbBTmiAfatOXFsaSknie8op0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Vpvl08456cDXb9EY+bO6VvezN8Ym0Je+IxPzecrIE5I9Y2jLiaUXLBACQB7GIYPCO FZGXH/7cFZXoBRva/IE/vj8KWGF/49M0jDOAX2s71bYy6isJyRnAa1fTJ+Z6GpRp1w R6lvAqXbosHHkuV979Cy55hEDtvChH74dEwP7BFE= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 1BKJOMx4021170; Mon, 20 Dec 2021 19:24:23 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#52670: [PATCH] legacy base64 encoding of latin-1 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83h7b3148v.fsf@gnu.org> Date: Mon, 20 Dec 2021 20:24:21 +0100 Content-Transfer-Encoding: 7bit Message-Id: References: <7AAE6196-B9B9-4367-87EC-80DD6304CBCE@acm.org> <8D4B415F-DC16-456C-AC7E-0D8CE538EB5D@acm.org> <83h7b3148v.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F1F.61C0D868.0090, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=d7GWdTvE c=1 sm=1 tr=0 ts=61c0d868 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=ftTPA6ZTyh6tP0uGyGYA:9 a=CjuIK1q_8ugA:10 a=ncZ9vwaUYPMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 20 dec. 2021 kl. 20:10 skrev Eli Zaretskii : > Thanks, but this should at the very least be announced as an > incompatible Lisp change in NEWS. Right, I added a detailed notice. Thanks for taking a look! Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 52670-done Cc: 52670-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 20 dec. 2021 kl. 20:10 skrev Eli Zaretskii : > Thanks, but this should at the very least be announced as an > incompatible Lisp change in NEWS. Right, I added a detailed notice. Thanks for taking a look! Pushed; closing. From unknown Fri Jun 20 18:19:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 Jan 2022 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator