GNU bug report logs - #52660
[PATCH] gnu: Enable babeltrace Python's bindings.

Previous Next

Package: guix-patches;

Reported by: Olivier Dion <olivier.dion <at> polymtl.ca>

Date: Sun, 19 Dec 2021 19:21:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#52660: closed ([PATCH] gnu: Enable babeltrace Python's bindings.)
Date: Wed, 22 Dec 2021 08:26:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 22 Dec 2021 09:24:53 +0100
with message-id <87ilvhqc6i.fsf <at> gnu.org>
and subject line Re: bug#52660: [PATCH] gnu: Enable babeltrace Python's bindings.
has caused the debbugs.gnu.org bug report #52660,
regarding [PATCH] gnu: Enable babeltrace Python's bindings.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
52660: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52660
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Olivier Dion <olivier.dion <at> polymtl.ca>
To: guix-patches <at> gnu.org
Cc: Olivier Dion <olivier.dion <at> polymtl.ca>
Subject: [PATCH] gnu: Enable babeltrace Python's bindings.
Date: Sun, 19 Dec 2021 14:19:52 -0500
* gnu/packages/instrumentation.scm (babeltrace)
[tests?]: Set to false.
[configure-flags]: Enable Python's plugins and bindings.
[make-flags]: Add output's /lib to linker rpath.
---
 gnu/packages/instrumentation.scm | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/instrumentation.scm b/gnu/packages/instrumentation.scm
index 564547324c..4b2fe4095a 100644
--- a/gnu/packages/instrumentation.scm
+++ b/gnu/packages/instrumentation.scm
@@ -32,6 +32,7 @@ (define-module (gnu packages instrumentation)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages popt)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages swig)
   #:use-module (gnu packages tbb)
@@ -57,19 +58,23 @@ (define-public babeltrace
     (build-system gnu-build-system)
 
     (arguments
-     `(;; FIXME - When Python's bindings are enabled, tests do not pass.
-       #:configure-flags '("--enable-debug-info"
-                           "--enable-man-pages"
-                           "--disable-python-bindings"
-                           "--disable-python-plugins")
-                         #:phases
-                         (modify-phases %standard-phases
-                           ;; These are recommended in the project's README for a development
-                           ;; build configuration.
-                           (add-before 'configure 'set-environment-variables
-                             (lambda _
-                               (setenv "BABELTRACE_DEV_MODE" "1")
-                               (setenv "BABELTRACE_MINIMAL_LOG_LEVEL" "TRACE"))))))
+     `(#:tests? #f  ; FIXME - When Python's bindings are enabled, tests do not pass.
+       #:make-flags
+       (list (string-append "LDFLAGS=-Wl,-rpath="
+                            (assoc-ref %outputs "out") "/lib"))
+       #:configure-flags
+       '("--enable-debug-info"
+         "--enable-man-pages"
+         "--enable-python-bindings"
+         "--enable-python-plugins")
+       #:phases
+       (modify-phases %standard-phases
+         ;; These are recommended in the project's README for a development
+         ;; build configuration.
+         (add-before 'configure 'set-environment-variables
+           (lambda _
+             (setenv "BABELTRACE_DEV_MODE" "1")
+             (setenv "BABELTRACE_MINIMAL_LOG_LEVEL" "TRACE"))))))
     (inputs
      (list glib))
     ;; NOTE - elfutils is used for the LTTng debug information filter
-- 
2.34.0



[Message part 3 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Olivier Dion <olivier.dion <at> polymtl.ca>
Cc: 52660-done <at> debbugs.gnu.org
Subject: Re: bug#52660: [PATCH] gnu: Enable babeltrace Python's bindings.
Date: Wed, 22 Dec 2021 09:24:53 +0100
Hello Olivier,

> * gnu/packages/instrumentation.scm (babeltrace)
> [tests?]: Set to false.
> [configure-flags]: Enable Python's plugins and bindings.
> [make-flags]: Add output's /lib to linker rpath.

I gexpified it before pushing!

Thanks,

Mathieu


This bug report was last modified 3 years and 155 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.