Subject: bug#52605: [PATCH] Add isearch-emoji-by-name

From: Eli Zaretskii <[email-masked]>
Date: Sat, 18 Dec 2021 21:07:38 +0200

> Date: Sat, 18 Dec 2021 19:55:02 +0100
> From:  Daniel Martín via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <[email-masked]>
> 
> This patch adds support for searching a buffer for Emojis without
> needing to copy and paste them from another buffer or leaving isearch.
> Isearch already provides some methods to search for non-ASCII
> characters, so I decided to extend the package to search for Emoji as
> well.
> 
> With this patch, during an incremental search, if you press 'C-x 8 e
> RET', it will ask you for an Emoji character by name and insert it into
> the search string.  A prefix argument N will insert N copies of the
> character.

Thanks.

> +@item
> +@findex isearch-emoji-by-name
> +@kindex C-x 8 e RET @r{(Incremental Search)}
> +Type @kbd{C-x 8 e @key{RET}} (@code{isearch-emoji-by-name}), followed
> +by the name of an Emoji.  This adds the specified Emoji into the
> +search string.

This should explain what kind of "emoji names" the feature accepts.
It is entirely unclear from the text.

> +*** New command 'isearch-emoji-by-name'.
> +It is bound to 'C-x 8 e RET' during an incremental search and it
> +inserts an Emoji character into the search string.

Likewise here.  The NEWS entry doesn't even mention that Emoji are
specified by their names.

> +(defun isearch-emoji-by-name (&optional count)
> +  "Read an Emoji and add it to the search string.

  "Read and Emoji name and add it to the search string."

Likewise here, the doc string should clarify what kind of names are
acceptable.  I would also mention that completion is provided while
typing the name.