From unknown Tue Sep 23 12:56:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#52603 <52603@debbugs.gnu.org> To: bug#52603 <52603@debbugs.gnu.org> Subject: Status: [PATCH 0/2] Flag missing netmasks early on Reply-To: bug#52603 <52603@debbugs.gnu.org> Date: Tue, 23 Sep 2025 19:56:08 +0000 retitle 52603 [PATCH 0/2] Flag missing netmasks early on reassign 52603 guix-patches submitter 52603 Ludovic Court=C3=A8s severity 52603 normal tag 52603 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 12:03:04 2021 Received: (at submit) by debbugs.gnu.org; 18 Dec 2021 17:03:05 +0000 Received: from localhost ([127.0.0.1]:43691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd6u-0004yf-Mf for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:03:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:45578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd6s-0004yX-77 for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:03:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myd6r-0006gF-Sj for guix-patches@gnu.org; Sat, 18 Dec 2021 12:03:01 -0500 Received: from [2001:470:142:3::e] (port=59050 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myd6T-0007ag-8W; Sat, 18 Dec 2021 12:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=ddQqe/BJPC/lenFRW87w8wACN8srkPjrmbqzPz+1o94=; b=lkTeoUbzbqudXS kYsDzPwFNPFiD1Zh3LcXaMcZp+A8tHK74vl3rNngWc+T5fKAnDuIUHcIUddLjw0CRXJfgmhHgcLjQ TO0S3iiEKEfbypXBTYfuhaHtQVY+CS6U6f6QZeFtKZJazaNU2LHArHAhZqHuoLfXd+Mwhcrr4EA4x JLf5rLRTh2dDY2XwXR3JhxZZXxjsuVYHxnRc6EX0KNjQjRm5N0bAAxEbWHGQUovcckUmOTNCvXH8z KDXQ47K2EjiNPIaRc+6z1Qks5g0NOinfzr8UbYJypBUsUo6InlqX4zxKP3um3W8rrI4L3H8UF1m6k HFR3XT+dzQDIrJ3tAHsQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:61383 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myd6T-0007lf-8A; Sat, 18 Dec 2021 12:02:37 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/2] Flag missing netmasks early on Date: Sat, 18 Dec 2021 18:02:27 +0100 Message-Id: <20211218170227.19999-1-ludo@gnu.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! As discussed yesterday on IRC, I mistakenly configured a machine with something like: (network-address (device "eno1") (value "1.2.3.4")) This results in having a “/0” subnet, thereby preventing the addition of a route without a clear diagnostic from Guile-Netlink or ‘ip’. To avoid this, this patch flags it at expansion time (if possible) or at run time, before the machine configuration is built. Did I go overboard with ‘define-compile-time-procedure’? I don’t think so :-), I think it will serve us more than once. Thoughts? Ludo’. Ludovic Courtès (2): combinators: Add 'define-compile-time-procedure'. services: static-networking: Sanitize values. gnu/services/base.scm | 28 ++++++++++++++++++++++-- guix/combinators.scm | 50 +++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 74 insertions(+), 4 deletions(-) base-commit: 4204156eb4c1afd5365ef505e356f87daa91787d -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 12:10:57 2021 Received: (at 52603) by debbugs.gnu.org; 18 Dec 2021 17:10:57 +0000 Received: from localhost ([127.0.0.1]:43712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydEX-0005Ak-D0 for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:10:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydEV-0005AO-EZ for 52603@debbugs.gnu.org; Sat, 18 Dec 2021 12:10:56 -0500 Received: from [2001:470:142:3::e] (port=59256 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mydEQ-0000Fx-8E; Sat, 18 Dec 2021 12:10:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=sZPtlVu7O9kWRcWDKdsLxqBQTJwfevg1mscj9qDhRMY=; b=Ni7pyCQaJPlmPd JWNkHS5GWsUcZUDFOyKe3q7aDa2Q6fk0w0bpc+uT2JwFP/JI7zwGuH/YpRlcCTaeMAY4a7bo7Afa7 pFXVaGZAvpBRKrWzFc74qsXWXNFsq8PXbG2uk/Jq2J3yz6QpBo7xOf7R3WaLvGsbadGO5f8yOx6aI GLkZXEqMEJikVWXo4qCrf6TPayuLBLWGBvE264lkLoDJfh9djB0pPVOTXQrVxHhuFtqs2FqnNFQiT epEhxfI+gYerK/+BFhGHs77kiYVjNDohBbyFVyQAFInwZlbXKYIOym8WD25WGFStk24s/HThU3TLX eSxyiHj63jS/F+vyky8g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:51822 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mydEQ-0007OB-4q; Sat, 18 Dec 2021 12:10:50 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 52603@debbugs.gnu.org Subject: [PATCH 1/2] combinators: Add 'define-compile-time-procedure'. Date: Sat, 18 Dec 2021 18:10:39 +0100 Message-Id: <20211218171040.20268-1-ludo@gnu.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52603 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/combinators.scm (procedure-call-location): New syntax parameter. (define-compile-time-procedure): New macro. --- guix/combinators.scm | 50 ++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/guix/combinators.scm b/guix/combinators.scm index 88ad09dbe6..261d6bb57e 100644 --- a/guix/combinators.scm +++ b/guix/combinators.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès +;;; Copyright © 2012-2017, 2021 Ludovic Courtès ;;; Copyright © 2014 Eric Bavier ;;; Copyright © 2020 Arun Isaac ;;; @@ -24,7 +24,9 @@ (define-module (guix combinators) #:export (fold2 fold-tree fold-tree-leaves - compile-time-value)) + compile-time-value + procedure-call-location + define-compile-time-procedure)) ;;; Commentary: ;;; @@ -100,4 +102,48 @@ (define-syntax compile-time-value ;not quite at home (_ #`'#,(datum->syntax s val))))))) v)))) +(define-syntax-parameter procedure-call-location + (lambda (s) + (syntax-violation 'procedure-call-location + "'procedure-call-location' may only be used \ +within 'define-compile-time-procedure'" + s))) + +(define-syntax-rule (define-compile-time-procedure (proc (arg pred) ...) + body ...) + "Define PROC as a macro such that, if every actual argument in a \"call\" +matches PRED, then BODY is evaluated at macro-expansion time. BODY must +return a single value in a type that has read syntax--e.g., numbers, strings, +lists, etc. + +BODY can refer to 'procedure-call-location', which is bound to a source +property alist corresponding to the call site. + +This macro is meant to be used primarily for small procedures that validate or +process its arguments in a way that may be equally well performed at +macro-expansion time." + (define-syntax proc + (lambda (s) + (define loc + #`(identifier-syntax + '#,(datum->syntax #'s (syntax-source s)))) + + (syntax-case s () + ((_ arg ...) + (and (pred (syntax->datum #'arg)) ...) + (let ((arg (syntax->datum #'arg)) ...) + (syntax-parameterize ((procedure-call-location + (identifier-syntax (syntax-source s)))) + body ...))) + ((_ actual (... ...)) + #`((lambda (arg ...) + (syntax-parameterize ((procedure-call-location #,loc)) + body ...)) + actual (... ...))) + (id + (identifier? #'id) + #`(lambda (arg ...) + (syntax-parameterize ((procedure-call-location #,loc)) + body ...))))))) + ;;; combinators.scm ends here -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 18 12:11:00 2021 Received: (at 52603) by debbugs.gnu.org; 18 Dec 2021 17:11:00 +0000 Received: from localhost ([127.0.0.1]:43714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydEZ-0005At-O2 for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:11:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydEW-0005AQ-J2 for 52603@debbugs.gnu.org; Sat, 18 Dec 2021 12:10:56 -0500 Received: from [2001:470:142:3::e] (port=59258 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mydER-0000G4-E0; Sat, 18 Dec 2021 12:10:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=WlH2OKxELK+nlVYdV+ZepBgfo/88NxY8B+bHKGcvdcE=; b=kV4Ns5J5qCrXnqD8JtYg U7keJiTYhGPP2zHoR/wkW319HyuTGKP+AMbUTdSi7KPYaqGw4CFLXA2yKMM+JT6zhyHobR3A0E361 W51ivYD+H6EyEBpFgu3e8IivrZatVha+qXBoMzvqWlakh8749oTFT0M2ru8vsGZAB1KUm/5IyiYzq YSe6/V2xvXbq/k0nnYIttpz1KMSNWPgivtLkZmCRdVqgFmjGXxTe3b+jy10xZKIlPnQDpCSyKJFws HsjXWiQQQFy0xWYGtIu1LQHh9Z4e/wOM0tGpIcUllDc5agqvsoMBuQYKTJ5PxKt4QDtVw5ID9uqCu OSXWZxwPG/AQ9w==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:51822 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mydER-0007OB-Be; Sat, 18 Dec 2021 12:10:51 -0500 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: 52603@debbugs.gnu.org Subject: [PATCH 2/2] services: static-networking: Sanitize values. Date: Sat, 18 Dec 2021 18:10:40 +0100 Message-Id: <20211218171040.20268-2-ludo@gnu.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211218171040.20268-1-ludo@gnu.org> References: <20211218171040.20268-1-ludo@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52603 Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This makes sure users do not mistakenly configuring a network with "/0" as its netmask. * gnu/services/base.scm (assert-valid-address): New procedure. ()[value]: Add it as 'sanitize'. --- gnu/services/base.scm | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 5f93483dda..49ec856de4 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -35,8 +35,9 @@ (define-module (gnu services base) #:use-module (guix store) #:use-module (guix deprecation) - #:autoload (guix diagnostics) (warning) + #:autoload (guix diagnostics) (warning &fix-hint) #:autoload (guix i18n) (G_) + #:use-module (guix combinators) #:use-module (gnu services) #:use-module (gnu services admin) #:use-module (gnu services shepherd) @@ -72,6 +73,8 @@ (define-module (gnu services base) #:use-module (guix i18n) #:use-module (srfi srfi-1) #:use-module (srfi srfi-26) + #:use-module (srfi srfi-34) + #:use-module (srfi srfi-35) #:use-module (ice-9 match) #:use-module (ice-9 format) #:re-export (user-processes-service-type ;backwards compatibility @@ -2388,6 +2391,26 @@ (define (ipv6-address? str) "Return true if STR denotes an IPv6 address." (false-if-exception (->bool (inet-pton AF_INET6 str)))) +(define-compile-time-procedure (assert-valid-address (address string?)) + "Ensure ADDRESS has a valid netmask." + (unless (or (cidr->netmask address) + (and=> (false-if-exception (inet-pton AF_INET address)) + (cut = INADDR_LOOPBACK <>)) + (and=> (false-if-exception (inet-pton AF_INET6 address)) + (cut = 1 <>))) + (raise + (make-compound-condition + (formatted-message (G_ "address '~a' lacks a network mask") + address) + (condition (&error-location + (location + (source-properties->location procedure-call-location)))) + (condition (&fix-hint + (hint (format #f (G_ "\ +Write, say, @samp{\"~a/24\"} for a 24-bit network mask.") + address))))))) + address) + (define-record-type* static-networking make-static-networking static-networking? @@ -2405,7 +2428,8 @@ (define-record-type* network-address make-network-address network-address? (device network-address-device) ;string--e.g., "en01" - (value network-address-value) ;string--CIDR notation + (value network-address-value ;string--CIDR notation + (sanitize assert-valid-address)) (ipv6? network-address-ipv6? ;Boolean (thunked) (default -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 04:13:58 2021 Received: (at 52603) by debbugs.gnu.org; 19 Dec 2021 09:13:58 +0000 Received: from localhost ([127.0.0.1]:44784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mysGU-0000Xs-9H for submit@debbugs.gnu.org; Sun, 19 Dec 2021 04:13:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mysGR-0000Xc-Vh for 52603@debbugs.gnu.org; Sun, 19 Dec 2021 04:13:56 -0500 Received: from [2001:470:142:3::e] (port=56338 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mysGM-0003lU-M2; Sun, 19 Dec 2021 04:13:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=fe+z2L8kAtbus57EDA9gVBDeAkYkS613H8jPdzRQSo4=; b=d7nKRnnWhoBT2ZcRG3L1 dMjB/c9c1G/1nuI5pY+bHUdwczG82klIfL9FmPUUw7ddVa1FmsB41Ji4yXG4tRQ3o4+wC+n4UstPt HfLTbmYmM8D8kaCt6iFsbJ1fZFQ4lHSKY3GyA1o0SrgyOs8ntP3jTcaI+zAZtNC4SPep1mrgRIu17 bwWLH9jf1it94iIgqaMe3QYJNE6XJOIWmyxceUPcuRGmM8lyVnD9qD18IiuiIEyJtcUDiA0T3xHxH i9AlmtX6gIf3oS+BU4eos/RCQ5k0arD0566O88EE4MizxyAgWskMaXANdOwhV13J5GcdT8UU/rcLE c/+D0VVoSFHSkQ==; Received: from [2a01:e0a:19b:d9a0:45b5:a14a:5c75:5737] (port=54122 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mysGL-0005ah-Og; Sun, 19 Dec 2021 04:13:50 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#52603: [PATCH 0/2] Flag missing netmasks early on References: <20211218170227.19999-1-ludo@gnu.org> Date: Sun, 19 Dec 2021 10:13:47 +0100 In-Reply-To: <20211218170227.19999-1-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Sat, 18 Dec 2021 18:02:27 +0100") Message-ID: <87fsqpt0s4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52603 Cc: 52603@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Ludo, > To avoid this, this patch flags it at expansion time (if possible) or > at run time, before the machine configuration is built. > > Did I go overboard with =E2=80=98define-compile-time-procedure=E2=80=99? = I don=E2=80=99t think > so :-), I think it will serve us more than once. I tested this series, works fine! It is still possible to pass incorrect netmasks (negative, > 32 for IPv4), but they should be way less frequent than forgetting to add a netmask. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 10:28:18 2021 Received: (at 52603-done) by debbugs.gnu.org; 20 Dec 2021 15:28:18 +0000 Received: from localhost ([127.0.0.1]:51146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzKaI-0003Oq-6W for submit@debbugs.gnu.org; Mon, 20 Dec 2021 10:28:18 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:41918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzKaE-0003ON-67 for 52603-done@debbugs.gnu.org; Mon, 20 Dec 2021 10:28:17 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DA8C51DF; Mon, 20 Dec 2021 16:28:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5987Pn-arSfr; Mon, 20 Dec 2021 16:28:07 +0100 (CET) Received: from ribbon (unknown [IPv6:2001:660:6102:320:e120:2c8f:8909:cdfe]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9260718E; Mon, 20 Dec 2021 16:28:06 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#52603: [PATCH 0/2] Flag missing netmasks early on References: <20211218170227.19999-1-ludo@gnu.org> <87fsqpt0s4.fsf@gnu.org> Date: Mon, 20 Dec 2021 16:28:05 +0100 In-Reply-To: <87fsqpt0s4.fsf@gnu.org> (Mathieu Othacehe's message of "Sun, 19 Dec 2021 10:13:47 +0100") Message-ID: <87zgovgut6.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / Authentication-Results: hera.aquilenet.fr; none X-Rspamd-Server: hera X-Rspamd-Queue-Id: DA8C51DF X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 52603-done Cc: 52603-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, Mathieu Othacehe skribis: >> To avoid this, this patch flags it at expansion time (if possible) or >> at run time, before the machine configuration is built. >> >> Did I go overboard with =E2=80=98define-compile-time-procedure=E2=80=99?= I don=E2=80=99t think >> so :-), I think it will serve us more than once. > > I tested this series, works fine! It is still possible to pass incorrect > netmasks (negative, > 32 for IPv4), but they should be way less frequent > than forgetting to add a netmask. Yeah=E2=80=A6 Pushed as 4df584aeac56fb6575ba43bc94f60f04522caf88, thanks for testing! Ludo=E2=80=99. From unknown Tue Sep 23 12:56:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 Jan 2022 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator