Subject: bug#52568: closed (Re: [bug#52568] [PATCH] gnu: ableton-link: Run tests conditionally.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 17 Dec 2021 08:37:02 +0000

Your bug report

#52568: [PATCH] gnu: ableton-link: Run tests conditionally.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
52568: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52568
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#52568] [PATCH] gnu: ableton-link: Run tests conditionally.
From: Nicolas Goaziou <[email-masked]>
To: Aleksandr Vityazev <[email-masked]>
Cc: [email-masked]
Date: Fri, 17 Dec 2021 09:35:58 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Aleksandr Vityazev <[email-masked]> writes:

> * gnu/packages/audio.scm (ableton-link)[arguments]: Respect TESTS?
> option.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Subject: [PATCH] gnu: ableton-link: Run tests conditionally.
From: Aleksandr Vityazev <[email-masked]>
To: [email-masked]
Date: Fri, 17 Dec 2021 08:30:24 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/audio.scm (ableton-link)[arguments]: Respect TESTS? option.
---
 gnu/packages/audio.scm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index f5fda6d4e9..beae167fb3 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5245,11 +5245,12 @@ (define-public ableton-link
        #:phases
        (modify-phases %standard-phases
          (replace 'check
-           (lambda* (#:key inputs #:allow-other-keys)
-             (let* ((python (search-input-file inputs "/bin/python3"))
-                    (run-tests "../source/ci/run-tests.py"))
-               (invoke python run-tests "--target" "LinkCoreTest")
-               (invoke python run-tests "--target" "LinkDiscoveryTest"))))
+           (lambda* (#:key inputs tests? #:allow-other-keys)
+             (when tests?
+               (let* ((python (search-input-file inputs "/bin/python3"))
+                      (run-tests "../source/ci/run-tests.py"))
+                 (invoke python run-tests "--target" "LinkCoreTest")
+                 (invoke python run-tests "--target" "LinkDiscoveryTest")))))
          (add-before 'install 'patch-cmake
            (lambda* (#:key inputs #:allow-other-keys)
              (let* ((source "../source/"))
-- 
2.34.0

-- 

Aleksandr Vityazev