GNU bug report logs - #52532
[PATCH] ci: Restrict substitute search to guix jobset.

Previous Next

Package: guix-patches;

Reported by: Andrew Whatson <whatson <at> gmail.com>

Date: Thu, 16 Dec 2021 01:15:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrew Whatson <whatson <at> gmail.com>
Subject: bug#52532: closed (Re: bug#52532: [PATCH] ci: Restrict substitute
 search to guix jobset.)
Date: Sun, 19 Dec 2021 15:31:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#52532: [PATCH] ci: Restrict substitute search to guix jobset.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 52532 <at> debbugs.gnu.org.

-- 
52532: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=52532
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Andrew Whatson <whatson <at> gmail.com>
Cc: 52532-done <at> debbugs.gnu.org
Subject: Re: bug#52532: [PATCH] ci: Restrict substitute search to guix jobset.
Date: Sun, 19 Dec 2021 16:30:34 +0100
Hey Andrew,

> Hopefully the above shows the problem, the first link includes builds
> with jobset "staging" which probably shouldn't be returned as a
> suitable guix revision for guix pull.

Oh I guess it picked the "guix" package from the staging specification
which has noting to do with the "guix" package from the "guix"
specification. Hard to follow, naming could probably be improved here
:).

The first one is the package from (gnu packages package-management)
while the second is the guix modular package from the (build-self)
module.

Anyway your patch should prevent this problem from happening. Pushed as
11334d15d590073c631c574436d2110aa1ea2142.

Thanks,

Mathieu

[Message part 3 (message/rfc822, inline)]
From: Andrew Whatson <whatson <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] ci: Restrict substitute search to guix jobset.
Date: Thu, 16 Dec 2021 01:14:02 +0000
[Message part 4 (text/plain, inline)]
Hi!

I've been using channel-with-substitutes-available recently, and
noticed that at one point it's returned a commit from the staging
branch instead of master.  On further investigation, it seems the API
needs a jobset parameter to restrict the results to only main guix
builds.

eg. http://ci.guix.gnu.org/api/latestbuilds?nr=5&job=guix.x86_64-linux
vs. http://ci.guix.gnu.org/api/latestbuilds?nr=5&job=guix.x86_64-linux&jobset=guix

Hopefully the above shows the problem, the first link includes builds
with jobset "staging" which probably shouldn't be returned as a
suitable guix revision for guix pull.

This patch adds a jobset parameter to restrict the substitute search.

Cheers,
Andrew
[guix-restrict-substitute-jobset.patch (text/x-patch, attachment)]

This bug report was last modified 3 years and 191 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.