GNU bug report logs - #52523
29.0.50; defcustom :type 'key-sequence not following key-valid-p format

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Wed, 15 Dec 2021 20:36:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 52523 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52523 <at> debbugs.gnu.org
Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following
 key-valid-p format
Date: Thu, 16 Dec 2021 19:11:36 +0200
> Now that we prefer the key-valid-p format, we should think about what to
> do about defcustom as well.  We currently have that:
>
>     (defcustom foo "C-a" "" :type 'key-sequence)
>
> Followed by `M-x customize-option RET foo RET' leads to a customize
> buffer where this is displayed as "C - a".  IOW, there is only support
> for the legacy format "\C-a".
>
> We can't just change this in a backwards incompatible way, but perhaps
> we should document it as deprecated and introduce a new format for the
> new type?

Indeed, a new type would be preferable.  How about

  :type 'kbd




This bug report was last modified 3 years and 225 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.