GNU bug report logs - #52523
29.0.50; defcustom :type 'key-sequence not following key-valid-p format

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Wed, 15 Dec 2021 20:36:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 52523 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format
Date: Tue, 28 Dec 2021 15:32:16 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

>> Yes, that's confusing.  I meant to have the `key-valid-p' say what it
>> accepts as a valid key binding, and then the other functions refer to it.
>
> Do you mean here "a valid key"?

Yes.

> I tried to do that on master (commit 8df3a71c52), please take a look.
> I also filed a number of documentation bugs separately while looking
> over the  info manual.

Looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 3 years and 226 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.