From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 15:35:12 2021 Received: (at submit) by debbugs.gnu.org; 15 Dec 2021 20:35:12 +0000 Received: from localhost ([127.0.0.1]:33779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxazY-0000JI-NN for submit@debbugs.gnu.org; Wed, 15 Dec 2021 15:35:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:54248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxazY-0000JB-3q for submit@debbugs.gnu.org; Wed, 15 Dec 2021 15:35:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxazU-0004E2-Vx for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 15:35:11 -0500 Received: from mail-pl1-f174.google.com ([209.85.214.174]:37450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxazS-0005X0-8n for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 15:35:07 -0500 Received: by mail-pl1-f174.google.com with SMTP id n8so17530660plf.4 for ; Wed, 15 Dec 2021 12:35:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=UOdfxSWW/lv66t35bFyKPKd8EhBndrrs6QcZ0JX1OAQ=; b=N/2U9sZgzAVQbENpz9Y3xS55DgZM5ZD2MqN5+YDOyBwQe/+/DWee0aGuj9h7EoD5pd dpIFkmc+ySA+/r76MLaJSKKHRJttI3Riq9tqhmgumZaNalzak3LBGQHgoMHkhgcTtRjx q7Qfy+H7Lho6wixwdasZXknhCg0v60/gqI281FPbTsqNhcQqr24qBYxo1m34ufx0HQa+ s7PIY2JCdyxhOq6xn7YJ4H1vm/jNipNJIB0zoTEO0I2AkdpDNkXfEA4jSn3zz0ANZrEQ Frap5/ozM03qrNb8Ecjh5qbaeErG/9mBuEJT+C6hM+f+Mb3zDvMQq+6UMV5aVbPZTy+x aLWg== X-Gm-Message-State: AOAM5337c2OdT3kg/NEusFVVgvZvYdPxttYqO9xLTZL4S0xTEZYg8G+P OTKmUgz7o3scmsr7MjjSSQmUzIBHYP+wtJolz0cLW6Y8 X-Google-Smtp-Source: ABdhPJyd92eBFWH0wBInqmj0SUUwB+aUj5hPzNSzcfwKmQGoMQ2jTe/MOZCdIZoswCig9LE5GwwTd/NrdOu4fsGxYkM= X-Received: by 2002:a17:90a:1bc5:: with SMTP id r5mr1751249pjr.133.1639600503752; Wed, 15 Dec 2021 12:35:03 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 15 Dec 2021 12:35:03 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 15 Dec 2021 12:35:03 -0800 Message-ID: Subject: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.214.174; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f174.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Now that we prefer the key-valid-p format, we should think about what to do about defcustom as well. We currently have that: (defcustom foo "C-a" "" :type 'key-sequence) Followed by `M-x customize-option RET foo RET' leads to a customize buffer where this is displayed as "C - a". IOW, there is only support for the legacy format "\C-a". We can't just change this in a backwards incompatible way, but perhaps we should document it as deprecated and introduce a new format for the new type? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 16 12:35:16 2021 Received: (at 52523) by debbugs.gnu.org; 16 Dec 2021 17:35:16 +0000 Received: from localhost ([127.0.0.1]:36572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuey-0005zB-7k for submit@debbugs.gnu.org; Thu, 16 Dec 2021 12:35:16 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxuew-0005yf-EI for 52523@debbugs.gnu.org; Thu, 16 Dec 2021 12:35:15 -0500 Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 1FEAA60009; Thu, 16 Dec 2021 17:35:06 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format Organization: LINKOV.NET References: Date: Thu, 16 Dec 2021 19:11:36 +0200 In-Reply-To: (Stefan Kangas's message of "Wed, 15 Dec 2021 12:35:03 -0800") Message-ID: <865yroa7l7.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Now that we prefer the key-valid-p format, we should think about what to > do about defcustom as well. We currently have that: > > (defcustom foo "C-a" "" :type 'key-sequence) > > Followed by `M-x customize-option RET foo RET' leads to a customize > buffer where this is displayed as "C - a". IOW, there is only support > for the legacy format "\C-a". > > We can't just change this in a backwards incompatible way, but perhaps > we should document it as deprecated and introduce a new format for the > new type? Indeed, a new type would be preferable. How about :type 'kbd From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 07:15:49 2021 Received: (at 52523) by debbugs.gnu.org; 19 Dec 2021 12:15:49 +0000 Received: from localhost ([127.0.0.1]:45060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myv6T-0006ew-7t for submit@debbugs.gnu.org; Sun, 19 Dec 2021 07:15:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:40990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myv6S-0006YI-1I for 52523@debbugs.gnu.org; Sun, 19 Dec 2021 07:15:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YDYJNNoKe+CS/x01rVHMLXTUj1WR3o2/ORnl+ggNrek=; b=ACTjEZ2gzJeAGOql/5QAB1LRUk Db3NI6VolC0KnczHeHGT9rYIPrCt7xmlWMl3SMmsA3c4ClMAeSwH7pxybdlqYQicYb5PYg7fXuCpR tett8pU5NRYYBAGjDXtmA8NHpCDSul/SRCH2TabwEwGMYUW5UEE0O/oQ38nwx+tcazek=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myv6J-0003VX-J6; Sun, 19 Dec 2021 13:15:42 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> X-Now-Playing: John Martyn's _Bless the Weather_: "Head and Heart (Band Version)" Date: Sun, 19 Dec 2021 13:15:34 +0100 In-Reply-To: <865yroa7l7.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 16 Dec 2021 19:11:36 +0200") Message-ID: <87fsqou6xl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Indeed, a new type would be preferable. How about > > :type 'kbd A new type would be good, but we're not using the `kbd' name explicitly in `key-valid-p' etc, so perhaps we could come up with a different name. But I have no suggestions. 🤐 Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: > Indeed, a new type would be preferable. How about > > :type 'kbd A new type would be good, but we're not using the `kbd' name explicitly in `key-valid-p' etc, so perhaps we could come up with a different name. But I have no suggestions. =F0=9F=A4=90 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 08:43:44 2021 Received: (at 52523) by debbugs.gnu.org; 19 Dec 2021 13:43:44 +0000 Received: from localhost ([127.0.0.1]:45263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mywTY-0004ar-5g for submit@debbugs.gnu.org; Sun, 19 Dec 2021 08:43:44 -0500 Received: from mail-pj1-f48.google.com ([209.85.216.48]:44921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mywTW-0004aa-9D for 52523@debbugs.gnu.org; Sun, 19 Dec 2021 08:43:42 -0500 Received: by mail-pj1-f48.google.com with SMTP id k6-20020a17090a7f0600b001ad9d73b20bso7498214pjl.3 for <52523@debbugs.gnu.org>; Sun, 19 Dec 2021 05:43:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=Jlps+r+K6LDO7vAImMIDW3r2pq7yIlM+Hmk1I8/np1Y=; b=dBINSwV9g7YDnl8xiVUgei1/NDMsSRebqg/6OhLy9o3T7VOgFIAAcua78peUuIq3oo HOyMllPDcgNs2QD0ZSypVVvTVt3E8jtql/+Tx+fR6X1hh2GdHsWBdY2wG4UG+Z58WtNn Rh2Tyx3Td/r7AYzXaeJ3FBu/LX0ixgdqornYcISXMjKBr8PYrjPHzztFgGc3eznMJD+k IlJHz4DjWhUJu0zY7n5U+iUcJaP4p3vikQeutxRIKYWPETOGuC1tlHFfWg3XCG3Wo3dJ ONxhnWVt5GfZiIHqtiyS6LWVRLTskioV7XRfnhN6/4AV8RUL+eRLj2wX2V7ujN/U/SJz MExQ== X-Gm-Message-State: AOAM533A/1cmSryqVZxqk1lp5AD1ek1i4appiV3p4RDQwHMtSumi5E+/ 3L6RjGwKqNGATxmiKkxbXdAdk9SB7A8OHcnH/LM= X-Google-Smtp-Source: ABdhPJzccR76I+AVaukJ5aZDzFCL1dPCUTaVPevXHZEyjtJWD1Bgqr6dGSc3sj2u47yg3cuBIENosHHn86AdmmTpZrM= X-Received: by 2002:a17:90a:1bc5:: with SMTP id r5mr14522191pjr.133.1639921416559; Sun, 19 Dec 2021 05:43:36 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Dec 2021 05:43:35 -0800 From: Stefan Kangas In-Reply-To: <87fsqou6xl.fsf@gnus.org> References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> MIME-Version: 1.0 Date: Sun, 19 Dec 2021 05:43:35 -0800 Message-ID: Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format To: Lars Ingebrigtsen , Juri Linkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > Juri Linkov writes: > >> Indeed, a new type would be preferable. How about >> >> :type 'kbd > > A new type would be good, but we're not using the `kbd' name explicitly > in `key-valid-p' etc, so perhaps we could come up with a different name. > But I have no suggestions. =F0=9F=A4=90 How about :type 'key-binding ? From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 08:54:44 2021 Received: (at 52523) by debbugs.gnu.org; 19 Dec 2021 13:54:44 +0000 Received: from localhost ([127.0.0.1]:45275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myweB-0004tl-Sn for submit@debbugs.gnu.org; Sun, 19 Dec 2021 08:54:44 -0500 Received: from quimby.gnus.org ([95.216.78.240]:42208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myweA-0004tY-Cf for 52523@debbugs.gnu.org; Sun, 19 Dec 2021 08:54:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d2sxAooc3ZBPwK1KDgiCnrp5oTNY0ekwIrYnw4Jt2tg=; b=E5YdWQzQSwt5aYFb4xGbUXNv7g Z2+WV0zWyUUwd9ltXuXs+4rFeXVf2CdFOOmHHO7ttKv0dabuw4J3/dD3+qU8Wub6IaU8tQ3gT4Znz m+E9PPe4UV4F0zJvi/Z7jOuaGXV3Nn9dcf3sP496dNJ05N30gg6PBy3ICNOD4tFjZqa8=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mywe1-0004BP-Fd; Sun, 19 Dec 2021 14:54:35 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEU+S3MmMW4fMGZA Xohzi5iur7D///8Y+2PYAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UMEw0dHZmzpncAAAGySURBVDjL lZRNjuQgDIVNkdlD0gdo0Bwg1a7e1yhm31LB/a8yzxBCUprNOFIS/Nk880vG/9McmeBjjLM24gkE ahkzGWfI43F7F9S/5KjZBYT2fxapIERFEWLhDWi76s8nEIM+SKkCnQQtd47Rz67JmgEQj3EEjVdH J3RTdwyWV2IGcj1DQYyOqwmTMeEMLJxJ1kdZ2c4HQE/Mj5QLccrMdy3HtYxFE5402VRevOps7sCy SHlugndhProKAR1BouSUJW18R0oT/9RIhKtfXlWkgUVdMM3LwusBPhBY7TtLLhtEKvDzJKUB+Zly ka2JI++7dKAZIvu0x5hKyTvICb83XQSAGQBlwTLKAviqsxtqRgP7twGsHsLSG4A4KLwHyD3DYCq7 FyJlgBi03IvdKsA4Hld/9h1MQ1y7GmCp7txLfoUd+GWPT+31c2zRzwn1Z9ml8p+x23/BzbffDWxm gKnkjXkfIp3Ox6Kzm5q4mPOJSpVUBeyFdjgr+JC6F3RhrD8D7F3sLU5FnvcL8C4SWSuykb8CT5b4 sckReACcKCvMozmuDLLrONBn8H6X/DfoV8i7/QUUV6fom29HFgAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMS0xMi0xOVQxMzoyOToyOSswMDowMAO7pwUAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTIt MTlUMTM6Mjk6MjkrMDA6MDBy5h+5AAAAAElFTkSuQmCC X-Now-Playing: John Martyn's _One World (1)_: "Dancing" Date: Sun, 19 Dec 2021 14:54:32 +0100 In-Reply-To: (Stefan Kangas's message of "Sun, 19 Dec 2021 05:43:35 -0800") Message-ID: <87zgowpunb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > How about > > :type 'key-binding > > ? Looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > How about > > :type 'key-binding > > ? Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 12:20:20 2021 Received: (at 52523) by debbugs.gnu.org; 19 Dec 2021 17:20:20 +0000 Received: from localhost ([127.0.0.1]:47949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myzrA-00079z-DY for submit@debbugs.gnu.org; Sun, 19 Dec 2021 12:20:20 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myzr8-00079Q-8w for 52523@debbugs.gnu.org; Sun, 19 Dec 2021 12:20:18 -0500 Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D1D1BC0008; Sun, 19 Dec 2021 17:20:10 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format Organization: LINKOV.NET References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> Date: Sun, 19 Dec 2021 19:08:25 +0200 In-Reply-To: (Stefan Kangas's message of "Sun, 19 Dec 2021 05:43:35 -0800") Message-ID: <86a6gwk6t2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Lars Ingebrigtsen writes: > >> Juri Linkov writes: >> >>> Indeed, a new type would be preferable. How about >>> >>> :type 'kbd >> >> A new type would be good, but we're not using the `kbd' name explicitly >> in `key-valid-p' etc, so perhaps we could come up with a different name. >> But I have no suggestions. 🤐 > > How about > > :type 'key-binding Or simply :type 'keys? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 01:59:23 2021 Received: (at 52523) by debbugs.gnu.org; 20 Dec 2021 06:59:23 +0000 Received: from localhost ([127.0.0.1]:48746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzCdn-0000ni-9Q for submit@debbugs.gnu.org; Mon, 20 Dec 2021 01:59:23 -0500 Received: from mail-pl1-f174.google.com ([209.85.214.174]:35821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzCdk-0000nU-LV for 52523@debbugs.gnu.org; Mon, 20 Dec 2021 01:59:21 -0500 Received: by mail-pl1-f174.google.com with SMTP id n16so6589730plc.2 for <52523@debbugs.gnu.org>; Sun, 19 Dec 2021 22:59:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=k5xPhdk3UQ1aqwCSb7RmmxHIS9D5ClAHHevnc9yaBpw=; b=EdBZe8ezfuu5KQCJvTwUfuLBm+KAlUQTRKP0p/rJv56bt2mskGgXeVBaMOAsdBK6SD aoUezY0ZSHcnCYDLC6+wO0lWFKJzCQtBuJMwCJH5TPE56Ka8tS23UplrkPzG9W+YWBUT erRSNwkfUm8YVprqdyLtRt446TeBPsOIiRbTxvcFX0m1Jk0oG+5TaS0UPK1T8GjfU0Zl KGhiianKRUU+G3RbxtzDjm1U3rgX29Vkt8rLaeO6A7AtFSRBZ+7DSR817gvqhp1tglXR HOL/Blnseshiu0VVHPo5FySapXf7jCSL6g605CPzP9M+ETwQrTVLsk6fmEzs8uKBxIj2 wTMA== X-Gm-Message-State: AOAM530EgsXmvyAq0PbkIXgqZCyUnFReIlkHEIaUOXS9v9XNcpRLUSIP nYnrVAAiLTA4TTtUvoGMz91lyPEXqpjBEM80D/4= X-Google-Smtp-Source: ABdhPJy25pzWlFtjdREmJXOMNYTPKZ6FI27Wnv3+QkXnUJwHdUg2RrgNERwfpHriyALt62RJRC5J/mVQR2qAIeUJJj8= X-Received: by 2002:a17:902:8e87:b0:148:a2e8:2c5f with SMTP id bg7-20020a1709028e8700b00148a2e82c5fmr15616281plb.174.1639983554875; Sun, 19 Dec 2021 22:59:14 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 19 Dec 2021 22:59:14 -0800 From: Stefan Kangas In-Reply-To: <86a6gwk6t2.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 19 Dec 2021 19:08:25 +0200") References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Sun, 19 Dec 2021 22:59:14 -0800 Message-ID: Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format To: Juri Linkov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Juri Linkov writes: >> How about >> >> :type 'key-binding > > Or simply :type 'keys? It sounds like you are supposed to provide a list to that type, I think? If we are going short, how about :type 'key? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 20 23:07:03 2021 Received: (at 52523) by debbugs.gnu.org; 21 Dec 2021 04:07:03 +0000 Received: from localhost ([127.0.0.1]:51949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzWQZ-0000O0-Dv for submit@debbugs.gnu.org; Mon, 20 Dec 2021 23:07:03 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzWQX-0000NU-Nd for 52523@debbugs.gnu.org; Mon, 20 Dec 2021 23:07:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Resent-Message-ID:Resent-Date:Resent-From: Resent-To:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Sender:Resent-Cc:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ixqw/LPbNYB4hyEFhy9eFGFI7o5w9912kikXD/KuUss=; b=eezqpNMRnXTaA4b9eV5k7uyr9d S37Y9B/RFA0UmAe4vYo6TbDbm7CGVGaKYJ7k6RjKklOrwSbDbmjtkpbBr+9lvryAJcWiTvoU65i7p yuTPZpPqaWu7Cd4s5U/MZ5XHOhzcpRGsWdxfaEeXcqkMKIapvo9Fjf48DUcsW1ZSGhgM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzWQP-0002jf-Fp for 52523@debbugs.gnu.org; Tue, 21 Dec 2021 05:06:55 +0100 Resent-X-Now-Playing: Heidi Berry's _Love_: "Gloria" Resent-To: 52523@debbugs.gnu.org Resent-From: Lars Ingebrigtsen Resent-Date: Tue, 21 Dec 2021 05:06:51 +0100 Resent-Message-ID: <87h7b2mwis.fsf@gnus.org> X-From-Line: nobody Mon Dec 20 11:27:24 2021 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEWOoVlMZDn///9k 6/PIAAAAAWJLR0QCZgt8ZAAAAAd0SU1FB+UMFAkxCrmP2HsAAAFESURBVCjPRVFBDuQwCDNSuKdS +A+RmjuR4P9fWdMd7ebSOAZsXIBnYMx4+yaJwFCYF1xLHJgVFkBV34HFqvhAQJdpg5KA8N1gBLvu hChbiE7VADzZTxJKPpsi5lTJU2BJ1fW20c+ZJBKmG/1uFbRDvUFRspcjEl7q99btVpSr63cl6DW0 fiBi/gf3vp/L5iGie44pY9LBddHRJw73L31YMrjsYAZ7TpGXlYKzG4BgDepsVfEnpy+cDorlPInn S7LjqPjikr+aDHH/qrT4fhw/N9zH//UUZt7AuxSHJcnUOhjoFrIJPQd4juEpH0+q49HLELGYVFXr VI6VztC6hy0fEebajE2qs06Qiz1ZVLj0PXzFsqAx/tNB49PcMKzLqMjkocYPg5DqZV6UTs4+QiOL FsM5zSlEvz73sAeRjEq5txqTnbA/cGxYvOKgEBwAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTIt MjBUMDk6NDk6MTArMDA6MDDZqP18AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEyLTIwVDA5OjQ5 OjEwKzAwOjAwqPVFwAAAAABJRU5ErkJggg== X-Now-Playing: The Incredible String Band's _Strange Folk_: "Saturday Night" Date: Mon, 20 Dec 2021 11:27:21 +0100 In-Reply-To: <86tuf3ptcr.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 20 Dec 2021 10:34:44 +0200") Message-ID: <87fsqno9km.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Lines: 12 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >> If we are going short, how about :type 'key? > > But it's not a key, it's a key sequence. We'll, we're kinda sloppy in the terminology here, so I think any of these are fine -- key-binding, keys, key. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: >> If we are going short, how about :type 'key? > > But it's not a key, it's a key sequence. We'll, we're kinda sloppy in the terminology here, so I think any of these are fine -- key-binding, keys, key. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 06:19:34 2021 Received: (at 52523) by debbugs.gnu.org; 21 Dec 2021 11:19:34 +0000 Received: from localhost ([127.0.0.1]:52551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzdB8-00042N-1b for submit@debbugs.gnu.org; Tue, 21 Dec 2021 06:19:34 -0500 Received: from mail-pj1-f48.google.com ([209.85.216.48]:46704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzdB4-000426-AK for 52523@debbugs.gnu.org; Tue, 21 Dec 2021 06:19:32 -0500 Received: by mail-pj1-f48.google.com with SMTP id rj2-20020a17090b3e8200b001b1944bad25so2887310pjb.5 for <52523@debbugs.gnu.org>; Tue, 21 Dec 2021 03:19:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=MrbAYbUSYdu63jeG7nG1UfCQV4pvPv11enyog00ClIM=; b=aa3qx9ApiYAxa2d57w4+73wYTSauja+BSCh6hoeg+wzPoJszs/lkL6xTNBU+PwwTpK xAxJkh333oD/yPPs9fck6yy2YEWedHuGl4PTgDF/Zfex2bNLLI/yk/ngRSiVmtA5DEhN W38ERyy9B2g5oOapuCUx5/koPtkN6kf5BxN5uCeWgzVy2GqU9dKbKbVRFShrhlNgaT0j K2f6zvT3Krg4xCMuqs69/zC8klDcHQT7SUsij8LU2VKHxrdP5igbAF7m3uG2lu5fIrI4 OmuG4z178OV6QXBsqE3NtIuovTK6U9Wbq+epwfHt/id/yXqSis8BBMkDz8G3yY6dM6Ev JSvA== X-Gm-Message-State: AOAM530jrB+CS+yYecEE2hxxK14m2FXELyDSDPcCF1DZKT3j3uXTtSIP atAwlT0NTtZQHYrWJz2EZn3JhBudU1sUg+HrmFs= X-Google-Smtp-Source: ABdhPJyaYcuUMFKwmxP0omw34IMFQahq51Q+0yPUtQDzaicw7G6MIZ1IN5KxpHKVjA/ckp6FC6bMOgLfoJTRg6uAJcQ= X-Received: by 2002:a17:902:7615:b0:148:db50:6b9f with SMTP id k21-20020a170902761500b00148db506b9fmr2556818pll.102.1640085564562; Tue, 21 Dec 2021 03:19:24 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 21 Dec 2021 03:19:24 -0800 From: Stefan Kangas In-Reply-To: <87fsqno9km.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 20 Dec 2021 11:27:21 +0100") References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 21 Dec 2021 03:19:23 -0800 Message-ID: Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > We'll, we're kinda sloppy in the terminology here, so I think any of > these are fine -- key-binding, keys, key. FWIW, I find the plural "keys" confusing, but other than that any of the suggestions proposed so far are fine by me as well. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 14:14:46 2021 Received: (at 52523) by debbugs.gnu.org; 21 Dec 2021 19:14:46 +0000 Received: from localhost ([127.0.0.1]:55661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzkaz-0004LZ-Q2 for submit@debbugs.gnu.org; Tue, 21 Dec 2021 14:14:45 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:39029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzkay-0004LJ-1Z for 52523@debbugs.gnu.org; Tue, 21 Dec 2021 14:14:44 -0500 Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 6B669C0005; Tue, 21 Dec 2021 19:14:35 +0000 (UTC) From: Juri Linkov To: Stefan Kangas Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format Organization: LINKOV.NET References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> Date: Tue, 21 Dec 2021 20:53:32 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 21 Dec 2021 03:19:23 -0800") Message-ID: <86ilvi9c8b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> We'll, we're kinda sloppy in the terminology here, so I think any of >> these are fine -- key-binding, keys, key. > > FWIW, I find the plural "keys" confusing, but other than that any of the > suggestions proposed so far are fine by me as well. I agree. OTOH, I still see no problem with 'kbd', or even 'kbd-sequence'. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 21 23:16:12 2021 Received: (at 52523) by debbugs.gnu.org; 22 Dec 2021 04:16:12 +0000 Received: from localhost ([127.0.0.1]:56406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzt2x-0003sZ-Nh for submit@debbugs.gnu.org; Tue, 21 Dec 2021 23:16:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzt2u-0003s9-1T for 52523@debbugs.gnu.org; Tue, 21 Dec 2021 23:16:10 -0500 Received: from [2001:470:142:3::e] (port=51872 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzt2o-0005XS-Kk; Tue, 21 Dec 2021 23:16:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From: mime-version; bh=MsMzoJ0GyPk/7el8jwSLFa1uT18yAI0Rx7T3whkTg5I=; b=k2veM31cb5y8 +TVjYALzydRpHZS3vt6wUDYrDrY/VI0elX+Lq2G86bk6rBzbc3kJH+lN+0rg9uDbtoZ3Qd5J13A2P Reww852jcDVYFLiFcUt8Wej5lX1bCW6GYaRrQ64A+nHUzClDCCMNeq1CFvs/HbbS9tVTJ5R2JyKE2 64d+ew80TBR4GLHZx8Ytb6aUw1E8t9/MqnJeBGkViUF7yo7FDGb8YKWvKYvS/9IpoEMQTUa9RQ9OQ z389x6UuHqXKKlqz5SIlIEegwsqLb3RH6tWqAphWk6G8X1rN7Qv55z62pKlAT82YDXIWyiB+fFpmC V0+kxajQjb/3Ec9u/tSWVQ==; Received: from rms by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mzt2o-0004hJ-Ql; Tue, 21 Dec 2021 23:16:02 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Wed, 15 Dec 2021 12:35:03 -0800) Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: Message-Id: Date: Tue, 21 Dec 2021 23:16:02 -0500 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > Now that we prefer the key-valid-p format, we should think about what to > do about defcustom as well. We currently have that: > (defcustom foo "C-a" "" :type 'key-sequence) That defcustom seems to use incorrect syntax for its initial value. Here are two real ones: (defcustom outline-minor-mode-prefix "\C-c@" "Prefix key to use for Outline commands in Outline minor mode. The value of this variable is checked as part of loading Outline mode. After that, changing the prefix key requires manipulating keymaps." :type 'key-sequence :initialize 'custom-initialize-default ...) (defcustom gud-key-prefix "\C-x\C-a" "Prefix of all GUD commands valid in C buffers." :type 'key-sequence) They both use the literal string syntax, rather than our new user-friendly `kbd' syntax, but the value is a valid key sequence. > Followed by `M-x customize-option RET foo RET' leads to a customize > buffer where this is displayed as "C - a". IOW, there is only support > for the legacy format "\C-a". M-x customize-option RET gud-key-prefix RET shows this: Hide Gud Key Prefix: Key sequence: C-x C-a [ State ]: STANDARD. Prefix of all GUD commands valid in C buffers. Groups: [Gud] It seems that all is working correctly, and nothing needs to be fixed. -- Dr Richard Stallman (https://stallman.org) Chief GNUisance of the GNU Project (https://gnu.org) Founder, Free Software Foundation (https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 22 07:41:32 2021 Received: (at 52523) by debbugs.gnu.org; 22 Dec 2021 12:41:32 +0000 Received: from localhost ([127.0.0.1]:57027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n00w0-0007X3-L2 for submit@debbugs.gnu.org; Wed, 22 Dec 2021 07:41:32 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n00vy-0007Wp-EZ for 52523@debbugs.gnu.org; Wed, 22 Dec 2021 07:41:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=i3OtgLNPRu4PmQ9hTCHGjPjELFZZlGFF8XIwNWQImGY=; b=fCrto6hOLgpu9P1BDvUcCUicYN 2ftdB1G7EoUo7kb+Eveb8qlL7S0xQGQthEIKFAqcJ8a0/h8rWy0vYEFthnG5508E95U66e0QFt2Ia RwMlQeZ2dcfROKzYKcRBzX7nuKPNoHfqRHPzkPH4HFtmMCmHhlHI3gdXDifwD0RBQUec=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n00vo-0008Sz-SY; Wed, 22 Dec 2021 13:41:23 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEXZUEb9/f3XqaTj 09BVKyf////XUO5+AAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UMFgwEOH+rQS0AAAG4SURBVDjLdZON ccMgDIVlzAAWdAB+PIAFHYA67D9Tn3AvIU2iS862PiGJJyDiVwsLM9HyBqwKVm8EHy6zvwNSYAp+ seT+Q+ny10ARQK3f9lsJ3Z7FAKSD1gs0/A0fljqenjeXaACroP84fSUKuQRRMNxk+2kb3G18VYoI 7cjQbC+94VWzUdrIXNGt2yxBYzSBCYVEI/QbWzquPJaMkxAV2JO0S2dqQLxtCx85aj8mbkOXxE47 VrCKAuEBPJQJqEc3PkxEPy2JU1BZ6wA0OWgZ7YmTP/mcdtVMQLvaSLwL7odEANezymMUly6XLXma EXLpHrMCkQm0AaAWjc09gOrWsDf4jxlcyduYoJd5xRioGRGzH2NEgR4HiJMfQx1A+F/tWjRXH8X8 E8ilU9zho8zxCTh7SoKepGN4WCl1N6XcFLg0teV8wsH0XcE2F3GYwH5WzA4nq84r2MUa8o4V3qwz EKn8ZcIeiWdt0Qk6Kk0PDsvTRhwSi4O8LzctpSRbxxRfL1rF0YW9AlXyPcB8P4DvAWqqucImsLW3 xVEEpxErnqPVvN5XLrmk/yvoU6pP7X4EG9n3qXYc01+TTl5+r2VD4gAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMS0xMi0yMlQxMjowNDo1NiswMDowMIZzRTgAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEt MTItMjJUMTI6MDQ6NTYrMDA6MDD3Lv2EAAAAAElFTkSuQmCC X-Now-Playing: Morgan Caney & Kamal Joory's _Magic Radios_: "Darling" Date: Wed, 22 Dec 2021 13:41:17 +0100 In-Reply-To: <86ilvi9c8b.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 21 Dec 2021 20:53:32 +0200") Message-ID: <87pmpoerrm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: >> FWIW, I find the plural "keys" confusing, but other than that any of the >> suggestions proposed so far are fine by me as well. > > I agree. OTOH, I still see no problem with 'kbd', or even 'kbd-se [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: >> FWIW, I find the plural "keys" confusing, but other than that any of the >> suggestions proposed so far are fine by me as well. > > I agree. OTOH, I still see no problem with 'kbd', or even 'kbd-sequence'. The problem is that we don't use the name "kbd" anywhere in the new keymap functions, so it'd be confusing to use them in defcustom. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 26 11:40:03 2021 Received: (at 52523) by debbugs.gnu.org; 26 Dec 2021 16:40:03 +0000 Received: from localhost ([127.0.0.1]:41378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1WZ0-0002mv-MB for submit@debbugs.gnu.org; Sun, 26 Dec 2021 11:40:02 -0500 Received: from mail-pj1-f44.google.com ([209.85.216.44]:45038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1WYy-0002mK-Ma for 52523@debbugs.gnu.org; Sun, 26 Dec 2021 11:40:02 -0500 Received: by mail-pj1-f44.google.com with SMTP id k6-20020a17090a7f0600b001ad9d73b20bso12435389pjl.3 for <52523@debbugs.gnu.org>; Sun, 26 Dec 2021 08:40:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=nEucWPCiiSapSYO4OWLBBEfZwvWIvafNPIzxhy0fZmg=; b=KkgU00r+BznDTDP8F9UTm5gRZCR3RuJq/+wODXu/TqnZB6/VzFlPp8zbywBSrjy3iF F4WCUUyFr/4iNHebhvjbPY2FIqQuYKl0aas5nsT3KDfZiiAXASfUX3ZByK1nvKq6wJOc NUrrb5ZP6203Vb8rRdz5FeJPh8bSeNDJ+Po53dBNPewza8FWfYyiYP/9Nlbfr7xjoR04 5Ya48J8T5lVlhYFaG0WyqsVdqYpoB0W29ZzI5ZBpQoN0Wn23CSigAbDMEuaUreuUsjzF S5MKplSqbERpTwhKZFwHMwi+z1TOhQtWQGLO79ZhI0qMBYsDlBjsEp2z43Aw3S/dxmkE sMmQ== X-Gm-Message-State: AOAM532y7oyH+pcXD01icDn2aSkzFPnmLdQ9JyVXooC2OeZ7PFqOtyvk k2tRTMHidYW24fcW4LXXblSFqXt05qrkt/ehayE= X-Google-Smtp-Source: ABdhPJxM3Rw2NyJgeEtCw4yZn2tBiN36AZUauobK2Kdl8fYwRxrZhMrFxQWadoYxKKKv32fZ3WDyYupwZvAaV1syoCQ= X-Received: by 2002:a17:902:d512:b0:149:3070:48ec with SMTP id b18-20020a170902d51200b00149307048ecmr13925479plg.66.1640536794911; Sun, 26 Dec 2021 08:39:54 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 26 Dec 2021 08:39:54 -0800 From: Stefan Kangas In-Reply-To: <87pmpoerrm.fsf@gnus.org> References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> MIME-Version: 1.0 Date: Sun, 26 Dec 2021 08:39:54 -0800 Message-ID: Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format To: Lars Ingebrigtsen , Juri Linkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: >> I still see no problem with 'kbd', or even 'kbd-sequence'. > > The problem is that we don't use the name "kbd" anywhere in the new > keymap functions, so it'd be confusing to use them in defcustom. I started looking into this but noticed that the docstring for `key-valid-p' says: Say whether KEYS is a valid =E2=80=98kbd=E2=80=99 sequence. A =E2=80=98kbd=E2=80=99 sequence is a string consisting of one and more= key strokes. The key strokes are separated by a space character. I guess that docstring should be updated if we don't want to settle for the terminology "`kbd' sequence". However, if we do that the problem is that we then risk having two definitions of "key sequence": both the old and the new style. See also (info "(elisp) Key Sequences"), that uses the old style. --- Relatedly, the `define-keymap' docstring currently says: Create a new keymap and define KEY/DEFINITION pairs as key sequences. Should that say "key bindings" instead of "key sequences"? Otherwise, it doesn't seem clear what it does. --- `keymap-set' says: Set key sequence KEY to DEFINITION in KEYMAP. So here is again the "new" style used as the definition of a key sequence, which seems to contradict the Elisp manual. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 27 07:05:25 2021 Received: (at 52523) by debbugs.gnu.org; 27 Dec 2021 12:05:25 +0000 Received: from localhost ([127.0.0.1]:42296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1okn-0001zK-2L for submit@debbugs.gnu.org; Mon, 27 Dec 2021 07:05:25 -0500 Received: from quimby.gnus.org ([95.216.78.240]:41012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1okj-0001z1-6S for 52523@debbugs.gnu.org; Mon, 27 Dec 2021 07:05:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=llQAptRWfNmOwvmUHKmWwUEUyKRE8ebGv4n3ieDY6oI=; b=ob4fUNiqk5yC0WFY+IdcLBd8Vm ExeWd2tSDfX+VxCGVpoybbyYQXBSSv9qILOe8LA3MZBvHzZA5oP7zcx5CWIPvyJhgFGfmEjR1uquZ M8fZoM6f4eVxyoWWmqovDKG4k/PcYXIplT6haIgOMIqf/LdO/l1cWham3cZIsXFoin6o=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1oka-0005Ia-Eu; Mon, 27 Dec 2021 13:05:15 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWWa1iulI2jbF2W WTz///9An9F3AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UMGws3CrQyu8UAAAG2SURBVDjLZZQBssIw CESrJzD0ArJcwIb73+3vQlrr/I7TVp5hF0LcHmOMyKkbL2CM11bXGM4YvOL5wHAD3ngTDMuJUXGu NFcEEEB6RZ+ZH4UZabDnzvAnD6YrYHgWiAmG+Ngv8O5UNitBgukatPiIo8CeQZFHgUFglg1s+ToB BdqLaqRxXq8Cp5cG1u/2A6BMq5IGY4FYarwIMuaZqbp5B2rq2I+I1l5AX1mJJVNd8bbL9fBdXn+A hZro9h8gTQD6/IARfHFWZt8FAsOjavXq0R1wjVaAavNKtq2nWjpxk29g3CrD2Vy/gaAlDxYISuEG kGADxGOZXsBDAgIanTswdpa3qTmscpYrmMaUGzX22UtOoI9pO4Bf4D0ldD3LWbdEw9qzgAJKcNqV pM6HxG8ArKML54P9WsDMq0uhmxopydIwGcpKVb61BRtLda+RqsnVOmjHBKJsxQ3wx5vqGb0ZleoC 7c8qMuWqBpZnkEDnhl3PBY4vmDVcWbMaJ0BPokQisIA14DkvEUlT4tj1tsmChp8xKcCOOr/YTCLp F+jzK4Cqmo2rfunU1QRsNYBVmrA2mH8ROeMPKf2ChUdv/oIAAAAldEVYdGRhdGU6Y3JlYXRlADIw MjEtMTItMjdUMTE6NTU6MTArMDA6MDA47whcAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEyLTI3 VDExOjU1OjEwKzAwOjAwSbKw4AAAAABJRU5ErkJggg== X-Now-Playing: Jane Siberry's _Love Is Everything (2)_: "Are You Burning, Little Candle?" Date: Mon, 27 Dec 2021 13:05:11 +0100 In-Reply-To: (Stefan Kangas's message of "Sun, 26 Dec 2021 08:39:54 -0800") Message-ID: <87ee5ycky0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > I started looking into this but noticed that the docstring for > `key-valid-p' says: > > Say whether KEYS is a valid ‘kbd’ sequence. > A ‘kbd’ sequence is a string consisting of one and more [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > I started looking into this but noticed that the docstring for > `key-valid-p' says: > > Say whether KEYS is a valid =E2=80=98kbd=E2=80=99 sequence. > A =E2=80=98kbd=E2=80=99 sequence is a string consisting of one and mo= re key > strokes. The key strokes are separated by a space character. > > I guess that docstring should be updated if we don't want to settle for > the terminology "`kbd' sequence". Yes, I forgot to update the doc string when I redid this. > However, if we do that the problem is that we then risk having two > definitions of "key sequence": both the old and the new style. > > See also (info "(elisp) Key Sequences"), that uses the old style. Yes, that's confusing. I meant to have the `key-valid-p' say what it accepts as a valid key binding, and then the other functions refer to it. > Relatedly, the `define-keymap' docstring currently says: > > Create a new keymap and define KEY/DEFINITION pairs as key sequences. > > Should that say "key bindings" instead of "key sequences"? Otherwise, > it doesn't seem clear what it does. Yes, it should. > `keymap-set' says: > > Set key sequence KEY to DEFINITION in KEYMAP. > > So here is again the "new" style used as the definition of a key > sequence, which seems to contradict the Elisp manual. Yes. Please go ahead and fix up the doc strings. =F0=9F=98=80 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 27 10:41:44 2021 Received: (at 52523) by debbugs.gnu.org; 27 Dec 2021 15:41:44 +0000 Received: from localhost ([127.0.0.1]:43989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1s88-00077N-4c for submit@debbugs.gnu.org; Mon, 27 Dec 2021 10:41:44 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:43567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1s84-000777-OQ for 52523@debbugs.gnu.org; Mon, 27 Dec 2021 10:41:43 -0500 Received: by mail-pl1-f176.google.com with SMTP id m24so11614531pls.10 for <52523@debbugs.gnu.org>; Mon, 27 Dec 2021 07:41:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=tSmRa5inWH8OJZWYQoRX2x2hhqc1m54YqUKPglqr5Zs=; b=Hl5XEPUOYlo+kBGGfvConstKMIT6fZMb6+MnR4XnMrztLfjYKEsiH/W6DhYxoSXzWd D0oc6GPWIHQ3FCmnM9dN3YsaMC0dypUFd2Ei4ZmnqI9j6CJLrWDIkvcdEPoIMQ7E6s6Q bkVocxonhWhWcsqczwcAs5pgZA8NJn3OxV7s7dIewn2wZZe54sjpJMCtzOoFQa5egKhm Fmd+2tRKsKFxPuMJ4BmkzSP7VzfkbYPgmhXxIGv3Ev5R8kKLbZq+INdaHs4FLq5BIvl1 zGzFAI/BhSV3Z7P4xhaLHdo42NYvX6+J1EtEg4v+uj6bkQe6QZJqNRif5/br+wCfm1fn E5Yg== X-Gm-Message-State: AOAM533d/+qQ7h5KjcRLOG2hpp37HKdcbkz1jEOCwf1NWhvy8N/VU4fC PwwMIu6ho1XXOhuXRM6wpbvKTBPvCgl8R6Ba4fk= X-Google-Smtp-Source: ABdhPJznoDr52IC3m4GO/fQ2PIFdt+peHz9K5HeE1n4UXV6obG23BHGrog8m3YldxrnuQ1/Y6ksVus2ec/zktJ8fR3s= X-Received: by 2002:a17:902:7615:b0:148:db50:6b9f with SMTP id k21-20020a170902761500b00148db506b9fmr17419789pll.102.1640619694800; Mon, 27 Dec 2021 07:41:34 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 27 Dec 2021 07:41:34 -0800 From: Stefan Kangas In-Reply-To: <87ee5ycky0.fsf@gnus.org> References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> <87ee5ycky0.fsf@gnus.org> MIME-Version: 1.0 Date: Mon, 27 Dec 2021 07:41:34 -0800 Message-ID: Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: >> However, if we do that the problem is that we then risk having two >> definitions of "key sequence": both the old and the new style. >> >> See also (info "(elisp) Key Sequences"), that uses the old style. > > Yes, that's confusing. I meant to have the `key-valid-p' say what it > accepts as a valid key binding, and then the other functions refer to it. Do you mean here "a valid key"? A key binding AFAIU is a mapping from "KEY =3D> DEFINITION" as described in `keymap-set-after', and belongs in a key map. >> `keymap-set' says: >> >> Set key sequence KEY to DEFINITION in KEYMAP. >> >> So here is again the "new" style used as the definition of a key >> sequence, which seems to contradict the Elisp manual. > > Yes. Please go ahead and fix up the doc strings. =F0=9F=98=80 I tried to do that on master (commit 8df3a71c52), please take a look. I also filed a number of documentation bugs separately while looking over the info manual. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 27 22:08:50 2021 Received: (at 52523) by debbugs.gnu.org; 28 Dec 2021 03:08:50 +0000 Received: from localhost ([127.0.0.1]:44814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n22r4-000729-BA for submit@debbugs.gnu.org; Mon, 27 Dec 2021 22:08:50 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:35672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n22r3-00071r-40 for 52523@debbugs.gnu.org; Mon, 27 Dec 2021 22:08:49 -0500 Received: by mail-pl1-f176.google.com with SMTP id n16so12633636plc.2 for <52523@debbugs.gnu.org>; Mon, 27 Dec 2021 19:08:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=hbIaREiIaLgSP0BD8rd6dnQqA12qyYq7DJ4cKwedEXg=; b=Xf9toRncEvLpowmYXoDyw/fs/7LZN4Jd0as9QZPwAzec59ZzP0xv6GzuiyPS/2dOUM nT9guLq9ERpK0miuRywzYLRpvAe3eZbxDUyT9Bkt3ZoB1u22G9FRe8mQe/gb/vC/Se2u j7YYuS+CH8KU+zUAsrATSDtwx4mr41IifSdW7TsmWvwTmyVZOnSD+1ZaASPPua2J0JrO DH0lq6aCcUCBUwyQkGa7x673KYUWEycOvFExYBjd+5OhenVI8duk0FJ/zTUjyjrNvVT5 12OOwhS4CQV79q/x2xIkXRfAhgeI8vPmgQjDL334CQ3+n1nSBkX3vE5ywWLLaSDqWkEz zS2Q== X-Gm-Message-State: AOAM533phA0BFFefohAWH8rjvfSINU5C1CkI+T+XylWUAmywVIR1ZymC BQgOfHncBxdWYAGkHnDQ1G0iA2XpNUmZU6HdzD4= X-Google-Smtp-Source: ABdhPJydby6vUhRepue7jc0BPjW7Ybmh1jIwEItN7dkaU/C5mMeKF0f7YIPIX+4YH15YEWr2MKDy3nphdIIMGM6qrMM= X-Received: by 2002:a17:902:7615:b0:148:db50:6b9f with SMTP id k21-20020a170902761500b00148db506b9fmr19549990pll.102.1640660923406; Mon, 27 Dec 2021 19:08:43 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 27 Dec 2021 19:08:42 -0800 From: Stefan Kangas In-Reply-To: <87pmpoerrm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 22 Dec 2021 13:41:17 +0100") References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Mon, 27 Dec 2021 19:08:42 -0800 Message-ID: Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="0000000000008975ee05d42c2363" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --0000000000008975ee05d42c2363 Content-Type: text/plain; charset="UTF-8" tags 52523 + patch thanks Lars Ingebrigtsen writes: > The problem is that we don't use the name "kbd" anywhere in the new > keymap functions, so it'd be confusing to use them in defcustom. Having looked over the documentation to these functions, I actually think "key" is the least confusing name here. How does the attached patch look? --0000000000008975ee05d42c2363 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-New-type-key-for-defcustom.patch" Content-Disposition: attachment; filename="0001-New-type-key-for-defcustom.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 54545acb9b942ab6_0.1 RnJvbSBjNDMzYjljMDIxMmMxYjZkMjVkZDA2YmExYjYzNTlkN2RlZGNkZWRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVHVlLCAyOCBEZWMgMjAyMSAwMjo1OTo1MSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIE5ldyA6 dHlwZSBrZXkgZm9yIGRlZmN1c3RvbQoKQXMgY29tcGFyZWQgdG8gdGhlIG9sZCB0eXBlIGtleS1z ZXF1ZW5jZSB0aGF0IGRlYWxzIHdpdGggcmF3IGtleQpzZXF1ZW5jZXMsIHRoaXMgOnR5cGUgY29u Zm9ybXMgdG8gdGhlIGZvcm1hdCB1c2VkIGJ5IHRoZSBuZXcga2V5bWFwLSoKZnVuY3Rpb25zLgoq IGxpc3Avd2lkLWVkaXQuZWwgKGtleSk6IE5ldyB3aWRnZXQgdHlwZS4gIChCdWcjNTI1MjMpCih3 aWRnZXQta2V5LXByb21wdC12YWx1ZS1oaXN0b3J5KTogTmV3IHZhcmlhYmxlLgood2lkZ2V0LWtl eS12YWxpZGF0ZSk6IE5ldyBmdW5jdGlvbi4KKGtleS1zZXF1ZW5jZSk6IERvYyBmaXguCiogZG9j L2xpc3ByZWYvY3VzdG9taXplLnRleGkgKFNpbXBsZSBUeXBlcyk6IERvY3VtZW50IGFib3ZlIG5l dyB0eXBlLgotLS0KIGRvYy9saXNwcmVmL2N1c3RvbWl6ZS50ZXhpIHwgIDYgKysrKystCiBldGMv TkVXUyAgICAgICAgICAgICAgICAgICB8ICA1ICsrKysrCiBsaXNwL3dpZC1lZGl0LmVsICAgICAg ICAgICB8IDIzICsrKysrKysrKysrKysrKysrKysrKystCiAzIGZpbGVzIGNoYW5nZWQsIDMyIGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvY3Vz dG9taXplLnRleGkgYi9kb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aQppbmRleCAwMDI4N2E3MjEy Li5kYTVlNzYxMTk4IDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aQorKysg Yi9kb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aQpAQCAtNjU0LDEwICs2NTQsMTQgQEAgU2ltcGxl IFR5cGVzCiBzcGVjaWZ5IHRoZSB0ZXh0IHRvIGRlc2NyaWJlIGVhY2ggdmFsdWUgaW4gYSB3YXkg dGhhdCBmaXRzIHRoZSBzcGVjaWZpYwogbWVhbmluZyBvZiB0aGUgYWx0ZXJuYXRpdmUuCiAKK0Bp dGVtIGtleQorVGhlIHZhbHVlIGlzIGEgdmFsaWQga2V5IGFjY29yZGluZyB0byBAa2Jke2tleS12 YWxpZC1wfSwgYW5kIHN1aXRhYmxlCitmb3IgdXNlIHdpdGgsIGZvciBleGFtcGxlIEBjb2Rle2tl eW1hcC1zZXR9LgorCiBAaXRlbSBrZXktc2VxdWVuY2UKIFRoZSB2YWx1ZSBpcyBhIGtleSBzZXF1 ZW5jZS4gIFRoZSBjdXN0b21pemF0aW9uIGJ1ZmZlciBzaG93cyB0aGUga2V5CiBzZXF1ZW5jZSB1 c2luZyB0aGUgc2FtZSBzeW50YXggYXMgdGhlIEBrYmR7a2JkfSBmdW5jdGlvbi4gIEB4cmVme0tl eQotU2VxdWVuY2VzfS4KK1NlcXVlbmNlc30uICBUaGlzIGlzIGEgbGVnYWN5IHR5cGU7IHVzZSBA Y29kZXtrZXl9IGluc3RlYWQuCiAKIEBpdGVtIGNvZGluZy1zeXN0ZW0KIFRoZSB2YWx1ZSBtdXN0 IGJlIGEgY29kaW5nLXN5c3RlbSBuYW1lLCBhbmQgeW91IGNhbiBkbyBjb21wbGV0aW9uIHdpdGgK ZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggMDFlMWE4ZTk0MC4uYWQ5ZTYx NDgwYiAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTk3NCw2ICs5NzQs MTEgQEAgc3ludGF4LgogVGhpcyBpcyBsaWtlICdrYmQnLCBidXQgb25seSByZXR1cm5zIHZlY3Rv cnMgaW5zdGVhZCBvZiBhIG1peCBvZgogdmVjdG9ycyBhbmQgc3RyaW5ncy4KIAorKysrCisqKiog TmV3ICc6dHlwZScgZm9yICdkZWZjdXN0b20nIGZvciBrZXlzLgorVGhlIG5ldyAna2V5JyB0eXBl IGNhbiBiZSB1c2VkIGZvciBvcHRpb25zIHRoYXQgc2hvdWxkIGJlIGEgdmFsaWQga2V5CithY2Nv cmRpbmcgdG8gJ2tleS12YWxpZC1wJy4gIFRoZSB0eXBlICdrZXktc2VxdWVuY2UnIGlzIG5vdyBv YnNvbGV0ZS4KKwogKysrCiAqKiBOZXcgc3Vic3RpdHV0aW9uIGluIGRvY3N0cmluZ3MgYW5kICdz dWJzdGl0dXRlLWNvbW1hbmQta2V5cycuCiBVc2UgXFxgS0VZU0VRJyB0byBpbnNlcnQgYSBsaXRl cmFsIGtleSBzZXF1ZW5jZSAiS0VZU0VRIiAoZm9yIGV4YW1wbGUKZGlmZiAtLWdpdCBhL2xpc3Av d2lkLWVkaXQuZWwgYi9saXNwL3dpZC1lZGl0LmVsCmluZGV4IGE1M2FkZDdkMDguLjc1NGFhODNk MGEgMTAwNjQ0Ci0tLSBhL2xpc3Avd2lkLWVkaXQuZWwKKysrIGIvbGlzcC93aWQtZWRpdC5lbApA QCAtMzQ1OSw3ICszNDU5LDcgQEAgd2lkZ2V0LWtleS1zZXF1ZW5jZS1tYXAKICAgICBtYXApKQog CiAoZGVmaW5lLXdpZGdldCAna2V5LXNlcXVlbmNlICdyZXN0cmljdGVkLXNleHAKLSAgIkEga2V5 IHNlcXVlbmNlLiIKKyAgIkEga2V5IHNlcXVlbmNlLiAgTm93IG9ic29sZXRlOyB1c2UgdGhlIGBr ZXknIHR5cGUgaW5zdGVhZC4iCiAgIDpwcm9tcHQtdmFsdWUgJ3dpZGdldC1maWVsZC1wcm9tcHQt dmFsdWUKICAgOnByb21wdC1pbnRlcm5hbCAnd2lkZ2V0LXN5bWJvbC1wcm9tcHQtaW50ZXJuYWwK IDsgOnByb21wdC1tYXRjaCAnZmJvdW5kcCAgIDs7IFdoYXQgd2FzIHRoaXMgZ29vZCBmb3I/ICBL RlMKQEAgLTM1MjQsNiArMzUyNCwyNyBAQCB3aWRnZXQta2V5LXNlcXVlbmNlLXZhbHVlLXRvLWV4 dGVybmFsCiAJKHJlYWQta2JkLW1hY3JvIHZhbHVlKSkKICAgICB2YWx1ZSkpCiAKKwwKKyhkZWZ2 YXIgd2lkZ2V0LWtleS1wcm9tcHQtdmFsdWUtaGlzdG9yeSBuaWwKKyAgIkhpc3Rvcnkgb2YgaW5w dXQgdG8gYHdpZGdldC1rZXktcHJvbXB0LXZhbHVlJy4iKQorCisoZGVmaW5lLXdpZGdldCAna2V5 ICdlZGl0YWJsZS1maWVsZAorICAiQSBrZXkgc2VxdWVuY2UuIgorICA6cHJvbXB0LXZhbHVlICd3 aWRnZXQtZmllbGQtcHJvbXB0LXZhbHVlCisgIDptYXRjaCAna2V5LXZhbGlkLXAKKyAgOmZvcm1h dCAiJXsldCV9OiAldiIKKyAgOnZhbGlkYXRlICd3aWRnZXQta2V5LXZhbGlkYXRlCisgIDprZXlt YXAgd2lkZ2V0LWtleS1zZXF1ZW5jZS1tYXAKKyAgOmhlbHAtZWNobyAiQy1xOiBpbnNlcnQgS0VZ LCBFVkVOVCwgb3IgQ09ERTsgUkVUOiBlbnRlciB2YWx1ZSIKKyAgOnRhZyAiS2V5IikKKworKGRl ZnVuIHdpZGdldC1rZXktdmFsaWRhdGUgKHdpZGdldCkKKyAgKHVubGVzcyAoYW5kIChzdHJpbmdw ICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSkKKyAgICAgICAgICAgICAgIChrZXktdmFsaWQtcCAod2lk Z2V0LXZhbHVlIHdpZGdldCkpKQorICAgICh3aWRnZXQtcHV0IHdpZGdldCA6ZXJyb3IgKGZvcm1h dCAiSW52YWxpZCBrZXk6ICVTIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAod2lkZ2V0LXZhbHVlIHdpZGdldCkpKQorICAgIHdpZGdldCkpCisKIAwKIChkZWZpbmUtd2lk Z2V0ICdzZXhwICdlZGl0YWJsZS1maWVsZAogICAiQW4gYXJiaXRyYXJ5IExpc3AgZXhwcmVzc2lv bi4iCi0tIAoyLjMwLjIKCg== --0000000000008975ee05d42c2363-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 28 07:51:15 2021 Received: (at 52523) by debbugs.gnu.org; 28 Dec 2021 12:51:15 +0000 Received: from localhost ([127.0.0.1]:45300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Bwh-0004mI-2W for submit@debbugs.gnu.org; Tue, 28 Dec 2021 07:51:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2Bwg-0004m6-9u for 52523@debbugs.gnu.org; Tue, 28 Dec 2021 07:51:14 -0500 Received: from [2001:470:142:3::e] (port=35064 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2Bwa-0003Kb-Fl; Tue, 28 Dec 2021 07:51:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=h4HtsufmGFu8vvlNDN0b/j0Le+DrwlpDU4f5nhKLVyM=; b=LMd0wY4J8SidtBcOW6DE enHNz/fsTaYTln8Pne4LhCht06Gy1NY1XpQAVnQeYz6I5RnGSdmrp1Lzjj92ftYBWd/JoTv9ANANX JTKZblncISRNrgPPGm5ibNbaGyRT++Gv0y4SCoRCaHtqMGj38J9f0lL+hogeue/JdOgC666Kh/C9d 0MVwWp5u3oLyqDkl9udGKS8FfGrdP/oLNiOnED3Yt+kSNKV6+qhgCeDkMS3mW33Ac/WxX0qZaUCku Jyuhc9oXF/Jjpfnbp2Or100a1VtxDUiJTgIYFwazUWKy3eARZXh8IVh99TQpf7VP0/++M9MieVDu4 NdJjghM7ww834w==; Received: from [87.69.77.57] (port=4193 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2Bwa-0003d0-9Z; Tue, 28 Dec 2021 07:51:08 -0500 Date: Tue, 28 Dec 2021 14:51:08 +0200 Message-Id: <831r1wnb9f.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Mon, 27 Dec 2021 19:08:42 -0800) Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Mon, 27 Dec 2021 19:08:42 -0800 > Cc: 52523@debbugs.gnu.org, Juri Linkov > > Having looked over the documentation to these functions, I actually > think "key" is the least confusing name here. > > How does the attached patch look? > > > +@item key > +The value is a valid key according to @kbd{key-valid-p}, and suitable > +for use with, for example @code{keymap-set}. But the doc string of key-valid-p says: Say whether KEYS is a valid ‘kbd’ sequence. A ‘kbd’ sequence is a string consisting of one and more key strokes. The key strokes are separated by a space character. So just referring to key-valid-p is not enough, because it accepts a more general kind of objects. > (define-widget 'key-sequence 'restricted-sexp > - "A key sequence." > + "A key sequence. Now obsolete; use the `key' type instead." Please drop the "Now" part: it doesn't fare well with time. Instead, say something like "This is obsolete; ...". From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 28 09:32:28 2021 Received: (at 52523) by debbugs.gnu.org; 28 Dec 2021 14:32:28 +0000 Received: from localhost ([127.0.0.1]:45424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2DWe-0007Ic-Gg for submit@debbugs.gnu.org; Tue, 28 Dec 2021 09:32:28 -0500 Received: from quimby.gnus.org ([95.216.78.240]:51264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2DWc-0007IM-Lu for 52523@debbugs.gnu.org; Tue, 28 Dec 2021 09:32:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PKMhORhtwgZKo6tHNGXqx6Ekqgd1NW1JMcyCF+l7bGg=; b=orEvQov8IdGKoXv+R9nwo0vTro 7Qq1USAoS/URp47an0DnDmuRoGA8uq+sc9ohhWUBNlTiKipJzj6ZPLH0fXAwsqJTt/LK4lmWsbio/ cFp6jw0mAb6j5ebHTwlrKJyq/n/l0YWT7L+mI4oSA5/Dj9eRVtxdOzgVHBKE05RGpkcA=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2DWT-0007IG-D4; Tue, 28 Dec 2021 15:32:19 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> <87ee5ycky0.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEX7+vbb1s/Fvret opySg3yKdnFrWlX///+5nBMEAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UMHA4VHHxIsuYAAAGYSURB VDjLxVNRktsgDJV7AsQJCnTyb4lcoNh7AawcYLP4/keowIQ4mdmZTn/67A9bTxJIegL4r7BoTn8T wmQmY/4x2d8ifEfQcbL3+AajD1ZC4Y73zA6i4cSAP+Nbwp0JemMa6RCCD1zR+Wp33jqnqaj7Wqxv c8e5E+QDUaih/ohmBn5Bu5nVeAf9gKOolsk7bUj/rk7VIa6iyFSp/iOyLXlJI6cDtTAvyypbStyJ eh1YF9niykuOaqi3ClQrI8jqtWlE5muikYkYUpQo+y5SpDAHppg0hn8Di/rue5E1R7kt23oV0YQE mkFupcWnj02NN5F6T0i3/Ql12UiP/pUIhrF8lY+9bInIaRvNkxD55NYZMERaebPloO2znrGJGXCq xF2rclZnYEO+/JwQ46GrWIh6IwNdZjNhVz/f3VMCAcdygJ1733W2niyObTlmbNvUXZ3fg7CzfRVV m50Sl/tDWZ1Q34zZah0PTbkeoEL/MWOt4yXVWJPrPZwJM5b3qc4jYmpBqLoi5rcdMLUuuJbXiLEG I9Pb5vwBnmqG4gFQXfsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTItMjhUMTQ6MjE6MjgrMDA6 MDA2miAIAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEyLTI4VDE0OjIxOjI4KzAwOjAwR8eYtAAA AABJRU5ErkJggg== X-Now-Playing: Static's _Eject Your Mind_: "Northrop" Date: Tue, 28 Dec 2021 15:32:16 +0100 In-Reply-To: (Stefan Kangas's message of "Mon, 27 Dec 2021 07:41:34 -0800") Message-ID: <87ee5wajgv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: >> Yes, that's confusing. I meant to have the `key-valid-p' say what it >> accepts as a valid key binding, and then the other functions refer to it. > > Do you mean here "a valid key"? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: >> Yes, that's confusing. I meant to have the `key-valid-p' say what it >> accepts as a valid key binding, and then the other functions refer to it. > > Do you mean here "a valid key"? Yes. > I tried to do that on master (commit 8df3a71c52), please take a look. > I also filed a number of documentation bugs separately while looking > over the info manual. Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 28 09:33:49 2021 Received: (at 52523) by debbugs.gnu.org; 28 Dec 2021 14:33:49 +0000 Received: from localhost ([127.0.0.1]:45440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2DXx-0007LC-L2 for submit@debbugs.gnu.org; Tue, 28 Dec 2021 09:33:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:51284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2DXv-0007Kx-5k for 52523@debbugs.gnu.org; Tue, 28 Dec 2021 09:33:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HmvsyDjK/nnIwHijDQqLnV4xZMxoY5jonnNXsqyjlvk=; b=mMQRlDBHbCQEDZ8WxtkjASuR1J Km4yAAZzdQ9DtqKEIIgXDOa4Lo/Ub8j+wAEaQcgJosXStLuo0BUS8IANXTD7BtYy9xjmPhqcDwQKv r2i7dEetCYpV0B9h8SmuIw2CyQz79sn113r4xBTdnwmH3E+4exZ5QFSMKgnNXVm6ALUE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2DXm-0007IT-37; Tue, 28 Dec 2021 15:33:40 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> <831r1wnb9f.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEX7+vbb1s/Fvret opySg3yKdnFrWlX///+5nBMEAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UMHA4VHHxIsuYAAAGYSURB VDjLxVNRktsgDJV7AsQJCnTyb4lcoNh7AawcYLP4/keowIQ4mdmZTn/67A9bTxJIegL4r7BoTn8T wmQmY/4x2d8ifEfQcbL3+AajD1ZC4Y73zA6i4cSAP+Nbwp0JemMa6RCCD1zR+Wp33jqnqaj7Wqxv c8e5E+QDUaih/ohmBn5Bu5nVeAf9gKOolsk7bUj/rk7VIa6iyFSp/iOyLXlJI6cDtTAvyypbStyJ eh1YF9niykuOaqi3ClQrI8jqtWlE5muikYkYUpQo+y5SpDAHppg0hn8Di/rue5E1R7kt23oV0YQE mkFupcWnj02NN5F6T0i3/Ql12UiP/pUIhrF8lY+9bInIaRvNkxD55NYZMERaebPloO2znrGJGXCq xF2rclZnYEO+/JwQ46GrWIh6IwNdZjNhVz/f3VMCAcdygJ1733W2niyObTlmbNvUXZ3fg7CzfRVV m50Sl/tDWZ1Q34zZah0PTbkeoEL/MWOt4yXVWJPrPZwJM5b3qc4jYmpBqLoi5rcdMLUuuJbXiLEG I9Pb5vwBnmqG4gFQXfsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTItMjhUMTQ6MjE6MjgrMDA6 MDA2miAIAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEyLTI4VDE0OjIxOjI4KzAwOjAwR8eYtAAA AABJRU5ErkJggg== X-Now-Playing: Static's _Eject Your Mind_: "Northrop" Date: Tue, 28 Dec 2021 15:33:33 +0100 In-Reply-To: <831r1wnb9f.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Dec 2021 14:51:08 +0200") Message-ID: <87a6gkajeq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > But the doc string of key-valid-p says: > > Say whether KEYS is a valid ‘kbd’ sequence. > A ‘kbd’ sequence is a string consisting of one and more key > strokes. The key strokes are separated [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Stefan Kangas , juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > But the doc string of key-valid-p says: > > Say whether KEYS is a valid =E2=80=98kbd=E2=80=99 sequence. > A =E2=80=98kbd=E2=80=99 sequence is a string consisting of one and more= key > strokes. The key strokes are separated by a space character. This has been changed now. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 28 09:34:24 2021 Received: (at 52523) by debbugs.gnu.org; 28 Dec 2021 14:34:24 +0000 Received: from localhost ([127.0.0.1]:45449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2DYV-0007Mu-UD for submit@debbugs.gnu.org; Tue, 28 Dec 2021 09:34:24 -0500 Received: from quimby.gnus.org ([95.216.78.240]:51302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2DYU-0007Mh-Da for 52523@debbugs.gnu.org; Tue, 28 Dec 2021 09:34:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GoGnxBnndugpohRULBHLRjDhmgp0R5qSzOSrGFg/Yi8=; b=BNapNRh/NByoOVFADaKfjSP33g Xvy/rQbzdeMagQrRZUUmPhdKVWDDyqok/d1A3ehv/8GLIW7OnWVCmqD3WGsZ/fS4fQSLTwrqWM9Ze eZR3bvcxSsSBp+xgUlWF8duhC79k58hzeiXePqgIFis20H2E1lCjk+iSK6eS1KZkMMRs=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2DYL-0007Il-Ou; Tue, 28 Dec 2021 15:34:16 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEX7+vbb1s/Fvret opySg3yKdnFrWlX///+5nBMEAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UMHA4VHHxIsuYAAAGYSURB VDjLxVNRktsgDJV7AsQJCnTyb4lcoNh7AawcYLP4/keowIQ4mdmZTn/67A9bTxJIegL4r7BoTn8T wmQmY/4x2d8ifEfQcbL3+AajD1ZC4Y73zA6i4cSAP+Nbwp0JemMa6RCCD1zR+Wp33jqnqaj7Wqxv c8e5E+QDUaih/ohmBn5Bu5nVeAf9gKOolsk7bUj/rk7VIa6iyFSp/iOyLXlJI6cDtTAvyypbStyJ eh1YF9niykuOaqi3ClQrI8jqtWlE5muikYkYUpQo+y5SpDAHppg0hn8Di/rue5E1R7kt23oV0YQE mkFupcWnj02NN5F6T0i3/Ql12UiP/pUIhrF8lY+9bInIaRvNkxD55NYZMERaebPloO2znrGJGXCq xF2rclZnYEO+/JwQ46GrWIh6IwNdZjNhVz/f3VMCAcdygJ1733W2niyObTlmbNvUXZ3fg7CzfRVV m50Sl/tDWZ1Q34zZah0PTbkeoEL/MWOt4yXVWJPrPZwJM5b3qc4jYmpBqLoi5rcdMLUuuJbXiLEG I9Pb5vwBnmqG4gFQXfsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTItMjhUMTQ6MjE6MjgrMDA6 MDA2miAIAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEyLTI4VDE0OjIxOjI4KzAwOjAwR8eYtAAA AABJRU5ErkJggg== X-Now-Playing: Static's _Eject Your Mind_: "Sometimes I'm Sad For A Few Seconds" Date: Tue, 28 Dec 2021 15:34:13 +0100 In-Reply-To: (Stefan Kangas's message of "Mon, 27 Dec 2021 19:08:42 -0800") Message-ID: <875yr8ajdm.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > Having looked over the documentation to these functions, I actually > think "key" is the least confusing name here. > > How does the attached patch look? Other than the "Now obsolete" also noted by Eli, it looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > Having looked over the documentation to these functions, I actually > think "key" is the least confusing name here. > > How does the attached patch look? Other than the "Now obsolete" also noted by Eli, it looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 02 11:00:41 2022 Received: (at 52523) by debbugs.gnu.org; 2 Jan 2022 16:00:41 +0000 Received: from localhost ([127.0.0.1]:33488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n43Hk-0007RX-Qf for submit@debbugs.gnu.org; Sun, 02 Jan 2022 11:00:40 -0500 Received: from mail-pj1-f54.google.com ([209.85.216.54]:45927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n43Hj-0007RD-0X for 52523@debbugs.gnu.org; Sun, 02 Jan 2022 11:00:39 -0500 Received: by mail-pj1-f54.google.com with SMTP id l16-20020a17090a409000b001b2e9628c9cso2356400pjg.4 for <52523@debbugs.gnu.org>; Sun, 02 Jan 2022 08:00:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=yHuHolCSDclTdQV9loloEMcYrOUIOmqKWFV8P6HzYc4=; b=ir+OZbKpUI0GsxEZloW5K66MHWiG/bE+3V7jdfSObJlnTJUMiEpvgqHUH8/hKwDvjo t2BP11o2+xFpcKI5odLNjIjd1HL5lKWXGDaWPM1b7uyFm0Wk6DHxWRWrmwu1x18b/5Af g6aem03RftetV2YcJv58m1WkIJZf674m6mfgvbzftSHS4/m85EeXAIOhwlptfG6iUUGC /XHs/AX4nhr9LdJw5gDybRTnOEbGsHCAq2U9H40y31LMnIuz616gsnVZr8RbPuC6pYtA 49J3sosavWTW8XCpirn+YgniOH2nhHNOOjrwE8gCLky7V5RnVZLUyLsVxb3IEnp9vXuJ Tk3A== X-Gm-Message-State: AOAM533XYPR5xFMcGc3VomaJAK8k7IysDtIoBfutPP5yCcBkjflDae4R oxYbu5uf83J6h/5qzFNflgYny/nl70ScIx3a9iQ= X-Google-Smtp-Source: ABdhPJzO7WSngWamo0qNMyU5GCJvgdEHo6UK7r4UjiZ1e8gp8IxoPk/kZHf3mT5PCC/idaU+YIoQnjJpci78SsVeODs= X-Received: by 2002:a17:902:d512:b0:149:3070:48ec with SMTP id b18-20020a170902d51200b00149307048ecmr41311605plg.66.1641139233248; Sun, 02 Jan 2022 08:00:33 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 Jan 2022 11:00:32 -0500 From: Stefan Kangas In-Reply-To: <875yr8ajdm.fsf@gnus.org> References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> <875yr8ajdm.fsf@gnus.org> MIME-Version: 1.0 Date: Sun, 2 Jan 2022 11:00:32 -0500 Message-ID: Subject: Re: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 52523 Cc: 52523@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 52523 29.1 thanks Lars Ingebrigtsen writes: > Other than the "Now obsolete" also noted by Eli, it looks good to me. Fixed that and pushed to master as commit 984391a9dc. From unknown Sat Sep 13 04:54:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 31 Jan 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator